inch 0.4.3.rc2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 51a684b0122ca78cb12bfe784278c7f1e2aced3b
-  data.tar.gz: 047e6d479de69c949e4adf3c79f72ea63f5db753
+  metadata.gz: dab543a34157a4fe5467c6dbb51a94c112f29a83
+  data.tar.gz: 674f4bd46b9f9b23b10bb5b8264f31019fb6d686
 SHA512:
-  metadata.gz: 9d6ef7ac83572913777a95e3408b54c1451d3d9c3a96772b30f106f0bf452b5fe28c0bf687b3e3caad58ec94342916b27bf62ddb6b3e86405bc738e1283d3782
-  data.tar.gz: c7fcf1abab329c2c18b84b11a1419b4aa5be23c852f4ea4403d82c1d09247d0fef3560fc3f799589d7e72bbdbcdae3c5300f8f8ad48d673403b4f26e97c0c2cc
+  metadata.gz: 6dc8d3ee59dceb8c04145f470820a28a6aff12d2c3462f893bdafc7b274b243bf6f1b12057606c91b2b0573dc0696334b46c993843d2048acc145a12765d8257
+  data.tar.gz: 1270332e354f079ae12c9548d7f40f96b0c94c1debef1974c710ad80e7e03891bce603ef0fd4c6d89db8c19724b53d204d4e2f5f2c00f7a091453f6718ffdbbb

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 # Changelog
 
 
+## 0.4.3
+
+- Fixed a bug where the 'show' command did not properly recognize overloaded
+  method signatures
+
+
 ## 0.4.2
 
 - The 'inspect' command now shows the original docstring provided by the

data/lib/inch/version.rb

@@ -1,3 +1,3 @@
 module Inch
-  VERSION = "0.4.3.rc2"
+  VERSION = "0.4.3"
 end

data/test/fixtures/simple/lib/broken.rb

@@ -224,6 +224,25 @@ module Overloading
   #   @option user_options [Number] :xid an alias to transaction_id.
   def params_only_in_overloads(user_options = {})
   end
+
+  # Tests that the default signature can be present as an overload tag.
+  #
+  # @overload params_only_in_overloads()
+  #   @example
+  #     Hello.new
+  #
+  # @overload params_only_in_overloads(transaction_id)
+  #   @example
+  #     Hello.new(123)
+  #
+  # @example
+  #   Hello.new(transaction_id: 123)
+  #   Hello.new(xid: 123)
+  # @param [Hash] user_options the options to create a message with.
+  # @option user_options [Number] :transaction_id
+  # @option user_options [Number] :xid an alias to transaction_id.
+  def one_param_missing_in_overload(user_options = {})
+  end
 end
 
 module YardError

data/test/test_helper.rb

@@ -7,6 +7,16 @@ require 'bundler'
 Bundler.require
 require 'inch'
 
+def assert_roles(object, expected, unexpected)
+  roles = object.roles.map(&:class)
+  unexpected.each do |role|
+    refute roles.include?(role), "Should not assign #{role}"
+  end
+  expected.each do |role|
+    assert roles.include?(role), "Should assign #{role}"
+  end
+end
+
 def fixture_path(name)
   File.join(File.dirname(__FILE__), "fixtures", name.to_s)
 end

data/test/unit/code_object/proxy/method_object_test.rb

@@ -295,14 +295,23 @@ describe ::Inch::CodeObject::Proxy::MethodObject do
 
   def test_overloading_with_bad_doc
     m = @objects.find("Overloading#params_only_in_overloads")
-    roles = m.roles.map(&:class)
-    bad_roles = [
+    unexpected_roles = [
       Inch::Evaluation::Role::Object::WithoutCodeExample,
       Inch::Evaluation::Role::MethodParameter::WithoutMention,
       Inch::Evaluation::Role::MethodParameter::WithoutType,
     ]
-    bad_roles.each do |role|
-      refute roles.include?(role), "Should not assign #{role}"
-    end
+    assert_roles m, [], unexpected_roles
+  end
+
+  def test_overloading_with_half_bad_doc
+    m = @objects.find("Overloading#one_param_missing_in_overload")
+    unexpected_roles = [
+      Inch::Evaluation::Role::Object::WithoutCodeExample,
+    ]
+    expected_roles = [
+      Inch::Evaluation::Role::MethodParameter::WithoutMention,
+      Inch::Evaluation::Role::MethodParameter::WithoutType,
+    ]
+    assert_roles m, expected_roles, unexpected_roles
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: inch
 version: !ruby/object:Gem::Version
-  version: 0.4.3.rc2
+  version: 0.4.3
 platform: ruby
 authors:
 - René Föhring
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-26 00:00:00.000000000 Z
+date: 2014-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -315,9 +315,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2