ims-lti 2.2.3 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1ecba7e383b26f256f513d977ce7a1a5ddc6cf4d
-  data.tar.gz: cbb2dcd2d373cb968b72d8ec689d6d1bb4e1b8df
+SHA256:
+  metadata.gz: 6de9bbbf79d7c9a876eadd145ec7317b05268aa095ab1df5202db6c96d08599a
+  data.tar.gz: 3122f727f095833a7a3a380c46698da81f638a670f8bf49c72124327bf8fd1bb
 SHA512:
-  metadata.gz: 1eee3ca7972a1c446be5e4a0abb85eba9c6aed471af0891c6cfad4999a876393349a89adbf84865e401b77732bd8da7bec9803adbb4e7d6fd054675a7f99bb49
-  data.tar.gz: ef39d166b973161e51f2b91f01e39a26e26fe71fdde1ecee3d4f37f178db9bc5a9bdbf8b04afe9923385862bcea0b162a6ef23ce967778b11792ea0ea773108e
+  metadata.gz: 8c6f21d78459aa18c5953e7e4d40f59882abc5e927eff0c3fedb9672208ac89d4ee4bced6222498cf86b4ef7f9f0803f64ca7f0a99af79dcb6283f6cced63c0d
+  data.tar.gz: 8032a4d4d4ffb044a7fb915467b5267fcc0bbbeb07683f5d7d920cdd1d9ee4942f8a394da50c92c9c7c5ae2bbe27cee599b997ab60019931cf6ada666425ed9d

data/lib/ims/lti/models/membership_service/lis_person.rb

@@ -1,6 +1,6 @@
 module IMS::LTI::Models::MembershipService
   class LISPerson < Person
-    attr_reader :email, :result_sourced_id, :sourced_id, :user_id
+    attr_reader :email, :result_sourced_id, :sourced_id, :user_id, :sis_id
 
     def initialize(opts={})
       super(opts)
@@ -8,6 +8,7 @@ module IMS::LTI::Models::MembershipService
       @result_sourced_id = opts[:result_sourced_id]
       @sourced_id = opts[:sourced_id]
       @user_id = opts[:user_id]
+      @sis_id = opts[:sis_id]
     end
   end
 end

data/lib/ims/lti/models/messages/message.rb

@@ -47,6 +47,19 @@ module IMS::LTI::Models::Messages
         @descendants || Set.new
       end
 
+      # For signature generation -- see usage in signed_post_params
+      def convert_param_values_to_crlf_endings(hash)
+        hash.transform_values do |val|
+          if val.is_a?(String)
+            # Convert to all newlines first, for consistency, just in case there
+            # is some weird mix of newlines & carriage returns in input
+            val.encode(universal_newline: true).encode(crlf_newline: true)
+          else
+            val
+          end
+        end
+      end
+
       private
 
       def add_params(instance_variable, param, *params)
@@ -148,7 +161,11 @@ module IMS::LTI::Models::Messages
     end
 
     def signed_post_params(secret)
-      message_params = oauth_params.merge(post_params)
+      # The params will be used in an HTML form, and browsers will always use
+      # newlines+carriage return line endings for submitted form data. The
+      # signature needs to match, and signature generation does not add carriage
+      # returns, so we ensure CRLF endings here.
+      message_params = self.class.convert_param_values_to_crlf_endings(oauth_params.merge(post_params))
       @message_authenticator = IMS::LTI::Services::MessageAuthenticator.new(launch_url, message_params, secret)
       @message_authenticator.signed_params
     end
@@ -219,4 +236,4 @@ module IMS::LTI::Models::Messages
     end
 
   end
-end
+end

data/lib/ims/lti/serializers/membership_service/lis_person_serializer.rb

@@ -7,5 +7,6 @@ module IMS::LTI::Serializers::MembershipService
     set_attribute :result_sourced_id, key: :resultSourcedId
     set_attribute :sourced_id, key: :sourcedId
     set_attribute :user_id, key: :userId
+    set_attribute :sis_id, key: :sisId, optional: true
   end
 end

data/lib/ims/lti/version.rb

@@ -1,5 +1,5 @@
 module IMS
   module LTI
-    VERSION = "2.2.3"
+    VERSION = "2.3.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ims-lti
 version: !ruby/object:Gem::Version
-  version: 2.2.3
+  version: 2.3.2
 platform: ruby
 authors:
 - Instructure
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-02 00:00:00.000000000 Z
+date: 2022-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -48,30 +48,30 @@ dependencies:
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: json-jwt
   requirement: !ruby/object:Gem::Requirement
@@ -100,6 +100,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.3.1
+- !ruby/object:Gem::Dependency
+  name: rexml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -335,10 +349,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 3.2.15
 signing_key: 
 specification_version: 4
 summary: Ruby library for creating IMS LTI tool providers and consumers
 test_files: []
-has_rdoc: