imprint 1.4.3 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5459901d3dc0b3f89bf973e477c409230a60e611
-  data.tar.gz: c460d8059c154b9079098e4d7da14a4c0df002c8
+  metadata.gz: f4370ea757046369c30687047892243b4e434a66
+  data.tar.gz: 05e2f21ae874968110af3506ee8c5456d6cc9d51
 SHA512:
-  metadata.gz: ed8cadb75ca9549197cb8407bb4d566ded40c6136859d03e1a6d17a8ae17f47f5a426c66aab55876ba7e92d5beaf9ffb7e24474bc68535a374c101e521c7139a
-  data.tar.gz: a473cc378d6b1870c836481540d2fabba7e3bfb84241a6de6d8648ac39c034759e09f99c74085052ddf4ae8d8fc58ce5b21841c1a5dc7c2bfb4844d4ba95415c
+  metadata.gz: 2cebe40077377c417f246ab44b9daf5f5cc81bb023561d22c1b0199ae93505915ec3ef0fcbe778846f1a8b99475c10bcc3942f8024e3cfc1462801659c5b383c
+  data.tar.gz: d655f847cbc22d1cbf8f04687ad77dceb39d2b62c2859a49869fdcd0382f9efb70050a297743f612fab962b77af904dcc4352dd2f4f80ad29713f28d2b08e237

data/lib/imprint/middleware.rb

@@ -6,7 +6,7 @@ module Imprint
     def self.set_request_trace_id(rack_env)
       trace_id = rack_env[Imprint::Tracer::TRACER_HEADER] || rack_env[Imprint::Tracer::RAILS_REQUEST_ID]
       if trace_id.nil?
-        trace_id = "#{Time.now.to_i}_#{Imprint::Tracer.rand_trace_id}"
+        trace_id = Imprint::Tracer.rand_trace_id
         logger.info("trace_status=initiated trace_id=#{trace_id}")
       end
       Imprint::Tracer.set_trace_id(trace_id, rack_env)

data/lib/imprint/tracer.rb

@@ -1,3 +1,5 @@
+require 'securerandom'
+
 module Imprint
   class Tracer
     TRACER_HEADER    = 'HTTP_IMPRINTID'
@@ -5,7 +7,6 @@ module Imprint
     RAILS_REQUEST_ID = "action_dispatch.request_id"
     TRACE_ID_DEFAULT = "-1"
     TRACER_TIMESTAMP = "TIMESTAMP"
-    TRACE_CHARS      = [('a'..'z'), ('A'..'Z')].map { |i| i.to_a }.flatten
 
     def self.set_trace_id(id, rack_env = {})
       Thread.current[TRACER_TIMESTAMP] = Time.now.utc.strftime("%Y-%m-%dT%H:%M:%S.%6N")
@@ -42,7 +43,7 @@ module Imprint
     end
 
     def self.rand_trace_id
-      (0...6).map { TRACE_CHARS[rand(TRACE_CHARS.length)] }.join
+      SecureRandom.uuid
     end
   end
 end

data/lib/imprint/version.rb

@@ -1,3 +1,3 @@
 module Imprint
-  VERSION = "1.4.3"
+  VERSION = "1.5.0"
 end

data/test/unit/tracer_test.rb

@@ -39,8 +39,8 @@ class TracerTest < Minitest::Test
   should "generate rand trace id" do
     trace_id = Imprint::Tracer.rand_trace_id
     refute_nil trace_id
-    assert_equal 6, trace_id.length
-    assert trace_id.match(/[A-Za-z]/)
+    assert_equal 36, trace_id.length
+    assert trace_id.match(/[a-f0-9\-]/)
   end
 
   protected

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: imprint
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.5.0
 platform: ruby
 authors:
 - Dan Mayer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-07 00:00:00.000000000 Z
+date: 2015-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler