impressionist2 1.5.1

data/tests/test_app/public/javascripts/rails.js

@@ -0,0 +1,175 @@
+(function() {
+  // Technique from Juriy Zaytsev
+  // http://thinkweb2.com/projects/prototype/detecting-event-support-without-browser-sniffing/
+  function isEventSupported(eventName) {
+    var el = document.createElement('div');
+    eventName = 'on' + eventName;
+    var isSupported = (eventName in el);
+    if (!isSupported) {
+      el.setAttribute(eventName, 'return;');
+      isSupported = typeof el[eventName] == 'function';
+    }
+    el = null;
+    return isSupported;
+  }
+
+  function isForm(element) {
+    return Object.isElement(element) && element.nodeName.toUpperCase() == 'FORM'
+  }
+
+  function isInput(element) {
+    if (Object.isElement(element)) {
+      var name = element.nodeName.toUpperCase()
+      return name == 'INPUT' || name == 'SELECT' || name == 'TEXTAREA'
+    }
+    else return false
+  }
+
+  var submitBubbles = isEventSupported('submit'),
+      changeBubbles = isEventSupported('change')
+
+  if (!submitBubbles || !changeBubbles) {
+    // augment the Event.Handler class to observe custom events when needed
+    Event.Handler.prototype.initialize = Event.Handler.prototype.initialize.wrap(
+      function(init, element, eventName, selector, callback) {
+        init(element, eventName, selector, callback)
+        // is the handler being attached to an element that doesn't support this event?
+        if ( (!submitBubbles && this.eventName == 'submit' && !isForm(this.element)) ||
+             (!changeBubbles && this.eventName == 'change' && !isInput(this.element)) ) {
+          // "submit" => "emulated:submit"
+          this.eventName = 'emulated:' + this.eventName
+        }
+      }
+    )
+  }
+
+  if (!submitBubbles) {
+    // discover forms on the page by observing focus events which always bubble
+    document.on('focusin', 'form', function(focusEvent, form) {
+      // special handler for the real "submit" event (one-time operation)
+      if (!form.retrieve('emulated:submit')) {
+        form.on('submit', function(submitEvent) {
+          var emulated = form.fire('emulated:submit', submitEvent, true)
+          // if custom event received preventDefault, cancel the real one too
+          if (emulated.returnValue === false) submitEvent.preventDefault()
+        })
+        form.store('emulated:submit', true)
+      }
+    })
+  }
+
+  if (!changeBubbles) {
+    // discover form inputs on the page
+    document.on('focusin', 'input, select, texarea', function(focusEvent, input) {
+      // special handler for real "change" events
+      if (!input.retrieve('emulated:change')) {
+        input.on('change', function(changeEvent) {
+          input.fire('emulated:change', changeEvent, true)
+        })
+        input.store('emulated:change', true)
+      }
+    })
+  }
+
+  function handleRemote(element) {
+    var method, url, params;
+
+    var event = element.fire("ajax:before");
+    if (event.stopped) return false;
+
+    if (element.tagName.toLowerCase() === 'form') {
+      method = element.readAttribute('method') || 'post';
+      url    = element.readAttribute('action');
+      params = element.serialize();
+    } else {
+      method = element.readAttribute('data-method') || 'get';
+      url    = element.readAttribute('href');
+      params = {};
+    }
+
+    new Ajax.Request(url, {
+      method: method,
+      parameters: params,
+      evalScripts: true,
+
+      onComplete:    function(request) { element.fire("ajax:complete", request); },
+      onSuccess:     function(request) { element.fire("ajax:success",  request); },
+      onFailure:     function(request) { element.fire("ajax:failure",  request); }
+    });
+
+    element.fire("ajax:after");
+  }
+
+  function handleMethod(element) {
+    var method = element.readAttribute('data-method'),
+        url = element.readAttribute('href'),
+        csrf_param = $$('meta[name=csrf-param]')[0],
+        csrf_token = $$('meta[name=csrf-token]')[0];
+
+    var form = new Element('form', { method: "POST", action: url, style: "display: none;" });
+    element.parentNode.insert(form);
+
+    if (method !== 'post') {
+      var field = new Element('input', { type: 'hidden', name: '_method', value: method });
+      form.insert(field);
+    }
+
+    if (csrf_param) {
+      var param = csrf_param.readAttribute('content'),
+          token = csrf_token.readAttribute('content'),
+          field = new Element('input', { type: 'hidden', name: param, value: token });
+      form.insert(field);
+    }
+
+    form.submit();
+  }
+
+
+  document.on("click", "*[data-confirm]", function(event, element) {
+    var message = element.readAttribute('data-confirm');
+    if (!confirm(message)) event.stop();
+  });
+
+  document.on("click", "a[data-remote]", function(event, element) {
+    if (event.stopped) return;
+    handleRemote(element);
+    event.stop();
+  });
+
+  document.on("click", "a[data-method]", function(event, element) {
+    if (event.stopped) return;
+    handleMethod(element);
+    event.stop();
+  });
+
+  document.on("submit", function(event) {
+    var element = event.findElement(),
+        message = element.readAttribute('data-confirm');
+    if (message && !confirm(message)) {
+      event.stop();
+      return false;
+    }
+
+    var inputs = element.select("input[type=submit][data-disable-with]");
+    inputs.each(function(input) {
+      input.disabled = true;
+      input.writeAttribute('data-original-value', input.value);
+      input.value = input.readAttribute('data-disable-with');
+    });
+
+    var element = event.findElement("form[data-remote]");
+    if (element) {
+      handleRemote(element);
+      event.stop();
+    }
+  });
+
+  document.on("ajax:after", "form", function(event, element) {
+    var inputs = element.select("input[type=submit][disabled=true][data-disable-with]");
+    inputs.each(function(input) {
+      input.value = input.readAttribute('data-original-value');
+      input.removeAttribute('data-original-value');
+      input.disabled = false;
+    });
+  });
+})();

data/tests/test_app/public/robots.txt

@@ -0,0 +1,5 @@
+# See http://www.robotstxt.org/wc/norobots.html for documentation on how to use the robots.txt file
+#
+# To ban all spiders from the entire site uncomment the next two lines:
+# User-Agent: *
+# Disallow: /

data/tests/test_app/script/cucumber

@@ -0,0 +1,10 @@
+#!/usr/bin/env ruby
+
+vendored_cucumber_bin = Dir["#{File.dirname(__FILE__)}/../vendor/{gems,plugins}/cucumber*/bin/cucumber"].first
+if vendored_cucumber_bin
+  load File.expand_path(vendored_cucumber_bin)
+else
+  require 'rubygems' unless ENV['NO_RUBYGEMS']
+  require 'cucumber'
+  load Cucumber::BINARY
+end

data/tests/test_app/script/rails

@@ -0,0 +1,6 @@
+#!/usr/bin/env ruby
+# This command will automatically be run when you run "rails" with Rails 3 gems installed from the root of your application.
+
+APP_PATH = File.expand_path('../../config/application',  __FILE__)
+require File.expand_path('../../config/boot',  __FILE__)
+require 'rails/commands'

data/tests/test_app/spec/controllers/articles_controller_spec.rb

@@ -0,0 +1,76 @@
+require 'spec_helper'
+
+describe ArticlesController do
+  fixtures :articles,:impressions,:posts,:widgets
+
+  render_views
+
+  it "should make the impressionable_hash available" do
+    get "index"
+    response.body.include?("false").should eq true
+  end
+
+  it "should log an impression with a message" do
+    get "index"
+    Impression.all.size.should eq 12
+    Article.first.impressions.last.message.should eq "this is a test article impression"
+    Article.first.impressions.last.controller_name.should eq "articles"
+    Article.first.impressions.last.action_name.should eq "index"
+  end
+
+  it "should log an impression without a message" do
+    get "show", :id=> 1
+    Impression.all.size.should eq 12
+    Article.first.impressions.last.message.should eq nil
+    Article.first.impressions.last.controller_name.should eq "articles"
+    Article.first.impressions.last.action_name.should eq "show"
+  end
+
+  it "should log the user_id if user is authenticated (@current_user before_filter method)" do
+    session[:user_id] = 123
+    get "show", :id=> 1
+    Article.first.impressions.last.user_id.should eq 123
+  end
+
+  it "should not log the user_id if user is authenticated" do
+    get "show", :id=> 1
+    Article.first.impressions.last.user_id.should eq nil
+  end
+
+  it "should log the request_hash, ip_address, referrer and session_hash" do
+    get "show", :id=> 1
+    Impression.last.request_hash.size.should eq 64
+    Impression.last.ip_address.should eq "0.0.0.0"
+    Impression.last.session_hash.size.should eq 32
+    Impression.last.referrer.should eq nil
+  end
+
+  # Capybara has change the way it works
+  # We need to pass :type options in order to make include helper methods
+  # see https://github.com/jnicklas/capybara#using-capybara-with-rspec
+  it "should log the referrer when you click a link", :type => :feature do
+    visit article_url(Article.first)
+    click_link "Same Page"
+    Impression.last.referrer.should eq "http://test.host/articles/1"
+  end
+
+  it "should log request with params (checked = true)" do
+    get "show", id: 1, checked: true
+    Impression.last.params.should eq({"checked"=>true})
+    Impression.last.request_hash.size.should eq 64
+    Impression.last.ip_address.should eq "0.0.0.0"
+    Impression.last.session_hash.size.should eq 32
+    Impression.last.referrer.should eq nil
+  end
+
+  it "should log request with params {}" do
+    get "index"
+    Impression.last.params.should eq({})
+    Impression.last.request_hash.size.should eq 64
+    Impression.last.ip_address.should eq "0.0.0.0"
+    Impression.last.session_hash.size.should eq 32
+    Impression.last.referrer.should eq nil
+  end
+end
+
+

data/tests/test_app/spec/controllers/dummy_controller_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe DummyController do
+  fixtures :impressions
+  render_views
+
+  it "should log impression at the per action level on non-restful controller" do
+    get "index"
+    Impression.all.size.should eq 12
+  end
+end

data/tests/test_app/spec/controllers/impressionist_uniqueness_spec.rb

@@ -0,0 +1,396 @@
+require 'spec_helper'
+
+# we use the posts controller as it uses the impressionsist module. any such controller would do.
+describe DummyController do
+
+  before do
+    @impression_count = Impression.all.size
+  end
+
+  describe "impressionist filter uniqueness" do
+
+    it "should ignore uniqueness if not requested" do
+      controller.impressionist_subapp_filter
+      controller.impressionist_subapp_filter
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize unique session" do
+      controller.stub(:session_hash).and_return(request.session_options[:id])
+      controller.impressionist_subapp_filter(unique: [:session_hash])
+      controller.impressionist_subapp_filter(unique: [:session_hash])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique ip" do
+      controller.request.stub(:remote_ip).and_return("1.2.3.4")
+      controller.impressionist_subapp_filter(unique: [:ip_address])
+      controller.impressionist_subapp_filter(unique: [:ip_address])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique request" do
+      controller.impressionist_subapp_filter(unique: [:request_hash])
+      controller.impressionist_subapp_filter(unique: [:request_hash])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique action" do
+      controller.stub(:action_name).and_return("test_action")
+      controller.impressionist_subapp_filter(unique: [:action_name])
+      controller.impressionist_subapp_filter(unique: [:action_name])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique controller" do
+      controller.stub(:controller_name).and_return("post")
+      controller.impressionist_subapp_filter(unique: [:controller_name])
+      controller.impressionist_subapp_filter(unique: [:controller_name])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique user" do
+      controller.stub(:user_id).and_return(42)
+      controller.impressionist_subapp_filter(unique: [:user_id])
+      controller.impressionist_subapp_filter(unique: [:user_id])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique referer" do
+      controller.request.stub(:referer).and_return("http://foo/bar")
+      controller.impressionist_subapp_filter(unique: [:referrer])
+      controller.impressionist_subapp_filter(unique: [:referrer])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique id" do
+      controller.stub(:params).and_return({:id => "666"}) # for correct impressionable id in filter
+      controller.impressionist_subapp_filter(unique: [:impressionable_id])
+      controller.impressionist_subapp_filter(unique: [:impressionable_id])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    # extra redundant test for important controller and action combination.
+    it "should recognize different controller and action" do
+      controller.stub(:controller_name).and_return("post")
+      controller.stub(:action_name).and_return("test_action")
+      controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
+      controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
+      Impression.should have(@impression_count + 1).records
+      controller.stub(:action_name).and_return("another_action")
+      controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
+      controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
+      Impression.should have(@impression_count + 2).records
+      controller.stub(:controller_name).and_return("article")
+      controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
+      controller.impressionist_subapp_filter(unique: [:controller_name, :action_name])
+      Impression.should have(@impression_count + 3).records
+    end
+
+    it "should recognize different action" do
+      controller.stub(:action_name).and_return("test_action")
+      controller.impressionist_subapp_filter(unique: [:action_name])
+      controller.impressionist_subapp_filter(unique: [:action_name])
+      Impression.should have(@impression_count + 1).records
+      controller.stub(:action_name).and_return("another_action")
+      controller.impressionist_subapp_filter(unique: [:action_name])
+      controller.impressionist_subapp_filter(unique: [:action_name])
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize different controller" do
+      controller.stub(:controller_name).and_return("post")
+      controller.impressionist_subapp_filter(unique: [:controller_name])
+      controller.impressionist_subapp_filter(unique: [:controller_name])
+      Impression.should have(@impression_count + 1).records
+      controller.stub(:controller_name).and_return("article")
+      controller.impressionist_subapp_filter(unique: [:controller_name])
+      controller.impressionist_subapp_filter(unique: [:controller_name])
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize different session" do
+      controller.stub(:session_hash).and_return("foo")
+      controller.impressionist_subapp_filter(unique: [:session_hash])
+      controller.impressionist_subapp_filter(unique: [:session_hash])
+      Impression.should have(@impression_count + 1).records
+      controller.stub(:session_hash).and_return("bar")
+      controller.impressionist_subapp_filter(unique: [:session_hash])
+      controller.impressionist_subapp_filter(unique: [:session_hash])
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize different ip" do
+      controller.request.stub(:remote_ip).and_return("1.2.3.4")
+      controller.impressionist_subapp_filter(unique: [:ip_address])
+      controller.impressionist_subapp_filter(unique: [:ip_address])
+      Impression.should have(@impression_count + 1).records
+      controller.request.stub(:remote_ip).and_return("5.6.7.8")
+      controller.impressionist_subapp_filter(unique: [:ip_address])
+      controller.impressionist_subapp_filter(unique: [:ip_address])
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize different referer" do
+      controller.request.stub(:referer).and_return("http://foo/bar")
+      controller.impressionist_subapp_filter(unique: [:referrer])
+      controller.impressionist_subapp_filter(unique: [:referrer])
+      Impression.should have(@impression_count + 1).records
+      controller.request.stub(:referer).and_return("http://bar/fo")
+      controller.impressionist_subapp_filter(unique: [:referrer])
+      controller.impressionist_subapp_filter(unique: [:referrer])
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize different id" do
+      controller.stub(:params).and_return({:id => "666"}) # for correct impressionable id in filter
+      controller.impressionist_subapp_filter(unique: [:impressionable_type, :impressionable_id])
+      controller.impressionist_subapp_filter(unique: [:impressionable_type, :impressionable_id])
+      controller.stub(:params).and_return({:id => "42"}) # for correct impressionable id in filter
+      controller.impressionist_subapp_filter(unique: [:impressionable_type, :impressionable_id])
+      controller.impressionist_subapp_filter(unique: [:impressionable_type, :impressionable_id])
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize combined uniqueness" do
+      controller.stub(:action_name).and_return("test_action")
+      controller.impressionist_subapp_filter(unique: [:ip_address, :request_hash, :action_name])
+      controller.impressionist_subapp_filter(unique: [:request_hash, :ip_address, :action_name])
+      controller.impressionist_subapp_filter(unique: [:request_hash, :action_name])
+      controller.impressionist_subapp_filter(unique: [:ip_address, :action_name])
+      controller.impressionist_subapp_filter(unique: [:ip_address, :request_hash])
+      controller.impressionist_subapp_filter(unique: [:action_name])
+      controller.impressionist_subapp_filter(unique: [:ip_address])
+      controller.impressionist_subapp_filter(unique: [:request_hash])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize combined non-uniqueness" do
+      controller.stub(:action_name).and_return(nil)
+      controller.impressionist_subapp_filter(unique: [:ip_address, :action_name])
+      controller.stub(:action_name).and_return("test_action")
+      controller.impressionist_subapp_filter(unique: [:ip_address, :action_name])
+      controller.stub(:action_name).and_return("another_action")
+      controller.impressionist_subapp_filter(unique: [:ip_address, :action_name])
+      Impression.should have(@impression_count + 3).records
+    end
+
+  end
+
+  describe "impressionist method uniqueness for impressionables" do
+
+    # in this test we reuse the post model. might break if model changes.
+
+    it "should ignore uniqueness if not requested" do
+      impressionable = Post.create
+      controller.impressionist impressionable
+      controller.impressionist impressionable
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize unique session" do
+      controller.stub(:session_hash).and_return(request.session_options[:id])
+      impressionable = Post.create
+      controller.impressionist(impressionable, nil, :unique => [:session_hash])
+      controller.impressionist(impressionable, nil, :unique => [:session_hash])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique ip" do
+      controller.request.stub(:remote_ip).and_return("1.2.3.4")
+      impressionable = Post.create
+      controller.impressionist(impressionable, nil, :unique => [:ip_address])
+      controller.impressionist(impressionable, nil, :unique => [:ip_address])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique request" do
+      impressionable = Post.create
+      controller.impressionist(impressionable, nil, :unique => [:request_hash])
+      controller.impressionist(impressionable, nil, :unique => [:request_hash])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique user" do
+      controller.stub(:user_id).and_return(666)
+      impressionable = Post.create
+      controller.impressionist(impressionable, nil, :unique => [:user_id])
+      controller.impressionist(impressionable, nil, :unique => [:user_id])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize unique referer" do
+      controller.request.stub(:referer).and_return("http://foo/bar")
+      impressionable = Post.create
+      controller.impressionist(impressionable, nil, :unique => [:referrer])
+      controller.impressionist(impressionable, nil, :unique => [:referrer])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize different session" do
+      impressionable = Post.create
+      controller.stub(:session_hash).and_return("foo")
+      controller.impressionist(impressionable, nil, :unique => [:session_hash])
+      controller.impressionist(impressionable, nil, :unique => [:session_hash])
+      Impression.should have(@impression_count + 1).records
+      controller.stub(:session_hash).and_return("bar")
+      controller.impressionist(impressionable, nil, :unique => [:session_hash])
+      controller.impressionist(impressionable, nil, :unique => [:session_hash])
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize different ip" do
+      controller.request.stub(:remote_ip).and_return("1.2.3.4")
+      impressionable = Post.create
+      controller.impressionist(impressionable, nil, :unique => [:ip_address])
+      controller.impressionist(impressionable, nil, :unique => [:ip_address])
+      Impression.should have(@impression_count + 1).records
+      controller.request.stub(:remote_ip).and_return("5.6.7.8")
+      controller.impressionist(impressionable, nil, :unique => [:ip_address])
+      controller.impressionist(impressionable, nil, :unique => [:ip_address])
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize different user" do
+      impressionable = Post.create
+      controller.stub(:user_id).and_return(666)
+      controller.impressionist(impressionable, nil, :unique => [:user_id])
+      controller.impressionist(impressionable, nil, :unique => [:user_id])
+      Impression.should have(@impression_count + 1).records
+      controller.stub(:user_id).and_return(42)
+      controller.impressionist(impressionable, nil, :unique => [:user_id])
+      controller.impressionist(impressionable, nil, :unique => [:user_id])
+      Impression.should have(@impression_count + 2).records
+    end
+
+    it "should recognize combined uniqueness" do
+      impressionable = Post.create
+      controller.stub(:session_hash).and_return("foo")
+      controller.impressionist(impressionable, nil, :unique => [:ip_address, :request_hash, :session_hash])
+      controller.impressionist(impressionable, nil, :unique => [:request_hash, :ip_address, :session_hash])
+      controller.impressionist(impressionable, nil, :unique => [:request_hash, :session_hash])
+      controller.impressionist(impressionable, nil, :unique => [:ip_address, :session_hash])
+      controller.impressionist(impressionable, nil, :unique => [:ip_address, :request_hash])
+      controller.impressionist(impressionable, nil, :unique => [:session_hash])
+      controller.impressionist(impressionable, nil, :unique => [:ip_address])
+      controller.impressionist(impressionable, nil, :unique => [:request_hash])
+      Impression.should have(@impression_count + 1).records
+    end
+
+    it "should recognize combined non-uniqueness" do
+      impressionable = Post.create
+      controller.stub(:session_hash).and_return(nil)
+      controller.impressionist(impressionable, nil, :unique => [:ip_address, :session_hash])
+      controller.stub(:session_hash).and_return("foo")
+      controller.impressionist(impressionable, nil, :unique => [:ip_address, :session_hash])
+      controller.stub(:session_hash).and_return("bar")
+      controller.impressionist(impressionable, nil, :unique => [:ip_address, :session_hash])
+      Impression.should have(@impression_count + 3).records
+    end
+
+  end
+
+  describe "impressionist filter and method uniqueness" do
+
+    it "should recognize uniqueness" do
+      impressionable = Post.create
+      controller.stub(:controller_name).and_return("posts") # for correct impressionable type in filter
+      controller.stub(:params).and_return({:id => impressionable.id.to_s}) # for correct impressionable id in filter
+      controller.stub(:session_hash).and_return("foo")
+      controller.request.stub(:remote_ip).and_return("1.2.3.4")
+      # order of the following methods is important for the test!
+      controller.impressionist_subapp_filter(unique: [:ip_address, :request_hash, :session_hash])
+      controller.impressionist(impressionable, nil, :unique => [:ip_address, :request_hash, :session_hash])
+      Impression.should have(@impression_count + 1).records
+    end
+
+  end
+
+  describe 'impressionist with friendly id' do
+    it 'should unique' do
+      impressionable = Profile.create({username: 'test_profile', slug: 'test_profile'})
+
+      controller.stub(:controller_name).and_return('profile')
+      controller.stub(:action_name).and_return('show')
+      controller.stub(:params).and_return({id: impressionable.slug})
+      controller.request.stub(:remote_ip).and_return('1.2.3.4')
+
+      controller.impressionist(impressionable, nil, :unique => [:impressionable_type, :impressionable_id])
+      controller.impressionist(impressionable, nil, :unique => [:impressionable_type, :impressionable_id])
+      Impression.should have(@impression_count + 1).records
+    end
+  end
+
+  shared_examples_for 'an impressionable action' do
+    it 'should record an impression' do
+      controller.impressionist_subapp_filter(condition)
+      Impression.should have(@impression_count + 1).records
+    end
+  end
+
+  shared_examples_for 'an unimpressionable action' do
+    it 'should record an impression' do
+      controller.impressionist_subapp_filter(condition)
+      Impression.should have(@impression_count).records
+    end
+  end
+
+  describe "conditional impressions" do
+    describe ":if condition" do
+      context "true condition" do
+        before do
+          controller.stub(:true_condition).and_return(true)
+        end
+        it_behaves_like 'an impressionable action' do
+          let(:condition) {{ if: :true_condition }}
+        end
+
+        it_behaves_like 'an impressionable action' do
+          let(:condition) {{ if: lambda { true } }}
+        end
+      end
+
+      context "false condition" do
+        before do
+          controller.stub(:false_condition).and_return(false)
+        end
+        it_behaves_like 'an unimpressionable action' do
+          let(:condition) {{ if: :false_condition }}
+        end
+
+        it_behaves_like 'an unimpressionable action' do
+          let(:condition) {{ if: lambda { false } }}
+        end
+      end
+    end
+
+    describe ":unless condition" do
+      context "true condition" do
+        before do
+          controller.stub(:true_condition).and_return(true)
+        end
+        it_behaves_like 'an unimpressionable action' do
+          let(:condition) {{ unless: :true_condition }}
+        end
+
+        it_behaves_like 'an unimpressionable action' do
+          let(:condition) {{ unless: lambda { true } }}
+        end
+      end
+
+      context "false condition" do
+        before do
+          controller.stub(:false_condition).and_return(false)
+        end
+        it_behaves_like 'an impressionable action' do
+          let(:condition) {{ unless: :false_condition }}
+        end
+
+        it_behaves_like 'an impressionable action' do
+          let(:condition) {{ unless: lambda { false } }}
+        end
+      end
+    end
+  end
+end
+