importmap-rails 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 33dce6ec9c0694844753828ea342c40c03dc7cc07460461b37e0310e995b9238
-  data.tar.gz: fa91a5de60f67973d7075e58c0f6ac45cf74bc023d96407072c65c616f546472
+  metadata.gz: 4aeaabf5f2e5ff22f899b925176126c59d50f0160fc380b2614ba90ef187b077
+  data.tar.gz: 7b2a751caf4d3e8a6669fbef2ca9165b5a25681240cb4656e1a24094628e9ff2
 SHA512:
-  metadata.gz: 79168173967c286f3ffa36b912cd6a230159f225d1842a0d458b05a54ec8e53ac051cf7fd5903ffab43348b0bfcdf17f17cb1d065de31af6b4b392a5da33e039
-  data.tar.gz: d8eb7c52ace629023a350c01755f2f3a17a8b835905b019bb51599af9e058e2de213902acb1e3fa5b7d4d31f9a623f075b697b5270f5547de98c087a37096672
+  metadata.gz: 1010224d71e6d9e7d9f4a4da395fd025b87a7c765be93917afb5160cc7a6f2aa25829c4cbad98b49ea2d6b813c5770acff76172dd200fa520219f2e44e80bb8b
+  data.tar.gz: 54c230bb6c7fefeb91f1b84cba05d826c3883a29dfeba49b4e0cbd68253e68cd16acd59240a3a481bd09e75605b44c6fd7664deae4163b5e26dcd1bcb6de1a80

data/README.md

@@ -63,6 +63,27 @@ It's in `app/javascript/application.js` you setup your application by importing
 
 It makes sense to use logical names that match the package names used by npm, such that if you later want to start transpiling or bundling your code, you won't have to change any module imports.
 
+### Local modules
+
+If you want to import local js module files from `app/javascript/src` or other sub-folders of `app/javascript` (such as `channels`), you must pin these to be able to import them.
+You can use `pin_all_from` to pick all files in a specific folder, so you don't have to `pin` each module individually.
+
+```rb
+# config/importmap.rb
+pin_all_from 'app/javascript/src`, under: 'src', to: 'src'
+```
+
+The `:to` parameter is only required if you want to change the destination logical import name. If you drop the :to option, you must place the :under option directly after the first parameter.
+
+Allows you to:
+
+```js
+// app/javascript/application.js
+import { ExampleFunction } from 'src/example_function'
+```
+Which imports the function from `app/javascript/src/example_function.js`.
+
+Note: Sprockets used to serve assets (albeit without filename digests) it couldn't find from the `app/javascripts` folder with logical relative paths, meaning pinning local files wasn't needed. Propshaft doesn't have this fallback, so when you use Propshaft you have to pin your local modules.
 
 ## Using npm packages via JavaScript CDNs
 

data/lib/importmap/map.rb

@@ -145,7 +145,7 @@ class Importmap::Map
     end
 
     def module_path_from(filename, mapping)
-      [ mapping.path || mapping.under, filename.to_s ].compact.join("/")
+      [ mapping.path || mapping.under, filename.to_s ].compact.reject(&:empty?).join("/")
     end
 
     def find_javascript_files_in_tree(path)

data/lib/importmap/npm.rb

@@ -48,8 +48,8 @@ class Importmap::Npm
     # We cannot use the name after "pin" because some dependencies are loaded from inside packages
     # Eg. pin "buffer", to: "https://ga.jspm.io/npm:@jspm/core@2.0.0-beta.19/nodelibs/browser/buffer.js"
 
-    importmap.scan(/^pin .*(?<=npm:|npm\/|skypack\.dev\/|unpkg\.com\/)(.*)(?=@\d+\.\d+\.\d+)@(\d+\.\d+\.\d+(?:[^\/\s"]*)).*$/) |
-      importmap.scan(/^pin "([^"]*)".* #.*@(\d+\.\d+\.\d+(?:[^\s]*)).*$/)
+    importmap.scan(/^pin .*(?<=npm:|npm\/|skypack\.dev\/|unpkg\.com\/)(.*)(?=@\d+\.\d+\.\d+)@(\d+\.\d+\.\d+(?:[^\/\s["']]*)).*$/) |
+      importmap.scan(/^pin ["']([^["']]*)["'].* #.*@(\d+\.\d+\.\d+(?:[^\s]*)).*$/)
   end
 
   private

data/lib/importmap/version.rb

@@ -1,3 +1,3 @@
 module Importmap
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

data/lib/importmap-rails.rb

@@ -3,4 +3,4 @@ end
 
 require "importmap/version"
 require "importmap/reloader"
-require "importmap/engine"
+require "importmap/engine" if defined?(Rails::Railtie)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: importmap-rails
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-18 00:00:00.000000000 Z
+date: 2023-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties