importance 0.2.14 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13f0d850ad8abf42c5a29c7afd3e2c80dd9381c85cc06008d1ff3c56b473361f
-  data.tar.gz: 20c2e53788c462b2041459ea74f1d5d583a7957c6b21a0e64e948c982f1830d4
+  metadata.gz: dbdc483174bf2b9f013661c446a36a6a9c2534413e4f2a284b7ef420521519fe
+  data.tar.gz: 68a6102bd591252119a64c75991ac9973b8c13b3553b12ef0b83ef666c29d5d3
 SHA512:
-  metadata.gz: eb1e8d3b030f659add4ee0ef352457dd22efff8e385e4b2aaa07dd3e6f5619f13e2d5c31b35de4b5356f11fd6fe1588fd2673da88329655ecd1d054b784c900f
-  data.tar.gz: ca2815baf04a533fa00a81cd9d0b3b22b87dd9e5d2506a12ddf66beba7602913950683cc8f1298e1a760e9883d5055884b288a917da3346cbd908e253768cb66
+  metadata.gz: 49455565c8bea02443019f8f5593bfc42d4a5321cacc7ade04ab4a1aeb3e7ace480125c1b5e0c83770478afe5e1aab58e8154cad2783d8f22fcfa186e7712417
+  data.tar.gz: 954f6138def8957247b32088f6caa96d938167128965c1cc9d4af1545f220b0c4f8907722468ba7e46d51864f31fb29a71f0a573b325c24a77a35e385c23dc66

data/README.md

@@ -120,6 +120,43 @@ Importance.configure do |config|
 end
 ```
 
+### Repeatable columns (`multiple: true`)
+
+Sometimes the number of columns is not known when the importer is written: a file may
+carry one quantity column per location, and the location names live in the header row.
+Declare such an attribute with `multiple: true` and it can be mapped to any number of
+columns at once.
+
+```ruby
+importer.attribute :location, [ "Standort", "Location" ], multiple: true
+```
+
+Instead of a single value, the record then carries a hash of file header => value, in the
+column order of the file:
+
+```ruby
+importer.perform do |records|
+  records.each do |record|
+    record[:name]     # => "MTP-4711"
+    record[:location] # => { "WEIS" => 10, "LUBO1" => 10, "LUBO2" => 80, "LOCH" => 0 }
+  end
+end
+```
+
+Details worth knowing:
+
+- Attributes without `multiple: true` behave exactly as before, and mapping two columns
+  to one of them is still rejected with the `duplicate_mapping` error.
+- A `multiple` attribute that is not `optional` requires **at least one** mapped column.
+- Every mapped column appears in the hash, including ones whose cell is empty, so the
+  keys are stable across rows. A row is still skipped when *all* of its values are blank.
+- A mapped column with a blank header gets the positional key `column_N` (1-based) rather
+  than a blank one.
+- If two columns share the same header, the last one wins. Validate in your `perform`
+  block if that matters for your file format.
+- The mapping page does not pre-select columns for `multiple` attributes — the labels are
+  only used to name the option in the dropdown, which the user picks per column.
+
 Add a file upload form to your application. You can use libraries like
 Dropzone.js to create drag and drop interfaces, and you can style them just
 as you wish. Make sure the path stays, and it is a multipart form.
@@ -202,6 +239,7 @@ en:
     use_column_as: Use column as
     ignore: Ignore
     import: Import
+    multiple_label: "%{attribute} (multiple columns)"
 ```
 
 ## Contributing

data/app/controllers/importance/imports_controller.rb

@@ -11,7 +11,7 @@ module Importance
 
       if upload.nil?
         flash[:alert] = t("importance.errors.no_file")
-        redirect_to session[:redirect_url] and return
+        redirect_to redirect_target and return
       end
 
       upload_extension = File.extname(upload.original_filename).downcase
@@ -19,7 +19,7 @@ module Importance
 
       if !supported_extensions.include?(upload_extension)
         flash[:alert] = t("importance.errors.invalid_file_type", types: supported_extensions.join(", "))
-        redirect_to session[:redirect_url] and return
+        redirect_to redirect_target and return
       end
 
       system_tmp_dir = Dir.tmpdir
@@ -31,7 +31,7 @@ module Importance
 
       if !File.exist?(upload_path)
         flash[:alert] = t("importance.errors.no_file")
-        redirect_to session[:redirect_url] and return
+        redirect_to redirect_target and return
       end
 
       FileUtils.mv(upload_path, persist_path)
@@ -46,7 +46,7 @@ module Importance
 
       if @importer.nil?
         flash[:alert] = t("importance.errors.no_importer")
-        redirect_to session[:redirect_url] and return
+        redirect_to redirect_target and return
       end
 
       @importer.add_spreadsheet(session[:path])
@@ -73,7 +73,7 @@ module Importance
       @mappings = params[:mappings].permit!.to_h.map { |k, v| [ k.to_i, v ] }.to_h
 
       @importer.importer_attributes.each do |attribute|
-        next if !attribute.options[:required]
+        next if attribute.options[:optional]
         next if @mappings.values.include?(attribute.key.to_s)
 
         flash[:alert] = t("importance.errors.missing_mapping", attribute: attribute.labels.first)
@@ -82,9 +82,12 @@ module Importance
 
       @mappings.each do |column_index, attribute_name|
         next if attribute_name == ""
+
+        attribute = @importer.importer_attributes.find { |attr| attr.key.to_s == attribute_name }
+        next if attribute&.options&.dig(:multiple) # multiple attributes absorb any number of columns
         next if @mappings.values.count(attribute_name) <= 1
 
-        attribute_label = @importer.importer_attributes.find { |attr| attr.key.to_s == attribute_name }.labels.first
+        attribute_label = attribute&.labels&.first || attribute_name
         flash[:alert] = t("importance.errors.duplicate_mapping", attribute: attribute_label)
         render :map, status: :unprocessable_entity and return
       end
@@ -111,12 +114,21 @@ module Importance
       if @importer.teardown_callback
         instance_exec(&@importer.teardown_callback)
       else
-        redirect_to (session[:redirect_url] || main_app.root_path), notice: t("importance.success.import_completed")
+        redirect_to redirect_target, notice: t("importance.success.import_completed")
       end
-    rescue Importance::ImportException => e
+    rescue => e
       if @importer.error_callback
         instance_exec(e, &@importer.error_callback)
       end
     end
+
+    private
+
+    # Where to send the user when the import finishes or is rejected. The host app may
+    # pass a redirect_url along with the upload; fall back to the application root if it
+    # did not, so an error path never redirects to nil.
+    def redirect_target
+      session[:redirect_url] || main_app.root_path
+    end
   end
 end

data/app/models/importance/header.rb

@@ -4,6 +4,11 @@ module Importance
       attribute_mappings = {}
 
       importer_attributes.each do |attribute|
+        # A multiple attribute spans an unknown number of columns, and this matcher can
+        # claim at most one header per attribute. Pre-selecting a single arbitrary column
+        # would be misleading, so leave them for the user to map by hand.
+        next if attribute.options&.dig(:multiple)
+
         best_header = nil
         best_similarity = 0
 

data/app/views/importance/imports/map.html.erb

@@ -14,7 +14,10 @@
               <%= form.select "mappings[#{file_header_idx}]",
                               options_for_select(
                                 [[t('importance.ignore'), ""]] + 
-                                @importer.importer_attributes.map { |attr| [attr.labels.first, attr.key] },
+                                @importer.importer_attributes.map { |attr|
+                                  label = attr.options[:multiple] ? t('importance.multiple_label', attribute: attr.labels.first) : attr.labels.first
+                                  [label, attr.key]
+                                },
                                 default_value
                               ), {}, class: @layout.select_class %>
             </th>

data/config/locales/de.yml

@@ -3,6 +3,7 @@ de:
     use_column_as: Spalte verwenden als
     ignore: Ignorieren
     import: Importieren
+    multiple_label: "%{attribute} (mehrere Spalten)"
     import_description: Es werden %{count} von %{full_count} Beispieldatensätzen angezeigt.
     errors:
       no_importer: Kein Importer ausgewählt.

data/config/locales/en.yml

@@ -3,6 +3,7 @@ en:
     use_column_as: Use column as
     ignore: Ignore
     import: Import
+    multiple_label: "%{attribute} (multiple columns)"
     import_description: Showing %{count} of %{full_count} sample records.
     errors:
       no_importer: No importer selected.

data/config/locales/fr.yml

@@ -3,6 +3,7 @@ fr:
     use_column_as: Utiliser la colonne comme
     ignore: Ignorer
     import: Importer
+    multiple_label: "%{attribute} (plusieurs colonnes)"
     import_description: Affichage de %{count} sur %{full_count} exemples d'enregistrements.
     errors:
       no_importer: Aucun importateur sélectionné.

data/config/locales/it.yml

@@ -3,6 +3,7 @@ it:
     use_column_as: Utilizzare come
     ignore: Ignora
     import: Importare
+    multiple_label: "%{attribute} (più colonne)"
     import_description: Mostrati %{count} di %{full_count} record di esempio.
     errors:
       no_importer: Nessun importatore selezionato.

data/lib/importance/configuration.rb

@@ -34,6 +34,12 @@ module Importance
     end
 
     def attribute(key, labels, options = {})
+      if options[:multiple] && Array(labels).empty?
+        raise ArgumentError, "attribute #{key.inspect} is declared multiple: true but has no labels; " \
+                             "labels are what the mapping dropdown and error messages display"
+      end
+
+      @multiple_keys = nil
       @attributes << OpenStruct.new(key: key, labels: labels, options: options)
     end
 
@@ -60,10 +66,11 @@ module Importance
     def add_spreadsheet(path)
       workbook = Roo::Spreadsheet.open(path, { csv_options: { encoding: "bom|utf-8" } })
       @worksheet = workbook.sheet(0)
+      @file_headers = nil
     end
 
     def file_headers
-      @worksheet.row(1)
+      @file_headers ||= @worksheet.row(1)
     end
 
     def samples
@@ -78,13 +85,22 @@ module Importance
       @attributes
     end
 
+    # Keys (as strings) of the attributes declared with multiple: true.
+    def multiple_keys
+      @multiple_keys ||= @attributes.select { |attr| attr.options[:multiple] }.map { |attr| attr.key.to_s }
+    end
+
     # Yields each processed row (a hash of attribute => value) to the given block.
     # Skips empty rows (all values nil or empty).
     def each_processed_row(path, mappings)
       @worksheet.each_with_index do |row, idx|
         next if idx == 0 # Skip header row
         record = process_row(row, mappings)
-        next if record.empty? || record.values.all? { |v| v.nil? || v.to_s.strip.empty? }
+        next if record.empty?
+        # A multiple attribute holds a hash, whose #to_s is never empty - look at its
+        # values instead, or empty trailing rows would be imported.
+        values = record.values.flat_map { |v| v.is_a?(Hash) ? v.values : [ v ] }
+        next if values.all? { |v| v.nil? || v.to_s.strip.empty? }
         yield record
       end
     end
@@ -92,17 +108,38 @@ module Importance
     # Turn a row of the form ["Hans", "Robert", 1970, "male", "Apple Inc.", "hr@apple.com"]
     # and a mapping of the form {"0"=>"first_name", "1"=>"last_name", "2"=>"", "3"=>"", "4"=>"", "5"=>"email"}
     # into a record of the form { first_name: "Hans", last_name: "Robert", email: "hr@apple.com" }
+    #
+    # Attributes declared with multiple: true may be mapped to any number of columns and
+    # collect a hash of file header => value instead of a single value, e.g.
+    # { location: { "WEIS" => 10, "LUBO1" => 80 } }.
     def process_row(row, mappings)
       record = {}
 
       mappings.each do |column_index, attribute_name|
         next if attribute_name.nil? || attribute_name == ""
-        value = row[column_index.to_i]
-        record[attribute_name.to_sym] = value
+
+        idx = column_index.to_i
+        value = row[idx]
+
+        if multiple_keys.include?(attribute_name.to_s)
+          record[attribute_name.to_sym] ||= {}
+          record[attribute_name.to_sym][header_name_for(idx)] = value
+        else
+          record[attribute_name.to_sym] = value
+        end
       end
 
       record
     end
+
+    private
+
+    # The file header of a column, used as the key for multiple attributes. Columns with a
+    # blank header fall back to a positional name so they never collide on a nil key.
+    def header_name_for(column_index)
+      name = file_headers[column_index].to_s.strip
+      name.empty? ? "column_#{column_index + 1}" : name
+    end
   end
 
   def self.configure

data/lib/importance/version.rb

@@ -1,3 +1,3 @@
 module Importance
-  VERSION = "0.2.14"
+  VERSION = "0.3.0"
 end

data/lib/importance.rb

@@ -1,7 +1,6 @@
 require "importance/version"
 require "importance/engine"
 require "importance/configuration"
-require "importance/import_exception"
 require "generators/importance/install/install_generator" if defined?(Rails::Generators)
 
 module Importance

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: importance
 version: !ruby/object:Gem::Version
-  version: 0.2.14
+  version: 0.3.0
 platform: ruby
 authors:
 - Lukas_Skywalker
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-11-27 00:00:00.000000000 Z
+date: 2026-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -88,7 +88,6 @@ files:
 - lib/importance.rb
 - lib/importance/configuration.rb
 - lib/importance/engine.rb
-- lib/importance/import_exception.rb
 - lib/importance/version.rb
 - lib/tasks/importance_tasks.rake
 homepage: https://github.com/code-fabrik/importance
@@ -99,7 +98,7 @@ metadata:
   homepage_uri: https://github.com/code-fabrik/importance
   source_code_uri: https://github.com/code-fabrik/importance
   changelog_uri: https://github.com/code-fabrik/importance
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -114,8 +113,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key: 
+rubygems_version: 3.5.16
+signing_key:
 specification_version: 4
 summary: Flexible Excel and CSV import engine with column mapping for Rails applications
 test_files: []

data/lib/importance/import_exception.rb

@@ -1,4 +0,0 @@
-module Importance
-  class ImportException < StandardError
-  end
-end