implicit_rendering 0.1.2 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 054b31dc40e71f2b8d722f6dcf4e2e48f4fbd0cf5f9653e9ef9077954e90afaf
-  data.tar.gz: dcb7e93cc6636e1380167e45fa5412c1074be128a1990f56b95d7647f6c69553
+  metadata.gz: a485c155742515c2b8ba986eb6e67b25107b5cfbb7a21dfb96a9297a4880d851
+  data.tar.gz: aaab8dbb66276a464644174825f2c20e1c0502c31b1b232cf3feb46f6236c01e
 SHA512:
-  metadata.gz: 6b1c0752c01c45bd15e5a619da810637a0059fc94b26de96dad2c7002f986c3b6b92aaee68ac3b6ba7f65ccfd40d80e2135398b7b85311390eaa151a78f604fc
-  data.tar.gz: fe36aa9858e16570a8f450d56b725ed3aa401c654b7c4ea7e98b22f021bbecc6699c7ad78870d2a2b1f457fcbe11a7e32ab0c993a2719d97ed06f58684cec00b
+  metadata.gz: 4c4ec9f9ad8dddc3522879f31d57f4aa6a862345ba6059a526aa0f8f623e598095d5a9ea3f39ac3dea043a7304e4dec7d4d328062f276826b1beb37b4d67f0d1
+  data.tar.gz: 5dfc4432d26b8bb1a9923a3c2ec2b2fc05f66ce6fc65cc1ecae22cc88f59ea6b268e57d47aa35be6a77fa348ae5958305f18274adb02a25da10baf6e4ec36d04

data/.github/workflows/rspec.yml

@@ -0,0 +1,15 @@
+name: RSpec Tests
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    name: CI
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: '3.0' # Not needed with a .ruby-version file
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - run: bundle exec rake spec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    implicit_rendering (0.1.1)
+    implicit_rendering (0.1.4)
       actionpack
       activesupport
       zeitwerk

data/lib/CHANGELOG.md

@@ -1,7 +1,17 @@
+## ImplicitRendering 0.1.4
+
+* Fix bug for existing templates in combination with explicit `render` call
+
+## ImplicitRendering 0.1.3
+
+* Fix bug for existing templates
+
+
 ## ImplicitRendering 0.1.2
 
 * Added `action_before_implicit_render`
 
+
 ## ImplicitRendering 0.1.1
 
 * Initial release

data/lib/implicit_rendering/version.rb

@@ -1,3 +1,3 @@
 module ImplicitRendering
-  VERSION = '0.1.2'.freeze
+  VERSION = '0.1.4'.freeze
 end

data/lib/implicit_rendering.rb

@@ -17,22 +17,27 @@ module ImplicitRendering
   end
 
   def default_render
-    template_name = self.class.implicit_render_mapping&.dig(action_name)
+    override_template_name = self.class.implicit_render_mapping&.dig(action_name)
 
-    return super unless perform_implicit_rendering?(template_name)
+    return super unless perform_implicit_rendering?(action_name, override_template_name)
 
-    render template_name
+    render override_template_name
   end
 
   def render(options={})
-    if options.is_a?(Hash) && (template_name = self.class.implicit_render_mapping&.dig(options[:action].to_s))
+    if options.is_a?(Hash) &&
+      (override_template_name = self.class.implicit_render_mapping&.dig(options[:action].to_s)) &&
+      perform_implicit_rendering?(options[:action], override_template_name)
+
       @action_before_implicit_render = options[:action]
-      options[:action] = template_name
+      options[:action] = override_template_name
     end
     super
   end
 
-  def perform_implicit_rendering?(template_name)
+  def perform_implicit_rendering?(action_name, template_name)
+    return false if template_exists?(action_name.to_s, _prefixes, variants: request.variant)
+
     template_name.present? &&
       self.class.implicit_render_formats.any? {|format| request.format == format }
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: implicit_rendering
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.4
 platform: ruby
 authors:
 - Alexander Pauly
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-14 00:00:00.000000000 Z
+date: 2022-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -157,6 +157,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/rspec.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -191,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: Adjust default template names for Rails