impala 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 488007beb7a8a2ecc5e1663356305ea2d2a705d1
-  data.tar.gz: 4e7276e73ee5d17e790116fc38f59938e00d5e15
+  metadata.gz: d6d04d8e537a01c0ba40812df78ee3746c11ef63
+  data.tar.gz: 3de3a3dea1535e62fa72fe55efa3ae60506b7802
 SHA512:
-  metadata.gz: 6e903365b98beb2a78e2a2a4bea721035ca58344b54e196ba67ae15ac814a20024ef79565d019dc390a58529ff80cc760f254d67080833e21fdb44f90f164eeb
-  data.tar.gz: 0d43d9e6442237bd7ecc27ff9770bc3e51058d166a847200c1830b5466bb3c51250be848b8563922618dc10199c716f487bd01d3e5c40ba97188205d137375e4
+  metadata.gz: 9e1b70f914e5ce0fb488d19c0048f53506c1a9c329126385919831e396833db7b867d68db356aa99ff29129b100a1be61c9c70dfa8c4b4c506d5be63a59f5dc6
+  data.tar.gz: 1a5e96394a14b0af13d9e1e388a896bc7d4265b7acee77a7875cef8ca32abc2be9d4c60c645f0207982685a99ecf8e770a6e0aa97ebd7a2a3cb727b53b7da578

data/lib/impala/connection.rb

@@ -65,8 +65,8 @@ module Impala
     #   except for :user, see TImpalaQueryOptions in ImpalaService.thrift
     # @option query_options [String] :user the user runs the query
     # @return [Array<Hash>] an array of hashes, one for each row.
-    def query(raw_query, query_options = {})
-      execute(raw_query, query_options).fetch_all
+    def query(query, query_options = {})
+      execute(query, query_options).fetch_all
     end
 
     # Perform a query and return a cursor for iterating over the results.
@@ -75,29 +75,19 @@ module Impala
     #   except for :user, see TImpalaQueryOptions in ImpalaService.thrift
     # @option query_options [String] :user the user runs the query
     # @return [Cursor] a cursor for the result rows
-    def execute(raw_query, query_options = {})
+    def execute(query, query_options = {})
       raise ConnectionError.new("Connection closed") unless open?
 
-      query = sanitize_query(raw_query)
       handle = send_query(query, query_options)
-
       check_result(handle)
       Cursor.new(handle, @service)
     end
 
     private
 
-    def sanitize_query(raw_query)
-      words = raw_query.split
-      raise InvalidQueryError.new("Empty query") if words.empty?
-
-      command = words.first.downcase
-      ([command] + words[1..-1]).join(' ')
-    end
-
-    def send_query(sanitized_query, query_options)
+    def send_query(query_text, query_options)
       query = Protocol::Beeswax::Query.new
-      query.query = sanitized_query
+      query.query = query_text
 
       query.hadoop_user = query_options.delete(:user) if query_options[:user]
       query.configuration = query_options.map do |key, value|

data/lib/impala/version.rb

@@ -1,3 +1,3 @@
 module Impala
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
 end

data/test/test_impala.rb

@@ -29,22 +29,6 @@ describe 'Impala.connect' do
 end
 
 describe Impala::Connection do
-  describe '#sanitize_query' do
-    before do
-      Impala::Connection.any_instance.stubs(:open)
-      @connection = Impala::Connection.new('test', 1234)
-    end
-
-    it 'should downcase the command but nothing else' do
-      query = 'SELECT blah FROM Blah'
-      assert_equal('select blah FROM Blah', @connection.send(:sanitize_query, query))
-    end
-
-    it 'should reject empty or invalid queries' do
-      assert_raises(Impala::InvalidQueryError) { @connection.send(:sanitize_query, '')}
-    end
-  end
-
   describe '#check_result' do
     before do
       Impala::Connection.any_instance.stubs(:open)
@@ -66,12 +50,12 @@ describe Impala::Connection do
       Impala::Connection.any_instance.stubs(:open)
       Impala::Cursor.stubs(:new)
       @connection = Impala::Connection.new('test', 1234)
-      @connection.stubs(:open? => true, :sanitize_query => 'sanitized_query', :check_result => nil)
+      @connection.stubs(:open? => true, :check_result => nil)
     end
 
-    it 'should call Protocol::ImpalaService::Client#executeAndWait with the sanitized query' do
+    it 'should call Protocol::ImpalaService::Client#executeAndWait with the query' do
       query = Impala::Protocol::Beeswax::Query.new
-      query.query = 'sanitized_query'
+      query.query = 'query'
       query.configuration = []
 
       @service = stub()
@@ -83,7 +67,7 @@ describe Impala::Connection do
 
     it 'should call Protocol::ImpalaService::Client#executeAndWait with the hadoop_user and configuration if passed as parameter' do
       query = Impala::Protocol::Beeswax::Query.new
-      query.query = 'sanitized_query'
+      query.query = 'query'
       query.hadoop_user = 'impala'
       query.configuration = %w|NUM_SCANNER_THREADS=8 MEM_LIMIT=3221225472|
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: impala
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Colin Marc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-25 00:00:00.000000000 Z
+date: 2017-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thrift
@@ -202,7 +202,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.4.5.2
 signing_key: 
 specification_version: 4
 summary: A ruby client for Cloudera's Impala