impala 0.4.0 → 0.4.1

data/lib/impala/connection.rb

@@ -58,7 +58,10 @@ module Impala
     # @option query_options [String] :user the user runs the query
     # @return [Array<Hash>] an array of hashes, one for each row.
     def query(raw_query, query_options = {})
-      execute(raw_query, query_options).fetch_all
+      cursor = execute(raw_query, query_options)
+      cursor.fetch_all
+    ensure
+      cursor.close
     end
 
     # Perform a query and return a cursor for iterating over the results.

data/lib/impala/version.rb

@@ -1,3 +1,3 @@
 module Impala
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

data/test/test_impala.rb

@@ -99,4 +99,19 @@ describe Impala::Connection do
       @connection.execute('query', opt)
     end
   end
+
+  describe '#query' do
+    before do
+      Impala::Cursor.any_instance.stubs(:fetch_more)
+      @cursor = Impala::Cursor.new(nil, nil)
+      Impala::Connection.any_instance.stubs(:open)
+      @connection = Impala::Connection.new('test', 1234)
+      @connection.stubs(:open? => true, :sanitize_query => 'sanitized_query', :check_result => nil, :execute => @cursor)
+    end
+
+    it 'should close the cursor after returning a value' do
+      @cursor.expects(:close).once
+      @connection.query('query')
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: impala
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-01 00:00:00.000000000 Z
+date: 2014-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thrift
@@ -228,12 +228,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -146128838497320562
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -146128838497320562
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23