imogen 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 501d565f9750790ca1339cdb3ab5e13c4c8f1b88
-  data.tar.gz: 53c8ca7c304e5f83e6450a5da27cd1a9d54ee666
+SHA256:
+  metadata.gz: fa9d6f61ab8d5aa8f99517c1d4d638cf3a5cb508179d05cf8262bd24f796df35
+  data.tar.gz: 27dc10c53681b2fbd7ea25b258dd5d049c5bbf5b31dc4e01d16d25f829798300
 SHA512:
-  metadata.gz: b02498db95b990e0d0d45d1760f409a16c13534f4728e0709d4e91fae99c4cbce7e96bf26c5c624e100762d5e69419e03471dc8daf8ede199eb3b776a4fdce0d
-  data.tar.gz: 7734e6e312916a9f8098947881353308767f859285d6e5382d61311243524390608abce700e0f7554ea8f64098cb98d128c2c9911ba4077f0fc6eaab8eedd2b8
+  metadata.gz: f482b46a68ae037dd849cac3232ec7fe74a4902fde31a5c84c7ec323cbddb61a1138aa4192d58092b80acdbc0ae4475569e4d14bb4c17513d18cb8637cad5ae4
+  data.tar.gz: e54a8310bb1af53d1cb6f2287ea6aa23fade2cf51980cc3096dec7fe91844b77c982d46373df67c0028a385175e1276cc7deed5356515e695339cff912cf8bf3

data/lib/imogen/iiif/rotation.rb

@@ -3,10 +3,8 @@ module Iiif
 class Rotation < Transform
   RIGHT_ANGLES = [0,90,180,270]
   def get(rotate)
-    if rotate.nil? or rotate.eql? '0'
-      return nil
-    end
-    raise BadRequest.new("bad rotate #{rotate}") unless rotate =~ /^-?\d+$/
+    return nil if [nil, 0, '0'].include?(rotate)
+    raise BadRequest.new("bad rotate #{rotate}") unless rotate.to_s =~ /^-?\d+$/
     # negate offset because IIIF spec counts clockwise, FreeImage counterclockwise
     r = (rotate.to_i * -1) % 360
     r = r + 360 if r < 0
@@ -23,4 +21,4 @@ class Rotation < Transform
   end
 end
 end
-end
+end

data/spec/unit/imogen_iiif_rotate_spec.rb

@@ -7,7 +7,9 @@ describe Imogen::Iiif::Rotation, type: :unit do
   subject {Imogen::Iiif::Rotation.new(@test_image)}
   describe "#get" do
     describe "with values mod 360 in 90 degree rotations" do
-      it "should nil for 0 or nil" do
+      it "should nil for 0 or '0' or nil" do
+        expect(subject.get(0)).to be_nil
+        expect(subject.get(360)).to be_nil
         expect(subject.get("360")).to be_nil
         expect(subject.get("-360")).to be_nil
         expect(subject.get("0")).to be_nil
@@ -15,6 +17,7 @@ describe Imogen::Iiif::Rotation, type: :unit do
       end
       # IIIF rotation is opposite FreeImage
       it "should calculate for positive values" do
+        expect(subject.get(90)).to eql(270)
         expect(subject.get("90")).to eql(270)
         expect(subject.get("180")).to eql(180)
         expect(subject.get("270")).to eql(90)
@@ -22,6 +25,7 @@ describe Imogen::Iiif::Rotation, type: :unit do
       end
       # IIIF rotation is opposite FreeImage
       it "should calculate for negative values" do
+        expect(subject.get(-90)).to eql(90)
         expect(subject.get("-90")).to eql(90)
         expect(subject.get("-180")).to eql(180)
         expect(subject.get("-270")).to eql(270)
@@ -29,11 +33,12 @@ describe Imogen::Iiif::Rotation, type: :unit do
       end
     end
     it "should reject arbitrary integer and float values" do
-        expect{subject.get("2")}.to raise_error Imogen::Iiif::BadRequest
-        expect{subject.get("90.0")}.to raise_error Imogen::Iiif::BadRequest
+      expect{subject.get(2)}.to raise_error Imogen::Iiif::BadRequest
+      expect{subject.get("2")}.to raise_error Imogen::Iiif::BadRequest
+      expect{subject.get("90.0")}.to raise_error Imogen::Iiif::BadRequest
     end
     it "should reject bad values" do
-        expect{subject.get("-2,")}.to raise_error Imogen::Iiif::BadRequest
+      expect{subject.get("-2,")}.to raise_error Imogen::Iiif::BadRequest
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: imogen
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Ben Armintor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-23 00:00:00.000000000 Z
+date: 2019-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-opencv
@@ -79,8 +79,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: derivative generation via FreeImage and smart square thumbnail via OpenCV