immosquare-cleaner 1.2.3 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53d2dc2a160c411d3acbeb2dc03692343ef60b598468fe288bfca2ec85667e87
-  data.tar.gz: 802af16e18bb055b0f6a6a77b2e9ec47d2a1dab3d7a624ee848cd4f813f27e48
+  metadata.gz: 7caffdb6ce093eae93ca5f22d1e25676d935bbd8f034805307d53bd20e69c201
+  data.tar.gz: 3fa0fc3dc8f247f866f89108a13752aee5761b9e0fcb1f62071bb2de3eb35add
 SHA512:
-  metadata.gz: c75021c32ffb683d464ef3834eb0e40bec740645f7be9afc045942b99093b160ad6e9867798858d37b030e34227a2f1b31df72895e9e376cd704f82af4e522a4
-  data.tar.gz: d4023816cebb368e5bff4bbc5ac7b824135532b2d738b74a0df0c530923a375bef4ee627a77f31d09ffd22d1e44bcc94f3e77d241963eb83ca142d8d039f98d8
+  metadata.gz: e94943fb8aedca8ff9d71bd0dcc4a9a4360392806b814b8e72dbed789d37b3bdfe0952c95bf7c19bc3fc26038920de831577d44894f97fa032a5f9e2f6c8bb7c
+  data.tar.gz: 1d27e92164cf050d08421c100af8d181a696ba8b3c0c25648d669ef269cff5b2b724fccf4fe8d40da5785949aa7fc99640dec8797e788640fcf37eda9cadf346

data/lib/immosquare-cleaner/configuration.rb

@@ -2,16 +2,19 @@ module ImmosquareCleaner
   class Configuration
 
     attr_accessor(:rubocop_options, :htmlbeautifier_options, :erblint_options, :exclude_files)
+    attr_reader :ruby_target_version
 
     def initialize
       @rubocop_options        = nil
+      @ruby_target_version    = nil
       @htmlbeautifier_options = nil
       @erblint_options        = nil
       @exclude_files          = []
     end
 
-
-
+    def ruby_target_version=(version)
+      @ruby_target_version = version.nil? ? nil : RubyTarget.normalize(version)
+    end
 
   end
 end

data/lib/immosquare-cleaner/processors/erb.rb

@@ -22,14 +22,14 @@ module ImmosquareCleaner
         ##                        rubocop-X.Y.Z.yml)
         ## --autocorrect        : apply autocorrectable offenses in place
         ##============================================================##
-        config_path            = "#{ImmosquareCleaner.gem_root}/linters/erb-lint-#{RUBY_VERSION}.yml"
+        config_path            = ImmosquareCleaner.linter_config_path("erb-lint", origin_path)
         htmlbeautifier_options = ImmosquareCleaner.configuration.htmlbeautifier_options || "--keep-blank-lines 4"
         erblint_options        = ImmosquareCleaner.configuration.erblint_options || "--autocorrect"
         escaped_file           = Shellwords.escape(file_path)
 
         cmds = [
           "bundle exec htmlbeautifier #{escaped_file} #{htmlbeautifier_options}",
-          "bundle exec erb_lint --config #{config_path} #{escaped_file} #{erblint_options}"
+          "bundle exec erb_lint --config #{Shellwords.escape(config_path)} #{escaped_file} #{erblint_options}"
         ]
 
         launch_cmds(cmds)

data/lib/immosquare-cleaner/processors/javascript.rb

@@ -70,9 +70,9 @@ module ImmosquareCleaner
             ## HTML-context linters off the host string literals.
             ##============================================================##
             config_basename = file_path.downcase.end_with?(*JS_ERB_EXTENSIONS) ? "js-erb-lint" : "erb-lint"
-            erblint_config  = "#{ImmosquareCleaner.gem_root}/linters/#{config_basename}-#{RUBY_VERSION}.yml"
+            erblint_config  = ImmosquareCleaner.linter_config_path(config_basename, origin_path)
             erblint_options = ImmosquareCleaner.configuration.erblint_options || "--autocorrect"
-            cmds << "bundle exec erb_lint --config #{erblint_config} #{escaped_temp} #{erblint_options}"
+            cmds << "bundle exec erb_lint --config #{Shellwords.escape(erblint_config)} #{escaped_temp} #{erblint_options}"
           else
             cmds << "bun #{ImmosquareCleaner.gem_root}/linters/normalize-comments.mjs #{escaped_temp}"
           end

data/lib/immosquare-cleaner/processors/ruby.rb

@@ -47,9 +47,9 @@ module ImmosquareCleaner
         ##                       overhead and breaks custom cop loading
         ##============================================================##
         rubocop_options = ImmosquareCleaner.configuration.rubocop_options || "--autocorrect-all --no-parallel"
-        config_path     = "#{ImmosquareCleaner.gem_root}/linters/rubocop-#{RUBY_VERSION}.yml"
+        config_path     = ImmosquareCleaner.linter_config_path("rubocop", origin_path)
 
-        cmds = ["bundle exec rubocop -c #{config_path} #{Shellwords.escape(file_path)} #{rubocop_options}"]
+        cmds = ["bundle exec rubocop -c #{Shellwords.escape(config_path)} #{Shellwords.escape(file_path)} #{rubocop_options}"]
         launch_cmds(cmds)
         normalize_last_line
       end

data/lib/immosquare-cleaner/ruby_target.rb

@@ -0,0 +1,109 @@
+module ImmosquareCleaner
+  class RubyTarget
+
+    MUTEX                     = Mutex.new
+    GEMSPEC_REQUIREMENT_REGEX = /required_ruby_version\s*=\s*(?:Gem::Requirement\.new\()?\s*(\[[^\]]*\]|"[^"]*"|'[^']*')/
+    RUBY_VERSION_FILE_REGEX   = /\A(?:ruby-)?(\d+\.\d+)/
+    LOWER_BOUND_OPERATORS     = [">=", ">", "~>", "="].freeze
+    PROJECT_MARKERS           = ["Gemfile", ".git"].freeze
+
+    class << self
+
+      ##============================================================##
+      ## RuboCop targets Ruby releases rather than patch versions.
+      ## Explicit targets must be supported by the installed RuboCop.
+      ##============================================================##
+      def normalize(version)
+        value = version.to_s
+        raise(ArgumentError, "ruby_target_version must be a Ruby version such as 3.2 or 3.2.6") if !value.match?(/\A\d+\.\d+(?:\.\d+)?\z/)
+
+        target = release(value)
+        validate!(target)
+        target
+      end
+
+      def release(version)
+        Gem::Version.new(version).segments.first(2).join(".")
+      end
+
+      ##============================================================##
+      ## Target of the project that owns the file: the gemspec minimum
+      ## (a gem must keep working on the oldest Ruby it accepts), then
+      ## .ruby-version, then the running Ruby. The lookup stops at the
+      ## project root so a parent folder's .ruby-version never applies.
+      ## Autocorrect with a newer target can introduce syntax that the
+      ## project's Ruby rejects (`_1` rewritten to `it`, Ruby 3.4+).
+      ##============================================================##
+      def detect(path)
+        directory = File.dirname(File.expand_path(path))
+        MUTEX.synchronize do
+          @detected ||= {}
+          @detected[directory] ||= supported_target(declared_version(directory)) || release(RUBY_VERSION)
+        end
+      end
+
+      private
+
+      def declared_version(directory)
+        loop do
+          gemspecs = Dir.glob("*.gemspec", :base => directory).sort
+          version  = gemspec_minimum(directory, gemspecs) || ruby_version_file(directory)
+          return release(version) if version
+          return nil if gemspecs.any? || PROJECT_MARKERS.any? {|marker| File.exist?(File.join(directory, marker)) }
+
+          parent = File.dirname(directory)
+          return nil if parent == directory
+
+          directory = parent
+        end
+      end
+
+      def gemspec_minimum(directory, gemspecs)
+        gemspecs.each do |name|
+          declaration = File.read(File.join(directory, name))[GEMSPEC_REQUIREMENT_REGEX, 1]
+          next if declaration.nil?
+
+          requirement = Gem::Requirement.new(*declaration.scan(/["']([^"']+)["']/).flatten)
+          bounds      = requirement.requirements.filter_map {|operator, version| version if LOWER_BOUND_OPERATORS.include?(operator) }
+          return bounds.max.to_s if bounds.any?
+        rescue Gem::Requirement::BadRequirementError
+          next
+        end
+        nil
+      end
+
+      def ruby_version_file(directory)
+        path = File.join(directory, ".ruby-version")
+        File.file?(path) ? File.read(path).strip[RUBY_VERSION_FILE_REGEX, 1] : nil
+      end
+
+      ##============================================================##
+      ## A declared version the installed RuboCop cannot target falls
+      ## back to the running Ruby: cleaning must never stop on it.
+      ##============================================================##
+      def supported_target(target)
+        return nil if target.nil?
+        return target if target == release(RUBY_VERSION)
+
+        validate!(target)
+        target
+      rescue ArgumentError => e
+        warn("immosquare-cleaner: #{e.message}; using Ruby #{release(RUBY_VERSION)}")
+        nil
+      end
+
+      def validate!(target)
+        require "rubocop"
+
+        config = RuboCop::Config.new({"AllCops" => {"TargetRubyVersion" => target}}, __FILE__)
+        raise(ArgumentError, "ruby_target_version #{target.inspect} does not match RuboCop's effective target #{config.target_ruby_version}") if config.target_ruby_version.to_s != target
+
+        config.validate_after_resolution
+      rescue RuboCop::ValidationError => e
+        raise(ArgumentError, "Invalid ruby_target_version #{target.inspect}: #{e.message}")
+      end
+
+    end
+
+  end
+end

data/lib/immosquare-cleaner/version.rb

@@ -1,3 +1,3 @@
 module ImmosquareCleaner
-  VERSION = "1.2.3".freeze
+  VERSION = "1.3.0".freeze
 end

data/lib/immosquare-cleaner.rb

@@ -4,6 +4,8 @@ require "json"
 require "immosquare-yaml"
 require "immosquare-extensions"
 require "fileutils"
+require "digest"
+require_relative "immosquare-cleaner/ruby_target"
 require_relative "immosquare-cleaner/configuration"
 require_relative "immosquare-cleaner/markdown"
 require_relative "immosquare-cleaner/directory_cleaner"
@@ -39,6 +41,9 @@ require_relative "immosquare-cleaner/processors/prettier"
 ## See: https://github.com/Shopify/erb_lint/blob/main/lib/erb_lint/linter_registry.rb#L7
 ##============================================================##
 module ImmosquareCleaner
+  LINTER_CONFIG_MUTEX = Mutex.new
+  LINTER_CONFIG_NAMES = ["rubocop", "erb-lint", "js-erb-lint"].freeze
+
   class << self
 
     ##============================================================##
@@ -66,11 +71,6 @@ module ImmosquareCleaner
     end
 
     def clean(file_path, origin_path = nil)
-      ##============================================================##
-      ## Ensure linter configurations are ready
-      ##============================================================##
-      setup_linter_configs!
-
       ##============================================================##
       ## Return if the file is in the exclusion list or is a generator
       ## template. With `-p`, file_path is a /tmp copy: the template
@@ -101,6 +101,17 @@ module ImmosquareCleaner
       File.expand_path("..", __dir__)
     end
 
+    ##============================================================##
+    ## path : the file's location in its project (origin_path), which
+    ##        decides the Ruby target unless ruby_target_version is set
+    ##============================================================##
+    def linter_config_path(name, path)
+      raise(ArgumentError, "Unknown Ruby linter configuration") if !LINTER_CONFIG_NAMES.include?(name)
+
+      target = configuration.ruby_target_version || RubyTarget.detect(path)
+      setup_linter_configs!(target).fetch(name)
+    end
+
     ##============================================================##
     ## Processor registry — order matters.
     ##
@@ -136,36 +147,43 @@ module ImmosquareCleaner
     end
 
     ##============================================================##
-    ## Setup linter with the correct ruby version
-    ## This is run once to avoid redundant file operations.
+    ## Configs are shared by target Ruby and template fingerprint.
+    ## Atomic writes and a mutex prevent partially generated YAML
+    ## during parallel cleaning; template edits invalidate the cache.
     ##============================================================##
-    def setup_linter_configs!
-      @setup_linter_configs ||= begin
-        rubocop_config_with_version_path = "#{gem_root}/linters/rubocop-#{RUBY_VERSION}.yml"
-
-        if !File.exist?(rubocop_config_with_version_path)
-          rubocop_config                                  = YAML.load_file("#{gem_root}/linters/rubocop.yml")
-          rubocop_config["AllCops"]["TargetRubyVersion"]  = RUBY_VERSION
-          rubocop_config["AllCops"]["ParserEngine"]       = RUBY_VERSION >= "3.3" ? "parser_prism" : "parser_whitequark"
-          File.write(rubocop_config_with_version_path, rubocop_config.to_yaml)
+    def setup_linter_configs!(target)
+      templates = LINTER_CONFIG_NAMES.to_h {|name| [name, File.join(gem_root, "linters", "#{name}.yml")] }
+      signature = templates.values.map {|path| [File.mtime(path), File.size(path)] }
+      LINTER_CONFIG_MUTEX.synchronize do
+        @linter_configs ||= {}
+        key = [target, signature]
+        return @linter_configs[key] if @linter_configs.key?(key)
+
+        sources = templates.transform_values {|path| File.read(path) }
+        fingerprint = Digest::SHA256.hexdigest(sources.values.join("\n")).slice(0, 16)
+        paths = LINTER_CONFIG_NAMES.to_h {|name| [name, File.join(gem_root, "linters", "#{name}-#{target}-#{fingerprint}.yml")] }
+        rubocop_config = YAML.safe_load(sources.fetch("rubocop"))
+        rubocop_config["AllCops"]["TargetRubyVersion"] = target
+        rubocop_config["AllCops"]["ParserEngine"] = Gem::Version.new(target) >= Gem::Version.new("3.3") ? "parser_prism" : "parser_whitequark"
+        write_linter_config(paths.fetch("rubocop"), rubocop_config)
+
+        ["erb-lint", "js-erb-lint"].each do |name|
+          config = YAML.safe_load(sources.fetch(name))
+          config["linters"]["Rubocop"]["rubocop_config"]["inherit_from"] = ["linters/#{File.basename(paths.fetch("rubocop"))}"]
+          write_linter_config(paths.fetch(name), config)
         end
+        @linter_configs[key] = paths.freeze
+      end
+    end
 
-        ##============================================================##
-        ## erb_lint configs that inherit the versioned rubocop config.
-        ## - erb-lint     : default config for .html.erb
-        ## - js-erb-lint  : JS-specific config for .js.erb / .ts.erb / etc.
-        ##============================================================##
-        ["erb-lint", "js-erb-lint"].each do |basename|
-          versioned_path = "#{gem_root}/linters/#{basename}-#{RUBY_VERSION}.yml"
-          next if File.exist?(versioned_path)
-
-          config                                                         = YAML.load_file("#{gem_root}/linters/#{basename}.yml")
-          config["linters"]["Rubocop"]["rubocop_config"]["inherit_from"] = ["linters/rubocop-#{RUBY_VERSION}.yml"]
-          File.write(versioned_path, config.to_yaml)
-        end
+    def write_linter_config(path, config)
+      return if File.file?(path)
 
-        true
-      end
+      temporary = "#{path}.#{Process.pid}.#{Thread.current.object_id}.tmp"
+      File.write(temporary, config.to_yaml)
+      File.rename(temporary, path)
+    ensure
+      File.delete(temporary) if temporary && File.file?(temporary)
     end
 
   end

data/linters/rubocop/cop/custom_cops/style/align_routes.rb

@@ -0,0 +1,308 @@
+module RuboCop
+  module Cop
+    module CustomCops
+      module Style
+        ##============================================================##
+        ## This cop aligns the blocks of Rails routes in
+        ## `config/routes.rb` and `config/routes/*.rb`: inside a
+        ## block of consecutive route lines, the verb, the path,
+        ## the target and every option (`:as`, `:via`,
+        ## `:constraints`...) start in the same column. Options are
+        ## aligned by name: a route without `:via` leaves that
+        ## column empty and its `:as` lands under the `:as` of its
+        ## neighbours.
+        ##
+        ## Only whitespace changes: paths, targets, options and
+        ## comments come out identical, in the same order. The
+        ## corrections only rewrite the gaps between tokens, never
+        ## a token itself, so they cannot clash with the
+        ## corrections of other cops.
+        ##
+        ## The option columns follow an order compatible with the
+        ## order of every route in the block (`:via` before `:as`
+        ## when a route carries them in that order, even when a
+        ## neighbour without `:via` meets `:as` first). When two
+        ## routes impose opposite orders, the block is left alone:
+        ## no alignment can satisfy both without reordering.
+        ##
+        ## Recognized shapes: `get "a" => "c#a", :as => ...`, the
+        ## same call with parentheses (`match("a" => "c#a", ...)`),
+        ## and the shape without a positional target
+        ## (`match "404", :to => ...`).
+        ##
+        ## @example
+        ## bad
+        ## get "users" => "users#index", :as => :users
+        ## match "users/:id" => "users#update", :via => [:patch, :put], :as => :user
+        ##
+        ## good
+        ## get   "users"     => "users#index",                            :as => :users
+        ## match "users/:id" => "users#update", :via => [:patch, :put], :as => :user
+        ##============================================================##
+        class AlignRoutes < RuboCop::Cop::Base
+
+          extend AutoCorrector
+
+          MSG = "Align the columns of consecutive routes.".freeze
+
+          VERBS = [:get, :post, :put, :patch, :delete, :match].freeze
+
+          ##============================================================##
+          ## Only the files Rails loads its routes from. A `get`
+          ## call anywhere else is not a route.
+          ##============================================================##
+          ROUTES_FILE = %r{config/routes(?:/[^/]+\.rb|\.rb)\z}
+
+          def on_new_investigation
+            @routes = []
+          end
+
+          def on_send(node)
+            return unless routes_file?
+            return unless VERBS.include?(node.method_name)
+            return unless node.receiver.nil?
+
+            route = parse_route(node)
+            @routes << route if route
+          end
+
+          def on_investigation_end
+            groups.each {|group| check_group(group) }
+          end
+
+          private
+
+          def routes_file?
+            path = processed_source.file_path
+            path.nil? || ROUTES_FILE.match?(path.to_s)
+          end
+
+          ##============================================================##
+          ## A route line cut into segments: verb, path, target when
+          ## there is one, then its options under their name (`:as`,
+          ## `:via`...), in the order the line carries them. Every
+          ## segment keeps its source range, so the corrections can
+          ## address the gaps between segments. Nil when the call
+          ## is not a single-line route starting its line.
+          ##============================================================##
+          def parse_route(node)
+            range = node.source_range
+            return if range.first_line != range.last_line
+
+            line = processed_source.lines[range.first_line - 1]
+            return if line.nil? || !line.strip.start_with?(node.source.strip)
+
+            first = node.arguments.first
+            return if first.nil?
+
+            if first.hash_type?
+              return if first.braces? || first.pairs.empty?
+
+              pair = first.pairs.first
+              return unless pair.key.str_type?
+
+              target_pair = pair
+              path_range  = pair.key.source_range
+              rest_pairs  = first.pairs.drop(1)
+            elsif first.str_type?
+              target_pair = nil
+              path_range  = first.source_range
+              rest_pairs  = []
+              if node.arguments.size > 1
+                hash = node.arguments[1]
+                return unless hash.hash_type? && !hash.braces?
+
+                rest_pairs = hash.pairs
+              end
+            else
+              return
+            end
+
+            segments = [{:kind => :path, :range => path_range}]
+            segments << {:kind => :target, :range => target_pair.value.source_range, :pair => target_pair} if target_pair
+            rest_pairs.each_with_index do |pair, index|
+              key = pair.key.sym_type? ? ":#{pair.key.value}" : "__raw#{index}"
+              segments << {:kind => :option, :key => key, :range => pair.source_range}
+            end
+
+            {:node => node, :line => range.first_line, :segments => segments}
+          end
+
+          ##============================================================##
+          ## Blocks of routes on adjacent lines. Any other line
+          ## (comment, `scope`, `end`, a route this cop does not
+          ## recognize...) puts at least one line between two
+          ## routes and so closes the block. Two routes sharing a
+          ## line are dropped: aligning them would rewrite the
+          ## same line twice.
+          ##============================================================##
+          def groups
+            sorted = @routes.sort_by {|route| route[:node].source_range.begin_pos }
+            counts = sorted.map {|route| route[:line] }.tally
+            sorted = sorted.reject {|route| counts[route[:line]] > 1 }
+
+            sorted.chunk_while {|a, b| b[:line] == a[:line] + 1 }.to_a
+          end
+
+          ##============================================================##
+          ## Check one block: compute the column of every segment,
+          ## then flag each route whose gaps differ, correcting
+          ## gap by gap.
+          ##============================================================##
+          def check_group(group)
+            return if group.size < 2
+
+            keys = ordered_keys(group)
+            return if keys.nil?
+
+            place_segments(group, keys)
+
+            group.each do |route|
+              corrections = corrections_for(route)
+              next if corrections.empty?
+
+              add_offense(route[:node], :message => MSG) do |corrector|
+                corrections.each {|range, text| corrector.replace(range, text) }
+              end
+            end
+          end
+
+          ##============================================================##
+          ## The column of every segment of every route of the
+          ## block: first `=>` in one column, then one column per
+          ## option name, in the order computed for the block. The
+          ## comma stays glued to the value before it, the spaces
+          ## follow it.
+          ##============================================================##
+          def place_segments(group, keys)
+            verb_width = group.map {|route| route[:node].method_name.length }.max
+            path_width = group.map {|route| segment(route, :path)[:range].size }.max
+
+            group.each do |route|
+              node       = route[:node]
+              path_start = node.source_range.column + verb_width + 1
+              segment(route, :path)[:start] = path_start
+
+              target = segment(route, :target)
+              head_end =
+                if target
+                  target[:start] = path_start + path_width + 4
+                  target[:start] + target[:range].size
+                else
+                  path_start + path_width
+                end
+              route[:head_end] = head_end
+            end
+
+            starts = {}
+            column = group.map {|route| route[:head_end] }.max + 2
+            keys.each do |key|
+              starts[key] = column
+              followers = keys.drop(keys.index(key) + 1)
+              ends      = group.filter_map do |route|
+                option = route[:segments].find {|seg| seg[:key] == key }
+                column + option[:range].size if option && (option_keys(route) & followers).any?
+              end
+              column = ends.max + 2 if ends.any?
+            end
+
+            group.each do |route|
+              route[:segments].each do |seg|
+                seg[:start] = starts[seg[:key]] if seg[:kind] == :option
+              end
+            end
+          end
+
+          ##============================================================##
+          ## The gaps of one route that do not match the computed
+          ## columns, as [range, expected text] pairs. Ranges only
+          ## ever span whitespace and the commas separating the
+          ## segments, never a segment itself.
+          ##============================================================##
+          def corrections_for(route)
+            node        = route[:node]
+            selector    = node.loc.selector
+            path        = segment(route, :path)
+            corrections = []
+
+            if node.loc.begin
+              replace_gap(corrections, selector.end_pos, node.loc.begin.begin_pos, "")
+              replace_gap(corrections, node.loc.begin.end_pos, path[:range].begin_pos, "")
+            else
+              replace_gap(corrections, selector.end_pos, path[:range].begin_pos,
+                " " * (path[:start] - selector.column - selector.size))
+            end
+
+            previous = path
+            if (target = segment(route, :target))
+              operator = target[:pair].loc.operator
+              ##============================================================##
+              ## The `=>` sits 3 columns before the target (its 2
+              ## chars plus the space after it); the path ends, in
+              ## the aligned line, at its start plus its length.
+              ##============================================================##
+              replace_gap(corrections, path[:range].end_pos, operator.begin_pos,
+                " " * ((target[:start] - 3) - (path[:start] + path[:range].size)))
+              replace_gap(corrections, operator.end_pos, target[:range].begin_pos, " ")
+              previous = target
+            end
+
+            route[:segments].select {|seg| seg[:kind] == :option }.each do |option|
+              prev_end = previous[:start] + previous[:range].size
+              replace_gap(corrections, previous[:range].end_pos, option[:range].begin_pos,
+                ",#{" " * (option[:start] - prev_end - 1)}")
+              previous = option
+            end
+            corrections
+          end
+
+          ##============================================================##
+          ## Record a gap correction when the current text differs.
+          ##============================================================##
+          def replace_gap(corrections, begin_pos, end_pos, expected)
+            range = Parser::Source::Range.new(processed_source.buffer, begin_pos, end_pos)
+            return if range.source == expected
+
+            corrections << [range, expected]
+          end
+
+          def segment(route, kind)
+            route[:segments].find {|seg| seg[:kind] == kind }
+          end
+
+          def option_keys(route)
+            route[:segments].filter_map {|seg| seg[:key] }
+          end
+
+          ##============================================================##
+          ## The order of the option columns: the first one
+          ## compatible with the order every route gives its
+          ## options, keeping first-encounter order on ties. Nil
+          ## when two routes impose opposite orders.
+          ##============================================================##
+          def ordered_keys(group)
+            keys         = group.flat_map {|route| option_keys(route) }.uniq
+            predecessors = Hash.new {|hash, key| hash[key] = [] }
+            group.each do |route|
+              option_keys(route).each_cons(2) do |before, after|
+                predecessors[after] << before unless predecessors[after].include?(before)
+              end
+            end
+
+            sorted    = []
+            remaining = keys.dup
+            while remaining.any?
+              ready = remaining.select {|key| (predecessors[key] - sorted).empty? }
+              return if ready.empty?
+
+              sorted << ready.first
+              remaining.delete(ready.first)
+            end
+            sorted
+          end
+
+        end
+      end
+    end
+  end
+end

data/linters/rubocop.yml

@@ -5,6 +5,7 @@ require:
   - rubocop/cop/custom_cops/style/align_assignments
   - rubocop/cop/custom_cops/style/inline_multiline_calls
   - rubocop/cop/custom_cops/style/kwarg_priority_order
+  - rubocop/cop/custom_cops/style/align_routes
 
 # Enable all RuboCop methods and turn caching on for large files
 AllCops:
@@ -127,6 +128,10 @@ Style/RescueModifier:
   Enabled: false # Allow inline rescue modifier (some_method rescue SomeException)
 Style/ArrayIntersect:
   Enabled: false # The cop assumes the receiver of `include?` is a collection, so `MARKERS.any? { |m| some_string.include?(m) }` (searching several markers in one string) is rewritten as `MARKERS.intersect?(some_string)`. `Array#intersect?` only takes an Array, so the corrected code raises `TypeError: no implicit conversion of String into Array` — at runtime, not on save. The correction is unsafe, hence applied by our `--autocorrect-all`. Fixed upstream in rubocop/rubocop#15439 but unreleased as of 1.88.2; re-enable once a release ships it. To match several markers in a string, use `some_string.match?(Regexp.union(*MARKERS))`.
+Style/HashSlice:
+  AutoCorrect: false # The cop assumes the receiver of `select {|key, _value| LIST.include?(key) }` is a Hash and rewrites it as `.slice(*LIST)`. On an Array of pairs (e.g. `Gem::Requirement#requirements`) the corrected code raises `TypeError: no implicit conversion of String into Integer` at runtime. The correction is unsafe, hence applied by our `--autocorrect-all`. Keep the warning, drop the rewrite.
+Style/HashExcept:
+  AutoCorrect: false # Same receiver guess as Style/HashSlice: `reject {|key, _value| LIST.include?(key) }` on an Array of pairs becomes `.except(*LIST)`, which Array does not define (NoMethodError at runtime). Keep the warning, drop the rewrite.
 Style/NestedParenthesizedCalls:
   Enabled: false # Redundant with Style/MethodCallWithArgsParentheses (require_parentheses) — both flag `outer(inner arg)`. RuboCop dedupes the inserted `(` but not the matching `)`, and erb_lint's integration ships both corrections independently → output gets an extra `)` (e.g. `j(render :partial => "x")` becomes `j(render(:partial => "x")))`, breaking the ERB at render time).
 
@@ -257,8 +262,11 @@ CustomCops/Style/KwargPriorityOrder:
     - remote
     - method
 
+CustomCops/Style/AlignRoutes:
+  Enabled: true # Align the columns of consecutive routes in config/routes.rb and config/routes/*.rb
+
 #################### GEM ###########################
 Gemspec/RequireMFA:
   Enabled: false # Don't require MFA to push a gem
 Gemspec/RequiredRubyVersion:
-  Enabled: false # TargetRubyVersion is always set to the Ruby running the cleaner, so it never matches the minimum a gemspec declares (`>= 3.2.6` vs 4.0.x): the cop would flag every gemspec.
+  Enabled: false # Not autocorrectable, and TargetRubyVersion can come from ruby_target_version or .ruby-version rather than the gemspec: the cop would only report noise.

data/package.json

@@ -9,10 +9,10 @@
   "dependencies": {
     "@babel/parser":                    "^8.0.7",
     "@eslint/js":                       "^10.0.1",
-    "@typescript-eslint/eslint-plugin": "^8.71.2",
-    "@typescript-eslint/parser":        "^8.71.2",
+    "@typescript-eslint/eslint-plugin": "^8.72.0",
+    "@typescript-eslint/parser":        "^8.72.0",
     "@typescript/native":               "npm:typescript@^7.0.2",
-    "eslint":                           "^10.12.0",
+    "eslint":                           "^10.13.0",
     "eslint-plugin-align-import":       "^1.0.0",
     "eslint-plugin-erb":                "^2.1.1",
     "eslint-plugin-prefer-arrow":       "^1.2.3",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: immosquare-cleaner
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.3.0
 platform: ruby
 authors:
 - immosquare
@@ -181,9 +181,8 @@ files:
 - lib/immosquare-cleaner/processors/shell.rb
 - lib/immosquare-cleaner/processors/toml.rb
 - lib/immosquare-cleaner/processors/yaml.rb
+- lib/immosquare-cleaner/ruby_target.rb
 - lib/immosquare-cleaner/version.rb
-- linters/erb-lint-4.0.6.yml
-- linters/erb-lint-4.0.7.yml
 - linters/erb-lint.yml
 - linters/erb_lint/custom_align_consecutive_calls.rb
 - linters/erb_lint/custom_html_to_content_tag.rb
@@ -191,15 +190,12 @@ files:
 - linters/eslint-plugins/align-assignments.mjs
 - linters/eslint-plugins/eslint10-compat.mjs
 - linters/eslint.config.mjs
-- linters/js-erb-lint-4.0.6.yml
-- linters/js-erb-lint-4.0.7.yml
 - linters/js-erb-lint.yml
 - linters/normalize-comments.mjs
 - linters/prettier.yml
-- linters/rubocop-4.0.6.yml
-- linters/rubocop-4.0.7.yml
 - linters/rubocop.yml
 - linters/rubocop/cop/custom_cops/style/align_assignments.rb
+- linters/rubocop/cop/custom_cops/style/align_routes.rb
 - linters/rubocop/cop/custom_cops/style/comment_normalization.rb
 - linters/rubocop/cop/custom_cops/style/font_awesome_normalization.rb
 - linters/rubocop/cop/custom_cops/style/inline_multiline_calls.rb
@@ -228,7 +224,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.22
+rubygems_version: 4.0.23
 specification_version: 4
 summary: One command to format every file of a repository, built to run as an AI agent
   hook.

data/linters/erb-lint-4.0.6.yml

@@ -1,22 +0,0 @@
----
-EnableDefaultLinters: true
-linters:
-  NoJavascriptTagHelper:
-    enabled: false
-  SpaceInHtmlTag:
-    enabled: false
-  CustomSingleLineIfModifier:
-    enabled: true
-  CustomHtmlToContentTag:
-    enabled: true
-  CustomAlignConsecutiveCalls:
-    enabled: true
-    methods:
-    - link_to
-  Rubocop:
-    enabled: true
-    rubocop_config:
-      inherit_from:
-      - linters/rubocop-4.0.6.yml
-      Layout/TrailingWhitespace:
-        Enabled: false

data/linters/erb-lint-4.0.7.yml

@@ -1,27 +0,0 @@
----
-EnableDefaultLinters: true
-linters:
-  NoJavascriptTagHelper:
-    enabled: false
-  SpaceInHtmlTag:
-    enabled: false
-  AllowedScriptType:
-    enabled: true
-    allowed_types:
-    - text/javascript
-    - module
-  CustomSingleLineIfModifier:
-    enabled: true
-  CustomHtmlToContentTag:
-    enabled: true
-  CustomAlignConsecutiveCalls:
-    enabled: true
-    methods:
-    - link_to
-  Rubocop:
-    enabled: true
-    rubocop_config:
-      inherit_from:
-      - linters/rubocop-4.0.7.yml
-      Layout/TrailingWhitespace:
-        Enabled: false

data/linters/js-erb-lint-4.0.6.yml

@@ -1,26 +0,0 @@
----
-EnableDefaultLinters: true
-linters:
-  NoJavascriptTagHelper:
-    enabled: false
-  SpaceInHtmlTag:
-    enabled: false
-  SelfClosingTag:
-    enabled: false
-  RequireInputAutocomplete:
-    enabled: false
-  DeprecatedClassesInline:
-    enabled: false
-  HardCodedString:
-    enabled: false
-  CustomHtmlToContentTag:
-    enabled: false
-  CustomSingleLineIfModifier:
-    enabled: true
-  Rubocop:
-    enabled: true
-    rubocop_config:
-      inherit_from:
-      - linters/rubocop-4.0.6.yml
-      Layout/TrailingWhitespace:
-        Enabled: false

data/linters/js-erb-lint-4.0.7.yml

@@ -1,26 +0,0 @@
----
-EnableDefaultLinters: true
-linters:
-  NoJavascriptTagHelper:
-    enabled: false
-  SpaceInHtmlTag:
-    enabled: false
-  SelfClosingTag:
-    enabled: false
-  RequireInputAutocomplete:
-    enabled: false
-  DeprecatedClassesInline:
-    enabled: false
-  HardCodedString:
-    enabled: false
-  CustomHtmlToContentTag:
-    enabled: false
-  CustomSingleLineIfModifier:
-    enabled: true
-  Rubocop:
-    enabled: true
-    rubocop_config:
-      inherit_from:
-      - linters/rubocop-4.0.7.yml
-      Layout/TrailingWhitespace:
-        Enabled: false

data/linters/rubocop-4.0.6.yml

@@ -1,219 +0,0 @@
----
-require:
-- rubocop/cop/style/method_call_with_args_parentheses_override
-- rubocop/cop/custom_cops/style/comment_normalization
-- rubocop/cop/custom_cops/style/font_awesome_normalization
-- rubocop/cop/custom_cops/style/align_assignments
-- rubocop/cop/custom_cops/style/inline_multiline_calls
-- rubocop/cop/custom_cops/style/kwarg_priority_order
-AllCops:
-  NewCops: enable
-  EnabledByDefault: false
-  UseCache: true
-  SuggestExtensions: false
-  ActiveSupportExtensionsEnabled: true
-  TargetRubyVersion: 4.0.6
-  ParserEngine: parser_prism
-Metrics:
-  Enabled: false
-Lint/UselessAssignment:
-  Enabled: false
-Lint/RescueException:
-  Enabled: false
-Lint/UnusedMethodArgument:
-  Enabled: false
-Lint/UselessOr:
-  Enabled: false
-Lint/InterpolationCheck:
-  AutoCorrect: false
-Naming/VariableNumber:
-  Enabled: false
-Naming/FileName:
-  Enabled: false
-Naming/MethodParameterName:
-  MinNameLength: 1
-Layout/LeadingEmptyLines:
-  Enabled: false
-Layout/InitialIndentation:
-  Enabled: false
-Layout/TrailingEmptyLines:
-  Enabled: false
-Layout/ExtraSpacing:
-  Enabled: false
-Layout/LineLength:
-  Enabled: false
-Layout/TrailingWhitespace:
-  Enabled: true
-Layout/EmptyLines:
-  Enabled: false
-Layout/LeadingCommentSpace:
-  Enabled: false
-Layout/SpaceInsideBlockBraces:
-  SpaceBeforeBlockParameters: false
-Layout/EmptyLinesAroundClassBody:
-  EnforcedStyle: empty_lines
-Layout/FirstHashElementIndentation:
-  EnforcedStyle: consistent
-Layout/ArgumentAlignment:
-  EnforcedStyle: with_fixed_indentation
-Layout/HashAlignment:
-  EnforcedHashRocketStyle: table
-Layout/MultilineAssignmentLayout:
-  EnforcedStyle: same_line
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-Style/CombinableLoops:
-  Enabled: false
-Style/SingleArgumentDig:
-  Enabled: false
-Style/RedundantBegin:
-  Enabled: false
-Style/MultilineTernaryOperator:
-  Enabled: false
-Style/NestedTernaryOperator:
-  Enabled: false
-Style/MultilineIfModifier:
-  Enabled: false
-Style/FrozenStringLiteralComment:
-  Enabled: false
-Style/Next:
-  Enabled: false
-Style/Documentation:
-  Enabled: false
-Style/IfUnlessModifierOfIfUnless:
-  Enabled: false
-Style/NegatedIf:
-  Enabled: false
-Style/FormatStringToken:
-  EnforcedStyle: template
-Style/NumericPredicate:
-  EnforcedStyle: comparison
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-Style/StringLiteralsInInterpolation:
-  EnforcedStyle: double_quotes
-Style/HashSyntax:
-  EnforcedStyle: hash_rockets
-Style/WordArray:
-  EnforcedStyle: brackets
-Style/SymbolArray:
-  EnforcedStyle: brackets
-Style/RescueModifier:
-  Enabled: false
-Style/ArrayIntersect:
-  Enabled: false
-Style/NestedParenthesizedCalls:
-  Enabled: false
-Style/MethodCallWithArgsParentheses:
-  Enabled: true
-  EnforcedStyle: require_parentheses
-  IgnoreMacros: false
-  AllowedMethods:
-  - require
-  - require_relative
-  - include
-  - extend
-  - prepend
-  - raise
-  - fail
-  - yield
-  - attr_accessor
-  - attr_reader
-  - attr_writer
-  - run
-  - exec
-  - load
-  - gem
-  - group
-  - source
-  - ruby
-  - install_plugin
-  - desc
-  - task
-  - namespace
-  - before_action
-  - after_action
-  - around_action
-  - skip_before_action
-  - prepend_before_action
-  - append_before_action
-  - helper_method
-  - layout
-  - rescue_from
-  - belongs_to
-  - has_many
-  - has_one
-  - has_and_belongs_to_many
-  - validates
-  - validate
-  - validates_presence_of
-  - validates_uniqueness_of
-  - validates_length_of
-  - validates_format_of
-  - validates_numericality_of
-  - validates_inclusion_of
-  - validates_exclusion_of
-  - validates_confirmation_of
-  - validates_acceptance_of
-  - validates_absence_of
-  - validates_associated
-  - validates_each
-  - validates_with
-  - after_initialize
-  - after_find
-  - before_validation
-  - after_validation
-  - before_save
-  - after_save
-  - around_save
-  - before_create
-  - after_create
-  - around_create
-  - before_update
-  - after_update
-  - around_update
-  - before_destroy
-  - after_destroy
-  - around_destroy
-  - after_touch
-  - after_commit
-  - after_rollback
-  - delegate
-  - enum
-  - get
-  - post
-  - put
-  - patch
-  - delete
-  - options
-  - head
-  - match
-  - root
-  - rake
-  - every
-  - command
-  - set
-  - append
-  - server
-  - after
-CustomCops/Style/CommentNormalization:
-  Enabled: true
-CustomCops/Style/FontAwesomeNormalization:
-  Enabled: true
-CustomCops/Style/AlignAssignments:
-  Enabled: false
-CustomCops/Style/InlineMultilineCalls:
-  Enabled: true
-  Methods:
-  - link_to
-CustomCops/Style/KwargPriorityOrder:
-  Enabled: true
-  Methods:
-  - link_to
-  PriorityKeys:
-  - remote
-  - method
-Gemspec/RequireMFA:
-  Enabled: false

data/linters/rubocop-4.0.7.yml

@@ -1,234 +0,0 @@
----
-require:
-- rubocop/cop/style/method_call_with_args_parentheses_override
-- rubocop/cop/custom_cops/style/comment_normalization
-- rubocop/cop/custom_cops/style/font_awesome_normalization
-- rubocop/cop/custom_cops/style/align_assignments
-- rubocop/cop/custom_cops/style/inline_multiline_calls
-- rubocop/cop/custom_cops/style/kwarg_priority_order
-AllCops:
-  NewCops: enable
-  EnabledByDefault: false
-  UseCache: true
-  SuggestExtensions: false
-  ActiveSupportExtensionsEnabled: true
-  TargetRubyVersion: 4.0.7
-  ParserEngine: parser_prism
-Metrics:
-  Enabled: false
-Lint/UselessAssignment:
-  Enabled: false
-Lint/RescueException:
-  Enabled: false
-Lint/UnusedMethodArgument:
-  Enabled: false
-Lint/UselessOr:
-  Enabled: false
-Lint/InterpolationCheck:
-  AutoCorrect: false
-Naming/VariableNumber:
-  Enabled: false
-Naming/FileName:
-  Enabled: false
-Naming/MethodParameterName:
-  MinNameLength: 1
-Naming/PredicateMethod:
-  AllowedMethods:
-  - call
-  - move_to_cache
-  - move_to_store
-  - save
-  - check_health
-  - elastic_import_with_progressbar
-Layout/LeadingEmptyLines:
-  Enabled: false
-Layout/InitialIndentation:
-  Enabled: false
-Layout/TrailingEmptyLines:
-  Enabled: false
-Layout/ExtraSpacing:
-  Enabled: false
-Layout/LineLength:
-  Enabled: false
-Layout/TrailingWhitespace:
-  Enabled: true
-Layout/EmptyLines:
-  Enabled: false
-Layout/LeadingCommentSpace:
-  Enabled: false
-Layout/SpaceInsideBlockBraces:
-  SpaceBeforeBlockParameters: false
-Layout/EmptyLinesAroundClassBody:
-  EnforcedStyle: empty_lines
-Layout/FirstHashElementIndentation:
-  EnforcedStyle: consistent
-Layout/ArgumentAlignment:
-  EnforcedStyle: with_fixed_indentation
-Layout/HashAlignment:
-  EnforcedHashRocketStyle: table
-Layout/MultilineAssignmentLayout:
-  EnforcedStyle: same_line
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-Style/CombinableLoops:
-  Enabled: false
-Style/SingleArgumentDig:
-  Enabled: false
-Style/RedundantBegin:
-  Enabled: false
-Style/MultilineTernaryOperator:
-  Enabled: false
-Style/NestedTernaryOperator:
-  Enabled: false
-Style/MultilineIfModifier:
-  Enabled: false
-Style/FrozenStringLiteralComment:
-  Enabled: false
-Style/Next:
-  Enabled: false
-Style/Documentation:
-  Enabled: false
-Style/IfUnlessModifierOfIfUnless:
-  Enabled: false
-Style/NegatedIf:
-  Enabled: false
-Style/FormatStringToken:
-  EnforcedStyle: template
-  Mode: conservative
-Style/OptionalBooleanParameter:
-  AllowedMethods:
-  - respond_to_missing?
-  - perform
-Style/NumericPredicate:
-  EnforcedStyle: comparison
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-Style/StringLiteralsInInterpolation:
-  EnforcedStyle: double_quotes
-Style/HashSyntax:
-  EnforcedStyle: hash_rockets
-Style/WordArray:
-  EnforcedStyle: brackets
-Style/SymbolArray:
-  EnforcedStyle: brackets
-Style/RescueModifier:
-  Enabled: false
-Style/ArrayIntersect:
-  Enabled: false
-Style/NestedParenthesizedCalls:
-  Enabled: false
-Style/MethodCallWithArgsParentheses:
-  Enabled: true
-  EnforcedStyle: require_parentheses
-  IgnoreMacros: false
-  AllowedMethods:
-  - require
-  - require_relative
-  - include
-  - extend
-  - prepend
-  - raise
-  - fail
-  - yield
-  - attr_accessor
-  - attr_reader
-  - attr_writer
-  - run
-  - exec
-  - load
-  - gem
-  - group
-  - source
-  - ruby
-  - install_plugin
-  - desc
-  - task
-  - namespace
-  - before_action
-  - after_action
-  - around_action
-  - skip_before_action
-  - prepend_before_action
-  - append_before_action
-  - helper_method
-  - layout
-  - rescue_from
-  - belongs_to
-  - has_many
-  - has_one
-  - has_and_belongs_to_many
-  - validates
-  - validate
-  - validates_presence_of
-  - validates_uniqueness_of
-  - validates_length_of
-  - validates_format_of
-  - validates_numericality_of
-  - validates_inclusion_of
-  - validates_exclusion_of
-  - validates_confirmation_of
-  - validates_acceptance_of
-  - validates_absence_of
-  - validates_associated
-  - validates_each
-  - validates_with
-  - after_initialize
-  - after_find
-  - before_validation
-  - after_validation
-  - before_save
-  - after_save
-  - around_save
-  - before_create
-  - after_create
-  - around_create
-  - before_update
-  - after_update
-  - around_update
-  - before_destroy
-  - after_destroy
-  - around_destroy
-  - after_touch
-  - after_commit
-  - after_rollback
-  - delegate
-  - enum
-  - get
-  - post
-  - put
-  - patch
-  - delete
-  - options
-  - head
-  - match
-  - root
-  - rake
-  - every
-  - command
-  - set
-  - append
-  - server
-  - after
-CustomCops/Style/CommentNormalization:
-  Enabled: true
-CustomCops/Style/FontAwesomeNormalization:
-  Enabled: true
-CustomCops/Style/AlignAssignments:
-  Enabled: false
-CustomCops/Style/InlineMultilineCalls:
-  Enabled: true
-  Methods:
-  - link_to
-CustomCops/Style/KwargPriorityOrder:
-  Enabled: true
-  Methods:
-  - link_to
-  PriorityKeys:
-  - remote
-  - method
-Gemspec/RequireMFA:
-  Enabled: false
-Gemspec/RequiredRubyVersion:
-  Enabled: false