immosquare-cleaner 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7665690ab0d77f314f9feaa5a957d405e6180b886bc6ec0f8489984e4bb32b96
-  data.tar.gz: f8879a8bdbf932fd97f984ecac4a22b36e7ba223b6db7ef1f0f213375c34d785
+  metadata.gz: 7165a24bce4d5074d6c51081764a2689116e996bafa14ed85ddc1fc43ea50e29
+  data.tar.gz: a8b504859e4cfe9f9f1ecf552a058fad07a773b54639630601feee28c5038aeb
 SHA512:
-  metadata.gz: 952cac84543b75a8bf42cd2adf738bd702e2d0c424b069103aedc9145b522f10ad8aa5883e03b9532b6232ff605213f3e4c1bc781420fc35b5b21da693723cb0
-  data.tar.gz: 761039c215cf757e82f24b02e302dac4195f22a2233d336e94940d71ca2345eaea72c305bd3a8ace4658441f7bf3e9615bef7da2a1614c8050661b3ea989607a
+  metadata.gz: b6dbd75516dc30b9cecc8c6400597ec6b75c99a70882c9d2bc18523b7dada2d670ecd20287c4de7cdd6e0ad2a2949c64254f6a37b2856ca2cfa434427008809b
+  data.tar.gz: 69c695dc0204e4ef7a7ebfeaec6d1fcad0f5ba8adb8622d33dfc983a31b1453c8c668d149f31dfc344a17083a12c052bffa608c8d4dbd39b3545a6fc3d631f81

data/lib/immosquare-cleaner/version.rb

@@ -1,3 +1,3 @@
 module ImmosquareCleaner
-  VERSION = "1.0.1".freeze
+  VERSION = "1.0.2".freeze
 end

data/linters/erb_lint/custom_single_line_if_modifier.rb

@@ -74,7 +74,7 @@ module ERBLint
           context = {
             :new_code       => "<%= #{new_code} %>",
             :output_node    => output_node,
-            :is_output_node => is_output_erb?(output_node)
+            :is_output_node => output_erb?(output_node)
           }
 
           add_offense(full_range, MSG, context)
@@ -102,9 +102,9 @@ module ERBLint
         ## output_node should be <%= (output)
         ## end_node should be <% (not <%=)
         ##============================================================##
-        return false unless is_statement_erb?(if_node)
-        return false unless is_output_erb?(output_node)
-        return false unless is_statement_erb?(end_node)
+        return false unless statement_erb?(if_node)
+        return false unless output_erb?(output_node)
+        return false unless statement_erb?(end_node)
 
         ##============================================================##
         ## Extract and validate the code
@@ -133,7 +133,7 @@ module ERBLint
       ##============================================================##
       ## Check if ERB node is a statement (<% ... %>)
       ##============================================================##
-      def is_statement_erb?(erb_node)
+      def statement_erb?(erb_node)
         indicator = erb_node.children.first
         indicator.nil? || (indicator.respond_to?(:children) && indicator.children.first.nil?)
       end
@@ -141,7 +141,7 @@ module ERBLint
       ##============================================================##
       ## Check if ERB node is an output (<%= ... %>)
       ##============================================================##
-      def is_output_erb?(erb_node)
+      def output_erb?(erb_node)
         indicator = erb_node.children.first
         indicator.respond_to?(:children) && indicator.children.first == "="
       end

data/linters/rubocop/cop/custom_cops/style/comment_normalization.rb

@@ -104,16 +104,13 @@ module RuboCop
                 in_code = !in_code
                 body << text
                 content_seen = true
-              elsif in_code || text.match?(RAW_LINE)
+              elsif verbatim_line?(text, in_code)
                 body << text
                 content_seen = true
               elsif text == BLANK_LINE
                 body << BLANK_LINE if content_seen
               elsif text.match?(USER_SEPARATOR)
                 body << INSIDE_SEPARATOR if content_seen
-              elsif text.match?(STRUCTURED_LINE) || text.match?(INDENTED_LINE)
-                body << text
-                content_seen = true
               else
                 body << cleaned_line(text)
                 content_seen = true
@@ -123,6 +120,20 @@ module RuboCop
             body
           end
 
+          ##============================================================##
+          ## Lines kept as written. Precedence matters: inside a code
+          ## block or on a raw line everything is verbatim, even "##" or
+          ## a separator; elsewhere a blank line and a user separator win
+          ## over the structured/indented patterns ("##   ---" is a
+          ## separator, not an indented line).
+          ##============================================================##
+          def verbatim_line?(text, in_code)
+            return true if in_code || text.match?(RAW_LINE)
+            return false if text == BLANK_LINE || text.match?(USER_SEPARATOR)
+
+            text.match?(STRUCTURED_LINE) || text.match?(INDENTED_LINE)
+          end
+
           ##============================================================##
           ## Cleans up a standard text line:
           ## - "### foo"  → "## foo"  (collapse repeated #)

data/linters/rubocop-4.0.7.yml

@@ -32,6 +32,14 @@ Naming/FileName:
   Enabled: false
 Naming/MethodParameterName:
   MinNameLength: 1
+Naming/PredicateMethod:
+  AllowedMethods:
+  - call
+  - move_to_cache
+  - move_to_store
+  - save
+  - check_health
+  - elastic_import_with_progressbar
 Layout/LeadingEmptyLines:
   Enabled: false
 Layout/InitialIndentation:
@@ -88,6 +96,11 @@ Style/NegatedIf:
   Enabled: false
 Style/FormatStringToken:
   EnforcedStyle: template
+  Mode: conservative
+Style/OptionalBooleanParameter:
+  AllowedMethods:
+  - respond_to_missing?
+  - perform
 Style/NumericPredicate:
   EnforcedStyle: comparison
 Style/StringLiterals:

data/linters/rubocop.yml

@@ -37,6 +37,14 @@ Naming/FileName:
   Enabled: false # Allow filenames with dashes (e.g. immosquare-cleaner.rb)
 Naming/MethodParameterName:
   MinNameLength: 1 # Allow single-character parameter names
+Naming/PredicateMethod:
+  AllowedMethods:
+    - call
+    - move_to_cache # CarrierWave hooks: the gem calls them by these names and reads their boolean return.
+    - move_to_store
+    - save # ActiveModel contract: form objects expose `save` returning true/false, like ActiveRecord.
+    - check_health # Commands returning their success status (immosquare-railtie PumaManager, Elasticsearch import): a `?` name would hide the side effects.
+    - elastic_import_with_progressbar
 
 #################### Layout ###########################
 Layout/LeadingEmptyLines:
@@ -98,6 +106,11 @@ Style/NegatedIf:
   Enabled: false # Allow rewriting `if !` as `unless`
 Style/FormatStringToken:
   EnforcedStyle: "template" ## Use %{my_string} interpolation, not %<my_string>s
+  Mode: conservative # Only strings passed to format/sprintf/%. In aggressive mode any literal containing `%<x>s` is flagged, including prose that lists placeholders (e.g. an AI prompt telling the model which tokens to preserve), where rewriting the token changes the text.
+Style/OptionalBooleanParameter:
+  AllowedMethods:
+    - respond_to_missing?
+    - perform # Sidekiq and ActiveJob serialize `perform` arguments as JSON: keyword arguments are not reliably supported, and jobs already enqueued keep their positional shape.
 Style/NumericPredicate:
   EnforcedStyle: comparison # No `.zero?` `.negative?` `.positive?`
 Style/StringLiterals:

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: immosquare-cleaner
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - immosquare