immosquare-cleaner 0.1.90 → 0.1.92

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '039c6af561debfbe979defac9f7e31b82033b57eb9c7f994d56dd76ec80bd9e5'
-  data.tar.gz: ce34414e29d4e42626f552efc41a74696e8821a03f693e1d801cf239a83d5742
+  metadata.gz: 2af51f9a79564d3c4e797a60d559c8101baffafcb7653e53c527ea8cdb55544c
+  data.tar.gz: 5cb8a8cc680641237fb96511a543d9c4a191b16c611e5058a3082ebb82961425
 SHA512:
-  metadata.gz: ed73bf257cc143d1017a67d0d775f454e5a9811bf3b75d850b5814e384ef099541d20bdda963bd9aa7ec1aed4fef9ed2bbf3ee6701ecbb00520dc513013410ca
-  data.tar.gz: 00b7da8708f36b7e85d617140f1145c98707c7911a8f049b28bc03b5cbeef48c9e70b66d9d3c0d686808a9175a18956216bcceb664a74d8779a4b5c51396b2be
+  metadata.gz: 9fc266e0b300ccf012802b850895a5690e5555df1eddc41f17f333c5a80ef90fb33256d22e72fb3184e99feb931416fd3fa18d18a21b687508ac519b40415ae2
+  data.tar.gz: 384648e167d646ecb0b70cc228d6b47feba045e9a8bc9ec4b209fcc3101fba86716bacaf89eb684ceb82491a1e172b885123bc3fd5c40e2148101e9d2a421c2e

data/lib/immosquare-cleaner/version.rb

@@ -1,3 +1,3 @@
 module ImmosquareCleaner
-  VERSION = "0.1.90".freeze
+  VERSION = "0.1.92".freeze
 end

data/linters/erb_lint/custom_html_to_content_tag.rb

@@ -59,6 +59,8 @@ module ERBLint
       ##   - content_tag(:div, x) → allow (user-written)
       ##============================================================##
       EXCLUDED_METHODS = [
+        "yield",
+        "render_to_string",
         "render",
         "content_tag",
         "image_tag",
@@ -343,23 +345,170 @@ module ERBLint
 
       ##============================================================##
       ## Build content_tag call
+      ## Handles if/unless modifiers by moving them outside content_tag
       ##============================================================##
       def build_content_tag(tag_name, content, attributes)
+        ##============================================================##
+        ## Extract modifier (if/unless) from content if present
+        ##============================================================##
+        content_part, modifier_part = extract_modifier(content)
+
+        ##============================================================##
+        ## Wrap content in parentheses if it's an ambiguous method call
+        ## (method call without parentheses that has arguments)
+        ##============================================================##
+        wrapped_content = needs_parentheses?(content_part) ? "(#{content_part})" : content_part
+
+        ##============================================================##
+        ## Format tag name as symbol or string depending on characters
+        ##============================================================##
+        formatted_tag = format_tag_name(tag_name)
+
         if attributes.empty?
-          "<%= content_tag(:#{tag_name}, #{content}) %>"
+          base = "content_tag(#{formatted_tag}, #{wrapped_content})"
         else
           attrs_str = attributes.map do |name, value|
             key = normalize_attribute_name(name)
-            ##============================================================##
-            ## Check if value contains interpolation
-            ##============================================================##
-            if value&.include?('#{')
-            end
-            "#{key} => \"#{value}\""
+            quoted_value = quote_attribute_value(value)
+            "#{key} => #{quoted_value}"
           end.join(", ")
 
-          "<%= content_tag(:#{tag_name}, #{content}, #{attrs_str}) %>"
+          base = "content_tag(#{formatted_tag}, #{wrapped_content}, #{attrs_str})"
         end
+
+        if modifier_part
+          "<%= #{base} #{modifier_part} %>"
+        else
+          "<%= #{base} %>"
+        end
+      end
+
+      ##============================================================##
+      ## Format tag name for content_tag
+      ## - Simple tags (div, span) -> :div, :span
+      ## - Tags with special chars (x-card) -> "x-card"
+      ##============================================================##
+      def format_tag_name(tag_name)
+        if tag_name.match?(/\A[a-z_][a-z0-9_]*\z/i)
+          ":#{tag_name}"
+        else
+          "\"#{tag_name}\""
+        end
+      end
+
+      ##============================================================##
+      ## Check if Ruby code needs parentheses when used as argument
+      ## Returns true for method calls without parentheses that have
+      ## arguments (which would be ambiguous in content_tag context)
+      ## Example: "tag t('x'), path, :class => 'y'" needs parentheses
+      ##============================================================##
+      def needs_parentheses?(erb_code)
+        return false unless erb_code
+
+        result = Prism.parse(erb_code)
+        return false unless result.success?
+
+        node = result.value.statements.body.first
+        return false unless node.is_a?(Prism::CallNode)
+
+        ##============================================================##
+        ## Check if it's a method call with arguments but no parentheses
+        ##============================================================##
+        has_arguments = node.arguments&.arguments&.any?
+        return false unless has_arguments
+
+        ##============================================================##
+        ## Check if parentheses are missing by looking at the source
+        ## If the method name is not immediately followed by '(', it
+        ## needs wrapping
+        ##============================================================##
+        method_name = node.name.to_s
+        source = erb_code.strip
+
+        ##============================================================##
+        ## Find position after method name (accounting for receiver)
+        ##============================================================##
+        if node.receiver
+          ##============================================================##
+          ## For calls like "tag.div" or "f.input", find the method call
+          ##============================================================##
+          call_loc = node.call_operator_loc || node.message_loc
+          return false unless call_loc
+
+          after_method = call_loc.end_offset + method_name.length
+        else
+          after_method = method_name.length
+        end
+
+        ##============================================================##
+        ## Check if character after method name is '('
+        ##============================================================##
+        return false if after_method >= source.length
+
+        source[after_method] != "("
+      rescue StandardError
+        false
+      end
+
+      ##============================================================##
+      ## Quote attribute value for Ruby output
+      ## - Uses double quotes by default
+      ## - Switches to single quotes if value contains double quotes
+      ## - Handles interpolation by keeping double quotes and escaping
+      ##============================================================##
+      def quote_attribute_value(value)
+        return '""' if value.nil? || value.empty?
+
+        has_interpolation = value.include?('#{')
+        has_double_quotes = value.include?('"')
+
+        if has_interpolation
+          ##============================================================##
+          ## Must use double quotes for interpolation, escape inner quotes
+          ##============================================================##
+          escaped = value.gsub('"', '\\"')
+          "\"#{escaped}\""
+        elsif has_double_quotes
+          ##============================================================##
+          ## Use single quotes to avoid escaping
+          ##============================================================##
+          "'#{value}'"
+        else
+          "\"#{value}\""
+        end
+      end
+
+      ##============================================================##
+      ## Extract if/unless modifier from Ruby code
+      ## Returns [content, modifier] or [content, nil]
+      ## Example: "foo if bar" => ["foo", "if bar"]
+      ##============================================================##
+      def extract_modifier(erb_code)
+        return [erb_code, nil] unless erb_code
+
+        result = Prism.parse(erb_code)
+        return [erb_code, nil] unless result.success?
+
+        node = result.value.statements.body.first
+
+        ##============================================================##
+        ## Check for if/unless modifier
+        ##============================================================##
+        if node.is_a?(Prism::IfNode) || node.is_a?(Prism::UnlessNode)
+          ##============================================================##
+          ## Only handle modifier form (no else, single statement body)
+          ##============================================================##
+          if node.consequent.nil? && node.statements&.body&.size == 1
+            keyword = node.is_a?(Prism::IfNode) ? "if" : "unless"
+            condition = node.predicate.slice
+            content = node.statements.body.first.slice
+            return [content, "#{keyword} #{condition}"]
+          end
+        end
+
+        [erb_code, nil]
+      rescue StandardError
+        [erb_code, nil]
       end
 
       ##============================================================##

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: immosquare-cleaner
 version: !ruby/object:Gem::Version
-  version: 0.1.90
+  version: 0.1.92
 platform: ruby
 authors:
 - immosquare