immosquare-cleaner 0.1.80 → 0.1.82

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 160d617b3d77622b3c4c3b4978166b13a832eebd125e7e3cec3d27f250befcff
-  data.tar.gz: 7f4ea0e67420419f1c97b4cc6780aa6f6de11ead46f3e74f9fc6c32ba973325b
+  metadata.gz: 8e38b197fb7d113d6719e69a3aaa53cbb4ccd91663ee13f7f987a2651be2d9b1
+  data.tar.gz: 68feb71efbcd5ffcc6b71906230e0db69cdc11bd0b67eec47abe618bae0f3323
 SHA512:
-  metadata.gz: c6a38cffd458d0174ce2ac361249da090c7037d1d28ddc6dcc3653ad21f1c0091ee3c8056a2030abf8324f74bbe6f713038a064751b218b96b3d40c228d19869
-  data.tar.gz: 2f3b914ea9df14c7fe03d18cd45d9df078645aa5f37fc6fb27027d4c0a90c52c1e27527661fb12007ff5912f5b0430f1869e954dffa9b3098a640808d352651d
+  metadata.gz: fe430816fd49ab2e28ef871af7769567eeaa948e3f662c1ae576590633df4d6785782b0d03060808b4a1c0c2986ec6f17808c25f3ada516325a2f7bd5336dc70
+  data.tar.gz: ce6c6e8abdcae48294d6dca00a08f3fe437a0c731c22867ef99af46ace2d66624349a7b3dbb5283a927ea6bf3e7c3165bb6903cf631079675296470a98e7f423

data/lib/immosquare-cleaner/version.rb

@@ -1,3 +1,3 @@
 module ImmosquareCleaner
-  VERSION = "0.1.80".freeze
+  VERSION = "0.1.82".freeze
 end

data/linters/erb-lint-3.4.1.yml

@@ -9,6 +9,8 @@ linters:
     enabled: true
   CustomHtmlToContentTag:
     enabled: true
+  CustomNormalizeAttributeSpaces:
+    enabled: true
   Rubocop:
     enabled: true
     rubocop_config:

data/linters/erb-lint.yml

@@ -8,6 +8,8 @@ linters:
     enabled: true
   CustomHtmlToContentTag:
     enabled: true
+  CustomNormalizeAttributeSpaces:
+    enabled: true
   Rubocop:
     enabled: true
     rubocop_config:

data/linters/erb_lint/custom_html_to_content_tag.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "prism"
+
 module ERBLint
   module Linters
     ##============================================================##
@@ -7,14 +9,15 @@ module ERBLint
     ## output statement and converts them to content_tag helpers.
     ##
     ## @example
-    ##   # bad
+    ## bad
     ##   <div class="card-title"><%= t("app.title") %></div>
     ##
-    ##   # good
+    ## good
     ##   <%= content_tag(:div, t("app.title"), :class => "card-title") %>
     ##
     ##============================================================##
     class CustomHtmlToContentTag < Linter
+
       include LinterRegistry
 
       MSG = "Use content_tag helper instead of HTML tag with ERB output."
@@ -22,9 +25,26 @@ module ERBLint
       ##============================================================##
       ## Void elements that cannot have content (self-closing tags)
       ##============================================================##
-      VOID_ELEMENTS = %w[
-        area base br col command embed hr img input keygen
-        link menuitem meta param source track wbr
+      VOID_ELEMENTS = [
+        "area", "base", "br", "col", "command", "embed", "hr", "img", "input", "keygen", "link", "menuitem", "meta", "param", "source", "track", "wbr"
+      ].freeze
+
+      ##============================================================##
+      ## Methods that should not be converted to content_tag
+      ## - render: partials should stay in HTML for readability
+      ## - content_tag: prevents cascading on multiple erb_lint passes
+      ##
+      ## Note: If content_tag is removed from exclusions, additional
+      ## logic is needed to prevent cascading conversions. The approach
+      ## would be to check if the content_tag has HTML attributes
+      ## (:class, :id) which indicates it was generated by us in a
+      ## previous pass. See same_tag_content_tag? method pattern:
+      ##   - content_tag(:div, x, :class => "y") → skip (generated)
+      ##   - content_tag(:div, x) → allow (user-written)
+      ##============================================================##
+      EXCLUDED_METHODS = [
+        "render",
+        "content_tag"
       ].freeze
 
       def run(processed_source)
@@ -60,11 +80,15 @@ module ERBLint
           next unless extract_tag_name(closing_child) == tag_name
 
           ##============================================================##
-          ## Build the content_tag replacement
+          ## Extract ERB code and check if it should be skipped
           ##============================================================##
-          attributes = extract_attributes(child)
           erb_code = extract_erb_code(erb_node)
+          next if excluded_method?(erb_code)
 
+          ##============================================================##
+          ## Build the content_tag replacement
+          ##============================================================##
+          attributes = extract_attributes(child)
           new_code = build_content_tag(tag_name, erb_code, attributes)
 
           ##============================================================##
@@ -140,6 +164,34 @@ module ERBLint
         code_node&.loc&.source&.strip
       end
 
+      ##============================================================##
+      ## Check if the ERB code calls an excluded method
+      ## Uses Prism parser for proper Ruby AST analysis
+      ##============================================================##
+      def excluded_method?(erb_code)
+        return false unless erb_code
+
+        method_name = extract_method_name(erb_code)
+        return false unless method_name
+
+        EXCLUDED_METHODS.include?(method_name)
+      end
+
+      ##============================================================##
+      ## Extract the method name from Ruby code using Prism parser
+      ##============================================================##
+      def extract_method_name(erb_code)
+        result = Prism.parse(erb_code)
+        return nil unless result.success?
+
+        node = result.value.statements.body.first
+        return nil unless node.is_a?(Prism::CallNode)
+
+        node.name.to_s
+      rescue StandardError
+        nil
+      end
+
       ##============================================================##
       ## Extract attributes from tag node as hash
       ##============================================================##
@@ -203,10 +255,8 @@ module ERBLint
             ## Check if value contains interpolation
             ##============================================================##
             if value&.include?('#{')
-              "#{key} => \"#{value}\""
-            else
-              "#{key} => \"#{value}\""
             end
+            "#{key} => \"#{value}\""
           end.join(", ")
 
           "<%= content_tag(:#{tag_name}, #{content}, #{attrs_str}) %>"
@@ -224,6 +274,7 @@ module ERBLint
           ":\"#{name}\""
         end
       end
+
     end
   end
 end

data/linters/erb_lint/custom_normalize_attribute_spaces.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+module ERBLint
+  module Linters
+    ##============================================================##
+    ## This linter detects and removes multiple consecutive spaces
+    ## in HTML attribute values.
+    ##
+    ## @example
+    ## bad
+    ##   <div class="flex  grow  items-center">
+    ##
+    ## good
+    ##   <div class="flex grow items-center">
+    ##
+    ##============================================================##
+    class CustomNormalizeAttributeSpaces < Linter
+
+      include LinterRegistry
+
+      MSG = "Remove multiple consecutive spaces in attribute value."
+
+      def run(processed_source)
+        process_node(processed_source, processed_source.ast)
+      end
+
+      def autocorrect(_processed_source, offense)
+        lambda do |corrector|
+          corrector.replace(offense.source_range, offense.context[:new_value])
+        end
+      end
+
+      private
+
+      ##============================================================##
+      ## Recursively process all nodes in the AST
+      ##============================================================##
+      def process_node(processed_source, node)
+        return unless node
+
+        ##============================================================##
+        ## Check attribute values for multiple spaces
+        ##============================================================##
+        if node.respond_to?(:type) && node.type == :attribute_value
+          value_source = node.loc.source
+          if value_source.match?(/  +/)
+            normalized = value_source.gsub(/  +/, " ")
+            range = processed_source.to_source_range(node.loc.begin_pos...node.loc.end_pos)
+            add_offense(range, MSG, {:new_value => normalized})
+          end
+        end
+
+        ##============================================================##
+        ## Recurse into children
+        ##============================================================##
+        return unless node.respond_to?(:children)
+
+        node.children.each {|child| process_node(processed_source, child) }
+      end
+
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: immosquare-cleaner
 version: !ruby/object:Gem::Version
-  version: 0.1.80
+  version: 0.1.82
 platform: ruby
 authors:
 - immosquare
@@ -150,6 +150,7 @@ files:
 - linters/erb-lint-3.4.1.yml
 - linters/erb-lint.yml
 - linters/erb_lint/custom_html_to_content_tag.rb
+- linters/erb_lint/custom_normalize_attribute_spaces.rb
 - linters/erb_lint/custom_single_line_if_modifier.rb
 - linters/eslint.config.mjs
 - linters/prettier.yml