immosquare-cleaner 0.1.52 → 0.1.53

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 66d3816eb05bdddc44b9f698c183dcf179f93c98514a4da899695395d7ca814a
-  data.tar.gz: a3aafdfa9ce2e399346147641d6eec3d327fdb95cfb8a17a89171c6d4be1c52f
+  metadata.gz: 9196f9f8512b09892046a08e62a7d88651c64a303de24c06939f879892e52cf7
+  data.tar.gz: ebb02f2943eec1220d90bd122fb8eb74e93924e08e140d03d869dc9a046f2f35
 SHA512:
-  metadata.gz: 7ddd04828f677c3f025408b92627330182c40616d6c2fdb51f1f4e0287c2e41f3cc400379f13c7db1c1d3a8f934c379d667b8a08a6c0504289dd3c1c9942c312
-  data.tar.gz: 49e5bb957d7c5eade116eed5f673284fc603c52fcbc0e826f304acaf009de31cb4cb2c2e1088c27196ea4c885c1e0fc8b572243533a0b86d077456b83418c54c
+  metadata.gz: fad7b547a77506b0c92bc672a395e0ccee00ca2f7092fb838d9b621138e059bd57bc74e5317d0fbb4228a65899d1c591704e2f30fa8e0118afa0ce65c133da3a
+  data.tar.gz: ea5754c29eaf9d6bcd7f2e7b1531808d8a540a021f28f446d36cbd159ccd400c33cf2a1ed691da9b43ce096bf86408f5b4f625f3ed897d417029daa336b6e1da

data/lib/immosquare-cleaner/version.rb

@@ -1,3 +1,3 @@
 module ImmosquareCleaner
-  VERSION = "0.1.52".freeze
+  VERSION = "0.1.53".freeze
 end

data/lib/immosquare-cleaner.rb

@@ -72,7 +72,7 @@ module ImmosquareCleaner
             File.write(rubocop_config_with_version_path, rubocop_config.to_yaml)
           end
 
-          cmds = ["bundle exec rubocop -c #{rubocop_config_with_version_path} #{file_path} #{ImmosquareCleaner.configuration.rubocop_options || "--autocorrect-all"}"]
+          cmds = ["bundle exec rubocop -c #{rubocop_config_with_version_path} \"#{file_path}\" #{ImmosquareCleaner.configuration.rubocop_options || "--autocorrect-all"}"]
           launch_cmds(cmds)
           File.normalize_last_line(file_path)
           return

data/linters/rubocop/cop/custom_cops/style/use_credentials_instead_of_env.rb

@@ -0,0 +1,40 @@
+module RuboCop
+  module Cop
+    module CustomCops
+      module Style
+        ##============================================================##
+        ## Custom Cop: UseCredentialsInsteadOfEnv
+        ## To replace ENV.fetch with Rails.application.credentials
+        ##============================================================##
+        class UseCredentialsInsteadOfEnv < Base
+
+          extend AutoCorrector
+
+          MSG = "Use Rails.application.credentials instead of ENV.fetch".freeze
+
+          ##============================================================##
+          ## Node Matcher
+          ##============================================================##
+          def_node_matcher :env_fetch?, <<~PATTERN
+            (send (const nil? :ENV) :fetch ...)
+          PATTERN
+
+          def on_send(node)
+            return if !env_fetch?(node)
+
+            ##============================================================##
+            ## ENV.fetch("hello_world", nil)            => Rails.application.credentials.hello_world
+            ## ENV.fetch("hello_world_#{user_id}", nil) => Rails.application.credentials["hello_world_#{user_id}"]
+            ##============================================================##
+            add_offense(node) do |corrector|
+              key   = node.arguments.first
+              value = key.type == :dstr ? "[#{key.source}]" : ".#{key.source.delete('"')}"
+              corrector.replace(node, "Rails.application.credentials#{value}")
+            end
+          end
+
+        end
+      end
+    end
+  end
+end

data/linters/rubocop-3.3.6.yml

@@ -1,5 +1,7 @@
 ---
-require: rubocop/cop/style/method_call_with_args_parentheses_override
+require:
+- rubocop/cop/style/method_call_with_args_parentheses_override
+- rubocop/cop/custom_cops/style/use_credentials_instead_of_env
 AllCops:
   NewCops: enable
   EnabledByDefault: false
@@ -19,7 +21,7 @@ Naming/VariableNumber:
   Enabled: false
 Naming/FileName:
   Enabled: false
-MethodParameterName:
+Naming/MethodParameterName:
   MinNameLength: 1
 Layout/LeadingEmptyLines:
   Enabled: false
@@ -73,8 +75,6 @@ Style/IfUnlessModifierOfIfUnless:
   Enabled: false
 Style/NegatedIf:
   Enabled: false
-Style/MethodCallWithArgsParentheses:
-  Enabled: true
 Style/FormatStringToken:
   EnforcedStyle: template
 Style/NumericPredicate:
@@ -89,5 +89,9 @@ Style/WordArray:
   EnforcedStyle: brackets
 Style/SymbolArray:
   EnforcedStyle: brackets
+Style/MethodCallWithArgsParentheses:
+  Enabled: true
+CustomCops/Style/UseCredentialsInsteadOfEnv:
+  Enabled: true
 Gemspec/RequireMFA:
   Enabled: false

data/linters/rubocop.yml

@@ -1,4 +1,6 @@
-require: rubocop/cop/style/method_call_with_args_parentheses_override
+require:
+  - rubocop/cop/style/method_call_with_args_parentheses_override
+  - rubocop/cop/custom_cops/style/use_credentials_instead_of_env
 
 # Pour activer toutes les méthodes de Rubocop et activer le cache pour les gros fichiers
 AllCops:
@@ -25,7 +27,7 @@ Naming/VariableNumber:
   Enabled: false # On veut pouvour utiliser administrative_area_level_1 avec cette synthase
 Naming/FileName:
   Enabled: false # on veut pouvoir faire des nom de fichier avec des - immosquare-cleaner.rb
-MethodParameterName:
+Naming/MethodParameterName:
   MinNameLength: 1 # On veut pouvoir utiliser des noms de paramètres de 1 caractère
 
 #################### Layout ###########################
@@ -84,11 +86,8 @@ Style/IfUnlessModifierOfIfUnless:
   Enabled: false # On veut pourvoir mettre un if à la fin de end
 Style/NegatedIf:
   Enabled: false # On veut remplacer les if ! par des unless
-Style/MethodCallWithArgsParentheses:
-  Enabled: true # On veut forcer les parenthèses où elles sont utilises pour rendre le code plus propre
 Style/FormatStringToken:
   EnforcedStyle: "template" ## On veut les interpolation avec le format %{my_string} et avec avec %<my_string>s
-
 Style/NumericPredicate:
   EnforcedStyle: comparison # On ne veut pas des .zero? .negative? .positif?
 Style/StringLiterals:
@@ -102,6 +101,14 @@ Style/WordArray:
 Style/SymbolArray:
   EnforcedStyle: brackets # Pour formater les arrays de la forme [:a, :b, :c] et pas %i[a b c]
 
+#################### OVERWRITE ###########################
+Style/MethodCallWithArgsParentheses:
+  Enabled: true # On veut forcer les parenthèses où elles sont utilises pour rendre le code plus propre
+
+#################### CUSTOMS ###########################
+CustomCops/Style/UseCredentialsInsteadOfEnv:
+  Enabled: true # On veut forcer l'utilisation de credentials au lieu de ENV pour les secrets
+
 #################### GEM ###########################
 Gemspec/RequireMFA:
   Enabled: false # On ne veut pas obliger le MFA pour pusher un gem

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: immosquare-cleaner
 version: !ruby/object:Gem::Version
-  version: 0.1.52
+  version: 0.1.53
 platform: ruby
+original_platform: ''
 authors:
 - immosquare
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-27 00:00:00.000000000 Z
+date: 2024-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: erb_lint
@@ -119,9 +119,9 @@ files:
 - linters/eslint.config.mjs
 - linters/jscodeshift/arrow-function-transform.js
 - linters/prettier.yml
-- linters/rubocop-3.3.4.yml
 - linters/rubocop-3.3.6.yml
 - linters/rubocop.yml
+- linters/rubocop/cop/custom_cops/style/use_credentials_instead_of_env.rb
 - linters/rubocop/cop/style/method_call_with_args_parentheses_override.rb
 - node_modules/.bin/acorn
 - node_modules/.bin/babylon
@@ -34463,7 +34463,6 @@ homepage: https://github.com/immosquare/Immosquare-cleaner
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -34479,8 +34478,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 3.6.1
 specification_version: 4
 summary: A gem to lint and organize files in a Rails application.
 test_files: []

data/linters/rubocop-3.3.4.yml

@@ -1,93 +0,0 @@
----
-require: rubocop/cop/style/method_call_with_args_parentheses_override
-AllCops:
-  NewCops: enable
-  EnabledByDefault: false
-  UseCache: true
-  SuggestExtensions: false
-  ActiveSupportExtensionsEnabled: true
-  TargetRubyVersion: 3.3.4
-Metrics:
-  Enabled: false
-Lint/UselessAssignment:
-  Enabled: false
-Lint/RescueException:
-  Enabled: false
-Lint/UnusedMethodArgument:
-  Enabled: false
-Naming/VariableNumber:
-  Enabled: false
-Naming/FileName:
-  Enabled: false
-MethodParameterName:
-  MinNameLength: 1
-Layout/LeadingEmptyLines:
-  Enabled: false
-Layout/InitialIndentation:
-  Enabled: false
-Layout/TrailingEmptyLines:
-  Enabled: false
-Layout/ExtraSpacing:
-  Enabled: false
-Layout/LineLength:
-  Enabled: false
-Layout/TrailingWhitespace:
-  Enabled: true
-Layout/EmptyLines:
-  Enabled: false
-Layout/SpaceInsideBlockBraces:
-  SpaceBeforeBlockParameters: false
-Layout/EmptyLinesAroundClassBody:
-  EnforcedStyle: empty_lines
-Layout/FirstHashElementIndentation:
-  EnforcedStyle: consistent
-Layout/ArgumentAlignment:
-  EnforcedStyle: with_fixed_indentation
-Layout/HashAlignment:
-  EnforcedHashRocketStyle: table
-Layout/MultilineAssignmentLayout:
-  EnforcedStyle: same_line
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-Style/CombinableLoops:
-  Enabled: false
-Style/SingleArgumentDig:
-  Enabled: false
-Style/RedundantBegin:
-  Enabled: false
-Style/MultilineTernaryOperator:
-  Enabled: false
-Style/NestedTernaryOperator:
-  Enabled: false
-Style/MultilineIfModifier:
-  Enabled: false
-Style/FrozenStringLiteralComment:
-  Enabled: false
-Style/Next:
-  Enabled: false
-Style/Documentation:
-  Enabled: false
-Style/IfUnlessModifierOfIfUnless:
-  Enabled: false
-Style/NegatedIf:
-  Enabled: false
-Style/MethodCallWithArgsParentheses:
-  Enabled: true
-Style/FormatStringToken:
-  EnforcedStyle: template
-Style/NumericPredicate:
-  EnforcedStyle: comparison
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-Style/StringLiteralsInInterpolation:
-  EnforcedStyle: double_quotes
-Style/HashSyntax:
-  EnforcedStyle: hash_rockets
-Style/WordArray:
-  EnforcedStyle: brackets
-Style/SymbolArray:
-  EnforcedStyle: brackets
-Gemspec/RequireMFA:
-  Enabled: false