immoscout 2.1.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e7df9feb0754bbf3962e1eaf15042858af96b068e7ea75001d043cffbb9fd16a
-  data.tar.gz: d67beb5020f876f3da93d84905dea17a72a3bc162a5d7d35a560025e0ee182dc
+  metadata.gz: dcbd966d38bfd8e37865b7047be281ed020d361b25e530082da4b19f3055cc2b
+  data.tar.gz: 84d612c8d04f6dd3bb79b1b4163a9d33f27a4c2f0f2b7c482eb19cd673068ee7
 SHA512:
-  metadata.gz: 27de4448b1ebfa37731a6285324c4458be5ed09e1f93df7c7418911043abb57d98c72680c8a6f5767f61d01b2ce4ac80291c044423a96c6d21eacda053b814af
-  data.tar.gz: db5bb3ddaae29f3462bf073585009f954040ee0e61af8a1a1642a932798cbfa88747e9312e57f1378f3c54c24f87b0bed2f336425c0baebc85701167d09112b1
+  metadata.gz: ff387543e9e172d5d19842ce6a43824d68a04bee0131bcf6396bc5b3501fae887ee62696599edc51fcebf4440155f9fe1971a631693d2c0779955915f50b2f2f
+  data.tar.gz: 855114c75ccf6fcd276aab30b56a3d322ba88c67110a630b6cda782942b849e7cafc98a874039fdfa77c77bdd16f5fb1286a2d0e8b3bbf2e7c8c324012f16471

data/.github/workflows/release.yml

@@ -15,26 +15,24 @@ concurrency:
 jobs:
   docs:
     name: Release the gem
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 10
     steps:
-      - uses: actions/checkout@v4
-
-      - name: Install Ruby 3.2
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: 3.2
-          bundler-cache: true
-          rubygems: '3.6.9'
-
-      - name: Prepare the virtual environment
-        uses: hausgold/actions/ci@master
+      - name: Prepare the environment
+        uses: hausgold/actions/ci@v2
         with:
           clone_token: '${{ secrets.CLONE_TOKEN }}'
           settings_secret_key: '${{ secrets.SETTINGS_SECRET_KEY }}'
           settings: '${{ github.repository }}'
           target: ci/gem-test
 
+      - name: Install Ruby 3.3
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.3
+          bundler-cache: true
+          rubygems: '3.6.9'
+
       - name: Switch to SSH remotes for the Git repository
         run: git-ssh-remotes
 

data/.github/workflows/test.yml

@@ -13,17 +13,24 @@ concurrency:
 jobs:
   test:
     name: 'Test the gem (Ruby ${{ matrix.ruby }}, Rails ${{ matrix.rails }})'
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 5
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['3.2', '3.3', '3.4']
-        rails: ['7.1', '7.2', '8.0', '8.1']
+        ruby: ['3.3', '3.4', '4.0']
+        rails: ['7.2', '8.0', '8.1']
+    continue-on-error: ${{ matrix.ruby == '4.0' }}
     env:
       BUNDLE_GEMFILE: 'gemfiles/rails_${{ matrix.rails }}.gemfile'
     steps:
-      - uses: actions/checkout@v4
+      - name: Prepare the environment
+        uses: hausgold/actions/ci@v2
+        with:
+          clone_token: '${{ secrets.CLONE_TOKEN }}'
+          settings_secret_key: '${{ secrets.SETTINGS_SECRET_KEY }}'
+          settings: '${{ github.repository }}'
+          target: ci/gem-test
 
       - name: Install the correct Ruby version
         uses: ruby/setup-ruby@v1
@@ -32,14 +39,6 @@ jobs:
           bundler-cache: true
           rubygems: '3.6.9'
 
-      - name: Prepare the virtual environment
-        uses: hausgold/actions/ci@master
-        with:
-          clone_token: '${{ secrets.CLONE_TOKEN }}'
-          settings_secret_key: '${{ secrets.SETTINGS_SECRET_KEY }}'
-          settings: '${{ github.repository }}'
-          target: ci/gem-test
-
       - name: Run the gem tests
         run: make test
 

data/.rubocop.yml

@@ -1,3 +1,11 @@
+inherit_from:
+  - https://potpourri.hausgold.de/config/rubocop.yml
+  - https://potpourri.hausgold.de/config/rubocop-gem.yml
+
+inherit_mode:
+  merge:
+    - Exclude
+
 plugins:
   - rubocop-rspec
   - rubocop-rails
@@ -5,39 +13,20 @@ plugins:
 Rails:
   Enabled: true
 
-Style/Documentation:
-  Enabled: true
-
 AllCops:
   NewCops: enable
   SuggestExtensions: false
   DisplayCopNames: true
-  TargetRubyVersion: 3.2
-  TargetRailsVersion: 7.1
+  TargetRubyVersion: 3.3
+  TargetRailsVersion: 7.2
   Exclude:
     - bin/**/*
     - vendor/**/*
     - build/**/*
     - gemfiles/**/*
 
-Metrics/BlockLength:
-  Exclude:
-    - Rakefile
-    - '*.gemspec'
-    - spec/**/*.rb
-    - '**/*.rake'
-    - doc/**/*.rb
-
-# We stay at 80 characters per line.
-# See: https://rubystyle.guide/#max-line-length
-Layout/LineLength:
-  Max: 80
-
-# MFA is not yet enabled for our gems yet.
-Gemspec/RequireMFA:
-  Enabled: false
-
-# We use memoized helpers all over the place to construct inputs and output
-# which can be customized at nested contexts easily.
-RSpec/MultipleMemoizedHelpers:
+# Document all the things.
+# TODO: Add missing documentations for all methods.
+Style/DocumentationMethod:
   Enabled: false
+  RequireForNonPublicMethods: false

data/Appraisals

@@ -1,9 +1,5 @@
 # frozen_string_literal: true
 
-appraise 'rails-7.1' do
-  gem 'activesupport', '~> 7.1.0'
-end
-
 appraise 'rails-7.2' do
   gem 'activesupport', '~> 7.2.0'
 end

data/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 * TODO: Replace this bullet point with an actual description of a change.
 
+### 2.3.0 (7 January 2026)
+
+* Upgraded to Ubuntu 24.04 on Github Actions ([#31](https://github.com/hausgold/immoscout/pull/31))
+* Migrated to hausgold/actions@v2 ([#30](https://github.com/hausgold/immoscout/pull/30))
+* Dropped Ruby 3.2 and Rails 7.1 support ([#27](https://github.com/hausgold/immoscout/pull/27))
+* Added Ruby 4.0 support ([#28](https://github.com/hausgold/immoscout/pull/28))
+* Upgraded to Faraday 2 ([#29](https://github.com/hausgold/immoscout/pull/29))
+
+### 2.2.0 (19 December 2025)
+
+* Migrated to a shared Rubocop configuration for HAUSGOLD gems ([#26](https://github.com/hausgold/immoscout/pull/26))
+
 ### 2.1.0 (23 October 2025)
 
 * Dropped Reek ([#23](https://github.com/hausgold/immoscout/pull/23))

data/Dockerfile

@@ -1,4 +1,4 @@
-FROM hausgold/ruby:3.2
+FROM hausgold/ruby:3.3
 LABEL org.opencontainers.image.authors="containers@hausgold.de"
 
 # Update system gem

data/Envfile

@@ -1,3 +1,4 @@
 LANG=en_US.UTF-8
 LANGUAGE=en_US.UTF-8
 LC_ALL=en_US.UTF-8
+RUBOCOP_CACHE_ROOT=/app/tmp

data/Gemfile

@@ -9,11 +9,11 @@ gemspec
 
 # Development dependencies
 gem 'appraisal', '~> 2.4'
-gem 'bundler', '~> 2.6'
+gem 'bundler', '>= 2.6', '< 5'
 gem 'countless', '~> 2.2'
 gem 'factory_bot', '~> 6.2'
 gem 'guard-rspec', '~> 4.7'
-gem 'railties', '>= 7.1'
+gem 'railties', '>= 7.2'
 gem 'rake', '~> 13.0'
 gem 'redcarpet', '~> 3.5'
 gem 'rspec', '~> 3.12'

data/LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2023 HAUSGOLD | talocasa GmbH
+Copyright (c) 2026 HAUSGOLD | talocasa GmbH
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/Makefile

@@ -83,7 +83,8 @@ all:
 install:
 	# Install the dependencies
 	@$(MKDIR) -p $(VENDOR_DIR)
-	@$(call run-shell,$(BUNDLE) check || $(BUNDLE) install --path $(VENDOR_DIR))
+	@$(call run-shell,$(BUNDLE) config set --local path '$(VENDOR_DIR)')
+	@$(call run-shell,$(BUNDLE) check || $(BUNDLE) install)
 	@$(call run-shell,$(BUNDLE) exec $(APPRAISAL) install)
 
 update:

data/gemfiles/rails_7.2.gemfile

@@ -3,11 +3,11 @@
 source "https://rubygems.org"
 
 gem "appraisal", "~> 2.4"
-gem "bundler", "~> 2.6"
+gem "bundler", ">= 2.6", "< 5"
 gem "countless", "~> 2.2"
 gem "factory_bot", "~> 6.2"
 gem "guard-rspec", "~> 4.7"
-gem "railties", ">= 7.1"
+gem "railties", ">= 7.2"
 gem "rake", "~> 13.0"
 gem "redcarpet", "~> 3.5"
 gem "rspec", "~> 3.12"

data/gemfiles/rails_8.0.gemfile

@@ -3,11 +3,11 @@
 source "https://rubygems.org"
 
 gem "appraisal", "~> 2.4"
-gem "bundler", "~> 2.6"
+gem "bundler", ">= 2.6", "< 5"
 gem "countless", "~> 2.2"
 gem "factory_bot", "~> 6.2"
 gem "guard-rspec", "~> 4.7"
-gem "railties", ">= 7.1"
+gem "railties", ">= 7.2"
 gem "rake", "~> 13.0"
 gem "redcarpet", "~> 3.5"
 gem "rspec", "~> 3.12"

data/gemfiles/rails_8.1.gemfile

@@ -3,11 +3,11 @@
 source "https://rubygems.org"
 
 gem "appraisal", "~> 2.4"
-gem "bundler", "~> 2.6"
+gem "bundler", ">= 2.6", "< 5"
 gem "countless", "~> 2.2"
 gem "factory_bot", "~> 6.2"
 gem "guard-rspec", "~> 4.7"
-gem "railties", ">= 7.1"
+gem "railties", ">= 7.2"
 gem "rake", "~> 13.0"
 gem "redcarpet", "~> 3.5"
 gem "rspec", "~> 3.12"

data/immoscout.gemspec

@@ -30,11 +30,12 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 3.2'
+  spec.required_ruby_version = '>= 3.3'
 
-  spec.add_dependency 'activesupport', '>= 7.1'
-  spec.add_dependency 'faraday', '~> 1.10'
-  spec.add_dependency 'faraday_middleware', '~> 1.2'
-  spec.add_dependency 'simple_oauth', '>= 0.3'
+  spec.add_dependency 'activesupport', '>= 7.2'
+  spec.add_dependency 'faraday', '~> 2.14'
+  spec.add_dependency 'faraday-follow_redirects', '>= 0.5.0'
+  spec.add_dependency 'faraday-multipart', '~> 1.2'
+  spec.add_dependency 'faraday-oauth1', '>= 0.1.1'
   spec.add_dependency 'zeitwerk', '~> 2.6'
 end

data/lib/immoscout/api/connection.rb

@@ -20,7 +20,8 @@ module Immoscout
 
       def configure_oauth(builder)
         builder.request(
-          :oauth,
+          :oauth1,
+          :header,
           token: config.oauth_token,
           token_secret: config.oauth_token_secret,
           consumer_key: config.consumer_key,

data/lib/immoscout/api/request.rb

@@ -20,7 +20,6 @@ module Immoscout
         request(:delete, path, payload, multipart)
       end
 
-      # rubocop:disable Metrics/MethodLength -- because of the header handling
       def request(method, path, payload = nil, multipart = nil)
         connection.send(method, path, multipart) do |request|
           if multipart
@@ -34,7 +33,6 @@ module Immoscout
             "RubyImmoscout/#{Immoscout::VERSION}"
         end
       end
-      # rubocop:enable Metrics/MethodLength
     end
   end
 end

data/lib/immoscout/models/actions/attachment.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Metrics/BlockLength -- because this is how an ActiveSupport
-#   concern looks like
 module Immoscout
   module Models
     module Actions
@@ -19,9 +17,6 @@ module Immoscout
               .fetch('attachment')
           end
 
-          # rubocop:disable Metrics/AbcSize -- because this is the bare minimum
-          #   logic
-          # rubocop:disable Metrics/MethodLength -- ditto
           def save
             attachable_id = attachable.try(:id) || attachable
             response = api.post(
@@ -38,8 +33,6 @@ module Immoscout
             self.id = id_from_response(response)
             self
           end
-          # rubocop:enable Metrics/AbcSize
-          # rubocop:enable Metrics/MethodLength
 
           def destroy
             attachable_id = attachable.try(:id) || attachable
@@ -93,4 +86,3 @@ module Immoscout
     end
   end
 end
-# rubocop:enable Metrics/BlockLength

data/lib/immoscout/models/actions/real_estate.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Metrics/BlockLength -- because this is how an ActiveSupport
-#   concern looks like
 module Immoscout
   module Models
     module Actions
@@ -115,4 +113,3 @@ module Immoscout
     end
   end
 end
-# rubocop:enable Metrics/BlockLength

data/lib/immoscout/models/concerns/renderable.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Metrics/BlockLength -- because this is how an ActiveSupport
-#   concern looks like
 module Immoscout
   module Models
     module Concerns
@@ -25,11 +23,6 @@ module Immoscout
             self.class.try(:json_wrapper)
           end
 
-          # rubocop:disable Metrics/PerceivedComplexity -- because this is the
-          #   bare minimum logic
-          # rubocop:disable Metrics/MethodLength -- ditto
-          # rubocop:disable Metrics/CyclomaticComplexity -- ditto
-          # rubocop:disable Metrics/AbcSize -- ditto
           def to_h
             self.class.properties.each_with_object({}) do |(key, value), memo|
               # skip if it's readonly and should not be exposed in #as_json
@@ -51,10 +44,6 @@ module Immoscout
               memo
             end
           end
-          # rubocop:enable Metrics/PerceivedComplexity
-          # rubocop:enable Metrics/MethodLength
-          # rubocop:enable Metrics/CyclomaticComplexity
-          # rubocop:enable Metrics/AbcSize
 
           def to_json_wrapped
             { self.class.try(:json_wrapper) => to_json_unwrapped }
@@ -71,4 +60,3 @@ module Immoscout
     end
   end
 end
-# rubocop:enable Metrics/BlockLength

data/lib/immoscout/version.rb

@@ -3,7 +3,7 @@
 # The gem version details.
 module Immoscout
   # The version of the +immoscout+ gem
-  VERSION = '2.1.0'
+  VERSION = '2.3.0'
 
   class << self
     # Returns the version of gem as a string.

data/lib/immoscout.rb

@@ -10,7 +10,9 @@ require 'active_support/core_ext/hash'
 require 'active_support/core_ext/module'
 require 'singleton'
 require 'faraday'
-require 'faraday_middleware'
+require 'faraday/multipart'
+require 'faraday/follow_redirects'
+require 'faraday/oauth1'
 require 'json'
 
 # The top-namespace of the +immoscout+ gem.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: immoscout
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Marcus Geissler
@@ -15,30 +15,44 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '2.14'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '2.14'
 - !ruby/object:Gem::Dependency
-  name: faraday_middleware
+  name: faraday-follow_redirects
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.5.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.5.0
+- !ruby/object:Gem::Dependency
+  name: faraday-multipart
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -52,19 +66,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.2'
 - !ruby/object:Gem::Dependency
-  name: simple_oauth
+  name: faraday-oauth1
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: 0.1.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: 0.1.1
 - !ruby/object:Gem::Dependency
   name: zeitwerk
   requirement: !ruby/object:Gem::Requirement
@@ -112,8 +126,6 @@ files:
 - config/docker/.inputrc
 - doc/assets/project.svg
 - docker-compose.yml
-- gemfiles/rails_6.1.gemfile
-- gemfiles/rails_7.1.gemfile
 - gemfiles/rails_7.2.gemfile
 - gemfiles/rails_8.0.gemfile
 - gemfiles/rails_8.1.gemfile
@@ -170,7 +182,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.2'
+      version: '3.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/gemfiles/rails_6.1.gemfile

@@ -1,27 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal", "~> 2.4"
-gem "bundler", "~> 2.3"
-gem "countless", "~> 1.1"
-gem "factory_bot", "~> 6.2"
-gem "guard-rspec", "~> 4.7"
-gem "railties", ">= 6.1"
-gem "rake", "~> 13.0"
-gem "redcarpet", "~> 3.5"
-gem "rspec", "~> 3.12"
-gem "rspec-json_expectations", "~> 2.2"
-gem "rubocop"
-gem "rubocop-rails"
-gem "rubocop-rspec"
-gem "simplecov", ">= 0.22"
-gem "terminal-table", "~> 3.0"
-gem "timecop", ">= 0.9.6"
-gem "vcr", "~> 6.0"
-gem "webmock", "~> 3.18"
-gem "yard", ">= 0.9.28"
-gem "yard-activesupport-concern", ">= 0.0.1"
-gem "activesupport", "~> 6.1.0"
-
-gemspec path: "../"

data/gemfiles/rails_7.1.gemfile

@@ -1,27 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal", "~> 2.4"
-gem "bundler", "~> 2.6"
-gem "countless", "~> 2.2"
-gem "factory_bot", "~> 6.2"
-gem "guard-rspec", "~> 4.7"
-gem "railties", ">= 7.1"
-gem "rake", "~> 13.0"
-gem "redcarpet", "~> 3.5"
-gem "rspec", "~> 3.12"
-gem "rspec-json_expectations", "~> 2.2"
-gem "rubocop"
-gem "rubocop-rails"
-gem "rubocop-rspec"
-gem "simplecov", ">= 0.22"
-gem "terminal-table", "~> 3.0"
-gem "timecop", ">= 0.9.6"
-gem "vcr", "~> 6.0"
-gem "webmock", "~> 3.18"
-gem "yard", ">= 0.9.28"
-gem "yard-activesupport-concern", ">= 0.0.1"
-gem "activesupport", "~> 7.1.0"
-
-gemspec path: "../"