imgproxy 2.1.0 → 3.0.0

data/docs/yard/github_alerts.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "uri"
+require "yard"
+
+module YARD
+  # Add some formatting to the GitHub alert tags since they are not supported
+  # by YARD
+  module GithubAlerts
+    def html_markup_markdown(text)
+      super(text.gsub(/\[!(IMPORTANT|TIP|NOTE)\]/) { "**#{Regexp.last_match(1)}:**" })
+    end
+  end
+
+  Templates::Template.extra_includes << GithubAlerts
+end

data/docs/yard/relative_markdown_links.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require "yard"
+
+module YARD
+  # Fixes relative links in markdown files.
+  module RelativeMarkdownLinks
+    def resolve_links(text)
+      return super unless options.files
+
+      filenames = options.files.each_with_object({}) do |file, fns|
+        fn = file.filename
+        fns[fn] = fn
+        fns["#{fn.tr(".", "_")}.html"] = fn
+      end
+
+      # puts text
+
+      super(text.gsub(%r{<a href="([^"]+)"[^>]*>([^<]*)</a>}) do |str|
+        href = Regexp.last_match(1)
+        link_text = Regexp.last_match(2)
+
+        next str unless filenames.key?(href)
+
+        "{file:#{filenames[href]} #{link_text}}"
+      end)
+    end
+  end
+
+  Templates::Template.extra_includes << RelativeMarkdownLinks
+end

data/lib/imgproxy/config.rb

@@ -1,28 +1,13 @@
+# frozen_string_literal: true
+
 require "anyway_config"
 
+require "imgproxy/service_config"
 require "imgproxy/url_adapters"
 
 module Imgproxy
   # Imgproxy config
   #
-  # @!attribute endpoint
-  #   imgproxy endpoint
-  #   @return [String]
-  # @!attribute key
-  #   imgproxy hex-encoded signature key
-  #   @return [String]
-  # @!attribute salt
-  #   imgproxy hex-encoded signature salt
-  #   @return [String]
-  # @!attribute raw_key
-  #   Decoded signature key
-  #   @return [String]
-  # @!attribute raw_salt
-  #   Decoded signature salt
-  #   @return [String]
-  # @!attribute signature_size
-  #   imgproxy signature size. Defaults to 32
-  #   @return [String]
   # @!attribute use_short_options
   #   Use short processing option names (+rs+ for +resize+, +g+ for +gravity+, etc).
   #   Defaults to true
@@ -50,12 +35,6 @@ module Imgproxy
   # @see https://github.com/palkan/anyway_config anyway_config
   class Config < Anyway::Config
     attr_config(
-      :endpoint,
-      :key,
-      :salt,
-      :raw_key,
-      :raw_salt,
-      signature_size: 32,
       use_short_options: true,
       base64_encode_urls: false,
       always_escape_plain_urls: false,
@@ -63,36 +42,112 @@ module Imgproxy
       use_gcs_urls: false,
       gcs_bucket: nil,
       shrine_host: nil,
+      services: {},
+    )
+
+    coerce_types(
+      use_short_options: :boolean,
+      base64_encode_urls: :boolean,
+      always_escape_plain_urls: :boolean,
+      use_s3_urls: :boolean,
+      use_gcs_urls: :boolean,
+      gcs_bucket: :string,
+      shrine_host: :string,
     )
 
-    alias_method :set_key, :key=
-    alias_method :set_raw_key, :raw_key=
-    alias_method :set_salt, :salt=
-    alias_method :set_raw_salt, :raw_salt=
-    private :set_key, :set_raw_key, :set_salt, :set_raw_salt
+    def endpoint
+      service(:default).endpoint
+    end
+
+    def endpoint=(value)
+      service(:default).endpoint = value
+    end
+
+    def key
+      service(:default).key
+    end
 
     def key=(value)
-      value = value&.to_s
-      super(value)
-      set_raw_key(value && [value].pack("H*"))
+      service(:default).key = value
+    end
+
+    def raw_key
+      service(:default).raw_key
     end
 
     def raw_key=(value)
-      value = value&.to_s
-      super(value)
-      set_key(value&.unpack("H*")&.first)
+      service(:default).raw_key = value
+    end
+
+    def salt
+      service(:default).salt
     end
 
     def salt=(value)
-      value = value&.to_s
-      super(value)
-      set_raw_salt(value && [value].pack("H*"))
+      service(:default).salt = value
+    end
+
+    def raw_salt
+      service(:default).raw_salt
     end
 
     def raw_salt=(value)
-      value = value&.to_s
-      super(value)
-      set_salt(value&.unpack("H*")&.first)
+      service(:default).raw_salt = value
+    end
+
+    def signature_size
+      service(:default).signature_size
+    end
+
+    def signature_size=(value)
+      service(:default).signature_size = value
+    end
+
+    def source_url_encryption_key
+      service(:default).source_url_encryption_key
+    end
+
+    def source_url_encryption_key=(value)
+      service(:default).source_url_encryption_key = value
+    end
+
+    def raw_source_url_encryption_key
+      service(:default).raw_source_url_encryption_key
+    end
+
+    def raw_source_url_encryption_key=(value)
+      service(:default).raw_source_url_encryption_key = value
+    end
+
+    def always_encrypt_source_urls
+      service(:default).always_encrypt_source_urls
+    end
+
+    def always_encrypt_source_urls=(value)
+      service(:default).always_encrypt_source_urls = value
+    end
+
+    def service(name)
+      services[name.to_sym] ||= services[:default].dup
+
+      yield services[name.to_sym] if block_given?
+
+      services[name.to_sym]
+    end
+
+    def services
+      @services ||= {}.tap do |s|
+        s[:default] = ServiceConfig.new
+
+        super.each do |name, data|
+          config = s[name.to_sym] = s[:default].dup
+
+          data.symbolize_keys.slice(*config.class.config_attributes).each do |key, value|
+            value = config.class.type_caster.coerce(key, value)
+            config.public_send("#{key}=", value)
+          end
+        end
+      end
     end
 
     # @deprecated Please use {#key} instead

data/lib/imgproxy/extensions/active_storage.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Imgproxy
   module Extensions
     # Extension for ActiveStorage
@@ -6,20 +8,20 @@ module Imgproxy
       # Returns imgproxy URL for an attachment
       #
       # @return [String]
-      # @param options [Hash, Imgproxy::Builder]
+      # @param options [Hash, Imgproxy::UrlBuilders::Processing]
       # @see Imgproxy.url_for
       def imgproxy_url(options = {})
-        return options.url_for(self) if options.is_a?(Imgproxy::Builder)
+        return options.url_for(self) if options.is_a?(Imgproxy::UrlBuilders::Processing)
         Imgproxy.url_for(self, options)
       end
 
       # Returns imgproxy info URL for an attachment
       #
       # @return [String]
-      # @param options [Hash, Imgproxy::Builder]
+      # @param options [Hash, Imgproxy::UrlBuilders::Info]
       # @see Imgproxy.info_url_for
       def imgproxy_info_url(options = {})
-        return options.info_url_for(self) if options.is_a?(Imgproxy::Builder)
+        return options.info_url_for(self) if options.is_a?(Imgproxy::UrlBuilders::Info)
         Imgproxy.info_url_for(self, options)
       end
     end

data/lib/imgproxy/extensions/shrine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Imgproxy
   module Extensions
     # Extension for Shrine::UploadedFile
@@ -6,20 +8,20 @@ module Imgproxy
       # Returns imgproxy URL for a Shrine::UploadedFile instance
       #
       # @return [String]
-      # @param options [Hash, Imgproxy::Builder]
+      # @param options [Hash, Imgproxy::UrlBuilders::Processing]
       # @see Imgproxy.url_for
       def imgproxy_url(options = {})
-        return options.url_for(self) if options.is_a?(Imgproxy::Builder)
+        return options.url_for(self) if options.is_a?(Imgproxy::UrlBuilders::Processing)
         Imgproxy.url_for(self, options)
       end
 
       # Returns imgproxy info URL for a Shrine::UploadedFile instance
       #
       # @return [String]
-      # @param options [Hash, Imgproxy::Builder]
+      # @param options [Hash, Imgproxy::UrlBuilders::Info]
       # @see Imgproxy.info_url_for
       def imgproxy_info_url(options = {})
-        return options.info_url_for(self) if options.is_a?(Imgproxy::Builder)
+        return options.info_url_for(self) if options.is_a?(Imgproxy::UrlBuilders::Info)
         Imgproxy.info_url_for(self, options)
       end
     end

data/lib/imgproxy/option_aliases/info.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Imgproxy
+  module OptionAliases
+    INFO = {
+      size: :s,
+      format: :f,
+      dimensions: :d,
+      video_meta: :vm,
+      detect_objects: :do,
+      colorspace: :cs,
+      bands: :b,
+      sample_format: :sf,
+      pages_number: :pn,
+      alpha: :a,
+      crop: :c,
+      palette: :p,
+      average: :avg,
+      dominant_colors: :dc,
+      blurhash: :bh,
+      calc_hashsum: :chs,
+      page: :pg,
+      video_thumbnail_second: :vts,
+      video_thumbnail_keyframes: :vtk,
+      cachebuster: :cb,
+      expires: :exp,
+      preset: :pr,
+      hashsum: :hs,
+      max_src_resolution: :msr,
+      max_src_file_size: :msfs,
+    }.freeze
+  end
+end

data/lib/imgproxy/option_aliases/processing.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+module Imgproxy
+  module OptionAliases
+    PROCESSING = {
+      resize: :rs,
+      size: :s,
+      resizing_type: :rt,
+      resizing_algorithm: :ra,
+      width: :w,
+      height: :h,
+      "min-width": :mw,
+      "min-height": :mh,
+      zoom: :z,
+      enlarge: :el,
+      extend: :ex,
+      extend_aspect_ratio: :exar,
+      gravity: :g,
+      crop: :c,
+      trim: :t,
+      padding: :pd,
+      auto_rotate: :ar,
+      rotate: :rot,
+      background: :bg,
+      background_alpha: :bga,
+      adjust: :a,
+      brightness: :br,
+      contrast: :co,
+      saturation: :sa,
+      blur: :bl,
+      sharpen: :sh,
+      pixelate: :pix,
+      unsharp_masking: :ush,
+      blur_detections: :bd,
+      draw_detections: :dd,
+      gradient: :gr,
+      watermark: :wm,
+      watermark_url: :wmu,
+      watermark_text: :wmt,
+      watermark_size: :wms,
+      watermark_shadow: :wmsh,
+      style: :st,
+      strip_metadata: :sm,
+      keep_copyright: :kcr,
+      strip_color_profile: :scp,
+      enforce_thumbnail: :eth,
+      quality: :q,
+      format_quality: :fq,
+      autoquality: :aq,
+      max_bytes: :mb,
+      jpeg_options: :jpego,
+      png_options: :pngo,
+      webp_options: :webpo,
+      page: :pg,
+      pages: :pgs,
+      disable_animation: :da,
+      video_thumbnail_second: :vts,
+      video_thumbnail_keyframes: :vtk,
+      video_thumbnail_tile: :vtt,
+      fallback_image_url: :fiu,
+      skip_processing: :skp,
+      cachebuster: :cb,
+      expires: :exp,
+      filename: :fn,
+      return_attachment: :att,
+      preset: :pr,
+      hashsum: :hs,
+      max_src_resolution: :msr,
+      max_src_file_size: :msfs,
+      max_animation_frames: :maf,
+      max_animation_frame_resolution: :mafr,
+    }.freeze
+  end
+end

data/lib/imgproxy/options_builders/base.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require "imgproxy/trim_array"
+
+module Imgproxy
+  module OptionsBuilders
+    # Formats and regroups URL options
+    class Base < Hash
+      using TrimArray
+
+      # Hash of options casters. Redefine this in subclases
+      CASTERS = {}.freeze
+      # Array of meta-options names. Redefine this in subclases
+      META = [].freeze
+
+      # @param options [Hash] raw options
+      def initialize(options)
+        super()
+
+        # Options order hack: initialize known and meta options with nil value to preserve order
+        self.class::CASTERS.each_key do |n|
+          self[n] = nil if options.key?(n) || self.class::META.include?(n)
+        end
+
+        options.each do |name, value|
+          caster = self.class::CASTERS[name]
+          self[name] = caster ? caster.cast(value) : unwrap_hash(value)
+        end
+
+        group_opts
+
+        compact!
+      end
+
+      private
+
+      def unwrap_hash(raw)
+        return raw unless raw.is_a?(Hash)
+
+        raw.flat_map do |_key, val|
+          unwrap_hash(val)
+        end
+      end
+
+      def group_opts
+        # Do nothing in the base class. Can be redefined in subclasses
+      end
+
+      def extract_and_trim_nils(*keys)
+        keys.map { |k| delete(k) }.trim!
+      end
+    end
+  end
+end

data/lib/imgproxy/options_builders/info.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require "imgproxy/options_builders/base"
+
+require "imgproxy/options_casters/string"
+require "imgproxy/options_casters/integer"
+require "imgproxy/options_casters/float"
+require "imgproxy/options_casters/bool"
+require "imgproxy/options_casters/array"
+require "imgproxy/options_casters/alpha"
+require "imgproxy/options_casters/crop"
+require "imgproxy/options_casters/average"
+require "imgproxy/options_casters/dominant_colors"
+require "imgproxy/options_casters/blurhash"
+require "imgproxy/options_casters/hashsum"
+
+module Imgproxy
+  module OptionsBuilders
+    # Formats and regroups info options
+    class Info < Base
+      CASTERS = {
+        size: Imgproxy::OptionsCasters::Bool,
+        format: Imgproxy::OptionsCasters::Bool,
+        dimensions: Imgproxy::OptionsCasters::Bool,
+        exif: Imgproxy::OptionsCasters::Bool,
+        iptc: Imgproxy::OptionsCasters::Bool,
+        video_meta: Imgproxy::OptionsCasters::Bool,
+        detect_objects: Imgproxy::OptionsCasters::Bool,
+        colorspace: Imgproxy::OptionsCasters::Bool,
+        bands: Imgproxy::OptionsCasters::Bool,
+        sample_format: Imgproxy::OptionsCasters::Bool,
+        pages_number: Imgproxy::OptionsCasters::Bool,
+        alpha: Imgproxy::OptionsCasters::Alpha,
+        crop: Imgproxy::OptionsCasters::Crop,
+        palette: Imgproxy::OptionsCasters::Integer,
+        average: Imgproxy::OptionsCasters::Average,
+        dominant_colors: Imgproxy::OptionsCasters::DominantColors,
+        blurhash: Imgproxy::OptionsCasters::Blurhash,
+        calc_hashsum: Imgproxy::OptionsCasters::Array,
+        page: Imgproxy::OptionsCasters::Integer,
+        video_thumbnail_second: Imgproxy::OptionsCasters::Integer,
+        video_thumbnail_keyframes: Imgproxy::OptionsCasters::Bool,
+        cachebuster: Imgproxy::OptionsCasters::String,
+        expires: Imgproxy::OptionsCasters::Integer,
+        preset: Imgproxy::OptionsCasters::Array,
+        hashsum: Imgproxy::OptionsCasters::Hashsum,
+        max_src_resolution: Imgproxy::OptionsCasters::Float,
+        max_src_file_size: Imgproxy::OptionsCasters::Integer,
+      }.freeze
+    end
+  end
+end

data/lib/imgproxy/options_builders/processing.rb

@@ -0,0 +1,150 @@
+# frozen_string_literal: true
+
+require "imgproxy/options_builders/base"
+
+require "imgproxy/options_casters/string"
+require "imgproxy/options_casters/integer"
+require "imgproxy/options_casters/float"
+require "imgproxy/options_casters/bool"
+require "imgproxy/options_casters/array"
+require "imgproxy/options_casters/base64"
+require "imgproxy/options_casters/resize"
+require "imgproxy/options_casters/size"
+require "imgproxy/options_casters/zoom"
+require "imgproxy/options_casters/extend"
+require "imgproxy/options_casters/gravity"
+require "imgproxy/options_casters/crop"
+require "imgproxy/options_casters/trim"
+require "imgproxy/options_casters/padding"
+require "imgproxy/options_casters/background"
+require "imgproxy/options_casters/adjust"
+require "imgproxy/options_casters/unsharp_masking"
+require "imgproxy/options_casters/blur_detections"
+require "imgproxy/options_casters/draw_detections"
+require "imgproxy/options_casters/gradient"
+require "imgproxy/options_casters/watermark"
+require "imgproxy/options_casters/watermark_size"
+require "imgproxy/options_casters/format_quality"
+require "imgproxy/options_casters/autoquality"
+require "imgproxy/options_casters/jpeg_options"
+require "imgproxy/options_casters/png_options"
+require "imgproxy/options_casters/webp_options"
+require "imgproxy/options_casters/video_thumbnail_tile"
+require "imgproxy/options_casters/filename"
+require "imgproxy/options_casters/hashsum"
+
+module Imgproxy
+  module OptionsBuilders
+    # Formats and regroups processing options
+    class Processing < Base
+      CASTERS = {
+        resize: Imgproxy::OptionsCasters::Resize,
+        size: Imgproxy::OptionsCasters::Size,
+        resizing_type: Imgproxy::OptionsCasters::String,
+        resizing_algorithm: Imgproxy::OptionsCasters::String,
+        width: Imgproxy::OptionsCasters::Integer,
+        height: Imgproxy::OptionsCasters::Integer,
+        "min-width": Imgproxy::OptionsCasters::Integer,
+        "min-height": Imgproxy::OptionsCasters::Integer,
+        zoom: Imgproxy::OptionsCasters::Zoom,
+        dpr: Imgproxy::OptionsCasters::Float,
+        enlarge: Imgproxy::OptionsCasters::Bool,
+        extend: Imgproxy::OptionsCasters::Extend,
+        extend_aspect_ratio: Imgproxy::OptionsCasters::Extend,
+        gravity: Imgproxy::OptionsCasters::Gravity,
+        crop: Imgproxy::OptionsCasters::Crop,
+        trim: Imgproxy::OptionsCasters::Trim,
+        padding: Imgproxy::OptionsCasters::Padding,
+        auto_rotate: Imgproxy::OptionsCasters::Bool,
+        rotate: Imgproxy::OptionsCasters::Integer,
+        background: Imgproxy::OptionsCasters::Background,
+        background_alpha: Imgproxy::OptionsCasters::Float,
+        adjust: Imgproxy::OptionsCasters::Adjust,
+        brightness: Imgproxy::OptionsCasters::Integer,
+        contrast: Imgproxy::OptionsCasters::Float,
+        saturation: Imgproxy::OptionsCasters::Float,
+        blur: Imgproxy::OptionsCasters::Float,
+        sharpen: Imgproxy::OptionsCasters::Float,
+        pixelate: Imgproxy::OptionsCasters::Integer,
+        unsharp_masking: Imgproxy::OptionsCasters::UnsharpMasking,
+        blur_detections: Imgproxy::OptionsCasters::BlurDetections,
+        draw_detections: Imgproxy::OptionsCasters::DrawDetections,
+        gradient: Imgproxy::OptionsCasters::Gradient,
+        watermark: Imgproxy::OptionsCasters::Watermark,
+        watermark_url: Imgproxy::OptionsCasters::Base64,
+        watermark_text: Imgproxy::OptionsCasters::Base64,
+        watermark_size: Imgproxy::OptionsCasters::WatermarkSize,
+        watermark_shadow: Imgproxy::OptionsCasters::Float,
+        style: Imgproxy::OptionsCasters::Base64,
+        strip_metadata: Imgproxy::OptionsCasters::Bool,
+        keep_copyright: Imgproxy::OptionsCasters::Bool,
+        dpi: Imgproxy::OptionsCasters::Float,
+        strip_color_profile: Imgproxy::OptionsCasters::Bool,
+        enforce_thumbnail: Imgproxy::OptionsCasters::Bool,
+        quality: Imgproxy::OptionsCasters::Integer,
+        format_quality: Imgproxy::OptionsCasters::FormatQuality,
+        autoquality: Imgproxy::OptionsCasters::Autoquality,
+        max_bytes: Imgproxy::OptionsCasters::Integer,
+        jpeg_options: Imgproxy::OptionsCasters::JpegOptions,
+        png_options: Imgproxy::OptionsCasters::PngOptions,
+        webp_options: Imgproxy::OptionsCasters::WebpOptions,
+        format: Imgproxy::OptionsCasters::String,
+        page: Imgproxy::OptionsCasters::Integer,
+        pages: Imgproxy::OptionsCasters::Integer,
+        disable_animation: Imgproxy::OptionsCasters::Bool,
+        video_thumbnail_second: Imgproxy::OptionsCasters::Integer,
+        video_thumbnail_keyframes: Imgproxy::OptionsCasters::Bool,
+        video_thumbnail_tile: Imgproxy::OptionsCasters::VideoThumbnailTile,
+        fallback_image_url: Imgproxy::OptionsCasters::Base64,
+        skip_processing: Imgproxy::OptionsCasters::Array,
+        raw: Imgproxy::OptionsCasters::Bool,
+        cachebuster: Imgproxy::OptionsCasters::String,
+        expires: Imgproxy::OptionsCasters::Integer,
+        filename: Imgproxy::OptionsCasters::Filename,
+        return_attachment: Imgproxy::OptionsCasters::Bool,
+        preset: Imgproxy::OptionsCasters::Array,
+        hashsum: Imgproxy::OptionsCasters::Hashsum,
+        max_src_resolution: Imgproxy::OptionsCasters::Float,
+        max_src_file_size: Imgproxy::OptionsCasters::Integer,
+        max_animation_frames: Imgproxy::OptionsCasters::Integer,
+        max_animation_frame_resolution: Imgproxy::OptionsCasters::Float,
+      }.freeze
+
+      META = %i[size resize adjust].freeze
+
+      def initialize(options)
+        super
+
+        # Legacy name for unsharp_masking
+        if options.key?(:unsharpening)
+          warn "[DEPRECATION] `unsharpening` option is deprecated. Please use `unsharp_masking` instead."
+          delete(:unsharpening)
+          unless key?(:unsharp_masking)
+            self[:unsharp_masking] = CASTERS[:unsharp_masking].cast(options[:unsharpening])
+          end
+        end
+      end
+
+      private
+
+      def group_opts
+        group_resizing_opts
+        group_adjust_opts
+      end
+
+      def group_resizing_opts
+        return unless self[:width] && self[:height] && !self[:size] && !self[:resize]
+
+        self[:size] = extract_and_trim_nils(:width, :height, :enlarge, :extend)
+        self[:resize] = [delete(:resizing_type), *delete(:size)] if self[:resizing_type]
+      end
+
+      def group_adjust_opts
+        return if self[:adjust]
+        return unless values_at(:brightness, :contrast, :saturation).count { |o| o } > 1
+
+        self[:adjust] = extract_and_trim_nils(:brightness, :contrast, :saturation)
+      end
+    end
+  end
+end

data/lib/imgproxy/options_casters/adjust.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require "imgproxy/options_casters/group"
 require "imgproxy/options_casters/integer"
 require "imgproxy/options_casters/float"
 
 module Imgproxy
   module OptionsCasters
-    # Casts gravity option
+    # Casts `adjust` processing option
     module Adjust
       CASTER = Imgproxy::OptionsCasters::Group.new(
         brightness: Imgproxy::OptionsCasters::Integer,

data/lib/imgproxy/options_casters/alpha.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require "imgproxy/options_casters/group"
+require "imgproxy/options_casters/bool"
+
+module Imgproxy
+  module OptionsCasters
+    # Casts `alpha` info option
+    module Alpha
+      CASTER = Imgproxy::OptionsCasters::Group.new(
+        alpha: Imgproxy::OptionsCasters::Bool,
+        check_transparency: Imgproxy::OptionsCasters::Bool,
+      ).freeze
+
+      def self.cast(raw)
+        # Allow alpha to be just a boolean
+        return Imgproxy::OptionsCasters::Bool.cast(raw) if [true, false].include?(raw)
+
+        return raw unless raw.is_a?(Hash)
+        return if raw[:alpha].nil?
+
+        values = CASTER.cast(raw)
+        values[0].zero? ? 0 : values
+      end
+    end
+  end
+end