imgix 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 57ebb7ae8df29e8673a3c0988392313412408f0e
-  data.tar.gz: 1e465ab4bc2c1e11896bf734c7ab33b9f4bbadf2
+  metadata.gz: 7a760faaa0b10815f6507106c11fae9ef28ab574
+  data.tar.gz: f08596f57d3bc94cbc3f30a8f597c858ab154c80
 SHA512:
-  metadata.gz: d6755c1578a6677abb8bcc48c06c8886dec7202a54997a2618052bdddc96f7141a3d90b5c0707415c12df022cd7e7f65704c921db9e20ddd3cd90e0c23236b04
-  data.tar.gz: d131017e65866fb3cee2cf1adf012be943902b779eeffb147bacc46f26ffa0ced93c0e6c7928ada2a34c2281900a1e3a929b8fb299063e5adc01ab81062bd168
+  metadata.gz: 535a0f0626342197b5435564ed7d15af4163b8cbe11c6cba57da5dd6193965a3e0c4cc8f0b795448c7ee8ea1df991a4cdb142134c3c9a33f35adfbb4b8b28158
+  data.tar.gz: 6b41e460a3698bd90a9723fea1ddc43f75db4b6c19f1f5d48e4307aa8a9dee6a1de1e2d6e228c20b53a3bb5a99d406dbe33e2e61dc065c26c4169c62b5c2bd8f

data/.gitignore

@@ -3,6 +3,7 @@
 .bundle
 .config
 .yardoc
+.ruby-version
 Gemfile.lock
 InstalledFiles
 _yardoc

data/.travis.yml

@@ -2,8 +2,7 @@ language: ruby
 bundler_args: --without development
 before_install: gem install bundler
 rvm:
+  - 2.2.1
   - 1.9.2
-  - 1.9.3
-  - 2.0.0
-  - jruby-19mode
-  - rbx-2
+  - jruby-1.7.19
+  - rbx-2.2.7

data/Readme.markdown

@@ -1,13 +1,17 @@
 # Imgix
 
-Unofficial Ruby Gem for signing [imgix](http://imgix.com) URLs.
+Unofficial Ruby Gem for signing [imgix](http://imgix.com) URLs. Tested under 1.9.2, 2.2.1, JRuby 1.7.19, and Rubinius 2.2.7.
+
+[![Build Status](https://travis-ci.org/soffes/imgix-rb.png?branch=master)](https://travis-ci.org/soffes/imgix-rb)
 
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'imgix'
+``` ruby
+gem 'imgix'
+```
 
 And then execute:
 
@@ -25,7 +29,7 @@ Simply initialize a client with a host and your token. You can optionally genera
 Now, if you have the URL ready to go, you can call `sign_path` to get the Imgix URL back. If you would like to manipulate the path parameters you can call `path` with the resource path to get an Imgix::Path object back.
 
 ``` ruby
-client = Imgix::Client.new(:host => 'your-subdomain.imgix.net', :token => 'your-token', :secure => true)
+client = Imgix::Client.new(host: 'your-subdomain.imgix.net', token: 'your-token', secure: true)
 
 client.sign_path('/images/demo.png?w=200')
 #=> https://your-subdomain.imgix.net/images/demo.png?w=200&s=2eadddacaa9bba4b88900d245f03f51e
@@ -46,35 +50,42 @@ path.defaults.width(300).to_url # Resets parameters
 path.rect(x: 0, y: 50, width: 200, height: 300).to_url # Rect helper
 ```
 
-# Domain Sharded URLs
+
+## Domain Sharded URLs
+
 Domain sharding enables you to spread image requests across multiple domains. This allows you to bypass the requests-per-host limits of browsers. We recommend 2-3 domain shards maximum if you are going to use domain sharding.
 
 In order to use domain sharding, you need to add multiple domains to your source. You then provide a list of these domains to a builder.
 
 
 ``` ruby
-client = Imgix::Client.new(:hosts => ['your-subdomain-1.imgix.net', 'your-subdomain-2.imgix.net'])
+client = Imgix::Client.new(hosts: ['your-subdomain-1.imgix.net',
+  'your-subdomain-2.imgix.net'])
 ```
+
 By default, shards are calculated using a checksum so that the image path always resolves to the same domain. This improves caching in the browser. However, you can also specify cycle that simply cycles through the domains as you request them.
 
 
 ``` ruby
-client = Imgix::Client.new(:hosts => ['your-subdomain-1.imgix.net', 'your-subdomain-2.imgix.net'], :shard_strategy => :cycle))
+client = Imgix::Client.new(hosts: ['your-subdomain-1.imgix.net',
+  'your-subdomain-2.imgix.net'], shard_strategy: :cycle))
 ```
-# Multiple Parameters
+
+
+## Multiple Parameters
+
 When the imgix api requires multiple parameters you have to use the method rather than an accessor.
-For example to use the [noise reduction](http://www.imgix.com/docs/urlapi/enhance#nr-nrs) options
+
+For example to use the [noise reduction](http://www.imgix.com/docs/urlapi/enhance#nr-nrs) options:
 
 ``` ruby
 path.noise_reduction(50,50)
 ```
 
 
-## Supported Ruby Versions
-
-Imgix is tested under 1.9.2, 1.9.3, 2.0.0, JRuby 1.7.2 (1.9 mode), and Rubinius 2.0.0 (1.9 mode).
+## URL encoding and signed ImgIX URLs
 
-[![Build Status](https://travis-ci.org/soffes/imgix-rb.png?branch=master)](https://travis-ci.org/soffes/imgix-rb)
+Some important third parties (like Facebook) apply URL escaping to query string components, which can cause correctly signed ImgIX URLs to to be transformed into incorrectly signed ones. We URL encode the query part of the URL before signing, so you don't have to worry about this.
 
 
 ## Contributing

data/lib/imgix/path.rb

@@ -1,3 +1,4 @@
+require 'cgi/util'
 require 'imgix/param_helpers'
 
 module Imgix
@@ -38,7 +39,7 @@ module Imgix
     def to_url(opts={})
       prev_options = @options.dup
       @options.merge!(opts)
-      
+
       url = @prefix + path_and_params
 
       # Weird bug in imgix. If there are no params, you still have
@@ -80,7 +81,7 @@ module Imgix
 
     private
 
-    def signature      
+    def signature
       Digest::MD5.hexdigest(@token + @path + '?' + query)
     end
 
@@ -89,7 +90,7 @@ module Imgix
     end
 
     def query
-      @options.map { |k, v| "#{k.to_s}=#{v}" }.join('&')
+      @options.map { |k, v| "#{k.to_s}=#{CGI.escape(v.to_s)}" }.join('&')
     end
   end
-end
+end

data/lib/imgix/version.rb

@@ -1,3 +1,3 @@
 module Imgix
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

data/test/units/path_test.rb

@@ -41,6 +41,13 @@ class PathTest < Imgix::Test
     assert_equal url, path.height(200).width(200).to_url
   end
 
+  def test_path_with_multi_value_param_safely_encoded
+    url = 'http://demo.imgix.net/images/demo.png?markalign=middle%2Ccenter&s=f0d0e28a739f022638f4ba6dddf9b694'
+    path = client.path('/images/demo.png')
+
+    assert_equal url, path.markalign('middle', 'center').to_url
+  end
+
   def test_host_is_required
     assert_raises(ArgumentError) {Imgix::Client.new}
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: imgix
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Sam Soffes
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-16 00:00:00.000000000 Z
+date: 2015-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -72,7 +72,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Unofficial Ruby Gem for easily signing imgix URLs.