imdb_party 0.3.0 → 0.4.0

data/README.md

@@ -7,9 +7,9 @@
     imdb = ImdbParty::Imdb.new
 ### Search for a movie by title
 
-    imdb.find_movie_by_title("The Dark Knight") => [{:title => "The Dark Knight", :year => "2008", :imdb_id => "tt0468569"}, {:title => "Batman Unmasked", ...}]
+    imdb.find_by_title("The Dark Knight") => [{:title => "The Dark Knight", :year => "2008", :imdb_id => "tt0468569"}, {:title => "Batman Unmasked", ...}]
 
-### Get a movie by its imdb_id    
+### Get a movie by its imdb_id
 
     movie = imdb.find_movie_by_id("tt0468569")
 
@@ -18,10 +18,9 @@
     movie.certification => "PG-13"
 
 ### Find the top 250 movies of all time
-    
+
     imdb.top_250 => [{:title => "Shawshank Redemption", :year => "1994", :imdb_id => "tt0111161"}, {:title => "The Godfather", ...}]
 
 ### Get the currently popular tv shows
 
-    imdb.top_shows => [{:title => "Glee", :year => "2009", :imdb_id => "tt1327801"}, {:title => "Dexter", ...}]
-    
+    imdb.popular_shows => [{:title => "Glee", :year => "2009", :imdb_id => "tt1327801"}, {:title => "Dexter", ...}]

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.4.0

data/imdb_party.gemspec

@@ -1,49 +1,47 @@
 # Generated by jeweler
-# DO NOT EDIT THIS FILE
-# Instead, edit Jeweler::Tasks in Rakefile, and run `rake gemspec`
+# DO NOT EDIT THIS FILE DIRECTLY
+# Instead, edit Jeweler::Tasks in rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
   s.name = %q{imdb_party}
-  s.version = "0.3.0"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jon Maddox"]
-  s.date = %q{2010-11-19}
+  s.date = %q{2011-01-04}
   s.description = %q{IMDB client using the IMDB API that their iPhone app uses}
   s.email = %q{jon@mustacheinc.com}
   s.extra_rdoc_files = [
     "LICENSE",
-     "README.md"
+    "README.md"
   ]
   s.files = [
     ".document",
-     ".gitignore",
-     "LICENSE",
-     "README.md",
-     "Rakefile",
-     "VERSION",
-     "imdb_party.gemspec",
-     "lib/imdb_party.rb",
-     "lib/imdb_party/httparty_icebox.rb",
-     "lib/imdb_party/imdb.rb",
-     "lib/imdb_party/movie.rb",
-     "lib/imdb_party/person.rb",
-     "test/movie_test.rb",
-     "test/person_test.rb",
-     "test/search_test.rb",
-     "test/test_helper.rb"
+    "LICENSE",
+    "README.md",
+    "Rakefile",
+    "VERSION",
+    "imdb_party.gemspec",
+    "lib/imdb_party.rb",
+    "lib/imdb_party/httparty_icebox.rb",
+    "lib/imdb_party/imdb.rb",
+    "lib/imdb_party/movie.rb",
+    "lib/imdb_party/person.rb",
+    "test/movie_test.rb",
+    "test/person_test.rb",
+    "test/search_test.rb",
+    "test/test_helper.rb"
   ]
   s.homepage = %q{http://github.com/maddox/imdb_party}
-  s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
   s.rubygems_version = %q{1.3.7}
   s.summary = %q{IMDB client using the IMDB API that their iPhone app uses}
   s.test_files = [
     "test/movie_test.rb",
-     "test/person_test.rb",
-     "test/search_test.rb",
-     "test/test_helper.rb"
+    "test/person_test.rb",
+    "test/search_test.rb",
+    "test/test_helper.rb"
   ]
 
   if s.respond_to? :specification_version then
@@ -62,3 +60,4 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<httparty>, [">= 0"])
   end
 end
+

data/lib/imdb_party/imdb.rb

@@ -12,7 +12,7 @@ module ImdbParty
       movie_results = []
       results = self.class.get('/find', :query => {:q => title}).parsed_response
       
-      if results["data"]["results"]
+      if results["data"] && results["data"]["results"]
         results["data"]["results"].each do |result_section|
           result_section["list"].each do |r|
             next unless r["tconst"] && r["title"]

data/test/movie_test.rb

@@ -2,7 +2,7 @@ require 'test_helper'
 
 class MovieTest < Test::Unit::TestCase
   context "a movie" do
-    setup do 
+    setup do
       @imdb = ImdbParty::Imdb.new
       @movie = @imdb.find_movie_by_id("tt0382932")
     end
@@ -32,7 +32,7 @@ class MovieTest < Test::Unit::TestCase
     end
 
     should "have a poster_url" do
-      assert_equal "http://ia.media-imdb.com/images/M/MV5BMzgwNzY0MDkwOF5BMl5BanBnXkFtZTcwNzMxMDI1MQ@@._V1_.jpg", @movie.poster_url
+      assert_match /http:\/\/ia.media-imdb.com\/images\/.*/, @movie.poster_url
     end
 
     should "have a release date" do
@@ -70,4 +70,4 @@ class MovieTest < Test::Unit::TestCase
     end
 
   end
-end
+end

data/test/person_test.rb

@@ -2,11 +2,11 @@ require 'test_helper'
 
 class PersonTest < Test::Unit::TestCase
   context "a person" do
-    setup do 
+    setup do
       @imdb = ImdbParty::Imdb.new
       @movie = @imdb.find_movie_by_id("tt0382932")
     end
-    
+
     context "actors" do
       should "have a name" do
         assert_equal "Patton Oswalt", @movie.actors.first.name
@@ -22,7 +22,7 @@ class PersonTest < Test::Unit::TestCase
         assert_equal "Brad Bird", @movie.directors.first.name
       end
 
-      should "have not have a role" do
+      should "not have a role" do
         assert_equal nil, @movie.directors.first.role
       end
     end
@@ -32,7 +32,7 @@ class PersonTest < Test::Unit::TestCase
         assert_equal "Brad Bird", @movie.writers.first.name
       end
 
-      should "have not have a role" do
+      should "not have a role" do
         assert_equal nil, @movie.writers.first.role
       end
     end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: imdb_party
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 15
   prerelease: false
   segments: 
   - 0
-  - 3
+  - 4
   - 0
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Jon Maddox
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-19 00:00:00 -05:00
+date: 2011-01-04 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -57,7 +57,6 @@ extra_rdoc_files:
 - README.md
 files: 
 - .document
-- .gitignore
 - LICENSE
 - README.md
 - Rakefile
@@ -77,8 +76,8 @@ homepage: http://github.com/maddox/imdb_party
 licenses: []
 
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
+rdoc_options: []
+
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 

data/.gitignore

@@ -1,5 +0,0 @@
-*.sw?
-.DS_Store
-coverage
-rdoc
-pkg