imdb_og 0.5.1 → 0.5.2

data/VERSION

@@ -1 +1 @@
-0.5.1
+0.5.2

data/imdb_og.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{imdb_og}
-  s.version = "0.5.1"
+  s.version = "0.5.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jon Maddox"]
-  s.date = %q{2009-11-03}
+  s.date = %q{2009-11-28}
   s.description = %q{Simple library to look up movies on IMDB}
   s.email = %q{jon@mustacheinc.com}
   s.extra_rdoc_files = [

data/lib/imdb/imdb.rb

@@ -9,13 +9,17 @@ class Imdb
 
   def self.search_movies_by_title(title)
     document = Hpricot(open("#{IMDB_SEARCH_BASE_URL}#{CGI::escape(title)};s=tt").read)
-
-    results = document.search('a[@href^="/title/tt"]').reject do |element|
-      element.innerHTML.strip_tags.empty?
-    end.map do |element|
-      {:imdb_id => element['href'][/tt\d+/], :title => element.innerHTML.strip_tags.unescape_html}
+    # we got search results
+    if document.search('title').inner_text == "IMDb Title Search"
+      results = document.search('a[@href^="/title/tt"]').reject do |element|
+        element.innerHTML.strip_tags.empty?
+      end.map do |element|
+        {:imdb_id => element['href'][/tt\d+/], :title => element.innerHTML.strip_tags.unescape_html}
+      end
+      results.uniq
+    else
+      {:imdb_id => document.search('link[@href^="http://www.imdb.com/title/tt"]').first['href'].match(/tt\d+/).to_s, :title => document.search('meta[@name="title"]').first["content"].gsub(/\(\d\d\d\d\)$/, '').strip}
     end
-    results.uniq
   end
 
   def self.find_movie_by_id(id)

data/test/imdb_test.rb

@@ -11,21 +11,43 @@ class ImdbTest < Test::Unit::TestCase
     end
   end
   context "when searching" do
-    setup do
-      @results = Imdb.search_movies_by_title('transformers')
-    end
+    context "for an ambiguous title" do
+      setup do
+        @results = Imdb.search_movies_by_title('transformers')
+      end
     
-    should "return an array of results" do
-      assert_equal Array, @results.class
-    end
-
-    should "return an array of hashes" do
-      assert_equal Hash, @results.first.class
+      should "return an array of results" do
+        assert_equal Array, @results.class
+      end
+    
+      should "return an array of hashes" do
+        assert_equal Hash, @results.first.class
+      end
+    
+      should "return an array of hashes with the right keys" do
+        assert @results.first.has_key?(:title)
+        assert @results.first.has_key?(:imdb_id)
+      end
     end
-
-    should "return an array of hashes with the right keys" do
-      assert @results.first.has_key?(:title)
-      assert @results.first.has_key?(:imdb_id)
+    
+    context "for a distinct title" do
+      setup do
+        @result = Imdb.search_movies_by_title('the september issue')
+      end
+    
+      should "return a single hash of the exact result" do
+        assert_equal Hash, @result.class
+      end
+    
+      should "return an the correct movie title" do
+        assert @result.has_key?(:title)
+        assert_equal "The September Issue", @result[:title]
+      end
+    
+      should "return an the correct imdb id" do
+        assert @result.has_key?(:imdb_id)
+        assert_equal "tt1331025", @result[:imdb_id]
+      end
     end
 
   end
@@ -80,7 +102,7 @@ class ImdbTest < Test::Unit::TestCase
         assert_equal 'nm0083348', @movie.writers[0].imdb_id
         assert_equal 'Brad Bird', @movie.writers[0].name
         assert_equal 'screenplay', @movie.writers[0].role
-
+  
         assert_equal 'nm0684342', @movie.writers[1].imdb_id
         assert_equal 'Jan Pinkava', @movie.writers[1].name
         assert_equal 'story', @movie.writers[1].role
@@ -91,7 +113,7 @@ class ImdbTest < Test::Unit::TestCase
         assert_equal 'nm0652663', @movie.actors[0].imdb_id
         assert_equal 'Patton Oswalt', @movie.actors[0].name
         assert_equal 'Remy (voice)', @movie.actors[0].role
-
+  
         assert_equal 'nm0826039', @movie.actors[14].imdb_id
         assert_equal 'Jake Steinfeld', @movie.actors[14].name
         assert_equal 'Git (Lab Rat) (voice)', @movie.actors[14].role

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: imdb_og
 version: !ruby/object:Gem::Version 
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors: 
 - Jon Maddox
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-03 00:00:00 -05:00
+date: 2009-11-28 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency