imdb_lists 1.0.4 → 2.0.2

data/spec/imdb_list_spec.rb

@@ -0,0 +1,143 @@
+require "spec_helper"
+
+describe ImdbLists do  
+  describe "arguments" do
+    it "should raise an error if url is invalid" do
+      lambda { ImdbLists.fetch("random") }.should raise_error(ArgumentError, "Invalid url")
+    end
+    
+    it "should NOT raise an error if url is valid" do
+      lambda { ImdbLists.fetch("http://www.imdb.com/user/ur10777143/ratings") }.should_not raise_error
+    end
+  end
+
+  describe "rating list" do
+    let(:url) { "http://www.imdb.com/user/ur10777143/ratings" }
+    
+    use_vcr_cassette "ur10777143"
+    
+    before(:each) do
+      @list = ImdbLists.fetch(url)
+    end
+    
+    it "should have a name" do
+      @list.name.should eq("Demon_Hunter777's Ratings")
+    end
+    
+    it "should have csv link" do
+      @list.csv.should eq("http://www.imdb.com/list/export?list_id=ratings&author_id=ur10777143")
+    end
+    
+    it "should have 693 movies" do
+      @list.should have(693).movies
+    end
+    
+    it "should have a list of movies" do
+      @list.movies.each do |movie|
+        movie.id.should match(/tt\d{7}/)
+        movie.created_at.should be_instance_of(Time)
+        movie.title.should_not be_empty
+        movie.directors.should be_instance_of(Array)
+        movie.you_rated.should be_between(0, 10)
+        movie.rating.should be_between(0, 10)
+        movie.runtime.should >= 0
+        movie.year.should > 1900
+        movie.genres.map(&:titleize).should eq(movie.genres)
+        movie.votes.should > 1
+        movie.released_at.should be_instance_of(Time)
+        movie.details.should match(/^((http[s]?|ftp):\/)?\/?([^:\/\s]+)((\/\w+)*\/)([\w\-\.]+[^#?\s]+)(.*)?(#[\w\-]+)?$/)
+      end
+    end
+    
+    it "should not calculate #movies twice" do
+      @list.movies.should eq(@list.movies)
+    end
+    
+    it "should be able to cache a request" do
+      2.times { @list.name }
+      a_request(:get, url).should have_been_made.once
+    end
+    
+    it "should be able to return the given url" do
+      @list.url.should eq(url)
+    end
+  end
+  
+  describe "regular list" do
+    let(:url) { "http://www.imdb.com/list/qJi7_i3l25Y/" }
+    use_vcr_cassette "qJi7_i3l25Y"
+    
+    before(:each) do
+      @list = ImdbLists.fetch(url)
+    end
+    
+    it "should have a name" do
+      @list.name.should eq("Not so good movies...")
+    end
+    
+    it "should have csv link" do
+      @list.csv.should eq("http://www.imdb.com/list/export?list_id=qJi7_i3l25Y&author_id=ur28206273")
+    end
+    
+    it "should have 17 movies" do
+      @list.should have(17).movies
+    end
+    
+    it "should have a list of movies" do
+      @list.movies.each do |movie|
+        movie.id.should match(/tt\d{7}/)
+        movie.created_at.should be_instance_of(Time)
+        movie.title.should_not be_empty
+        movie.directors.should be_instance_of(Array)
+        movie.you_rated.should be_nil
+        movie.rating.should be_between(0, 10)
+        movie.runtime.should >= 0
+        movie.year.should > 1900
+        movie.genres.map(&:titleize).should eq(movie.genres)
+        movie.votes.should > 1
+        movie.released_at.should be_instance_of(Time)
+        movie.details.should match(/^((http[s]?|ftp):\/)?\/?([^:\/\s]+)((\/\w+)*\/)([\w\-\.]+[^#?\s]+)(.*)?(#[\w\-]+)?$/)
+      end
+    end
+    
+    it "should be able to cache a request" do
+      2.times { @list.name }
+      a_request(:get, url).should have_been_made.once
+    end
+    
+    it "should be able to return the given url" do
+      @list.url.should eq(url)
+    end
+  end
+  
+  
+  describe "invalid url" do
+    let(:url) { "http://www.imdb.com/list/random/" }
+    use_vcr_cassette "random"
+    
+    before(:each) do
+      @list = ImdbLists.fetch(url)
+    end
+    
+    it "should not have a name" do
+      @list.name.should be_nil
+    end
+    
+    it "should not have csv link" do
+      @list.csv.should be_nil
+    end
+    
+    it "should have 0 movies" do
+      @list.should have(0).movies
+    end
+        
+    it "should be able to cache a request" do
+      2.times { @list.name }
+      a_request(:get, url).should have_been_made.once
+    end
+    
+    it "should be able to return the given url" do
+      @list.url.should eq(url)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,12 +1,20 @@
 require "rspec"
 require "webmock/rspec"
+require "vcr"
 require "imdb_lists"
-require "imdb_lists/container"
-require "imdb_lists/history"
-require "imdb_lists/watchlist"
 
 WebMock.disable_net_connect!
 
 RSpec.configure do |config|
   config.mock_with :rspec
+  config.extend VCR::RSpec::Macros
+end
+
+VCR.config do |c|
+  c.cassette_library_dir = "spec/fixtures/vcr_cassettes"
+  c.stub_with :webmock
+  c.default_cassette_options = {
+    record: :new_episodes
+  }
+  c.allow_http_connections_when_no_cassette = false
 end

metadata

@@ -2,7 +2,7 @@
 name: imdb_lists
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.0.4
+  version: 2.0.2
 platform: ruby
 authors: 
 - Linus Oleander
@@ -10,8 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-03 00:00:00 +02:00
-default_executable: 
+date: 2011-09-20 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rest-client
@@ -36,7 +35,7 @@ dependencies:
   type: :runtime
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: movie_searcher
+  name: titleize
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
@@ -47,7 +46,7 @@ dependencies:
   type: :runtime
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: abstract
+  name: vcr
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
@@ -55,7 +54,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version 
         version: "0"
-  type: :runtime
+  type: :development
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
   name: rspec
@@ -92,27 +91,16 @@ files:
 - .gitignore
 - .rspec
 - Gemfile
-- README.markdown
+- README.md
 - Rakefile
 - imdb_lists.gemspec
 - lib/imdb_lists.rb
-- lib/imdb_lists/base.rb
-- lib/imdb_lists/container.rb
-- lib/imdb_lists/history.rb
-- lib/imdb_lists/watchlist.rb
-- spec/container_spec.rb
-- spec/fixtures/32558051.html
-- spec/fixtures/empty_watchlist.html
-- spec/fixtures/non_public.html
-- spec/fixtures/non_public_watchlist.html
-- spec/fixtures/pagination.html
-- spec/fixtures/pagination_end.html
-- spec/fixtures/redirect_watchlist.html
-- spec/fixtures/watchlist.html
-- spec/history_spec.rb
+- lib/imdb_lists/object.rb
+- spec/fixtures/vcr_cassettes/qJi7_i3l25Y.yml
+- spec/fixtures/vcr_cassettes/random.yml
+- spec/fixtures/vcr_cassettes/ur10777143.yml
+- spec/imdb_list_spec.rb
 - spec/spec_helper.rb
-- spec/watchlist_spec.rb
-has_rdoc: true
 homepage: https://github.com/oleander/imdb_lists
 licenses: []
 
@@ -126,7 +114,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      version: "0"
+      version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
@@ -136,20 +124,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.8
 signing_key: 
 specification_version: 3
 summary: Get easy access to any public IMDb list
 test_files: 
-- spec/container_spec.rb
-- spec/fixtures/32558051.html
-- spec/fixtures/empty_watchlist.html
-- spec/fixtures/non_public.html
-- spec/fixtures/non_public_watchlist.html
-- spec/fixtures/pagination.html
-- spec/fixtures/pagination_end.html
-- spec/fixtures/redirect_watchlist.html
-- spec/fixtures/watchlist.html
-- spec/history_spec.rb
+- spec/fixtures/vcr_cassettes/qJi7_i3l25Y.yml
+- spec/fixtures/vcr_cassettes/random.yml
+- spec/fixtures/vcr_cassettes/ur10777143.yml
+- spec/imdb_list_spec.rb
 - spec/spec_helper.rb
-- spec/watchlist_spec.rb

data/README.markdown

@@ -1,77 +0,0 @@
-# IMDb Lists
-
-Get easy access to any public [IMDb](http://www.imdb.com/) [vote history list](http://www.imdb.com/mymovies/list?l=19736607) and [watchlist](http://www.imdb.com/list/2BZy80bxY2U) using Ruby.
-
-## How to use
-
-### Find by url
-
-    $ require 'rubygems'
-    $ require 'imdb_lists'
-    
-    $ result = ImdbLists::find_by_url("http://www.imdb.com/mymovies/list?l=32558051")
-    
-    $ result.movies.count
-    >> 937
-    
-    $ result.user
-    >> "eddyproca" # Not me :)
-    
-    $ result.movies.last.title
-    >> "The Last Man on Earth"
-    
-    $ result.movies.first.class
-    >> Container::Movie
-    
-    $ result.movies.last.actors.first.name
-    >> "Vincent Price"
-    
-### Find by id
-
-    $ result = ImdbLists::find_by_id("32558051")
-    
-    $ result.movies.count
-    >> 937
-    
-## Data to work with
-
-### Accessors
-
-- **user** (String) Owner of the list.
-- **id** (Fixnum or String) A unique id for the list.
-- **url** (String) Full URL to the IMDb list itself.
-- **movies** (Array[Container::Movie]) A list of movies containing `Container::Movie` instances.
-- **title** (String) Title of the watchlist.
-- **valid?** (Boolean) Is the data that is being returned valid?
-
-### The Container::Movie class
-
-The `movies` method returns a list of `Container::Movie` objects, each object has two methods that returns information about the movie without doing another request to [IMDb](http://www.imdb.com/).
-
-If you for example want to get the title of the movie you can apply the accessors that is being described [here](https://github.com/oleander/MovieSearcher).
-Scroll down to the `ImdbParty::Movie` part to get information about the available accessors.
-
-- **imdb_link** (String) The full URL to the IMDb page.
-- **imdb_id** (String) The IMDb ID for the movie.
-
-You can, as said above, use any method that `ImdbParty::Movie` provides directly from the `Container::Movie` object, like *title*, *year* and *actors*.
-
-## How do install
-
-    [sudo] gem install imdb_lists
-    
-## How to use it in a rails 3 project
-
-Add `gem 'imdb_lists'` to your Gemfile and run `bundle`.
-
-## Requirements
-
-*IMDb Lists* is tested in OS X 10.6.6 using Ruby 1.9.2 and 1.8.7.
-
-## Thanks to
-
-[Chicago_gangster](http://www.imdb.com/user/ur13279695/boards/profile/) for solving the [pagination problem](http://www.imdb.com/board/bd0000041/thread/178983592?d=178983592&p=1#178983592).
-
-## License
-
-*IMDb Lists* is released under the MIT license.

data/lib/imdb_lists/base.rb

@@ -1,31 +0,0 @@
-require "abstract"
-
-module ImdbLists
-  class Base    
-    def download
-      RestClient.get(inner_url, :timeout => 10)
-    rescue RestClient::Exception => error
-      @errors == true ? raise(error) : warn("Error: #{error}, Where: #{error.backtrace.first}")
-    end
-    
-    def content
-      @content ||= Nokogiri::HTML(download)
-    end
-    
-    def movies
-      prepare! unless @movies.any?; @movies
-    end
-    
-    def errors(boolean)
-      tap { @errors = boolean }
-    end
-    
-    def prepare!
-      not_implemented
-    end
-    
-    def inner_url
-      not_implemented
-    end
-  end
-end

data/lib/imdb_lists/container.rb

@@ -1,49 +0,0 @@
-require "movie_searcher"
-
-module Container
-  class Movie
-    def initialize(args)
-      args.keys.each { |name| instance_variable_set "@" + name.to_s, args[name] }
-    end
-        
-    # Returns the imdb id for the movie.
-    # Example:
-    # => tt0066026
-    def imdb_id
-      imdb_link.match(/(tt\d+)/).to_a[1]
-    end
-    
-    # Returns the full imdb url for the movie.
-    # Example:
-    # => www.imdb.com/title/tt0066026/
-    def imdb_link
-      "http://www.imdb.com#{@imdb_link}"  
-    end
-    
-    # Does the container contains a valid imdb url?
-    # Return true if the url is valid.
-    # Example on valid url:
-    # => www.imdb.com/title/tt0066026/
-    def valid?
-      !! imdb_link.match(/http:\/\/www\.imdb\.com\/title\/tt\d{2,}/i)
-    end
-    
-    def method_missing(method, *args)
-      return movie.send(method, *args) if exists? and movie.methods.include?(prepare(method))
-      raise exists? ? NoMethodError.new("Undefined method '#{method}' for #{movie.class}") : ArgumentError.new("The imdb #{imdb_id} is invalid")
-    end
-    
-    private
-      def exists?
-        ! movie.nil?
-      end
-      
-      def movie
-        @movie ||= MovieSearcher.find_movie_by_id(imdb_id)
-      end
-      
-      def prepare(method)
-        RUBY_VERSION.to_s.match(/1\.9/) ? method.to_sym : method.to_s
-      end
-  end
-end

data/lib/imdb_lists/history.rb

@@ -1,35 +0,0 @@
-require "nokogiri"
-require "rest-client"
-require "imdb_lists/container"
-require "imdb_lists/base"
-
-module ImdbLists
-  class History < ImdbLists::Base
-    attr_reader :url, :id
-  
-    # Ingoing argument is the id to fetch movies from.
-    def initialize(id)
-      @movies = []
-      @url    = "http://www.imdb.com/mymovies/list?l=#{@id = id.to_i}"
-    end
-  
-    # The owners username, nil if the page doesn't exists.
-    def user
-      content.at_css(".blurb a:nth-child(1)").content
-    rescue NoMethodError
-      nil # The default value if no user i found
-    end
-  
-    private
-      def prepare!
-        movies = []; content.css("td.standard a").each do |movie|
-          movie = Container::Movie.new(:imdb_link => movie.attr("href"))
-          @movies << movie if movie.valid?
-        end
-      end
-    
-      def inner_url
-        "#{@url}&a=1"
-      end
-  end
-end