imdb 0.7.0 → 0.8.0

data/spec/imdb/movie_spec.rb

@@ -33,7 +33,7 @@ describe "Imdb::Movie" do
       char.should include("Hostage")
     end
 
-    it "should associates the cast members to the charachters" do
+    it "should associates the cast members to the characters" do
       cast = @movie.cast_members
       char = @movie.cast_characters
       cast_char = @movie.cast_members_characters
@@ -51,11 +51,11 @@ describe "Imdb::Movie" do
 
     describe 'fetching a list of imdb actor ids for the cast members' do
       it 'should not require arguments' do
-        lambda { @movie.cast_member_ids }.should_not raise_error(ArgumentError)
+        expect { @movie.cast_member_ids }.not_to raise_error
       end
 
       it 'should not allow arguments' do
-        lambda { @movie.cast_member_ids(:foo) }.should raise_error(ArgumentError)
+        expect { @movie.cast_member_ids(:foo) }.to raise_error(ArgumentError)
       end
 
       it 'should return the imdb actor number for each cast member' do
@@ -142,7 +142,7 @@ describe "Imdb::Movie" do
     end
 
     it "should find number of votes" do
-      @movie.votes.should be_within(10000).of(343463)
+      @movie.votes.should be_within(10000).of(397054)
     end
 
     it "should find the title" do
@@ -170,6 +170,14 @@ describe "Imdb::Movie" do
       end
     end
 
+    it "should find multiple filming locations" do
+      filming_locations = @movie.filming_locations
+      filming_locations.should be_an(Array)
+      filming_locations.size.should eql(4)
+      filming_locations[0].should match(/.*, USA$/i)
+
+    end
+
     it "should provide a convenience method to search" do
       movies = Imdb::Movie.search("Star Trek: TOS")
       movies.should respond_to(:each)
@@ -186,7 +194,7 @@ describe "Imdb::Movie" do
   describe "plot" do
     it "should find a correct plot when HTML links are present" do
       movie = Imdb::Movie.new("0083987")
-      movie.plot.should eql("Biography of Mohandas K. Gandhi, the lawyer who became the famed leader of the Indian revolts against the British rule through his philosophy of non-violent protest.")
+      movie.plot.should eql("Biography of Mohandas K. Gandhi, the lawyer who became the famed leader of the Indian revolts against the British rule through his philosophy of nonviolent protest.")
     end
 
     it "should not have a 'more' link in the plot" do

data/spec/imdb/search_spec.rb

@@ -10,8 +10,8 @@ describe "Imdb::Search with multiple search results" do
     @search.query.should == "Star Trek: TOS"
   end
 
-  it "should find 2 results" do
-    @search.movies.size.should eql(2)
+  it "should find 4 results" do
+    @search.movies.size.should eql(4)
   end
 
   it "should return Imdb::Movie objects only" do
@@ -30,9 +30,9 @@ end
 describe "Imdb::Search with an exact match and no poster" do
 
   it "should not raise an exception" do
-    lambda {
+    expect {
       @search = Imdb::Search.new("Kannethirey Thondrinal").movies
-    }.should_not raise_error
+    }.not_to raise_error
   end
 
   it "should return the movie id correctly" do

data/spec/imdb/series_spec.rb

@@ -11,7 +11,7 @@ describe "Imdb::Serie" do
   end
 
   it "reports the number of seasons" do
-    @serie.seasons.size.should eql(3)
+    @serie.seasons.size.should eql(4)
   end
 
   it "can fetch a specific season" do

data/spec/imdb/top_250_spec.rb

@@ -4,18 +4,18 @@ describe Imdb::Top250 do
   before(:each) do
     @movies = Imdb::Top250.new.movies
   end
-  
+
   it "should be a list of movies" do
     @movies.each { |movie| movie.should be_an_instance_of(Imdb::Movie) }
   end
-  
+
   it "should return the top 250 movies from IMDB.com" do
     @movies.size.should == 250
   end
 
   it "should provide array like access to the movies" do
-    @first = @movies.first
-    @first.title.should == "The Shawshank Redemption"
-    @first.genres.should include("Drama")
+    @movies[0].title.should == "1. The Shawshank Redemption"
+    @movies[1].title.should == "2. The Godfather"
+    @movies[2].title.should == "3. The Godfather: Part II"
   end
 end

data/spec/spec_helper.rb

@@ -26,6 +26,7 @@ IMDB_SAMPLES = {
   "http://akas.imdb.com:80/title/tt0095016/combined" => "tt0095016",
   "http://akas.imdb.com/title/tt0095016/synopsis" => "synopsis",
   "http://akas.imdb.com/title/tt0095016/plotsummary" => "plotsummary",
+  "http://akas.imdb.com/title/tt0095016/locations" => "locations",
   "http://akas.imdb.com:80/title/tt0242653/combined" => "tt0242653",
   "http://akas.imdb.com/title/tt0166222/?fr=c2M9MXxsbT01MDB8ZmI9dXx0dD0xfG14PTIwfGh0bWw9MXxjaD0xfGNvPTF8cG49MHxmdD0xfGt3PTF8cXM9SSBraWxsZWQgbXkgbGVzYmlhbiB3aWZlfHNpdGU9YWthfHE9SSBraWxsZWQgbXkgbGVzYmlhbiB3aWZlfG5tPTE_;fc=1;ft=7" => "tt0166222",
   "http://akas.imdb.com:80/chart/top" => "top_250",

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: imdb
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Ariejan de Vroom
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-26 00:00:00.000000000 Z
+date: 2013-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: hpricot
+  name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.8.6
+        version: 1.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.8.6
+        version: 1.6.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -107,8 +107,9 @@ files:
 - .travis.yml
 - Gemfile
 - History.txt
+- MIT-LICENSE
 - Manifest.txt
-- README.rdoc
+- README.md
 - Rakefile
 - bin/imdb
 - config/website.yml
@@ -128,6 +129,7 @@ files:
 - script/console
 - script/destroy
 - script/generate
+- spec/fixtures/locations
 - spec/fixtures/plotsummary
 - spec/fixtures/search_kannethirey_thondrinal
 - spec/fixtures/search_killed_wife
@@ -177,11 +179,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: imdb
-rubygems_version: 2.0.0
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Easily access the publicly available information on IMDB.
 test_files:
+- spec/fixtures/locations
 - spec/fixtures/plotsummary
 - spec/fixtures/search_kannethirey_thondrinal
 - spec/fixtures/search_killed_wife

data/README.rdoc

@@ -1,114 +0,0 @@
-= imdb
-
-{<img src="https://travis-ci.org/ariejan/imdb.png?branch=master" alt="Build Status" />}[https://travis-ci.org/ariejan/imdb]
-
-home :: http://github.com/ariejan/imdb
-rdoc :: http://ariejan.github.com/imdb/
-bugs :: http://github.com/ariejan/imdb/issues
-
-== Description
-
-This gem allows you to easy access publicly available data from IMDB.
-
-== Features
-
-IMDB currently features the following:
-
-* Querying details movie info
-* Searching for movies
-* Command-line utility included.
-
-== Synopsis
-
-Movies:
-
-    i = Imdb::Movie.new("0095016")
-    
-    i.title
-    #=> "Die Hard"
-    i.cast_members.first
-    #=> "Bruce Willis"
-
-Series:
-
-    serie = Imdb::Serie.new("1520211")
-
-    serie.title
-    #=> "\"The Walking Dead\""
-
-    serie.rating
-    #=> 8.8
-
-    serie.seasons.size
-    #=> 3
-
-    serie.seaon(1).episodes.size
-    #=> 6
-
-    series.season(1).episode(2).title
-    #=> "Guts"
-
-Searching:
-
-    i = Imdb::Search.new("Star Trek")
-
-    i.movies.size
-    #=> 97
-
-Using the command line utility is quite easy:
-
-    $ imdb Star Trek
-
-or to get movie info
-
-    $ imdb 0095016
-
-== Installation
-
-    $ gem install imdb
-
-== Documentation
-
-This README and generated RDoc documentation are available from http://ariejan.github.com/imdb/
-
-== Running tests
-
-You'll need rspec and fakeweb installed to run the specs.
-
-    $ bundle install
-    $ bundle exec rake spec
-
-Although not recommended, you may run the specs against the live imdb.com 
-website. This will make a lot of calls to imdb.com, use it wisely.
-
-    $ LIVE_TEST=true bundle exec rake spec
-
-To update the packaged fixtures files with actual imdb.com samples, use the
-fixtures:refresh rake task
-
-    $ bundle exec rake fixtures:refresh
-
-== License
-
-(The MIT License)
-
-Copyright (c) 2009 Ariejan de Vroom
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-'Software'), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
-IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
-CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
-TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
-SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.