imdb 0.5.0 → 0.5.1

data/spec/imdb/movie_spec.rb

@@ -7,87 +7,109 @@ require File.dirname(__FILE__) + '/../spec_helper.rb'
 
 describe "Imdb::Movie" do
   
-  before(:each) do
-    # Get Die Hard (1988)
-    @movie = Imdb::Movie.new("0095016")
-  end
+  describe "valid movie" do
+
+    before(:each) do
+      # Get Die Hard (1988)
+      @movie = Imdb::Movie.new("0095016")
+    end
   
-  it "should find the cast members" do
-    cast = @movie.cast_members
+    it "should find the cast members" do
+      cast = @movie.cast_members
     
-    cast.should be_an(Array)
-    cast.should include("Bruce Willis")
-    cast.should include("Bonnie Bedelia")
-    cast.should include("Alan Rickman")
-  end
+      cast.should be_an(Array)
+      cast.should include("Bruce Willis")
+      cast.should include("Bonnie Bedelia")
+      cast.should include("Alan Rickman")
+    end
   
-  it "should find the director" do
-    @movie.director.should be_an(Array)
-    @movie.director.size.should eql(1)
-    @movie.director.first.should =~ /John McTiernan/
-  end
+    it "should find the director" do
+      @movie.director.should be_an(Array)
+      @movie.director.size.should eql(1)
+      @movie.director.first.should =~ /John McTiernan/
+    end
   
-  it "should find the genres" do
-    genres = @movie.genres
+    it "should find the genres" do
+      genres = @movie.genres
     
-    genres.should be_an(Array)
-    genres.should include('Action')
-    genres.should include('Crime')
-    genres.should include('Drama')
-    genres.should include('Thriller')
-  end
-  
-  it "should find the length (in minutes)" do
-    @movie.length.should eql(131)
-  end
+      genres.should be_an(Array)
+      genres.should include('Action')
+      genres.should include('Crime')
+      genres.should include('Drama')
+      genres.should include('Thriller')
+    end
   
-  it "should find the plot" do
-    @movie.plot.should eql("New York cop John McClane gives terrorists a dose of their own medicine as they hold hostages in an LA office building.")
-  end
+    it "should find the length (in minutes)" do
+      @movie.length.should eql(131)
+    end
   
-  it "should find the poster" do
-    @movie.poster.should eql("http://ia.media-imdb.com/images/M/MV5BMTIxNTY3NjM0OV5BMl5BanBnXkFtZTcwNzg5MzY0MQ@@.jpg")
-  end
+    it "should find the plot" do
+      @movie.plot.should eql("New York cop John McClane gives terrorists a dose of their own medicine as they hold hostages in an LA office building.")
+    end
   
-  it "should find the rating" do
-    @movie.rating.should eql(8.3)
-  end
+    it "should find the poster" do
+      @movie.poster.should eql("http://ia.media-imdb.com/images/M/MV5BMTIxNTY3NjM0OV5BMl5BanBnXkFtZTcwNzg5MzY0MQ@@.jpg")
+    end
   
-  it "should find the title" do
-    @movie.title.should =~ /Die Hard/
-  end
+    it "should find the rating" do
+      @movie.rating.should eql(8.3)
+    end
   
-  it "should find the tagline" do
-    @movie.tagline.should =~ /It will blow you through the back wall of the theater/
-  end
+    it "should find the title" do
+      @movie.title.should =~ /Die Hard/
+    end
   
-  it "should find the year" do
-    @movie.year.should eql(1988)
-  end
+    it "should find the tagline" do
+      @movie.tagline.should =~ /It will blow you through the back wall of the theater/
+    end
   
-  describe "special scenarios" do
+    it "should find the year" do
+      @movie.year.should eql(1988)
+    end
     
-    it "should find multiple directors" do
-      # The Matrix Revolutions (2003)
-      movie = Imdb::Movie.new("0242653")
+    describe "special scenarios" do
+    
+      it "should find multiple directors" do
+        # The Matrix Revolutions (2003)
+        movie = Imdb::Movie.new("0242653")
       
-      movie.director.should be_an(Array)
-      movie.director.size.should eql(2)
-      movie.director.should include("Larry Wachowski")
-      movie.director.should include("Andy Wachowski")
+        movie.director.should be_an(Array)
+        movie.director.size.should eql(2)
+        movie.director.should include("Larry Wachowski")
+        movie.director.should include("Andy Wachowski")
+      end
     end
-  end
 
-  it "should provide a convenience method to search" do
-    movies = Imdb::Movie.search("Star Trek")
-    movies.should respond_to(:each)
-    movies.each { |movie| movie.should be_an_instance_of(Imdb::Movie) }
-  end
+    it "should provide a convenience method to search" do
+      movies = Imdb::Movie.search("Star Trek")
+      movies.should respond_to(:each)
+      movies.each { |movie| movie.should be_an_instance_of(Imdb::Movie) }
+    end
   
-  it "should provide a convenience method to top 250" do
-    movies = Imdb::Movie.top_250
-    movies.should respond_to(:each)
-    movies.each { |movie| movie.should be_an_instance_of(Imdb::Movie) }
+    it "should provide a convenience method to top 250" do
+      movies = Imdb::Movie.top_250
+      movies.should respond_to(:each)
+      movies.each { |movie| movie.should be_an_instance_of(Imdb::Movie) }
+    end
   end
   
+  describe "with no submitted poster" do
+    
+    before(:each) do 
+      # Grotesque (2009)
+      @movie = Imdb::Movie.new("1352369")
+    end
+    
+    it "should have a title" do
+      @movie.title(true).should =~ /Gurotesuku/
+    end
+    
+    it "should have a year" do 
+      @movie.year.should eql(2009)
+    end
+    
+    it "should return nil as poster url" do
+      @movie.poster.should be_nil
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@
 # run they will hit recorded responses.  However, if you don't have
 # the FakeWeb gem installed or you set the environment variable
 # LIVE_TEST then the tests will hit the live site IMDB.com.
-###
+#
 # Having both methods available for testing allows you to quickly
 # refactor and add features, while also being able to make sure that
 # no changes to the IMDB.com interface have affected the parser.
@@ -23,21 +23,25 @@ def read_fixture(path)
   File.read(File.expand_path(File.join(File.dirname(__FILE__), "fixtures", path)))
 end
 
+IMDB_SAMPLES = { 
+  "http://www.imdb.com:80/find?q=Matrix+Revolutions;s=tt" => "search_matrix_revolutions",
+  "http://www.imdb.com:80/find?q=Star+Trek;s=tt" => "search_star_trek",
+  "http://www.imdb.com:80/title/tt0117731/" => "tt0117731",
+  "http://www.imdb.com:80/title/tt0095016/" => "tt0095016",
+  "http://www.imdb.com:80/title/tt0242653/" => "tt0242653",
+  "http://www.imdb.com/title/tt0242653/?fr=c2M9MXxsbT01MDB8ZmI9dXx0dD0xfG14PTIwfGh0bWw9MXxjaD0xfGNvPTF8cG49MHxmdD0xfGt3PTF8cXM9TWF0cml4IFJldm9sdXRpb25zfHNpdGU9ZGZ8cT1NYXRyaXggUmV2b2x1dGlvbnN8bm09MQ__;fc=1;ft=20" => "tt0242653",
+  "http://www.imdb.com:80/chart/top" => "top_250",
+  "http://www.imdb.com/title/tt0111161/" => "tt0111161",
+  "http://www.imdb.com/title/tt1352369/" => "tt1352369"
+}
+
 unless ENV['LIVE_TEST']
   begin
     require 'rubygems'
     require 'fakeweb'
     
     FakeWeb.allow_net_connect = false
-    { "http://www.imdb.com:80/find?q=Matrix+Revolutions;s=tt" => "search_matrix_revolutions",
-      "http://www.imdb.com:80/find?q=Star+Trek;s=tt" => "search_star_trek",
-      "http://www.imdb.com:80/title/tt0117731/" => "tt0117731",
-      "http://www.imdb.com:80/title/tt0095016/" => "tt0095016",
-      "http://www.imdb.com:80/title/tt0242653/" => "tt0242653",
-      "http://www.imdb.com:80/title/tt0242653/?fr=c2M9MXxsbT01MDB8ZmI9dXx0dD0xfG14PTIwfHFzPU1hdHJpeCBSZXZvbHV0aW9uc3xodG1sPTF8c2l0ZT1kZnxxPU1hdHJpeCBSZXZvbHV0aW9uc3xwbj0w;fc=1;ft=20" => "tt0242653",
-      "http://www.imdb.com:80/chart/top" => "top_250",
-      "http://www.imdb.com/title/tt0111161/" => "tt0111161",
-    }.each do |url, response|
+    IMDB_SAMPLES.each do |url, response|
       FakeWeb.register_uri(:get, url, :response => read_fixture(response))
     end
   rescue LoadError

data/tasks/fixtures.rake

@@ -0,0 +1,15 @@
+namespace :fixtures do
+  desc "Refresh spec fixtures with fresh data from IMDB.com"
+  task :refresh do
+    require File.expand_path(File.dirname(__FILE__) + "/../spec/spec_helper")
+    
+    IMDB_SAMPLES.each_pair do |url, fixture|
+      page = `curl -is #{url}`
+      
+      File.open(File.expand_path(File.dirname(__FILE__) + "/../spec/fixtures/#{fixture}"), 'w') do |f|
+        f.write(page)
+      end
+      
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: imdb
 version: !ruby/object:Gem::Version 
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors: 
 - Ariejan de Vroom
@@ -9,9 +9,19 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-17 00:00:00 +02:00
-default_executable: 
+date: 2009-11-25 00:00:00 +01:00
+default_executable: imdb
 dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: rspec
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+    version: 
 - !ruby/object:Gem::Dependency 
   name: hpricot
   type: :runtime
@@ -23,42 +33,43 @@ dependencies:
         version: 0.8.1
     version: 
 - !ruby/object:Gem::Dependency 
-  name: newgem
+  name: fakeweb
   type: :development
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: 1.3.0
+        version: "0"
     version: 
 - !ruby/object:Gem::Dependency 
-  name: hoe
+  name: rspec
   type: :development
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: 1.8.0
+        version: "0"
     version: 
-description: This packages allows you to easy access publicly available data from IMDB.
-email: 
-- ariejan@ariejan.net
+description: Easily use Ruby or the command line to find information on IMDB.com.
+email: ariejan@ariejan.net
 executables: 
 - imdb
 extensions: []
 
 extra_rdoc_files: 
-- History.txt
-- Manifest.txt
 - README.rdoc
 files: 
+- .gitignore
 - History.txt
 - Manifest.txt
 - README.rdoc
 - Rakefile
+- VERSION
 - bin/imdb
+- config/website.yml
+- imdb.gemspec
 - lib/imdb.rb
 - lib/imdb/cli.rb
 - lib/imdb/movie.rb
@@ -76,19 +87,22 @@ files:
 - spec/fixtures/tt0111161
 - spec/fixtures/tt0117731
 - spec/fixtures/tt0242653
+- spec/fixtures/tt1352369
 - spec/imdb/cli_spec.rb
 - spec/imdb/movie_spec.rb
 - spec/imdb/search_spec.rb
 - spec/imdb/top_250_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
+- tasks/fixtures.rake
 - tasks/rspec.rake
 has_rdoc: true
-homepage: "The code, issue tracker and wiki can be found at:"
+homepage: http://github.com/ariejan/imdb
+licenses: []
+
 post_install_message: 
 rdoc_options: 
-- --main
-- README.rdoc
+- --charset=UTF-8
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
@@ -105,10 +119,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   version: 
 requirements: []
 
-rubyforge_project: imdb
-rubygems_version: 1.3.1
+rubyforge_project: 
+rubygems_version: 1.3.5
 signing_key: 
-specification_version: 2
-summary: This packages allows you to easy access publicly available data from IMDB.
-test_files: []
-
+specification_version: 3
+summary: Easily access the publicly available information on IMDB.
+test_files: 
+- spec/imdb/cli_spec.rb
+- spec/imdb/movie_spec.rb
+- spec/imdb/search_spec.rb
+- spec/imdb/top_250_spec.rb
+- spec/spec_helper.rb