imdb-terminal 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8d7d7e6701b93e4398983becfcd60d12bc964a71d1e5a50c8a28da010b627c2c
-  data.tar.gz: ce7d0a3926c832ee4f6880cb9cea077c7cdcb122507c84ca7302618ffcb0884c
+  metadata.gz: 8b26870720d0e55ae88bc797de5e902b24bca1deac0514c3c29058b90df31d08
+  data.tar.gz: 39c9433b18a602fa2f7b16493ae94841896da14493b24256852c1bd70253a403
 SHA512:
-  metadata.gz: 682c7dbf08de4a06677cdd5b04f91b1f4530fee204cba4a6d0505bde4b2025620f5b6a8bcda8d982843df29d25c536ac5d2b075647daebcbf304a928395afdfb
-  data.tar.gz: ab2ddcd5496e20fb133427833d2790d4ba492a20140e1cd8bff4848eb9bf607839b74f822ea1d8576136410d6ad2b96e9a78d04f2b9a12431a78fdc63c6799c9
+  metadata.gz: 92396d67a67433e37f25fa135577f012f1259c88e7cc859f868eec153705a35cd138fb57aeb26132927d82b502d3ebf40dab9ae0ee6999a6fb0e951b71a2ed0c
+  data.tar.gz: 556c17abd3c6e6b2b5aaebb6a5b1e179cb16374f82945ce2fa484185bebfb9eaf0a2329d892a9ed0cd3ee12987a22536e6dba767034a241feee07eda0d9af66f

data/bin/imdb

@@ -14,7 +14,7 @@
 #             for any damages resulting from its use. Further, I am under no
 #             obligation to maintain or extend this software. It is provided 
 #             on an 'as is' basis without any expressed or implied warranty.
-# Version:    2.1.0: Modern poster display using termpix gem
+# Version:    2.1.1: Add HTTP timeouts and external command error handling
 
 # REQUIRES AND CONSTANTS {{{1
 require 'io/console'
@@ -411,7 +411,8 @@ class IMDBApp
     uri = "https://www.imdb.com/#{path}/"
     
     begin
-      raw = `curl -sfL -H "User-Agent: #{ua}" "#{uri}"`
+      raw = `curl -sfL --max-time 15 --connect-timeout 10 -H "User-Agent: #{ua}" "#{uri}"`
+      return [] unless $?.success?
       html = raw.force_encoding('UTF-8').scrub('')
       doc = Nokogiri::HTML(html)
       
@@ -454,10 +455,19 @@ class IMDBApp
 
   def scrape_json_ld(path, ua) #{{{2
     uri = "https://www.imdb.com/#{path}/"
-    raw = `curl -sfL -H "User-Agent: #{ua}" "#{uri}"`
+    begin
+      raw = `curl -sfL --max-time 15 --connect-timeout 10 -H "User-Agent: #{ua}" "#{uri}"`
+      unless $?.success?
+        @progress.say("Warning: Failed to fetch #{path}") if defined?(@progress) && @progress
+        return []
+      end
+    rescue => e
+      @progress.say("Warning: curl error for #{path}: #{e.message}") if defined?(@progress) && @progress
+      return []
+    end
     html = raw.force_encoding('UTF-8').scrub('')
     doc = Nokogiri::HTML(html)
-    
+
     if (ld = doc.at_css('script[type="application/ld+json"]'))
       begin
         data = JSON.parse(ld.text)
@@ -475,7 +485,7 @@ class IMDBApp
         # fall back to HTML scrape
       end
     end
-    
+
     doc.css('.lister-list tr').map do |tr|
       rating = tr.at_css('td.ratingColumn strong')&.text.to_f || 0.0
       a      = tr.at_css('td.titleColumn a') or next
@@ -769,16 +779,27 @@ class IMDBApp
   def download_poster(tconst, cache) #{{{2
     url = fetch_imdb_poster_url(tconst)
     return unless url
-    
+
     dest = File.join(cache, "#{tconst}.jpg")
     return if File.exist?(dest) && File.size(dest) > 1000
-    
+
     cmd = [
-      'curl', '-sfL', '--max-time', '10', '--retry', '2', '--retry-delay', '1',
+      'curl', '-sfL', '--max-time', '10', '--connect-timeout', '10',
+      '--retry', '2', '--retry-delay', '1',
       '-H', 'User-Agent: Mozilla/5.0', '-o', dest, url
     ].map { |arg| Shellwords.escape(arg) }.join(' ')
-    
-    system(cmd, err: File::NULL)
+
+    begin
+      system(cmd, err: File::NULL)
+      # Remove incomplete downloads
+      if File.exist?(dest) && File.size(dest) < 100
+        File.delete(dest) rescue nil
+      end
+    rescue => e
+      File.open("/tmp/imdb_fetch_errors.log", "a") do |f|
+        f.puts "[#{Time.now.iso8601}] Poster download failed for #{tconst}: #{e.message}"
+      end
+    end
   end
 
   def fetch_imdb_poster_url(tconst) #{{{2
@@ -786,9 +807,13 @@ class IMDBApp
       html = URI.open(
         "https://www.imdb.com/title/#{tconst}/",
         "User-Agent"      => "Mozilla/5.0",
-        "Accept-Encoding" => "identity"
+        "Accept-Encoding" => "identity",
+        open_timeout:       10,
+        read_timeout:       10
       ).read
-    rescue SocketError, Errno::ECONNREFUSED, OpenURI::HTTPError, Net::HTTPBadResponse
+    rescue SocketError, Errno::ECONNREFUSED, OpenURI::HTTPError,
+           Net::HTTPBadResponse, Net::OpenTimeout, Net::ReadTimeout,
+           Timeout::Error, Errno::ETIMEDOUT
       return nil
     end
     html[/<meta property="og:image" content="([^"]+)"/,1]
@@ -1190,12 +1215,14 @@ class IMDBApp
     uri.query = URI.encode_www_form(q: query, s: 'tt')
     html = nil
     begin
-      Timeout.timeout(5) do
+      Timeout.timeout(15) do
         html = URI.open(uri.to_s,
                         'User-Agent'      => 'Mozilla/5.0',
                         'Accept'          => 'text/html,application/xhtml+xml',
                         'Accept-Language' => 'en-US,en;q=0.9',
-                        'Accept-Encoding' => 'identity'
+                        'Accept-Encoding' => 'identity',
+                        open_timeout:       10,
+                        read_timeout:       10
                       ).read
         # Fix encoding issues
         html = html.force_encoding('UTF-8').scrub('?')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: imdb-terminal
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Geir Isene
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-10-27 00:00:00.000000000 Z
+date: 2026-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rcurses
@@ -80,11 +80,12 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.0'
-description: 'IMDB v2.1.0: Modern poster display using termpix gem with Sixel and
+description: 'IMDB v2.1.1: Modern poster display using termpix gem with Sixel and
   w3m protocol support. Discover and manage movies and TV series from IMDb''s Top
   250 lists. Features smart search with preview mode, advanced filtering by rating/year/genre,
   streaming information via TMDb, wish lists, and terminal poster display. Enhanced
-  with jump-to-existing items, duplicate management, and robust data handling.'
+  with jump-to-existing items, duplicate management, robust data handling, and improved
+  HTTP timeout/error handling.'
 email: g@isene.com
 executables:
 - imdb