imdb-parser 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 864a142a24c3d4a7f66b4602372f023af7da6222
-  data.tar.gz: b7bdb4c6c32dd28fb354d52b11ea91ff0db85427
+  metadata.gz: 441dde337226bbb7a8fea631e575dfab6b68c17d
+  data.tar.gz: abdd01473df67f4c5c831cb4e7669b1b5f88c233
 SHA512:
-  metadata.gz: e69636a6a33391e03ff5af875c53964f4e093a3da0c747ffee36d8ab3a14ba4ae0e043d361065880f5ac5fc2ebba388a3b2f4ee7f26220d096c2207715f399fe
-  data.tar.gz: c44ff40e20eff3b4fa58f08ff89f40ccfdd3de1797f681d42946133717d96479b6d72cfe0fddf7c0ac60be1341f75021c314861d5866d306a2280a81fc194e70
+  metadata.gz: 174766a5872edf0f0ccb07f0836df379aa4a9c02a6aa97a9596acfa352b8c5667eac5908b73de5226fb506e082992019daccaec219671ac08c54323c8731beb6
+  data.tar.gz: e43f7eeeea73a61348a476019150aaecd330fbd478e4a88b48d29fbe7abf8f49e63dbcd773dfeba3431f70f758e0da83d9f9ce789c865a57c1841ed90c1094e5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    imdb-parser (0.0.1)
+    imdb-parser (0.1.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -30,7 +30,7 @@ Here is a simple example of how to use the library. Run `rspec` to see a list of
 ```ruby
 require 'imdb/parser'
 
-parser = IMDB::Parser::Parser.new(File.open("actors.list" ,'rb'))
+parser = IMDB::Parser::Parser.new(File.open("actors.list" ,'r:ISO-8859-1'))
 parser.each do |actor|
     puts actor.name
     puts "=" * actor.name.length
@@ -41,6 +41,10 @@ parser.each do |actor|
 end
 ```
 
+## File encoding
+
+The files provided by IMDB are encoded as `ISO-8859-1`. Make sure you open the files as such or you will get encoding errors.
+
 ## Contributing
 
 1. Fork it

data/lib/imdb/parser.rb

@@ -16,10 +16,10 @@ module IMDB
         else
           @input = StringIO.new(input.strip)
         end
+        strip_header
       end
 
       def each
-        strip_header
         record = ""
         input.each do |line|
           if line.strip.empty?

data/lib/imdb/parser/version.rb

@@ -1,5 +1,5 @@
 module IMDB
   module Parser
-    VERSION = "0.0.1"
+    VERSION = "0.1.0"
   end
 end

data/spec/parser_spec.rb

@@ -1,24 +1,31 @@
 require 'imdb/parser'
 
 
-describe IMDB::Parser::Parser, '#parse' do
+describe IMDB::Parser::Parser do
   let(:contents) { %{
     Name\t\t\tTitles
     ----\t\t\t------
+    Suvari, Mena\tAmerican Pie (1999)  [Heather]  <11>
+
     Trachtenberg, Michelle\tEuroTrip (2004)  [Jenny]  <6>
         "Buffy the Vampire Slayer" (1997) {After Life (#6.3)}  [Dawn Summers]  <4>
   }}
 
   it "parses actors" do
     parser = IMDB::Parser::Parser.new(contents)
-    expect(parser.actors.count).to eq(1)
+    expect(parser.actors.count).to eq(2)
+  end
+  it "can be resumed" do
+    parser = IMDB::Parser::Parser.new(contents)
+    parser.find { |a| a.name == "Suvari, Mena" }
+    expect(parser.to_enum.next.name).to eq("Trachtenberg, Michelle")
   end
   it "parses roles" do
     parser = IMDB::Parser::Parser.new(contents)
-    expect(parser.actors.first.roles.count).to eq(2)
+    expect(parser.actors.last.roles.count).to eq(2)
   end
   describe "knows role type" do
-    let(:roles) { IMDB::Parser::Parser.new(contents).actors.first.roles }
+    let(:roles) { IMDB::Parser::Parser.new(contents).actors.last.roles }
     it "parses movies" do
       expect(roles.first.type).to eq(:movie)
     end
@@ -29,7 +36,7 @@ describe IMDB::Parser::Parser, '#parse' do
   context "when passed an IO" do
     it "parses actors" do
       parser = IMDB::Parser::Parser.new(StringIO.new(contents.strip))
-      expect(parser.actors.count).to eq(1)
+      expect(parser.actors.count).to eq(2)
     end
   end
 

data/tools/next_edgecase.rb

@@ -1,13 +1,13 @@
 #! /usr/bin/env ruby
-require 'parser'
+require 'imdb/parser'
 
 # USAGE: ruby -I lib tools/next_edgecase.rb /path/to/actors.list
 
 begin
-  IMDB::Parser.new(File.open(ARGV[0], 'rb')).each do |a|
+  IMDB::Parser::Parser.new(File.open(ARGV[0], 'rb')).each do |a|
     a.roles
   end
-rescue IMDB::ParseError => e
+rescue IMDB::Parser::ParseError => e
   puts %{
 it "handles " do
   expect { parse "#{e}" }.not_to raise_error

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: imdb-parser
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Ben Olive
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-18 00:00:00.000000000 Z
+date: 2014-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler