imanip 0.1.3 → 0.1.4

data/History.txt

@@ -1,3 +1,9 @@
+== 0.1.4 2008-10-16
+
+* minor enhancements
+	* Added Image#ratio
+	* Crop resize is way better based on ratios
+
 == 0.1.2 2008-08-27
 
 * minor enhancements

data/lib/imanip/imanip_magick.rb

@@ -49,6 +49,10 @@ module Imanip
         end
       end
 
+      def ratio
+        width.to_f / height.to_f
+      end
+
       def crop(to_file, options = {})
         @options = options
         parse_size_options!
@@ -70,13 +74,8 @@ module Imanip
         crop_width = @geometry[:width]
         crop_height =  @geometry[:height]
         if !(crop_height.nil? || crop_width.nil?)
-          if width == height
-            if portrait?
-              crop_resize_string << "-resize #{to_geometry_string(:width => crop_width)}"
-            else
-              crop_resize_string << "-resize #{to_geometry_string(:height => crop_height)}"
-            end
-          elsif portrait?
+          crop_ratio = crop_width.to_f / crop_height.to_f
+          if crop_ratio > ratio
             crop_resize_string << "-resize #{to_geometry_string(:width => crop_width)}"
           else
             crop_resize_string << "-resize #{to_geometry_string(:height => crop_height)}"

data/lib/imanip/version.rb

@@ -2,7 +2,7 @@ module Imanip #:nodoc:
   module VERSION #:nodoc:
     MAJOR = 0
     MINOR = 1
-    TINY  = 3
+    TINY  = 4
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/test/test_imanip_magick.rb

@@ -47,6 +47,10 @@ class ImanipMagickTest < Test::Unit::TestCase
     assert !@portrait_image.landscape?
   end
   
+  def test_ratio_should_return_width_over_height
+    assert_equal(@landscape_image.width.to_f / @landscape_image.height.to_f, @landscape_image.ratio)
+  end
+  
   def test_resize_should_save_to_new_file
     assert !File.readable?(new_image_path)
     assert @portrait_image.resize(new_image_path, :width => 50)
@@ -73,6 +77,21 @@ class ImanipMagickTest < Test::Unit::TestCase
     assert @portrait_image.crop_resize(new_image_path, :dimensions => dimensions)
     @new_image = new_imanip_image(new_image_path)
     assert_equal dimensions, @new_image.dimensions
+    
+    dimensions = [200,153]
+    assert @landscape_image.crop_resize(new_image_path, :dimensions => dimensions)
+    @new_image = new_imanip_image(new_image_path)
+    assert_equal dimensions, @new_image.dimensions
+    
+    dimensions = [100,125]
+    assert @portrait_image.crop_resize(new_image_path, :dimensions => dimensions)
+    @new_image = new_imanip_image(new_image_path)
+    assert_equal dimensions, @new_image.dimensions
+    
+    dimensions = [100,125]
+    assert @landscape_image.crop_resize(new_image_path, :dimensions => dimensions)
+    @new_image = new_imanip_image(new_image_path)
+    assert_equal dimensions, @new_image.dimensions
   end
   
   def test_crop_resize_should_crop_and_resize_image_to_exact_dimensions_with_square_dimensions

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: imanip
 version: !ruby/object:Gem::Version 
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors: 
 - Aaron Quint
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-09-26 00:00:00 -04:00
+date: 2008-10-16 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency