image_voodoo 0.8.7 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 709c3a00ec625b53da4d6d207acaa3f90e65bf2e
-  data.tar.gz: 5aacbf95ce98e716d1835e3f247be935e35ab8b9
+SHA256:
+  metadata.gz: 5028b379cc34f48eb0851549a5f49a9ebd2495385d5fdbfe09d6b9fb0bdd006c
+  data.tar.gz: 873525e43dbfb68a86b664b19d19fa49d522e5312945f86d1939386d17369f94
 SHA512:
-  metadata.gz: 40c4daa327de23784c6b9c376057853049f5ac23a574a50a99e94cb12e5fdd2cbcc285e4578752fc00014425e900b289b6d0cdc154bca90ef9f9eb7fe748f4f3
-  data.tar.gz: 622bb1cdec6c00a93cf804a1abf12aa67da81e34d40fb179b819da7c6ef6a6f560d884f27337765175f5307341fb019a735a4bbe0e0c258ba56770d56831618b
+  metadata.gz: ee3af809b508d7cf1e4d880e155e487c19ce9579298d132b02d494edf2e63c681b0deed07b891b8d430f75fc6e3058c12fe7ad98fee47f704acdf4bc5abf8087
+  data.tar.gz: 50fd50f6ba4d34afc4b6585dfdeaeb2077a380ef1073522641253f89f7b2e5aa956174019e8275ee674a7cbad8287d22e42cd50fe2af5a576624bd0b577ce4e6

data/.gitignore

@@ -1,2 +1,6 @@
 /pkg
 *~
+Gemfile.lock
+lib/image_voodoo_jars.rb
+lib/com
+.idea

data/.rubocop.yml

@@ -0,0 +1,165 @@
+# Experiment to tweak source based on what rubocop wanted me to.  I basically
+# gave up and made the following exceptions.  Personally, I find the tool did
+# find many interesting/questionable code Qs in the project but it is soooo
+# opinionated in pretty unimportant ways (like who cares how I write my
+# comments, or why can't I use kind_of? or why give me a fail for a less
+# readable but more performant pattern).
+#
+# I can obviously tweak rules (like below) but I keep hearing of people pulling
+# their hair out over all the unimportant rules; I question why this project is
+# "all-in" on it's rules versus leaving most of the style rules as some preset
+# profiles people can opt in to.
+#
+# So I am committing this and I will try and run this every now and then to
+# see what it thinks about what I wrote but you will not see this as a
+# requirement for commits since I think by the time I configured it to my
+# liking I could have finished implementing this library.  Perhaps if I
+# continue using this here and there I will end up with a profile I find
+# acceptable?  I did find value but all the piddly shit just made me angry.
+# I will reflect on it some more...
+
+# This is a Java AWT call.  It is not what the tool thinks it is...which
+# might be an issue for users interacting with Java from JRuby.
+Lint/UselessSetterCall:
+  Exclude:
+    - 'lib/image_voodoo/awt.rb'
+
+# This is just impossible for them to call properly.  I am doing something
+# like rotate_impl and it is a bunch of reasonably simple math.  If you look
+# for this transformation in a text book it will look like this code.  Putting
+# a bunch of math within different methods would get the score down but
+# it would not help readability. (addendum: I did try and break it apart more
+# and never reached 15 but got closer.  I felt this rule is neat but the
+# score really depends on what it is.
+Metrics/AbcSize:
+  Max: 16.5
+
+# This is triggered for correct_orientation_impl.  I could put these transforms
+# in a table and then execute lambdas for each orientation but this is much
+# more clear.
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+# A bunch of fields in a hash are basically generated data. Correcting them
+# for column seems much too pedantic.  I guess exclude is the right thing for
+# an unusual file?
+Layout/LineLength:
+  Max: 132
+  Exclude:
+    - 'lib/image_voodoo/metadata.rb'
+
+# Metadata classes have data in them.  awt.rb is big and perhaps could be
+# shrunk but it is not a hard file to navigate and the cleaving points are
+# not super obvious.  These sorts of rules feel very arbitrary and if I have
+# n highly related things and they do not fit into a more restrictive
+# taxonomy why would the file being longer matter?  I do understand the
+# motivation here but as a default rule this feels wrong to me.
+Metrics/ClassLength:
+  Max: 250
+
+# I do not find this very useful.  There is no performance difference and
+# sometimes I want to highlight this string does not involve interpolation.
+# Other times it is not worth pointing out.
+Style/StringLiterals:
+  Enabled: false
+
+# require 'english' is a step too far for $! which is so baked into my
+# head I do not want to change :)
+Style/SpecialGlobalVars:
+  Enabled: false
+
+# I am grouping math and using lack of whitespace for separation.
+Layout/SpaceAroundOperators:
+  Enabled: false
+
+# I prefer tight assignment for opt args.
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: false
+
+# Java methods which override or implement Java method names cannot be switched
+# to snake case.  Do we really need this as a rule anyways?  I have never seen
+# a Rubyist do this as a preferred style?
+Naming/MethodName:
+  Enabled: false
+
+# bin/image_voodoo main options block.
+Metrics/BlockLength:
+  Exclude:
+    - 'bin/image_voodoo'
+
+# Hash rocket looks much more natural in a rakefile for its deps.
+Style/HashSyntax:
+  Exclude:
+    - 'Rakefile'
+
+# Forget it.  I do parallel assignment and you will have to peel it out of
+# my cold dead hands.
+Style/ParallelAssignment:
+  Enabled: false
+
+# FIXME: consider keywords for shapes.
+# I might switch these to keyword args if I ever revisit shapes support.
+# In general lots of params do suck and are hard to remember.  This library
+# still is supposed to work in 1.8 but I can probably soon major rev this
+# and switch over to keywords.
+Metrics/ParameterLists:
+  Exclude:
+    - 'lib/image_voodoo/awt/shapes.rb'
+
+# This is complaining that 'x' and 'y' are bad names because they are less
+# than 3 chars.  Silly rule even if I appreciate what it is trying to
+# accomplish. Interestingly, in image_voodoo I do use h for height and
+# w for width.  Those probably could be written out but they are so common
+# I am basically opting for short-hand.  This is something I rarely do except
+# domain-driven code like this (x,y,h,w).
+Naming/MethodParameterName:
+  Enabled: false
+
+# This represents one of those frustrating dogmatic rules where if I followed
+# this advice I would then violate the column length rule.  I specifically
+# use traditional if indented block in cases where if_mod doesn't fit.
+# Gramatically, if_mod can be across two lines but I hate how that looks. The
+# second solution of logical &&/|| change for a raise is alien to for all but
+# assignment.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# What the hell.  Really telling people that encoding: utf-8 should not happen
+# because there are no multi-byte utf-8 characters in it?  Why add this noise?
+Style/Encoding:
+  Enabled: false
+
+# FIXME:
+# This is an unknown error which I should figure out.  It must be some
+# StandardError (which is what nothing explicit means) but I should actually
+# be more explicit here.
+Style/RescueStandardError:
+  Exclude:
+    - 'lib/image_voodoo.rb'
+
+
+# This was complaining metadata_impl should use @metadata_impl instead of
+# @metadata.  I disagree and am unsure why I need to follow this programs
+# opinion on what a good name is?  What is commentable is if I change the
+# variable name to @gorgon it still tells me I need to use @metadata_impl.
+# So if I conditionally add any state in any method it will tell me I am
+# memoizing and have to use same ivar as the name of the method?  Is it more
+# sophisticated than that?  Should I have spent 2-3 minutes trying to figure
+# out how this rule was implemented? :)
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+
+# I have two modes of use for private.  If it is a small number of individual
+# methods I am explicit and inline the private.  If it is a large number of
+# methods especially when the name is fairly obvious that those will be private
+# (like render_impl) then I use block private.  Not sure telling me I can only
+# use a single style is very useful.
+Style/AccessModifierDeclarations:
+  Enabled: false
+
+# I feel for the tiny amount of generation here a better name would not help
+# me understand it better.  This is one of those naming rules I feel is
+# probably helpful a minority of the time.  Also I have never been confused
+# by what a heredoc text represents because of my heredoc terminator?
+Naming/HeredocDelimiterNaming:
+  Enabled: false

data/.travis.yml

@@ -0,0 +1,17 @@
+language: ruby
+
+sudo: false
+
+rvm:
+  - jruby-head
+
+before_install:
+  - mkdir rvm_tmp
+  - cd rvm_tmp
+
+before_script:
+  - cd ..
+  - git clone --depth 1 https://github.com/drewnoakes/metadata-extractor-images.git ../metadata-extractor-images
+
+install: JRUBY_OPTS=--dev jruby --dev -S bundle install --jobs=3 --retry=3
+

data/Gemfile

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
+
+gemspec

data/Jars.lock

@@ -0,0 +1,3 @@
+org.yaml:snakeyaml:1.23:compile:
+com.drewnoakes:metadata-extractor:2.11.0:compile:
+com.adobe.xmp:xmpcore:5.1.3:compile:

data/LICENSE-2.0.txt

@@ -0,0 +1,202 @@
+
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

data/README.exif

@@ -0,0 +1,18 @@
+Copyright 2002-2012 Drew Noakes
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+
+More information about this project is available at:
+
+   http://drewnoakes.com/code/exif/
+   http://code.google.com/p/metadata-extractor/

data/README.md

@@ -13,6 +13,7 @@ http://github.com/jruby/image_voodoo
 * Includes image_voodoo command-line utility for quick resizing of images, "image_voodoo --help" for usage.
 * Due to lack of TIFF support in ImageIO it is also not supported yet by image_voodoo. If you need it, create an issue in GitHub.
 * **JPEG CMYK support** is thanks to work of Werner Randelshofer and [Monte Media Library](http://www.randelshofer.ch/monte/). Monte Media Library is provided under [CC BY 3.0](http://creativecommons.org/licenses/by/3.0/) license.
+* Now supports reading a variety of EXIF data.  This also supports new function --orient based on how phones typically save photo data.
 
 ## SYNOPSIS:
 

data/Rakefile

@@ -1,2 +1,23 @@
+# frozen_string_literal: true
+
 require 'bundler'
+require 'rake/testtask'
+require 'jars/installer'
 Bundler::GemHelper.install_tasks
+Bundler.setup
+
+task :default => %i[vendor_jars test]
+
+desc 'Vendor Jars'
+task :vendor_jars do
+  test_file = File.expand_path File.join('lib', 'image_voodoo_jars.rb'), __dir__
+  Jars::Installer.vendor_jars! unless File.exist? test_file
+end
+
+desc 'Run tests'
+task :test => :vendor_jars do
+  Rake::TestTask.new do |t|
+    t.libs << 'lib:vendor'
+    t.test_files = FileList['test/test*.rb']
+  end
+end