image_vise 0.2.1 → 0.2.2

data/spec/image_vise/srgb_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe ImageVise::SRGB do
+  it 'applies the profile, creating a perceptible difference with the original' do
+    # This test will function only if you have RMagick with LCMS2 support
+    # built-in. If you do, the two images will look _very_ much like one
+    # another.
+    #
+    # If you don't, the images will look remarkably different
+    # (the AdobeRGB version has color values that match AdobeRGB
+    # primaries, and will render diffrently in pretty much any
+    # viewer).
+    image = Magick::Image.read(test_image_adobergb_path).first
+    subject.apply!(image)
+    image.strip!
+    examine_image(image, "from-adobergb-SHOULD-LOOK-IDENTICAL")
+
+    image = Magick::Image.read(test_image_path).first
+    subject.apply!(image)
+    image.strip!
+    examine_image(image, "from-srgb-SHOULD-LOOK-IDENTICAL")
+  end
+end

data/spec/image_vise/strip_metadata_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe ImageVise::StripMetadata do
+  it 'applies the strip! method to the image' do
+    image = Magick::Image.read(test_image_path).first
+    expect(image).to receive(:strip!).and_call_original
+    described_class.new.apply!(image)
+  end
+
+  it 'is registered with the operator registry' do
+    op = ImageVise.operator_from('strip_metadata')
+    expect(op).to eq(described_class)
+  end
+end

data/spec/image_vise/writers/auto_writer_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe ImageVise::AutoWriter do
+  it 'writes out a file with alpha as a PNG' do
+    sample_image = Magick::Image.read(test_image_png_transparency).first
+    tf = Tempfile.new 'outt'
+    subject.write_image!(sample_image, metadata=nil, tf.path)
+    
+    tf.rewind
+    expect(tf.size).not_to be_zero
+    fmt = MagicBytes.read_and_detect(tf)
+    expect(fmt.ext).to eq('png')
+  end
+  
+  it 'writes out a file without alpha as JPEG' do
+    sample_image = Magick::Image.read(test_image_path_tif).first
+    tf = Tempfile.new 'outt'
+    subject.write_image!(sample_image, metadata=nil, tf.path)
+    
+    tf.rewind
+    expect(tf.size).not_to be_zero
+    fmt = MagicBytes.read_and_detect(tf)
+    expect(fmt.ext).to eq('jpg')
+  end
+end

data/spec/image_vise/writers/jpeg_writer_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe ImageVise::JPGWriter do
+  it 'writes out a file with alpha as a JPEG regardless' do
+    sample_image = Magick::Image.read(test_image_png_transparency).first
+    tf = Tempfile.new 'outt'
+    
+    described_class.new(quality: 75).write_image!(sample_image, metadata=nil, tf.path)
+    
+    tf.rewind
+    expect(tf.size).not_to be_zero
+    fmt = MagicBytes.read_and_detect(tf)
+    expect(fmt.ext).to eq('jpg')
+  end
+  
+  it 'honors the JPEG compression quality setting, producing a smaller file with smaller quality' do
+    sample_image = Magick::Image.read(test_image_path_tif).first
+    
+    tf_hi = Tempfile.new 'hi'
+    tf_lo = Tempfile.new 'lo'
+    
+    described_class.new(quality: 50).write_image!(sample_image, metadata=nil, tf_hi.path)
+    described_class.new(quality: 10).write_image!(sample_image, metadata=nil, tf_lo.path)
+    
+    tf_hi.rewind
+    tf_lo.rewind
+    
+    expect(tf_hi.size).not_to be_zero
+    expect(tf_lo.size).not_to be_zero
+    expect(tf_lo.size).to be < tf_hi.size
+  end
+end

data/spec/image_vise_spec.rb

@@ -0,0 +1,110 @@
+require_relative 'spec_helper'
+require 'rack/test'
+
+describe ImageVise do
+  include Rack::Test::Methods
+  
+  def app
+    described_class.new
+  end
+  
+  context 'ImageVise.allowed_hosts' do
+    it 'returns the allowed hosts and is empty by default' do
+      expect(described_class.allowed_hosts).to be_empty
+    end
+    
+    it 'allows add_allowed_host! and reset_allowed_hosts!' do
+      described_class.add_allowed_host!('www.imageboard.im')
+      expect(described_class.allowed_hosts).to include('www.imageboard.im')
+      described_class.reset_allowed_hosts!
+      expect(described_class.allowed_hosts).not_to include('www.imageboard.im')
+    end
+  end
+  
+  context 'ImageVise.secret_keys' do
+    it 'raises when asked for a key and no keys has been set' do
+      expect {
+        described_class.secret_keys
+      }.to raise_error("No keys set, add a key using `ImageVise.add_secret_key!(key)'")
+    end
+    
+    it 'allows add_secret_key!(key) and reset_secret_keys!' do
+      described_class.add_secret_key!('l33t')
+      expect(described_class.secret_keys).to include('l33t')
+      described_class.reset_secret_keys!
+      expect {
+        expect(described_class.secret_keys)
+      }.to raise_error(/add a key using/)
+    end
+  end
+
+  describe 'ImageVise.new.call' do
+    it 'instantiates a new app and performs call() on it' do
+      expect_any_instance_of(ImageVise::RenderEngine).to receive(:call).with(:mock_env) { :yes }
+      ImageVise.new.call(:mock_env)
+    end
+  end
+
+  describe 'ImageVise.call' do
+    it 'instantiates a new app and performs call() on it' do
+      expect_any_instance_of(ImageVise::RenderEngine).to receive(:call).with(:mock_env) { :yes }
+      ImageVise.call(:mock_env)
+    end
+  end
+  
+  describe '.image_params' do
+    it 'generates a Hash with paremeters for processing the resized image' do
+      params = ImageVise.image_params(src_url: 'http://host.com/image.jpg', secret: 'l33t') do |pipe|
+        pipe.fit_crop width: 128, height: 256, gravity: 'c'
+      end
+      expect(params).to be_kind_of(Hash)
+      expect(params[:q]).not_to be_empty
+      expect(params[:sig]).not_to be_empty
+    end
+  end
+
+  describe 'methods dealing with fetchers' do
+    it 'returns the fetchers for the default schemes' do
+      http = ImageVise.fetcher_for('http')
+      expect(http).to respond_to(:fetch_uri_to_tempfile)
+      file = ImageVise.fetcher_for('file')
+      expect(http).to respond_to(:fetch_uri_to_tempfile)
+      
+      expect {
+        ImageVise.fetcher_for('undernet')
+      }.to raise_error(/No fetcher registered/)
+    end
+  end
+
+  describe '.image_path' do
+    it 'returns the path to the image within the application' do
+      path = ImageVise.image_path(src_url: 'file://tmp/img.jpg', secret: 'a') do |p|
+        p.ellipse_stencil
+      end
+      expect(path).to start_with('/')
+    end
+  end
+  
+  describe 'methods dealing with the operator list' do
+    it 'have the basic operators already set up' do
+      oplist = ImageVise.defined_operator_names
+      expect(oplist).to include('sharpen')
+      expect(oplist).to include('crop')
+    end
+    
+    it 'allows an operator to be added and retrieved' do
+      class CustomOp; end
+      ImageVise.add_operator 'custom_op', CustomOp
+      expect(ImageVise.operator_from(:custom_op)).to eq(CustomOp)
+      expect(ImageVise.operator_name_for(CustomOp.new)).to eq('custom_op')
+      expect(ImageVise.defined_operator_names).to include('custom_op')
+    end
+    
+    it 'raises an exception when an operator key is requested that does not exist' do
+      class UnknownOp; end
+      expect {
+        ImageVise.operator_name_for(UnknownOp.new)
+      }.to raise_error(/not registered using ImageVise/)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,112 @@
+require 'bundler'
+Bundler.require
+
+require 'tmpdir'
+require 'securerandom'
+
+require 'addressable/uri'
+require 'strenv'
+require_relative 'test_server'
+
+TEST_RENDERS_DIR = Dir.mktmpdir
+
+module Examine
+  def examine_image(magick_image, name_tag = 'test-img')
+    # When doing TDD, waiting for stuff to open is a drag - allow
+    # it to be squelched using 2 envvars. Also viewing images
+    # makes no sense on CI unless we bother with artifacts.
+    # The first one is what Gitlab-CI sets for us.
+    return if ENV.key?("CI_BUILD_ID")
+    return if ENV.key?("SKIP_INTERACTIVE")
+
+    Dir.mkdir(TEST_RENDERS_DIR) unless File.exist?(TEST_RENDERS_DIR)
+    path = File.join(TEST_RENDERS_DIR, name_tag + '.png')
+    magick_image.format = 'png'
+    magick_image.write(path)
+    `open #{path}`
+  end
+
+  def examine_image_from_string(string)
+    # When doing TDD, waiting for stuff to open is a drag - allow
+    # it to be squelched using 2 envvars. Also viewing images
+    # makes no sense on CI unless we bother with artifacts.
+    # The first one is what Gitlab-CI sets for us.
+    return if ENV.key?("CI_BUILD_ID")
+    return if ENV.key?("SKIP_INTERACTIVE")
+
+    Dir.mkdir(TEST_RENDERS_DIR) unless File.exist?(TEST_RENDERS_DIR)
+    random_name = 'test-image-%s' % SecureRandom.hex(3)
+    path = File.join(TEST_RENDERS_DIR, random_name)
+    File.open(path, 'wb'){|f| f << string }
+    `open #{path}`
+  end
+end
+
+require 'simplecov'
+SimpleCov.start do
+  add_filter "/spec/"
+end
+
+require_relative '../lib/image_vise'
+
+RSpec.configure do | config |
+  config.order = 'random'
+  config.include Examine
+  config.before :suite do
+    TestServer.start(nil, ssl=false, port=9001)
+  end
+
+  config.after :each do
+    ImageVise.reset_allowed_hosts!
+    ImageVise.reset_secret_keys!
+  end
+
+  config.after :suite do
+    sleep 2
+    FileUtils.rm_rf(TEST_RENDERS_DIR)
+  end
+
+  def test_image_path
+    File.expand_path(__dir__ + '/waterside_magic_hour.jpg')
+  end
+
+  def test_image_path_psd
+    File.expand_path(__dir__ + '/waterside_magic_hour.psd')
+  end
+
+  def test_image_path_tif
+    File.expand_path(__dir__ + '/waterside_magic_hour_gray.tif')
+  end
+
+  def test_image_adobergb_path
+    File.expand_path(__dir__ + '/waterside_magic_hour_adobergb.jpg')
+  end
+
+  def test_image_png_transparency
+    File.expand_path(__dir__ + '/waterside_magic_hour_transp.png')
+  end
+
+  def public_url
+    'http://localhost:9001/waterside_magic_hour.jpg'
+  end
+
+  def public_url_psd
+    'http://localhost:9001/waterside_magic_hour.psd'
+  end
+
+  def public_url_psd_multilayer
+    'http://localhost:9001/layers-with-blending.psd'
+  end
+
+  def public_url_tif
+    'http://localhost:9001/waterside_magic_hour_gray.tif'
+  end
+
+  def public_url_png_transparency
+    'http://localhost:9001/waterside_magic_hour_transp.png'
+  end
+
+  config.around :each do |e|
+    STRICT_ENV.with_protected_env { e.run }
+  end
+end

data/spec/test_server.rb

@@ -0,0 +1,61 @@
+require 'webrick'
+include WEBrick
+
+class ForbiddenServlet < HTTPServlet::AbstractServlet
+  def do_GET(req,res)
+    res['Content-Type'] = "text/plain"
+    res.status = 403
+  end
+end
+
+class TestServer
+  def self.start( log_file = nil, ssl = false, port = 9001 )
+    new(log_file, ssl, port).start
+  end
+
+  def initialize( log_file = nil, ssl = false, port = 9001 )
+    log_file ||= StringIO.new
+    log = WEBrick::Log.new(log_file)
+
+    options = {
+      :Port => port,
+      :Logger => log,
+      :AccessLog => [
+          [ log, WEBrick::AccessLog::COMMON_LOG_FORMAT ],
+          [ log, WEBrick::AccessLog::REFERER_LOG_FORMAT ]
+       ],
+       :DocumentRoot => File.expand_path(__dir__),
+    }
+
+    if ssl
+      options[:SSLEnable] = true
+      options[:SSLCertificate] = OpenSSL::X509::Certificate.new(File.open("spec/certs/cacert.pem").read)
+      options[:SSLPrivateKey] = OpenSSL::PKey::RSA.new(File.open("spec/certs/privkey.pem").read)
+      options[:SSLCertName] = [ ["CN", WEBrick::Utils::getservername ] ]
+    end
+
+    @server = WEBrick::HTTPServer.new(options)
+    @server.mount("/forbidden", ForbiddenServlet)
+  end
+
+  def start
+    trap('INT') {
+      begin
+        @server.shutdown unless @server.nil?
+      rescue Object => e
+        $stderr.puts "Error #{__FILE__}:#{__LINE__}\n#{e.message}"
+      end
+    }
+
+    @thread = Thread.new { @server.start }
+    Thread.pass
+    self
+  end
+
+  def join
+    if defined? @thread and @thread
+      @thread.join
+    end
+    self
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: image_vise
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Julik Tarkhanov
@@ -184,7 +184,68 @@ email:
 executables: []
 extensions: []
 extra_rdoc_files: []
-files: []
+files:
+- ".gitignore"
+- ".travis.yml"
+- DEVELOPMENT.md
+- Gemfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- SECURITY.md
+- examples/config.ru
+- examples/custom_image_operator.rb
+- examples/error_handline_appsignal.rb
+- examples/error_handling_sentry.rb
+- image_vise.gemspec
+- lib/image_vise.rb
+- lib/image_vise/fetchers/fetcher_file.rb
+- lib/image_vise/fetchers/fetcher_http.rb
+- lib/image_vise/file_response.rb
+- lib/image_vise/image_request.rb
+- lib/image_vise/operators/auto_orient.rb
+- lib/image_vise/operators/background_fill.rb
+- lib/image_vise/operators/crop.rb
+- lib/image_vise/operators/ellipse_stencil.rb
+- lib/image_vise/operators/fit_crop.rb
+- lib/image_vise/operators/force_jpg_out.rb
+- lib/image_vise/operators/geom.rb
+- lib/image_vise/operators/sRGB_v4_ICC_preference_displayclass.icc
+- lib/image_vise/operators/sharpen.rb
+- lib/image_vise/operators/srgb.rb
+- lib/image_vise/operators/strip_metadata.rb
+- lib/image_vise/pipeline.rb
+- lib/image_vise/render_engine.rb
+- lib/image_vise/version.rb
+- lib/image_vise/writers/auto_writer.rb
+- lib/image_vise/writers/jpeg_writer.rb
+- spec/image_vise/auto_orient_spec.rb
+- spec/image_vise/background_fill_spec.rb
+- spec/image_vise/crop_spec.rb
+- spec/image_vise/ellipse_stencil_spec.rb
+- spec/image_vise/fetcher_file_spec.rb
+- spec/image_vise/fetcher_http_spec.rb
+- spec/image_vise/file_response_spec.rb
+- spec/image_vise/fit_crop_spec.rb
+- spec/image_vise/force_jpg_out_spec.rb
+- spec/image_vise/geom_spec.rb
+- spec/image_vise/image_request_spec.rb
+- spec/image_vise/pipeline_spec.rb
+- spec/image_vise/render_engine_spec.rb
+- spec/image_vise/sharpen_spec.rb
+- spec/image_vise/srgb_spec.rb
+- spec/image_vise/strip_metadata_spec.rb
+- spec/image_vise/writers/auto_writer_spec.rb
+- spec/image_vise/writers/jpeg_writer_spec.rb
+- spec/image_vise_spec.rb
+- spec/layers-with-blending.psd
+- spec/spec_helper.rb
+- spec/test_server.rb
+- spec/waterside_magic_hour.jpg
+- spec/waterside_magic_hour.psd
+- spec/waterside_magic_hour_adobergb.jpg
+- spec/waterside_magic_hour_gray.tif
+- spec/waterside_magic_hour_transp.png
 homepage: https://github.com/WeTransfer/image_vise
 licenses:
 - MIT