image_optim 0.26.3 → 0.28.0

data/spec/image_optim/bin_resolver/comparable_condition_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/bin_resolver/comparable_condition'
 

data/spec/image_optim/bin_resolver/simple_version_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/bin_resolver/simple_version'
 

data/spec/image_optim/bin_resolver_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/bin_resolver'
 require 'image_optim/cmd'

data/spec/image_optim/cache_path_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/cache_path'
 require 'tempfile'
@@ -6,52 +8,95 @@ describe ImageOptim::CachePath do
   include CapabilityCheckHelpers
 
   before do
+    stub_const('Path', ImageOptim::Path)
     stub_const('CachePath', ImageOptim::CachePath)
   end
 
   describe '#replace' do
-    let(:src){ CachePath.temp_file_path }
-    let(:dst){ CachePath.temp_file_path }
+    let(:src_dir){ Path.temp_dir }
+    let(:src){ CachePath.temp_file_path(nil, src_dir) }
+    let(:dst){ Path.temp_file_path }
 
-    it 'moves data to destination' do
-      src.write('src')
+    shared_examples 'replaces file' do
+      it 'moves data to destination' do
+        src.write('src')
 
-      src.replace(dst)
+        src.replace(dst)
 
-      expect(dst.read).to eq('src')
-    end
+        expect(dst.read).to eq('src')
+      end
 
-    it 'does not remove original file' do
-      src.replace(dst)
+      it 'does not remove original file' do
+        src.replace(dst)
 
-      expect(src).to exist
-    end
+        expect(src).to exist
+      end
+
+      it 'preserves attributes of destination file' do
+        skip 'full file modes are not support' unless any_file_modes_allowed?
+        mode = 0o666
+
+        dst.chmod(mode)
+
+        src.replace(dst)
 
-    it 'preserves attributes of destination file' do
-      skip 'full file modes are not support' unless any_file_modes_allowed?
-      mode = 0o666
+        got = dst.stat.mode & 0o777
+        expect(got).to eq(mode), format('expected %04o, got %04o', mode, got)
+      end
 
-      dst.chmod(mode)
+      it 'does not preserve mtime of destination file' do
+        time = src.mtime
 
-      src.replace(dst)
+        dst.utime(time - 1000, time - 1000)
 
-      got = dst.stat.mode & 0o777
-      expect(got).to eq(mode), format('expected %04o, got %04o', mode, got)
+        src.replace(dst)
+
+        expect(dst.mtime).to be >= time
+      end
+
+      it 'changes inode of destination' do
+        skip 'inodes are not supported' unless inodes_supported?
+        expect{ src.replace(dst) }.to change{ dst.stat.ino }
+      end
+
+      it 'is using temporary file with .tmp extension' do
+        expect(src).to receive(:copy).with(having_attributes(:extname => '.tmp')).at_least(:once)
+
+        src.replace(dst)
+      end
     end
 
-    it 'does not preserve mtime of destination file' do
-      time = src.mtime
+    context 'when src and dst are on same device' do
+      before do
+        allow_any_instance_of(File::Stat).to receive(:dev).and_return(0)
+      end
 
-      dst.utime(time - 1000, time - 1000)
+      include_examples 'replaces file'
+    end
 
-      src.replace(dst)
+    context 'when src and dst are on different devices' do
+      before do
+        allow_any_instance_of(File::Stat).to receive(:dev, &:__id__)
+      end
 
-      expect(dst.mtime).to be >= time
+      include_examples 'replaces file'
     end
 
-    it 'changes inode of destination' do
-      skip 'inodes are not supported' unless inodes_supported?
-      expect{ src.replace(dst) }.to change{ dst.stat.ino }
+    context 'when src and dst are on same device, but rename causes Errno::EXDEV' do
+      before do
+        allow_any_instance_of(File::Stat).to receive(:dev).and_return(0)
+        allow(described_class).to receive(:temp_file_path).and_call_original
+        expect(described_class).to receive(:temp_file_path).
+          with([dst.basename.to_s, '.tmp'], src.dirname).
+          and_wrap_original do |m, *args, &block|
+            m.call(*args) do |tmp|
+              expect(tmp).to receive(:rename).with(dst.to_s).and_raise(Errno::EXDEV)
+              block.call(tmp)
+            end
+          end
+      end
+
+      include_examples 'replaces file'
     end
   end
 end

data/spec/image_optim/cache_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fspath'
 require 'image_optim/cache'
@@ -62,6 +64,7 @@ describe ImageOptim::Cache do
     end
   end
 
+  # rubocop:disable Style/RedundantFetchBlock
   shared_examples 'an enabled cache' do
     context 'when cached file does not exist' do
       describe :fetch do
@@ -99,7 +102,7 @@ describe ImageOptim::Cache do
           expect(FileUtils).not_to receive(:mv)
           expect(File).not_to receive(:rename)
 
-          expect(cache.fetch(original){}).to eq(cached)
+          expect(cache.fetch(original){ nil }).to eq(cached)
         end
 
         it 'returns nil when file is already optimized' do
@@ -114,6 +117,7 @@ describe ImageOptim::Cache do
       end
     end
   end
+  # rubocop:enable Style/RedundantFetchBlock
 
   context 'when cache is enabled (without worker digests)' do
     let(:image_optim) do

data/spec/image_optim/cmd_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/cmd'
 

data/spec/image_optim/config_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/config'
 

data/spec/image_optim/handler_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/handler'
 

data/spec/image_optim/hash_helpers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/hash_helpers'
 

data/spec/image_optim/image_meta_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'image_optim/image_meta'
 
 describe ImageOptim::ImageMeta do

data/spec/image_optim/optimized_path_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'image_optim/optimized_path'
 
 describe ImageOptim::OptimizedPath do

data/spec/image_optim/option_definition_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/option_definition'
 

data/spec/image_optim/option_helpers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/option_helpers'
 

data/spec/image_optim/path_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/path'
 require 'tempfile'
@@ -59,45 +61,84 @@ describe ImageOptim::Path do
     let(:src){ Path.temp_file_path }
     let(:dst){ Path.temp_file_path }
 
-    it 'moves data to destination' do
-      src.write('src')
+    shared_examples 'replaces file' do
+      it 'moves data to destination' do
+        src.write('src')
 
-      src.replace(dst)
+        src.replace(dst)
 
-      expect(dst.read).to eq('src')
-    end
+        expect(dst.read).to eq('src')
+      end
 
-    it 'removes original file' do
-      src.replace(dst)
+      it 'removes original file' do
+        src.replace(dst)
 
-      expect(src).to_not exist
-    end
+        expect(src).to_not exist
+      end
+
+      it 'preserves attributes of destination file' do
+        skip 'full file modes are not support' unless any_file_modes_allowed?
+        mode = 0o666
+
+        dst.chmod(mode)
+
+        src.replace(dst)
+
+        got = dst.stat.mode & 0o777
+        expect(got).to eq(mode), format('expected %04o, got %04o', mode, got)
+      end
+
+      it 'does not preserve mtime of destination file' do
+        time = src.mtime
+
+        dst.utime(time - 1000, time - 1000)
 
-    it 'preserves attributes of destination file' do
-      skip 'full file modes are not support' unless any_file_modes_allowed?
-      mode = 0o666
+        src.replace(dst)
 
-      dst.chmod(mode)
+        expect(dst.mtime).to be >= time
+      end
+
+      it 'changes inode of destination' do
+        skip 'inodes are not supported' unless inodes_supported?
+        expect{ src.replace(dst) }.to change{ dst.stat.ino }
+      end
+    end
 
-      src.replace(dst)
+    context 'when src and dst are on same device' do
+      before do
+        allow_any_instance_of(File::Stat).to receive(:dev).and_return(0)
+      end
 
-      got = dst.stat.mode & 0o777
-      expect(got).to eq(mode), format('expected %04o, got %04o', mode, got)
+      include_examples 'replaces file'
     end
 
-    it 'does not preserve mtime of destination file' do
-      time = src.mtime
+    context 'when src and dst are on different devices' do
+      before do
+        allow_any_instance_of(File::Stat).to receive(:dev, &:__id__)
+      end
 
-      dst.utime(time - 1000, time - 1000)
+      include_examples 'replaces file'
 
-      src.replace(dst)
+      it 'is using temporary file with .tmp extension' do
+        expect(src).to receive(:move).with(having_attributes(:extname => '.tmp'))
 
-      expect(dst.mtime).to be >= time
+        src.replace(dst)
+      end
     end
 
-    it 'changes inode of destination' do
-      skip 'inodes are not supported' unless inodes_supported?
-      expect{ src.replace(dst) }.to change{ dst.stat.ino }
+    context 'when src and dst are on same device, but rename causes Errno::EXDEV' do
+      before do
+        allow_any_instance_of(File::Stat).to receive(:dev).and_return(0)
+        expect(src).to receive(:rename).with(dst.to_s).once.and_raise(Errno::EXDEV)
+      end
+
+      include_examples 'replaces file'
+
+      it 'is using temporary file with .tmp extension' do
+        expect(src).to receive(:move).with(having_attributes(:extname => '.tmp'))
+
+        src.replace(dst)
+      end
     end
   end
 end

data/spec/image_optim/runner/glob_helpers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/runner/glob_helpers'
 

data/spec/image_optim/runner/option_parser_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/runner/option_parser'
 

data/spec/image_optim/space_spec.rb

@@ -1,20 +1,22 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/space'
 
 describe ImageOptim::Space do
   describe '.space' do
     {
-      0           => '      ',
-      1           => '    1B',
-      10          => '   10B',
-      100         => '  100B',
-      1_000       => ' 1000B',
-      10_000      => '  9.8K',
-      100_000     => ' 97.7K',
-      1_000_000   => '976.6K',
-      10_000_000  => '  9.5M',
-      100_000_000 => ' 95.4M',
-    }.each do |size, space|
+      '      ' => 0,
+      '    1B' => 1,
+      '   10B' => 10,
+      '  100B' => 100,
+      ' 1000B' => 1_000,
+      '  9.8K' => 10_000,
+      ' 97.7K' => 100_000,
+      '976.6K' => 1_000_000,
+      '  9.5M' => 10_000_000,
+      ' 95.4M' => 100_000_000,
+    }.each do |space, size|
       it "converts #{size} to #{space}" do
         expect(described_class.space(size)).to eq(space)
       end

data/spec/image_optim/worker/jpegrecompress_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'image_optim/worker/jpegrecompress'
+
+describe ImageOptim::Worker::Jpegrecompress do
+  describe 'method value' do
+    let(:subject){ described_class.new(ImageOptim.new, method).method }
+
+    context 'default' do
+      let(:method){ {} }
+
+      it{ is_expected.to eq('ssim') }
+    end
+
+    context 'uses default when invalid' do
+      let(:method){ {:method => 'invalid'} }
+
+      it 'warns and keeps default' do
+        expect_any_instance_of(described_class).
+          to receive(:warn).with('Unknown method for jpegrecompress: invalid')
+        is_expected.to eq('ssim')
+      end
+    end
+
+    context 'can use a valid option' do
+      let(:method){ {:method => 'smallfry'} }
+
+      it{ is_expected.to eq('smallfry') }
+    end
+  end
+end

data/spec/image_optim/worker/optipng_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/worker/optipng'
 require 'image_optim/path'

data/spec/image_optim/worker/pngquant_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/worker/pngquant'
 

data/spec/image_optim/worker_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'image_optim/worker'
 require 'image_optim/bin_resolver'