image_compare 1.0.5 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a4f15aaf75201eeea7e42796e91f00bb059b9bce5390b85d8f61d3596a94f1c4
-  data.tar.gz: 4cede23770aa3d38035403aeed400d0cafb764dbf78ac1215a44510537371891
+  metadata.gz: 83bfbc6343288b7b1c56f8b96df48e941b67aeb6c70f6628f08c11f0a224a48f
+  data.tar.gz: 2fa90cd2bba4c93988c1ca73cb55d29bf44e22d7375a5146f17c9a17597d8219
 SHA512:
-  metadata.gz: de19b90cf7387caea0f222c63f9dc132cf8a184f1578954853601bd440b9de0c75da094e1b3c1130eee1739a1cce318a394f0f2649fa16da1f7389461ba89212
-  data.tar.gz: 812d70bad6990ba71a2a58be872525349a452fa254ec5d75ad8f90558c9af97709681272547c815c79ae9e2fce790cdec102c3ada8bbd465789302b6eb6dd0a7
+  metadata.gz: ccdbc41fff4603801acb2ba62c7ee6e13b7b0dbed0e32509625958ac87dc5ab3dfa4e0cfb2aaf61226d52cfbcdd7cc324fb3c8a93a5e526512fa5cf64dc74a67
+  data.tar.gz: d0f1c158fe61387fb011ddd1da2265f6636c67799894fa9dec41927b1b6dbd51eb240042f8afaed435f254a49a36aac0112e971911f73e0135eae07330aa2fcd

data/CHANGELOG.md

@@ -7,6 +7,8 @@
 - v1.0.3: Fix documentation ([@gsguma][])
 - v1.0.4: Fix gem documentation images ([@gsguma][])
 - v1.0.5: Fix gem documentation ([@gsguma][])
+- v1.0.6: Fix the error when trying to add a rect exclude area that is partially outside the image bounds ([@gsguma][])
+- v1.0.7: Fix all code smells and integration tests ([@gsguma][], [@cristianofmc][])
 
 [@gsguma]: https://github.com/gsguma
 [@cristianofmc]: https://github.com/cristianofmc

data/README.md

@@ -1,4 +1,7 @@
 # ImageCompare
+[<img src="https://shields.io/github/license/instantink/image_compare?color=%2345a34c" />](LICENSE.txt)
+[<img src="https://shields.io/gem/v/image_compare" />](https://rubygems.org/gems/image_compare)
+<img alt="Gem total downloads" src="https://shields.io/gem/dt/image_compare" />
 
 Compare PNG images in pure Ruby (uses [ChunkyPNG](https://github.com/wvanbergen/chunky_png)) using different algorithms.
 This is an utility library for image regression testing.
@@ -30,7 +33,7 @@ ImageCompare supports different ways (_modes_) of comparing images.
 
 Source images used in examples:
 
-a1.png
+a.png
 
 <img alt="a.png" src="spec/fixtures/a.png" />
 

data/lib/image_compare/matcher.rb

@@ -34,12 +34,6 @@ module ImageCompare
 
       image_area = Rectangle.new(0, 0, a.width - 1, a.height - 1)
 
-      unless mode.exclude_rect.nil?
-        unless image_area.contains?(mode.exclude_rect)
-          raise ArgumentError, "Bounds must be in image"
-        end
-      end
-
       unless mode.include_rect.nil?
         unless image_area.contains?(mode.include_rect)
           raise ArgumentError, "Bounds must be in image"

data/lib/image_compare/modes/color.rb

@@ -16,14 +16,14 @@ module ImageCompare
         super(**options)
       end
 
-      def diff(bg, diff)
+      def diff(bg, _diff)
         diff_image = bg.highlight_rectangle(exclude_rect, :blue)
 
-        if area_in_exclude_rect?
-          diff_image
-        else
-          diff_image.highlight_rectangle(bounds)
+        unless result.match? || area_in_exclude_rect?
+          return diff_image.highlight_rectangle(bounds, :red)
         end
+
+        diff_image
       end
 
       def area_in_exclude_rect?

data/lib/image_compare/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ImageCompare
-  VERSION = "1.0.5"
+  VERSION = "1.0.7"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: image_compare
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.7
 platform: ruby
 authors:
 - cristianofmc
@@ -9,22 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-03-29 00:00:00.000000000 Z
+date: 2023-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chunky_png
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: 1.3.15
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: 1.3.15
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -91,7 +91,7 @@ licenses:
 metadata:
   bug_tracker_uri: https://github.com/instantink/image_compare/issues
   changelog_uri: https://github.com/instantink/image_compare/blob/master/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/image_compare/1.0.5
+  documentation_uri: https://www.rubydoc.info/gems/image_compare/1.0.7
   homepage_uri: https://github.com/instantink/image_compare
   source_code_uri: https://github.com/instantink/image_compare
 post_install_message: