im_onix 1.0.2 → 1.1.1

data/lib/onix/discount_coded.rb

@@ -1,20 +1,7 @@
 module ONIX
   class DiscountCoded < SubsetDSL
-    element "DiscountCodeType", :text
-    element "DiscountCodeTypeName", :text
-    element "DiscountCode", :text
-
-    # shortcuts
-    def code_type
-      @discount_code_type
-    end
-
-    def code_type_name
-      @discount_code_type_name
-    end
-
-    def code
-      @discount_code
-    end
+    element "DiscountCodeType", :text, :shortcut => :code_type
+    element "DiscountCodeTypeName", :text, :shortcut => :code_type_name
+    element "DiscountCode", :text, :shortcut => :code
   end
 end

data/lib/onix/entity.rb

@@ -5,6 +5,7 @@ require 'onix/website'
 module ONIX
   module EntityHelper
   end
+
   class Entity < SubsetDSL
     # entity name
     attr_accessor :name
@@ -37,16 +38,16 @@ module ONIX
       super
       n.children.each do |t|
         case t
-          when tag_match(self.class.name_tag)
-            @name=t.text
-          when tag_match(self.class.role_tag)
-            if self.class.role_class
-              @role=self.class.role_class.parse(t)
-            end
-          when tag_match(self.class.identifier_tag)
-            if self.class.identifier_class
-              @identifiers << self.class.identifier_class.parse(t)
-            end
+        when tag_match(self.class.name_tag)
+          @name = t.text
+        when tag_match(self.class.role_tag)
+          if self.class.role_class
+            @role = self.class.role_class.parse(t)
+          end
+        when tag_match(self.class.identifier_tag)
+          if self.class.identifier_class
+            @identifiers << self.class.identifier_class.parse(t)
+          end
         end
       end
     end
@@ -61,75 +62,40 @@ module ONIX
     def self.role_class
       nil
     end
-  end
-
-  class Agent < Entity
-    def self.prefix
-      "Agent"
-    end
 
-    def self.identifier_class
-      AgentIdentifier
+    def self.entity_setup prefix, identifier, role = nil
+      define_singleton_method :prefix do
+        return prefix
+      end
+      define_singleton_method :identifier_class do
+        return identifier
+      end
+      define_singleton_method :role_class do
+        return role
+      end
     end
+  end
 
-    def self.role_class
-      AgentRole
-    end
+  class Agent < Entity
+    entity_setup "Agent", AgentIdentifier, AgentRole
   end
 
   class Imprint < Entity
-    def self.prefix
-      "Imprint"
-    end
-
-    def self.identifier_class
-      ImprintIdentifier
-    end
-
-    def self.role_class
-      nil
-    end
+    entity_setup "Imprint", ImprintIdentifier
   end
 
   class Supplier < Entity
     elements "Website", :subset
-
-    def self.prefix
-      "Supplier"
-    end
-
-    def self.identifier_class
-      SupplierIdentifier
-    end
-
-    def self.role_class
-      SupplierRole
-    end
+    entity_setup "Supplier", SupplierIdentifier, SupplierRole
   end
 
   class Publisher < Entity
     elements "Website", :subset
+    entity_setup "Publisher", PublisherIdentifier, PublishingRole
 
-    def initialize
-      super
-      @websites = []
-    end
-
-    def self.prefix
-      "Publisher"
-    end
-
+    # @note role tag is not PublisherRole but PublishingRole
     def self.role_tag
       "PublishingRole"
     end
-
-    def self.identifier_class
-      PublisherIdentifier
-    end
-
-    def self.role_class
-      PublishingRole
-    end
   end
-
 end

data/lib/onix/epub_usage_constraint.rb

@@ -0,0 +1,7 @@
+module ONIX
+  class EpubUsageConstraint < SubsetDSL
+    element "EpubUsageType", :subset, :shortcut => :type
+    element "EpubUsageStatus", :subset, :shortcut => :status
+    elements "EpubUsageLimit", :subset, :shortcut => :limits
+  end
+end

data/lib/onix/epub_usage_limit.rb

@@ -0,0 +1,6 @@
+module ONIX
+  class EpubUsageLimit < SubsetDSL
+    element "EpubUsageUnit", :subset, :shortcut => :unit
+    element "Quantity", :integer
+  end
+end

data/lib/onix/extent.rb

@@ -0,0 +1,39 @@
+module ONIX
+  class Extent < SubsetDSL
+    element "ExtentType", :subset, :shortcut => :type
+    element "ExtentUnit", :subset, :shortcut => :unit
+    element "ExtentValue", :text, :shortcut => :value
+
+    scope :filesize, lambda { human_code_match(:extent_type, /Filesize/) }
+    scope :page, lambda { human_code_match(:extent_type, /Page/) }
+
+    # @!group High level
+
+    # bytes count
+    # @return [Integer]
+    def bytes
+      case @extent_unit.human
+      when "Bytes"
+        @extent_value.to_i
+      when "Kbytes"
+        (@extent_value.to_f * 1024).to_i
+      when "Mbytes"
+        (@extent_value.to_f * 1024 * 1024).to_i
+      else
+        nil
+      end
+    end
+
+    # pages count
+    # @return [Integer]
+    def pages
+      if @extent_unit.human == "Pages"
+        @extent_value.to_i
+      else
+        nil
+      end
+    end
+
+    # @!endgroup
+  end
+end

data/lib/onix/helper.rb

@@ -2,23 +2,23 @@ module ONIX
   class Helper
     # convert arbitrary arg to File/String
     def self.arg_to_data(arg)
-      data=""
+      data = ""
       case arg
-        when String
-          if File.file?(arg)
-            data=File.read(arg)
-          else
-            data=arg
-          end
-        when File, Tempfile
-          data=arg.read
+      when String
+        if File.file?(arg)
+          data = File.read(arg)
+        else
+          data = arg
+        end
+      when File, Tempfile
+        data = arg.read
       end
       data
     end
 
     # traverse each product as xml string
-    def self.each_xml_product(arg,  &block)
-      data=self.arg_to_data(arg)
+    def self.each_xml_product(arg, &block)
+      data = self.arg_to_data(arg)
       Nokogiri::XML::Reader(data).each do |node|
         if node.name == 'Product' and node.node_type == Nokogiri::XML::Reader::TYPE_ELEMENT
           yield(node.outer_xml)
@@ -29,11 +29,11 @@ module ONIX
     # traverse each product as xml string with added ONIXMessage
     def self.each_xml_product_as_full_message(arg, &block)
       self.each_xml_product(arg) do |p|
-        yield("<ONIXMessage>\n"+p+"\n</ONIXMessage>\n")
+        yield("<ONIXMessage>\n" + p + "\n</ONIXMessage>\n")
       end
     end
 
-    def self.text_at(n,xpath)
+    def self.text_at(n, xpath)
       if n.at_xpath(xpath)
         n.at_xpath(xpath).text.strip
       else
@@ -41,24 +41,24 @@ module ONIX
       end
     end
 
-    def self.mandatory_text_at(n,xpath)
-      self.text_at(n,xpath)
+    def self.mandatory_text_at(n, xpath)
+      self.text_at(n, xpath)
     end
 
     def self.strip_html(html)
-      html.gsub(/&nbsp;/," ").gsub(/<[^>]*(>+|\s*\z)/m, '')
+      html.gsub(/&nbsp;/, " ").gsub(/<[^>]*(>+|\s*\z)/m, '')
     end
 
-    def self.to_date(date_format,date_str_f)
+    def self.to_date(date_format, date_str_f)
       case date_format
-        when "00"
-          Date.strptime(date_str_f, "%Y%m%d")
-        when "01"
-          Date.strptime(date_str_f, "%Y%m")
-        when "14"
-          Time.strptime(date_str_f, "%Y%m%dT%H%M%S")
-        else
-          nil
+      when "00"
+        Date.strptime(date_str_f, "%Y%m%d")
+      when "01"
+        Date.strptime(date_str_f, "%Y%m")
+      when "14"
+        Time.strptime(date_str_f, "%Y%m%dT%H%M%S")
+      else
+        nil
       end
     end
 

data/lib/onix/identifier.rb

@@ -1,15 +1,7 @@
 module ONIX
   class Identifier < SubsetDSL
-    element "IDValue", :text
-    element "IDTypeName", :text
-
-    def value
-      @id_value
-    end
-
-    def name
-      @id_type_name
-    end
+    element "IDValue", :text, :shortcut => :value
+    element "IDTypeName", :text, :shortcut => :name
 
     def type
       nil
@@ -21,80 +13,47 @@ module ONIX
   end
 
   class SenderIdentifier < Identifier
-    element "SenderIDType", :subset
-    def type
-      @sender_id_type
-    end
+    element "SenderIDType", :subset, :shortcut => :type
   end
 
   class AddresseeIdentifier < Identifier
-    element "AddresseeIDType", :subset
-    def type
-      @addressee_id_type
-    end
+    element "AddresseeIDType", :subset, :shortcut => :type
   end
 
   class AgentIdentifier < Identifier
-    element "AgentIDType", :subset
-    def type
-      @agent_id_type
-    end
+    element "AgentIDType", :subset, :shortcut => :type
   end
 
   class ImprintIdentifier < Identifier
-    element "ImprintIDType", :subset
-    def type
-      @imprint_id_type
-    end
+    element "ImprintIDType", :subset, :shortcut => :type
   end
 
   class PublisherIdentifier < Identifier
-    element "PublisherIDType", :subset
-    def type
-      @publisher_id_type
-    end
+    element "PublisherIDType", :subset, :shortcut => :type
   end
 
   class SupplierIdentifier < Identifier
-    element "SupplierIDType", :subset
-    def type
-      @supplier_id_type
-    end
+    element "SupplierIDType", :subset, :shortcut => :type
   end
 
   class NameIdentifier < Identifier
-    element "NameIDType", :subset
-    def type
-      @name_id_type
-    end
+    element "NameIDType", :subset, :shortcut => :type
   end
 
   class CollectionIdentifier < Identifier
-    element "CollectionIDType", :subset
-    def type
-      @collection_id_type
-    end
+    element "CollectionIDType", :subset, :shortcut => :type
   end
 
   class ProductIdentifier < Identifier
-    element "ProductIDType", :subset
-    def type
-      @product_id_type
-    end
+    element "ProductIDType", :subset, :shortcut => :type
   end
 
   class SalesOutletIdentifier < Identifier
-    element "SalesOutletIDType", :subset
-    def type
-      @sales_outlet_id_type
-    end
+    element "SalesOutletIDType", :subset, :shortcut => :type
   end
 
   class WorkIdentifier < Identifier
-    element "WorkIDType", :subset
-    def type
-      @work_id_type
-    end
+    element "WorkIDType", :subset, :shortcut => :type
   end
 
   module EanMethods

data/lib/onix/language.rb

@@ -0,0 +1,8 @@
+module ONIX
+  class Language < SubsetDSL
+    element "LanguageRole", :subset, :shortcut => :role
+    element "LanguageCode", :subset, :shortcut => :code
+
+    scope :of_text, lambda { human_code_match(:language_role, "LanguageOfText") }
+  end
+end

data/lib/onix/market.rb

@@ -0,0 +1,5 @@
+module ONIX
+  class Market < SubsetDSL
+    element "Territory", :subset
+  end
+end

data/lib/onix/market_publishing_detail.rb

@@ -0,0 +1,20 @@
+module ONIX
+  class MarketPublishingDetail < SubsetDSL
+    elements "PublisherRepresentative", :subset, {:klass => "Agent"}
+    element "MarketPublishingStatus", :subset
+    elements "MarketDate", :subset
+
+    # @!group High level
+
+    # market availability date
+    # @return [Date]
+    def availability_date
+      av = @market_dates.availability.first
+      if av
+        av.date
+      end
+    end
+
+    # @!endgroup
+  end
+end

data/lib/onix/onix21.rb

@@ -2,13 +2,13 @@ module ONIX
   module ONIX21
     class ShortToRef
       def self.names
-        @shortnames||=YAML.load(File.open(File.dirname(__FILE__) + "/../../data/onix21/shortnames.yml"))
+        @shortnames ||= YAML.load(File.open(File.dirname(__FILE__) + "/../../data/onix21/shortnames.yml"))
       end
     end
 
     class RefToShort
       def self.names
-        @refnames||=ShortToRef.names.invert
+        @refnames ||= ShortToRef.names.invert
       end
     end
 
@@ -16,12 +16,13 @@ module ONIX
       def self.short_to_ref(name)
         ONIX::ONIX21::ShortToRef.names[name]
       end
+
       def self.ref_to_short(name)
         ONIX::ONIX21::RefToShort.names[name]
       end
 
       def self.get_class(name)
-        if ONIX::ONIX21.const_defined?(name,false)
+        if ONIX::ONIX21.const_defined?(name, false)
           ONIX::ONIX21.const_get(name)
         else
           ONIX.const_get(name)
@@ -33,11 +34,11 @@ module ONIX
 
     class CodeFromYaml < Code
       def self.hash
-        @hash||=YAML.load(File.open(File.dirname(__FILE__) + "/../../data/onix21/codelists/codelist-#{self.code_ident}.yml"))[:codelist]
+        @hash ||= YAML.load(File.open(File.dirname(__FILE__) + "/../../data/onix21/codelists/codelist-#{self.code_ident}.yml"))[:codelist]
       end
 
       def self.list
-        self.hash.to_a.map{|h| h.first}
+        self.hash.to_a.map { |h| h.first }
       end
 
       def self.code_ident
@@ -47,6 +48,7 @@ module ONIX
 
     class EpubType < CodeFromYaml
       private
+
       def self.code_ident
         10
       end
@@ -54,6 +56,7 @@ module ONIX
 
     class TextTypeCode < CodeFromYaml
       private
+
       def self.code_ident
         33
       end
@@ -61,6 +64,7 @@ module ONIX
 
     class MediaFileTypeCode < CodeFromYaml
       private
+
       def self.code_ident
         38
       end
@@ -68,6 +72,7 @@ module ONIX
 
     class MediaFileFormatCode < CodeFromYaml
       private
+
       def self.code_ident
         36
       end
@@ -75,6 +80,7 @@ module ONIX
 
     class MediaFileLinkTypeCode < CodeFromYaml
       private
+
       def self.code_ident
         37
       end
@@ -83,95 +89,60 @@ module ONIX
     # ONIX 2.1 subset
 
     class Title < SubsetDSL
-      element "TitleType", :subset
-      element "TitleText", :text
+      element "TitleType", :subset, :shortcut => :type
+      element "TitleText", :text, :shortcut => :title
       element "TitlePrefix", :text
       element "TitleWithoutPrefix", :text
       element "AbbreviatedLength", :integer
       element "Subtitle", :text
-
-      def type
-        @title_type
-      end
-
-      def title
-        @title_text
-      end
     end
 
     class OtherText < SubsetDSL
-      element "TextTypeCode", :subset
+      element "TextTypeCode", :subset, :shortcut => :type
       element "TextFormat", :text
       element "Text", :text
-
-      def type
-        @text_type_code
-      end
+      element "TextLinkType", :text
+      element "TextLink", :text
     end
 
     class MediaFile < SubsetDSL
-      element "MediaFileTypeCode", :subset
-      element "MediaFileFormatCode", :subset
-      element "MediaFileLinkTypeCode", :subset
-      element "MediaFileLink", :text
-
-      def type
-        @media_file_type_code
-      end
-
-      def format
-        @media_file_format_code
-      end
-
-      def link_type
-        @media_file_link_type_code
-      end
-
-      def link
-        @media_file_link
-      end
+      element "MediaFileTypeCode", :subset, :shortcut => :type
+      element "MediaFileFormatCode", :subset, :shortcut => :format
+      element "MediaFileLinkTypeCode", :subset, :shortcut => :link_type
+      element "MediaFileLink", :text, :shortcut => :link
     end
 
     class Territory
       attr_accessor :countries
 
       def initialize(countries)
-        @countries=countries
+        @countries = countries
       end
 
-      def +v
+      def + v
         Territory.new((@countries + v.countries).uniq)
       end
 
-      def -v
+      def - v
         Territory.new((@countries - v.countries).uniq)
       end
     end
 
     class Price < SubsetDSL
       element "PriceTypeCode", :subset, :klass => "PriceType"
-      element "PriceAmount", :float, {:parse_lambda => lambda { |v| (v*100).round }}
-      element "PriceQualifier", :subset
+      element "PriceAmount", :float, {
+          :shortcut => :amount,
+          :parse_lambda => lambda { |v| (v * 100).round }
+      }
+      element "PriceQualifier", :subset, :shortcut => :qualifier
       element "DiscountCoded", :subset
-      element "CurrencyCode", :text
+      element "CurrencyCode", :text, :shortcut => :currency
       elements "CountryCode", :text
       element "PriceEffectiveFrom", :text
       element "PriceEffectiveUntil", :text
 
-      def amount
-        @price_amount
-      end
-
-      def currency
-        @currency_code
-      end
-
-      def qualifier
-        @price_qualifier
-      end
-
       def including_tax?
-        if @price_type_code.human =~/IncludingTax/
+        if @price_type_code.human =~ /IncludingTax/
           true
         else
           false
@@ -180,13 +151,13 @@ module ONIX
 
       def from_date
         if @price_effective_from
-          Date.strptime(@price_effective_from,"%Y%m%d")
+          Date.strptime(@price_effective_from, "%Y%m%d")
         end
       end
 
       def until_date
         if @price_effective_until
-          Date.strptime(@price_effective_until,"%Y%m%d")
+          Date.strptime(@price_effective_until, "%Y%m%d")
         end
       end
 
@@ -199,12 +170,11 @@ module ONIX
       end
     end
 
-
     class Supplier
       attr_accessor :name
       attr_accessor :role
 
-      def initialize(name,role)
+      def initialize(name, role)
         @name = name
         @role = role
       end
@@ -225,19 +195,18 @@ module ONIX
 
       element "AvailabilityCode", :text
       element "ProductAvailability", :text
-      element "OnSaleDate", :text, {:parse_lambda => lambda { |v| Date.strptime(v, "%Y%m%d") }}
+      element "OnSaleDate", :text, {
+          :shortcut => :availability_date,
+          :parse_lambda => lambda { |v| Date.strptime(v, "%Y%m%d") }
+      }
       elements "Price", :subset
 
-      def availability_date
-        @on_sale_date
-      end
-
       def available?
-        @product_availability=="20" or @availability_code == "IP"
+        @product_availability == "20" or @availability_code == "IP"
       end
 
       def suppliers
-        [Supplier.new(self.supplier_name,self.supplier_role)]
+        [Supplier.new(self.supplier_name, self.supplier_role)]
       end
     end
 
@@ -246,7 +215,7 @@ module ONIX
       element "RightsCountry", :text
 
       def not_for_sale?
-        ["03","04","05","06"].include?(@sales_rights_type)
+        ["03", "04", "05", "06"].include?(@sales_rights_type)
       end
 
       def territory
@@ -266,56 +235,31 @@ module ONIX
       include EanMethods
       include ProprietaryIdMethods
 
-      element "RelationCode", :text
-      elements "ProductIdentifier", :subset
-
-      def product=v
-      end
-
-      def identifiers
-        @product_identifiers
-      end
+      element "RelationCode", :text, :shortcut => :code
+      elements "ProductIdentifier", :subset, :shortcut => :identifiers
 
-      def code
-        @relation_code
+      def product= v
       end
     end
 
     class MainSubject < SubsetDSL
-      element "SubjectCode", :text
-      element "SubjectHeadingText", :text
-      element "MainSubjectSchemeIdentifier", :subset, :klass=>"SubjectSchemeIdentifier"
-      element "SubjectSchemeName", :text
-      element "SubjectSchemeVersion", :text
-
-      # shortcuts
-      def code
-        @subject_code
-      end
-
-      def heading_text
-        @subject_heading_text
-      end
-
-      def scheme_identifier
-        @main_subject_scheme_identifier
-      end
-
-      def scheme_name
-        @subject_scheme_name
-      end
-
-      def scheme_version
-        @subject_scheme_version
-      end
+      element "SubjectCode", :text, :shortcut => :code
+      element "SubjectHeadingText", :text, :shortcut => :heading_text
+      element "MainSubjectSchemeIdentifier", :subset, {
+          :shortcut => :scheme_identifier,
+          :klass => "SubjectSchemeIdentifier"
+      }
+      element "SubjectSchemeName", :text, :shortcut => :scheme_name
+      element "SubjectSchemeVersion", :text, :shortcut => :scheme_version
     end
 
     class Product < SubsetDSL
       include EanMethods
+      include IsbnMethods
       include ProprietaryIdMethods
 
       element "RecordReference", :text
-      elements "ProductIdentifier", :subset
+      elements "ProductIdentifier", :subset, :shortcut => :identifiers
       element "NotificationType", :subset
       element "RecordSourceName", :text
       elements "Title", :subset
@@ -347,7 +291,7 @@ module ONIX
       element "PublishingStatus", :text
       element "PublicationDate", :text, {:parse_lambda => lambda { |v| Date.strptime(v, "%Y%m%d") }}
 
-      elements "RelatedProduct", :subset
+      elements "RelatedProduct", :subset, :shortcut => :related
 
       elements "SupplyDetail", :subset
 
@@ -360,45 +304,41 @@ module ONIX
       element "NoEdition", :ignore
       element "NoSeries", :ignore
 
-      # shortcuts
-      def identifiers
-        @product_identifiers
-      end
-
       # default LanguageCode from ONIXMessage
       attr_accessor :default_language_of_text
       # default code from ONIXMessage
       attr_accessor :default_currency_code
 
+      # @!group High level
+
       def title
         product_title.title
       end
 
-      # :category: High level
       # product subtitle string
       def subtitle
         product_title.subtitle
       end
 
       def product_title
-        @titles.select { |td| td.type.human=~/DistinctiveTitle/ }.first
+        @titles.select { |td| td.type.human =~ /DistinctiveTitle/ }.first
       end
 
       def bisac_categories_codes
-        cats=[]
+        cats = []
         if @basic_main_subject
           cats << @basic_main_subject
         end
-        cats+=(@main_subjects + @subjects).select { |s| s.scheme_identifier.human=="BisacSubjectHeading" }.map{|s| s.code}
+        cats += (@main_subjects + @subjects).select { |s| s.scheme_identifier.human == "BisacSubjectHeading" }.map { |s| s.code }
         cats
       end
 
       def clil_categories_codes
-        (@main_subjects + @subjects).select { |s| s.scheme_identifier.human=="Clil" }.map{|s| s.code}
+        (@main_subjects + @subjects).select { |s| s.scheme_identifier.human == "Clil" }.map { |s| s.code }
       end
 
       def keywords
-        kws=(@main_subjects + @subjects).select { |s| s.scheme_identifier.human=="Keywords" }.map { |kw| kw.heading_text }.compact
+        kws = (@main_subjects + @subjects).select { |s| s.scheme_identifier.human == "Keywords" }.map { |kw| kw.heading_text }.compact
         kws.map { |kw| kw.split(/;|,|\n/) }.flatten.map { |kw| kw.strip }
       end
 
@@ -409,10 +349,10 @@ module ONIX
 
       # product LanguageCode of text
       def language_of_text
-        lang=nil
-        l=@languages.select { |l| l.role.human=="LanguageOfText" }.first
+        lang = nil
+        l = @languages.select { |l| l.role.human == "LanguageOfText" }.first
         if l
-          lang=l.code
+          lang = l.code
         end
         lang || @default_language_of_text
       end
@@ -447,7 +387,7 @@ module ONIX
       end
 
       def description
-        desc_contents=@other_texts.select{|tc| tc.type.human=="MainDescription"} + @other_texts.select{|tc| tc.type.human=="LongDescription"} + @other_texts.select{|tc| tc.type.human=="ShortDescriptionannotation"}
+        desc_contents = @other_texts.select { |tc| tc.type.human == "MainDescription" } + @other_texts.select { |tc| tc.type.human == "LongDescription" } + @other_texts.select { |tc| tc.type.human == "ShortDescriptionannotation" }
         if desc_contents.length > 0
           desc_contents.first.text
         else
@@ -468,17 +408,17 @@ module ONIX
       end
 
       def countries
-        territory=Territory.new(CountryCode.list)
+        territory = Territory.new(CountryCode.list)
         @sales_rights.each do |sr|
           if sr.not_for_sale?
-            territory=territory-sr.territory
+            territory = territory - sr.territory
           else
-            territory=territory+sr.territory
+            territory = territory + sr.territory
           end
         end
 
         @not_for_sales.each do |sr|
-          territory=territory-sr.territory
+          territory = territory - sr.territory
         end
 
         territory.countries
@@ -502,10 +442,6 @@ module ONIX
 
       include ProductSuppliesExtractor
 
-      def related
-        @related_products
-      end
-
       # doesn't apply
       def parts
         []
@@ -517,7 +453,7 @@ module ONIX
       end
 
       def digital?
-        @product_form=="DG"
+        @product_form == "DG"
       end
 
       def available?
@@ -525,7 +461,7 @@ module ONIX
       end
 
       def available_for_country?(country)
-        self.supplies_for_country(country).select{|s| s[:available]}.length > 0 and self.available?
+        self.supplies_for_country(country).select { |s| s[:available] }.length > 0 and self.available?
       end
 
       def pages
@@ -543,7 +479,7 @@ module ONIX
       end
 
       def frontcover_url
-        fc=@media_files.select { |mf| mf.media_file_type_code.human=="ImageFrontCover" && mf.media_file_link_type_code.human=="Url"}
+        fc = @media_files.select { |mf| mf.media_file_type_code.human == "ImageFrontCover" && mf.media_file_link_type_code.human == "Url" }
         if fc.length > 0
           fc.first.link
         else
@@ -551,7 +487,7 @@ module ONIX
         end
       end
 
-      # TODO
+      # TODO
       def publisher_collection_title
         nil
       end
@@ -583,7 +519,7 @@ module ONIX
       end
 
       def print_product
-        @related_products.select { |rp| rp.code=="13" }.first
+        @related_products.select { |rp| rp.code == "13" }.first
       end
 
       # DEPRECATED see print_product instead
@@ -595,10 +531,11 @@ module ONIX
         nil
       end
 
+      # @!endgroup
+
       def method_missing(method)
         raise "WARN #{method} not found"
       end
-
     end
   end
 end