ilorb 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 62653f5b9895874fed33c3809ef3ee0ab36be009
-  data.tar.gz: cac900742ac25d1bfbff654e0aba7094d1419bb2
+  metadata.gz: ef13e4245bd8ab4b335dec77e001da8c498c5353
+  data.tar.gz: 285a8b272eba2ae35d1f76aca2a8e2b4082189df
 SHA512:
-  metadata.gz: d7cb339ba4da6be19d191aac561538b76324efd1cf205c8cd32b8a3724a12c91000cd2719b8ee47611a98d2ebd88a201c29fb9b58a4fe988e69f988f205e659f
-  data.tar.gz: 6801e037528efada5421ff2a088e7cd80749c4bf3db80974c6f803c16a93fc2dea9f1cc9bcdba288d555663f1019de2366c017fbde5fe1a48b1adaa7ca83dc36
+  metadata.gz: 04e755c6e729b2216288cab7250f028684ef2ab63a183a0110123cb2b0b9c54303338daeb67b4d8b49086b1d68769ed070d3aa40df59c591bd168b89f36307a2
+  data.tar.gz: 4d46b5905eca7e3ba167ccf776ae83152e828ddfa8b2a0a031c27db0f58b9a786c5e387966791d24836288cb1dd4483083f0fc82ef7754a3eb7789f2c1dc27d8

data/.rubocop.yml

@@ -0,0 +1,25 @@
+AllCops:
+  DisplayCopNames: true
+
+Lint/UnusedBlockArgument:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 120
+
+Metrics/MethodLength:
+  Max: 15
+  CountComments: false
+
+Metrics/ClassLength:
+  Max: 150
+  CountComments: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/StringLiteralsInInterpolation:
+  EnforcedStyle: double_quotes
+
+Style/TrailingComma:
+  EnforcedStyleForMultiline: consistent_comma

data/Gemfile

@@ -1,2 +1,2 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 gemspec

data/Gemfile.lock

@@ -9,6 +9,9 @@ GEM
   remote: https://rubygems.org/
   specs:
     addressable (2.3.5)
+    ast (2.0.0)
+    astrolabe (1.3.0)
+      parser (>= 2.2.0.pre.3, < 3.0)
     coderay (1.0.9)
     crack (0.4.1)
       safe_yaml (~> 0.9.0)
@@ -18,10 +21,14 @@ GEM
     nokogiri (1.6.6.2)
       mini_portile (~> 0.6.0)
     nori (2.5.0)
+    parser (2.2.2.2)
+      ast (>= 1.1, < 3.0)
+    powerpack (0.1.0)
     pry (0.9.12.2)
       coderay (~> 1.0.5)
       method_source (~> 0.8)
       slop (~> 3.4)
+    rainbow (2.0.0)
     rspec (2.14.1)
       rspec-core (~> 2.14.0)
       rspec-expectations (~> 2.14.0)
@@ -30,6 +37,13 @@ GEM
     rspec-expectations (2.14.0)
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.14.1)
+    rubocop (0.30.1)
+      astrolabe (~> 1.3)
+      parser (>= 2.2.2.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.4)
+    ruby-progressbar (1.7.5)
     safe_yaml (0.9.4)
     slop (3.4.5)
     webmock (1.13.0)
@@ -44,4 +58,5 @@ DEPENDENCIES
   ilorb!
   pry
   rspec (~> 2.14)
+  rubocop
   webmock (~> 1.13)

data/README.md

@@ -77,7 +77,6 @@ result:
 
 ## TODO
 
-  * Tests
   * Use a custom parser instead of Nori, to avoid one-element-hashes and cast responses to actual objects (e.g Y/N to true/false)
   * See for mandatory parameters
   * Add a CLI tool

data/Rakefile

@@ -1,6 +1,8 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require "rubocop/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new(:rubocop)
 
-task default: :spec
+task default: [:spec, :rubocop]

data/ilorb.gemspec

@@ -1,8 +1,8 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
-require 'ilorb/version'
+require "ilorb/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "ilorb"
@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/josqu4red/ilorb"
   spec.license       = "MIT"
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($RS)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
@@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 2.14"
   spec.add_development_dependency "webmock", "~> 1.13"
   spec.add_development_dependency "pry"
+  spec.add_development_dependency "rubocop"
   spec.add_dependency "nokogiri"
   spec.add_dependency "nori", "~> 2"
 end

data/lib/ilorb.rb

@@ -1,45 +1,45 @@
-require 'logger'
-require 'socket'
-require 'openssl'
-require 'net/https'
-require 'nokogiri'
-require 'nori'
-require 'ilorb/ribcl'
-
+require "logger"
+require "socket"
+require "openssl"
+require "net/https"
+require "nokogiri"
+require "nori"
+require "ilorb/ribcl"
+
+# Main library class
 class ILORb
-
   def initialize(config = {})
     @hostname = config[:hostname]
-    @login = config[:login] || "Administrator"
     @password = config[:password]
-    @port = config[:port] || 443
-    @protocol = config[:protocol] || :http
-    @verify_ssl = config[:verify_ssl] || false
-    @ribcl_path = "/ribcl"
+    @login = config.fetch(:login, "Administrator")
+    @port = config.fetch(:port, 443)
+    @protocol = config.fetch(:protocol, :http)
+    @verify_ssl = config.fetch(:verify_ssl, false)
+    @definitions_path = config.fetch(:definitions_path, File.join(File.dirname(__FILE__), "ilorb/definitions"))
+    @ribcl_path = config.fetch(:ribcl_path, "/ribcl")
 
     @log = Logger.new(STDOUT)
     @log.level = config[:debug] ? Logger::DEBUG : Logger::WARN
 
-    @nori = Nori.new(:convert_tags_to => lambda{|tag| tag.downcase.to_sym})
+    @nori = Nori.new(convert_tags_to: ->(tag) { tag.downcase.to_sym })
 
     setup_commands
   end
 
   # args should be empty or contain a hash anytime
   def method_missing(name, *args, &block)
-    if @ribcl.has_command?(name)
+    if @ribcl.command?(name)
       command = @ribcl.command(name)
 
-      raise RIBCL::NotImplementedError, "#{name} is not supported" unless command.supported?
+      fail RIBCL::NotImplementedError, "#{name} is not supported" unless command.supported?
       @log.info("Calling method #{name}")
 
       params = args.first || {}
       attributes = {}
-      element_map = nil
 
       command.get_attributes.each do |attr|
         # Attributes are mandatory
-        error("Attribute #{attr} missing in #{name} call") unless params.has_key?(attr)
+        fail "Attribute #{attr} missing in #{name} call" unless params.key?(attr)
         attributes.store(attr, @ribcl.encode(params.delete(attr)))
       end
 
@@ -47,26 +47,26 @@ class ILORb
         element_map = command.map_elements
 
         elements_array = [params].flatten.map do |params_hash|
-          Hash[params_hash.map{ |k,v| [ k, @ribcl.encode(params_hash.delete(k)) ] if element_map.has_key?(k) }.compact]
+          Hash[params_hash.map { |k, _| [k, @ribcl.encode(params_hash.delete(k))] if element_map.key?(k) }.compact]
         end
 
-        #TODO check for CDATA
+        # TODO: check for CDATA
 
         request = ribcl_request(command, attributes) do |xml|
           elements_array.each do |elements_hash|
             elements_hash.each do |key, value|
               elt = command.get_elements[element_map[key].first]
               if elt.is_a?(Array)
-                attrs = Hash[elt.map{|x| [x, elements_hash.delete(element_map.invert[[element_map[key].first, x]])]}]
+                attrs = Hash[elt.map { |x| [x, elements_hash.delete(element_map.invert[[element_map[key].first, x]])] }]
               else
-                attrs = {element_map[key].last => value}
+                attrs = { element_map[key].last => value }
               end
               xml.send(element_map[key].first, attrs)
             end
           end
         end
       elsif !command.get_text.nil?
-        if text = params[command.get_text]
+        if (text = params[command.get_text])
           request = ribcl_request(command, text, attributes)
         end
       else
@@ -74,33 +74,33 @@ class ILORb
       end
 
       response = send_request(request)
-      parse_response(response, name)
+      parse_response(response)
     else
       super
     end
   end
 
   def respond_to(name)
-    @ribcl.has_command?(name) ? true : super
+    @ribcl.command?(name) ? true : super
   end
 
   def supported_commands
-    @ribcl.select{|name, command| command.supported?}.keys
+    @ribcl.select { |_, command| command.supported? }.keys
   end
 
   private
 
-  def ribcl_request(command, *args, &block)
+  def ribcl_request(command, *args)
     builder = Nokogiri::XML::Builder.new do |xml|
-      xml.ribcl(:version => "2.0") {
-        xml.login(:password => @password, :user_login => @login) {
-          xml.send(command.context, :mode => command.mode) {
-            xml.send(command.name, *args) {
+      xml.ribcl(version: "2.0") do
+        xml.login(password: @password, user_login: @login) do
+          xml.send(command.context, mode: command.mode) do
+            xml.send(command.name, *args) do
               yield xml if block_given?
-            }
-          }
-        }
-      }
+            end
+          end
+        end
+      end
     end
 
     builder.to_xml
@@ -145,11 +145,11 @@ class ILORb
     ssl_sock.sync_close = true
 
     @log.info("Connecting to #{@hostname}:#{@port}")
-    ssl_sock.connect
     @log.debug("Request:\n#{xml}")
+    ssl_sock.connect
     ssl_sock.puts("#{xml}\r\n")
     response = ""
-    while line = ssl_sock.gets
+    while (line = ssl_sock.gets)
       response += line
     end
     ssl_sock.close
@@ -157,7 +157,7 @@ class ILORb
     response
   end
 
-  def parse_response(xml, command)
+  def parse_response(xml)
     @log.debug("Response:\n#{xml}")
 
     # ILO sends back multiple XML documents, split by XML header and remove first (empty)
@@ -166,17 +166,15 @@ class ILORb
     output = {}
 
     messages.each do |doc|
-      xml_doc = Nokogiri::XML(doc){|cfg| cfg.nonet.noblanks}
+      xml_doc = Nokogiri::XML(doc) { |cfg| cfg.nonet.noblanks }
 
       xml_doc.root.children.each do |node|
         case node.name
         when "RESPONSE"
           code = node.attr("STATUS").to_i(16)
           message = node.attr("MESSAGE")
-          if code == 0
-            output[:status] = { :code => code, :message => message }
-          else
-            output[:status] = { :code => code, :message => message }
+          output[:status] = { code: code, message: message }
+          if code != 0
             @log.error("#{message} (#{code})")
             break
           end
@@ -192,12 +190,7 @@ class ILORb
   end
 
   def setup_commands
-    @ribcl = ILORb::RIBCL.load(File.join(File.dirname(__FILE__), "ilorb/definitions", "*.rb"))
+    @ribcl = ILORb::RIBCL.load(File.join(@definitions_path, "*.rb"))
     nil
   end
-
-  def error(message)
-    @log.error(message)
-    raise message
-  end
 end

data/lib/ilorb/definitions/rib.rb

@@ -50,22 +50,27 @@ context :rib_info do
     attributes :device, :image_url
   end
   write_cmd :license do
-    elements :activate => :key
+    elements activate: :key
   end
   write_cmd :mod_global_settings do
-    elements :session_timeout, :f8_prompt_enabled, :http_port, :https_port, :remote_console_port, :min_password, :ilo_funct_enabled, :virtual_media_port, :f8_login_required, :enforce_aes, :authentication_failure_logging, :ssh_status, :ssh_port, :serial_cli_status, :serial_cli_speed, :rbsu_post_ip, :snmp_access_enabled, :snmp_port, :snmp_trap_port, :remote_syslog_enable, :remote_syslog_port, :remote_syslog_server_address, :alertmail_enable, :alertmail_email_address, :alertmail_sender_domain, :alertmail_smtp_server, :ipmi_dcmi_over_lan_enabled, :vsp_log_enable
+    elements :session_timeout, :f8_prompt_enabled, :http_port, :https_port, :remote_console_port, :min_password,
+             :ilo_funct_enabled, :virtual_media_port, :f8_login_required, :enforce_aes, :authentication_failure_logging,
+             :ssh_status, :ssh_port, :serial_cli_status, :serial_cli_speed, :rbsu_post_ip, :snmp_access_enabled,
+             :snmp_port, :snmp_trap_port, :remote_syslog_enable, :remote_syslog_port, :remote_syslog_server_address,
+             :alertmail_enable, :alertmail_email_address, :alertmail_sender_domain, :alertmail_smtp_server,
+             :ipmi_dcmi_over_lan_enabled, :vsp_log_enable
   end
   write_cmd :mod_network_settings do
     elements :enable_nic, :nic_speed, :full_duplex, :speed_autoselect, :ping_gateway,
              :shared_network_port, :vlan_enabled, :vlan_id,
-             :dhcp_enable, :dhcp_domain_name, :dhcp_gateway, :dhcp_dns_server, :dhcp_wins_server, :dhcp_static_route, :dhcp_sntp_settings,
-             :ip_address, :subnet_mask, :gateway_ip_address, :dns_name, :domain_name,
+             :dhcp_enable, :dhcp_domain_name, :dhcp_gateway, :dhcp_dns_server, :dhcp_wins_server, :dhcp_static_route,
+             :dhcp_sntp_settings, :ip_address, :subnet_mask, :gateway_ip_address, :dns_name, :domain_name,
              :prim_dns_server, :sec_dns_server, :ter_dns_server, :reg_ddns_server,
              :prim_wins_server, :sec_wins_server, :reg_wins_server,
              :sntp_server1, :sntp_server2, :timezone,
              :enclosure_ip_enable, :web_agent_ip_address
   end
-  write_cmd :mod_snmp_im_settings do #TODO
+  write_cmd :mod_snmp_im_settings do # TODO
     not_implemented
   end
   write_cmd :profile_apply do
@@ -92,7 +97,7 @@ context :rib_info do
   end
   write_cmd :set_security_msg do
     not_implemented
-    elements :security_msg, :security_msg_text => :cdata
+    elements :security_msg, security_msg_text: :cdata
   end
   write_cmd :set_vm_status do
     attributes :device
@@ -104,7 +109,7 @@ context :rib_info do
   write_cmd :trigger_test_event do
     not_implemented
   end
-  write_cmd :update_firmware do #TODO
+  write_cmd :update_firmware do # TODO
     not_implemented
   end
 end

data/lib/ilorb/definitions/server.rb

@@ -10,7 +10,7 @@ context :server_info do
 
   read_cmd :get_persistent_boot
   write_cmd :set_persistent_boot do
-    elements :device => [ :value ]
+    elements device: [:value]
   end
 
   read_cmd :get_one_time_boot
@@ -43,7 +43,7 @@ context :server_info do
 
   read_cmd :get_pwreg
   write_cmd :set_pwreg do
-    elements :pwralert => :type, :pwralert_settings => [:threshold, :duration]
+    elements pwralert: :type, pwralert_settings: [:threshold, :duration]
   end
 
   read_cmd :get_power_cap
@@ -92,4 +92,6 @@ context :server_info do
 
   read_cmd :get_server_power_on_time
   write_cmd :clear_server_power_on_time
+
+  write_cmd :clear_iml
 end

data/lib/ilorb/definitions/user.rb

@@ -14,7 +14,8 @@ context :user_info do
 
   write_cmd :mod_user do
     attributes :user_login
-    elements :user_name, :user_login, :password, :admin_priv, :remote_cons_priv, :reset_server_priv, :virtual_media_priv, :config_ilo_priv, :del_users_ssh_key
+    elements :user_name, :user_login, :password, :admin_priv, :remote_cons_priv, :reset_server_priv,
+             :virtual_media_priv, :config_ilo_priv, :del_users_ssh_key
   end
 
   read_cmd :get_all_users

data/lib/ilorb/ribcl.rb

@@ -1,6 +1,6 @@
 class ILORb
+  # ILO API methods DSL implementation
   class RIBCL < Hash
-
     class NotImplementedError < StandardError; end
     class InvalidDefinitionError < StandardError; end
 
@@ -9,7 +9,7 @@ class ILORb
     end
 
     # meaningful aliases
-    alias_method :has_command?, :has_key?
+    alias_method :command?, :key?
     alias_method :command, :fetch
 
     # mapping between Ruby objects and api format
@@ -31,7 +31,6 @@ class ILORb
     end
 
     private
-    # private methods are used by DSL
 
     def context(name, &block)
       context = Context.new(name)
@@ -39,6 +38,7 @@ class ILORb
       merge!(context.commands)
     end
 
+    # Implements contexts matching categories in ILO API (Server, RIB, User, etc.)
     class Context
       attr_reader :commands
 
@@ -47,9 +47,6 @@ class ILORb
         @commands = {}
       end
 
-      private
-      # private methods are used by DSL
-
       [:read, :write].each do |mode|
         define_method "#{mode}_cmd" do |name, &block|
           command = Command.new(name, @name, mode)
@@ -59,6 +56,7 @@ class ILORb
       end
     end
 
+    # Implements ILO API commands with their parameters
     class Command
       attr_reader :name, :context, :mode
 
@@ -97,7 +95,6 @@ class ILORb
       end
 
       private
-      # private methods are used by DSL
 
       def attributes(*params)
         @attributes += params
@@ -115,7 +112,7 @@ class ILORb
           end
           @elements.merge!(hash)
         else
-          raise InvalidDefinitionError, "no elements and text"
+          fail InvalidDefinitionError, "no elements and text"
         end
       end
 
@@ -123,7 +120,7 @@ class ILORb
         if @elements.empty?
           @text = param
         else
-          raise InvalidDefinitionError, "no text and elements"
+          fail InvalidDefinitionError, "no text and elements"
         end
       end
 

data/lib/ilorb/version.rb

@@ -1,3 +1,4 @@
+# just version
 class ILORb
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/assets/certificate.crt

@@ -0,0 +1,31 @@
+-----BEGIN CERTIFICATE-----
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+000000000000000000000000000000000000
+-----END CERTIFICATE-----

data/spec/assets/certificate_signing_request_request.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0"?>
+<ribcl version="2.0">
+  <login password="SECRET" user_login="Admin">
+    <rib_info mode="write">
+      <certificate_signing_request>
+        <csr_state value="state"/>
+        <csr_country value="country"/>
+        <csr_locality value="locality"/>
+        <csr_organization value="organization"/>
+        <csr_organizational_unit value="organizational_unit"/>
+        <csr_common_name value="common_name"/>
+      </certificate_signing_request>
+    </rib_info>
+  </login>
+</ribcl>

data/spec/assets/get_network_settings_request.xml

@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<ribcl version="2.0">
+  <login password="SECRET" user_login="Admin">
+    <rib_info mode="read">
+      <get_network_settings/>
+    </rib_info>
+  </login>
+</ribcl>

data/spec/assets/import_certificate_request.xml

@@ -0,0 +1,39 @@
+<?xml version="1.0"?>
+<ribcl version="2.0">
+  <login password="SECRET" user_login="Admin">
+    <rib_info mode="write">
+      <import_certificate>-----BEGIN CERTIFICATE-----
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+0000000000000000000000000000000000000000000000000000000000000000
+000000000000000000000000000000000000
+-----END CERTIFICATE-----
+</import_certificate>
+    </rib_info>
+  </login>
+</ribcl>

data/spec/assets/server_auto_pwr_request.xml

@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<ribcl version="2.0">
+  <login password="SECRET" user_login="Admin">
+    <server_info mode="write">
+      <server_auto_pwr value="On"/>
+    </server_info>
+  </login>
+</ribcl>

data/spec/assets/set_one_time_boot_request.xml

@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<ribcl version="2.0">
+  <login password="SECRET" user_login="Admin">
+    <server_info mode="write">
+      <set_one_time_boot value="FLOPPY"/>
+    </server_info>
+  </login>
+</ribcl>

data/spec/assets/set_persistent_boot_request.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0"?>
+<ribcl version="2.0">
+  <login password="SECRET" user_login="Admin">
+    <server_info mode="write">
+      <set_persistent_boot>
+        <device value="FLOPPY"/>
+        <device value="CDROM"/>
+      </set_persistent_boot>
+    </server_info>
+  </login>
+</ribcl>

data/spec/assets/set_pwreg_request.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0"?>
+<ribcl version="2.0">
+  <login password="SECRET" user_login="Admin">
+    <server_info mode="write">
+      <set_pwreg>
+        <pwralert type="PEAK"/>
+        <pwralert_settings threshold="200" duration="35"/>
+      </set_pwreg>
+    </server_info>
+  </login>
+</ribcl>

data/spec/definitions/test.rb

@@ -0,0 +1,33 @@
+context :rib_info do
+  read_cmd :get_network_settings
+
+  write_cmd :certificate_signing_request do
+    elements :csr_state, :csr_country, :csr_locality, :csr_organization, :csr_organizational_unit, :csr_common_name
+  end
+
+  write_cmd :import_certificate do
+    text :certificate
+  end
+
+  write_cmd :license do
+    elements activate: :key
+  end
+end
+
+context :server_info do
+  write_cmd :set_persistent_boot do
+    elements device: [:value]
+  end
+
+  write_cmd :set_one_time_boot do
+    attributes :value
+  end
+
+  write_cmd :set_pwreg do
+    elements pwralert: :type, pwralert_settings: [:threshold, :duration]
+  end
+
+  write_cmd :server_auto_pwr do
+    attributes :value
+  end
+end

data/spec/ilo_spec.rb

@@ -1,79 +1,113 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ILORb do
   let(:hostname) { "10.200.0.1" }
   let(:login) { "Admin" }
   let(:password) { "SECRET" }
-  let(:ilo) { ILORb.new(hostname: hostname, login: login, password: password) }
+  let(:definitions_path) { File.join(File.dirname(__FILE__), "definitions") }
+  let(:ilo) { ILORb.new(hostname: hostname, login: login, password: password, definitions_path: definitions_path) }
 
   describe "#get_network_settings" do
     before do
-      stub_request(:post, "https://10.200.0.1/ribcl").
-        with(:body => "<?xml version=\"1.0\"?>\n<ribcl version=\"2.0\">\n  <login password=\"SECRET\" user_login=\"Admin\">\n    <rib_info mode=\"read\">\n      <get_network_settings/>\n    </rib_info>\n  </login>\n</ribcl>\n").
-        to_return(:status => 200, :body => asset_file('get_network_settings_response.xml'))
+      stub_request(:post, "https://10.200.0.1/ribcl")
+        .with(body: asset_file("get_network_settings_request.xml"))
+        .to_return(status: 200, body: asset_file("get_network_settings_response.xml"))
     end
 
     subject { ilo.get_network_settings }
 
-    its([:status]) { should include(code: 0, message: 'No error') }
+    its([:status]) { should include(code: 0, message: "No error") }
     its([:get_network_settings]) { should_not be_empty }
   end
 
   describe "#set_one_time_boot" do
     before do
-      stub_request(:post, "https://10.200.0.1/ribcl").
-        with(:body => "<?xml version=\"1.0\"?>\n<ribcl version=\"2.0\">\n  <login password=\"SECRET\" user_login=\"Admin\">\n    <server_info mode=\"write\">\n      <set_one_time_boot value=\"FLOPPY\"/>\n    </server_info>\n  </login>\n</ribcl>\n").
-        to_return(:status => 200, :body => asset_file('basic_response.xml'))
+      stub_request(:post, "https://10.200.0.1/ribcl")
+        .with(body: asset_file("set_one_time_boot_request.xml"))
+        .to_return(status: 200, body: asset_file("basic_response.xml"))
     end
 
     subject { ilo.set_one_time_boot(value: "FLOPPY") }
 
-    its([:status]) { should include(code: 0, message: 'No error') }
+    its([:status]) { should include(code: 0, message: "No error") }
   end
 
   describe "#set_pwreg" do
     before do
-      stub_request(:post, "https://10.200.0.1/ribcl").
-        with(:body => "<?xml version=\"1.0\"?>\n<ribcl version=\"2.0\">\n  <login password=\"SECRET\" user_login=\"Admin\">\n    <server_info mode=\"write\">\n      <set_pwreg>\n        <pwralert type=\"PEAK\"/>\n        <pwralert_settings threshold=\"200\" duration=\"35\"/>\n      </set_pwreg>\n    </server_info>\n  </login>\n</ribcl>\n").
-        to_return(:status => 200, :body => asset_file('basic_response.xml'))
+      stub_request(:post, "https://10.200.0.1/ribcl")
+        .with(body: asset_file("set_pwreg_request.xml"))
+        .to_return(status: 200, body: asset_file("basic_response.xml"))
     end
 
-    subject { ilo.set_pwreg pwralert_type: "PEAK",
-                            pwralert_settings_threshold: 200,
-                            pwralert_settings_duration: 35 }
+    subject { ilo.set_pwreg(pwralert_type: "PEAK", pwralert_settings_threshold: 200, pwralert_settings_duration: 35) }
 
-    its([:status]) { should include(code: 0, message: 'No error') }
+    its([:status]) { should include(code: 0, message: "No error") }
   end
 
-  describe "#set_one_time_boot" do
+  describe "#set_persistent_boot" do
     before do
-      stub_request(:post, "https://10.200.0.1/ribcl").
-        with(:body => "<?xml version=\"1.0\"?>\n<ribcl version=\"2.0\">\n  <login password=\"SECRET\" user_login=\"Admin\">\n    <server_info mode=\"write\">\n      <set_one_time_boot value=\"FLOPPY\"/>\n    </server_info>\n  </login>\n</ribcl>\n").
-        to_return(:status => 200, :body => asset_file('basic_response.xml'))
+      stub_request(:post, "https://10.200.0.1/ribcl")
+        .with(body: asset_file("set_persistent_boot_request.xml"))
+        .to_return(status: 200, body: asset_file("basic_response.xml"))
     end
 
-    subject { ilo.set_one_time_boot(value: "FLOPPY") }
+    subject { ilo.set_persistent_boot([{ device_value: "FLOPPY" }, { device_value: "CDROM" }]) }
 
-    its([:status]) { should include(code: 0, message: 'No error') }
+    its([:status]) { should include(code: 0, message: "No error") }
   end
 
-  describe "#set_persistent_boot" do
+  describe "#certificate_signing_request" do
     before do
-      stub_request(:post, "https://10.200.0.1/ribcl").
-        with(:body => "<?xml version=\"1.0\"?>\n<ribcl version=\"2.0\">\n  <login password=\"SECRET\" user_login=\"Admin\">\n    <server_info mode=\"write\">\n      <set_persistent_boot>\n        <device value=\"FLOPPY\"/>\n        <device value=\"CDROM\"/>\n      </set_persistent_boot>\n    </server_info>\n  </login>\n</ribcl>\n").
-        to_return(:status => 200, :body => asset_file('basic_response.xml'))
+      stub_request(:post, "https://10.200.0.1/ribcl")
+        .with(body: asset_file("certificate_signing_request_request.xml"))
+        .to_return(status: 200, body: asset_file("basic_response.xml"))
+    end
+
+    subject do
+      ilo.certificate_signing_request(
+        csr_state: "state",
+        csr_country: "country",
+        csr_locality: "locality",
+        csr_organization: "organization",
+        csr_organizational_unit: "organizational_unit",
+        csr_common_name: "common_name"
+      )
     end
 
-    subject { ilo.set_persistent_boot([{ device_value: "FLOPPY" },
-                                       { device_value: "CDROM" }]) }
+    its([:status]) { should include(code: 0, message: "No error") }
+  end
+
+  describe "#import_certificate" do
+    before do
+      stub_request(:post, "https://10.200.0.1/ribcl")
+        .with(body: asset_file("import_certificate_request.xml"))
+        .to_return(status: 200, body: asset_file("basic_response.xml"))
+    end
+
+    subject do
+      ilo.import_certificate(certificate: asset_file("certificate.crt"))
+    end
+
+    its([:status]) { should include(code: 0, message: "No error") }
+  end
+
+  describe "#server_auto_pwr" do
+    before do
+      stub_request(:post, "https://10.200.0.1/ribcl")
+        .with(body: asset_file("server_auto_pwr_request.xml"))
+        .to_return(status: 200, body: asset_file("basic_response.xml"))
+    end
+
+    subject do
+      ilo.server_auto_pwr(value: "On")
+    end
 
-    its([:status]) { should include(code: 0, message: 'No error') }
+    its([:status]) { should include(code: 0, message: "No error") }
   end
 
   private
 
   def asset_file(asset)
-    path = File.join(File.dirname(__FILE__), 'assets', asset)
-    File.new(path)
+    File.open(File.join(File.dirname(__FILE__), "assets", asset)).read
   end
 end

data/spec/spec_helper.rb

@@ -1,8 +1,8 @@
-require 'rubygems'
-require 'bundler/setup'
-require 'ilorb'
-require 'webmock/rspec'
-require 'pry'
+require "rubygems"
+require "bundler/setup"
+require "ilorb"
+require "webmock/rspec"
+require "pry"
 
 RSpec.configure do |config|
   config.order = "random"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ilorb
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Jonathan Amiez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-05 00:00:00.000000000 Z
+date: 2016-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -102,6 +116,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".ruby-gemset"
 - Gemfile
 - Gemfile.lock
@@ -115,7 +130,16 @@ files:
 - lib/ilorb/ribcl.rb
 - lib/ilorb/version.rb
 - spec/assets/basic_response.xml
+- spec/assets/certificate.crt
+- spec/assets/certificate_signing_request_request.xml
+- spec/assets/get_network_settings_request.xml
 - spec/assets/get_network_settings_response.xml
+- spec/assets/import_certificate_request.xml
+- spec/assets/server_auto_pwr_request.xml
+- spec/assets/set_one_time_boot_request.xml
+- spec/assets/set_persistent_boot_request.xml
+- spec/assets/set_pwreg_request.xml
+- spec/definitions/test.rb
 - spec/ilo_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/josqu4red/ilorb
@@ -138,12 +162,21 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Configure and retrieve data from server's ILO management card
 test_files:
 - spec/assets/basic_response.xml
+- spec/assets/certificate.crt
+- spec/assets/certificate_signing_request_request.xml
+- spec/assets/get_network_settings_request.xml
 - spec/assets/get_network_settings_response.xml
+- spec/assets/import_certificate_request.xml
+- spec/assets/server_auto_pwr_request.xml
+- spec/assets/set_one_time_boot_request.xml
+- spec/assets/set_persistent_boot_request.xml
+- spec/assets/set_pwreg_request.xml
+- spec/definitions/test.rb
 - spec/ilo_spec.rb
 - spec/spec_helper.rb