iknow_view_models 3.9.1 → 3.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 847b6426a13f947b600789d37e80eb2987018117c916ea0f7a802871a13ca5be
-  data.tar.gz: 5d2547f725016af1965bc3ec18267c4ad79232f43d41e825e2a5ee035e84a7f3
+  metadata.gz: 85aa5f3dd882b989e6a4d1fa8d5d89be347f5f3c215af86851f1ef086d583472
+  data.tar.gz: d202810ca019d425b0de503b7a077d164d5919dc9206cf069e93b37ddf432334
 SHA512:
-  metadata.gz: 4e23bce06bde36efefec1d58a8a878562292e431a2d81d52e7e7307576a9ed715dfd46ef4600e4b04c49d965393ace84a7e7e9ca49f16b94d6313ceb26fc1816
-  data.tar.gz: 13450f34bab5d028f4993478b0fe40f49dc572eaf1b75aaef3e320a12236bb0097d674c7296b05325949c30dc6345981e48022007dbe596459b1689e8cb73745
+  metadata.gz: 3005ecb2044fd83003ccd444fb2b22d9787b74c929f157573baa084d4d3dff1b2f24d86e30f1ee9bd1e03604a4a0f9a57ec7431cadaea28faa45eda235dbcd28
+  data.tar.gz: 82971047b73442cbccaf9e3e80f1386dc373329b91f94260f2daeeb5794f99b3502cc47b911a62da38f7d0932b9fea49ae72319de9fb2d79f8be6035e0a34110

data/.github/workflows/test.yml

@@ -26,7 +26,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby-version: ['2.7', '3.0', '3.1', '3.2']
+        ruby-version: ['2.7', '3.0', '3.1', '3.2', '3.3']
         include:
           - ruby-version: '2.7'
             bundle-gemfile: gemfiles/rails_5_2.gemfile
@@ -36,6 +36,8 @@ jobs:
             bundle-gemfile: gemfiles/rails_6_1.gemfile
           - ruby-version: '3.2'
             bundle-gemfile: gemfiles/rails_7_0.gemfile
+          - ruby-version: '3.3'
+            bundle-gemfile: gemfiles/rails_7_1.gemfile
 
     env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
       BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.bundle-gemfile }}

data/gemfiles/rails_7_1.gemfile

@@ -0,0 +1,10 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem 'minitest-ci'
+gem "activerecord", "~> 7.1.0"
+gem "activesupport", "~> 7.1.0"
+gem "actionpack", "~> 7.1.0"
+
+gemspec path: '../'

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.9.1'
+  VERSION = '3.10.0'
 end

data/lib/view_model/active_record/controller.rb

@@ -3,6 +3,7 @@
 require 'view_model/active_record/controller_base'
 require 'view_model/active_record/collection_nested_controller'
 require 'view_model/active_record/singular_nested_controller'
+require 'view_model/controller/migration_versions'
 
 # Controller for accessing an ViewModel::ActiveRecord
 # Provides for the following routes:
@@ -16,8 +17,7 @@ module ViewModel::ActiveRecord::Controller
   include ViewModel::ActiveRecord::ControllerBase
   include ViewModel::ActiveRecord::CollectionNestedController
   include ViewModel::ActiveRecord::SingularNestedController
-
-  MIGRATION_VERSION_HEADER = 'X-ViewModel-Versions'
+  include ViewModel::Controller::MigrationVersions
 
   def show(scope: nil, viewmodel_class: self.viewmodel_class, serialize_context: new_serialize_context(viewmodel_class: viewmodel_class))
     view = nil
@@ -95,51 +95,6 @@ module ViewModel::ActiveRecord::Controller
     parse_param(:id)
   end
 
-  def migration_versions
-    @migration_versions ||=
-      begin
-        specified_migration_versions.reject do |viewmodel_class, required_version|
-          viewmodel_class.schema_version == required_version
-        end.freeze
-      end
-  end
-
-  def specified_migration_versions
-    @specified_migration_versions ||=
-      begin
-        version_spec =
-          if params.include?(:versions)
-            params[:versions]
-          elsif request.headers.include?(MIGRATION_VERSION_HEADER)
-            begin
-              JSON.parse(request.headers[MIGRATION_VERSION_HEADER])
-            rescue JSON::ParserError
-              raise ViewModel::Error.new(status: 400, detail: "Invalid JSON in #{MIGRATION_VERSION_HEADER}")
-            end
-          else
-            {}
-          end
-
-        versions =
-          IknowParams::Parser.parse_value(
-            version_spec,
-            with: IknowParams::Serializer::HashOf.new(
-              IknowParams::Serializer::String, IknowParams::Serializer::Integer))
-
-        migration_versions = {}
-
-        versions.each do |view_name, required_version|
-          viewmodel_class = ViewModel::Registry.for_view_name(view_name)
-          migration_versions[viewmodel_class] = required_version
-        rescue ViewModel::DeserializationError::UnknownView
-          # Ignore requests to migrate types that no longer exist
-          next
-        end
-
-        migration_versions.freeze
-      end
-  end
-
   def migrated_deep_schema_version
     ViewModel::Migrator.migrated_deep_schema_version(viewmodel_class, migration_versions, include_referenced: true)
   end

data/lib/view_model/after_transaction_runner.rb

@@ -4,6 +4,23 @@
 # `add_to_transaction`, the abstract method `after_transaction` will be invoked
 # by AR's callbacks.
 module ViewModel::AfterTransactionRunner
+  extend ActiveSupport::Concern
+
+  class_methods do
+    # Rails 7.1+ expects after transaction hooks to declare whether to run the
+    # hook on the first equivalent instance to be enqueued or the last one. For
+    # ActiveRecord models, this class method is defined on ActiveRecord::Core
+    # and delegates to Rails configuration. For us, we don't expect multiple
+    # equivalent AfterTransactionRunners for the same callback, and opting into
+    # the new behaviour would require implementing more of the ActiveRecord
+    # model interface here such as #destroyed?, so we'll lock in the older
+    # behavior that doesn't require so many inapplicable heuristics to identify
+    # the last valid callback.
+    def run_commit_callbacks_on_first_saved_instances_in_transaction
+      true
+    end
+  end
+
   # Rails' internal API
   def committed!(*)
     after_commit

data/lib/view_model/controller/migration_versions.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module ViewModel::Controller::MigrationVersions
+  extend ActiveSupport::Concern
+
+  MIGRATION_VERSION_HEADER = 'X-ViewModel-Versions'
+
+  def migration_versions
+    @migration_versions ||=
+      begin
+        specified_migration_versions.reject do |viewmodel_class, required_version|
+          viewmodel_class.schema_version == required_version
+        end.freeze
+      end
+  end
+
+  def specified_migration_versions
+    @specified_migration_versions ||=
+      begin
+        version_spec =
+          if params.include?(:versions)
+            params[:versions]
+          elsif request.headers.include?(MIGRATION_VERSION_HEADER)
+            begin
+              JSON.parse(request.headers[MIGRATION_VERSION_HEADER])
+            rescue JSON::ParserError
+              raise ViewModel::Error.new(status: 400, detail: "Invalid JSON in #{MIGRATION_VERSION_HEADER}")
+            end
+          else
+            {}
+          end
+
+        versions =
+          IknowParams::Parser.parse_value(
+            version_spec,
+            with: IknowParams::Serializer::HashOf.new(
+              IknowParams::Serializer::String, IknowParams::Serializer::Integer))
+
+        migration_versions = {}
+
+        versions.each do |view_name, required_version|
+          viewmodel_class = ViewModel::Registry.for_view_name(view_name)
+          migration_versions[viewmodel_class] = required_version
+        rescue ViewModel::DeserializationError::UnknownView
+          # Ignore requests to migrate types that no longer exist
+          next
+        end
+
+        migration_versions.freeze
+      end
+  end
+end

data/nix/dependencies.nix

@@ -1,5 +1,5 @@
 {pkgs}:
 {
-  ruby = pkgs.ruby_3_0;
-  postgresql = pkgs.postgresql_12;
+  ruby = pkgs.ruby_3_2;
+  postgresql = pkgs.postgresql_14;
 }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.9.1
+  version: 3.10.0
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-02-19 00:00:00.000000000 Z
+date: 2024-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -396,6 +396,7 @@ files:
 - gemfiles/rails_6_0.gemfile
 - gemfiles/rails_6_1.gemfile
 - gemfiles/rails_7_0.gemfile
+- gemfiles/rails_7_1.gemfile
 - iknow_view_models.gemspec
 - lib/iknow_view_models.rb
 - lib/iknow_view_models/railtie.rb
@@ -427,6 +428,7 @@ files:
 - lib/view_model/changes.rb
 - lib/view_model/config.rb
 - lib/view_model/controller.rb
+- lib/view_model/controller/migration_versions.rb
 - lib/view_model/deserialization_error.rb
 - lib/view_model/deserialize_context.rb
 - lib/view_model/error.rb