iknow_view_models 3.7.5 → 3.7.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93c994829498ed19d7214cca326ef7c361de788b5d88fb00e4927208aca9f21a
-  data.tar.gz: 75019085c70b0feed81316211922e3cb87b6dfee0485a3c6424070db028a68cd
+  metadata.gz: 849a8c0a38a21b8d8d8c706aae9800c2d5b009a81e59432d501cc0cef8329db3
+  data.tar.gz: b9cfa60ace9c9f6af4c711f7ae11fd8aa76934bcef7d6e7b360b749fe667d4b4
 SHA512:
-  metadata.gz: 90ac0ba33c195e22e1d3f51e9be84cdccb0fe5646d8f2ee93deba2eb5aff865a6a37dd1bf0f115a0c00fc6e33b64a086a5519b1acd90a107cede3d54c018f0c2
-  data.tar.gz: 949f86898a69d142dd5f1576054d18675785fcaae9d30c64344f1e3681f18aabae82c61cddd08a6ca3523796380cfb62e1ccb1ceee6d8d5c92753b59837c51a9
+  metadata.gz: 6e510f3a65791a27df5be2eabb889bd5a5addb84ee17f4e1b2f1ff7b76dfb1630978e3fc1b90bc1c26b36a83d9bb6892e9c3eb7e235b7f762946ab0c3b9b4ab4
+  data.tar.gz: 67f12f88ce24394ddcaa639008a66ea0120fa5e062463fed5c4d30e0f20a75e7dda7823f025304b3cf4d1cda9e5640cbe281f459aab22f84ed5a4d920eb7f9b6

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.7.5'
+  VERSION = '3.7.7'
 end

data/lib/view_model/active_record/controller.rb

@@ -97,6 +97,15 @@ module ViewModel::ActiveRecord::Controller
 
   def migration_versions
     @migration_versions ||=
+      begin
+        specified_migration_versions.reject do |viewmodel_class, required_version|
+          viewmodel_class.schema_version == required_version
+        end.freeze
+      end
+  end
+
+  def specified_migration_versions
+    @specified_migration_versions ||=
       begin
         version_spec =
           if params.include?(:versions)
@@ -121,10 +130,7 @@ module ViewModel::ActiveRecord::Controller
 
         versions.each do |view_name, required_version|
           viewmodel_class = ViewModel::Registry.for_view_name(view_name)
-
-          if viewmodel_class.schema_version != required_version
-            migration_versions[viewmodel_class] = required_version
-          end
+          migration_versions[viewmodel_class] = required_version
         rescue ViewModel::DeserializationError::UnknownView
           # Ignore requests to migrate types that no longer exist
           next

data/lib/view_model/active_record/update_operation.rb

@@ -81,15 +81,15 @@ class ViewModel::ActiveRecord
             viewmodel._list_attribute = reposition_to
           end
 
+          # Visit attributes and associations as much as possible in the order
+          # that they're declared in the view.
+          member_ordering = viewmodel.class._members.keys.each_with_index.to_h
+
           # update user-specified attributes
-          valid_members = viewmodel.class._members.keys.map(&:to_s).to_set
-          bad_keys = attributes.keys.reject { |k| valid_members.include?(k) }
-          if bad_keys.present?
-            causes = bad_keys.map { |k| ViewModel::DeserializationError::UnknownAttribute.new(k, blame_reference) }
-            raise ViewModel::DeserializationError::Collection.for_errors(causes)
-          end
+          attribute_keys = attributes.keys.sort_by { |k| member_ordering[k] }
+          attribute_keys.each do |attr_name|
+            serialized_value = attributes[attr_name]
 
-          attributes.each do |attr_name, serialized_value|
             # Note that the VM::AR deserialization tree asserts ownership over any
             # references it's provided, and so they're intentionally not passed on
             # to attribute deserialization for use by their `using:` viewmodels. A
@@ -101,7 +101,13 @@ class ViewModel::ActiveRecord
           end
 
           # Update points-to associations before save
-          points_to.each do |association_data, child_operation|
+          points_to_keys = points_to.keys.sort_by do |association_data|
+            member_ordering[association_data.association_name]
+          end
+
+          points_to_keys.each do |association_data|
+            child_operation = points_to[association_data]
+
             reflection = association_data.direct_reflection
             debug "-> #{debug_name}: Updating points-to association '#{reflection.name}'"
 
@@ -138,7 +144,12 @@ class ViewModel::ActiveRecord
 
           # Update association cache of pointed-from associations after save: the
           # child update will have saved the pointer.
-          pointed_to.each do |association_data, child_operation|
+          pointed_to_keys = pointed_to.keys.sort_by do |association_data|
+            member_ordering[association_data.association_name]
+          end
+
+          pointed_to_keys.each do |association_data|
+            child_operation = pointed_to[association_data]
             reflection = association_data.direct_reflection
 
             debug "-> #{debug_name}: Updating pointed-to association '#{reflection.name}'"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.7.5
+  version: 3.7.7
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-31 00:00:00.000000000 Z
+date: 2024-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack