iknow_view_models 3.7.4 → 3.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c4284905ecbec0ee35c1d61c687ed9bc12dd9030ea600f34584e97333a559141
-  data.tar.gz: 5270dfdfed945d140452555a32dbdd08ffdbc61dc26d0a6133eced8a3e261244
+  metadata.gz: f4e2ce83aca25f76c562927351a4c3061566428bd6d599f8d1efd3a0fe67b953
+  data.tar.gz: e6f11b57045e611fd9e3133f28fbfe7e9ee42c82edafdaa4a7be9a0c25311080
 SHA512:
-  metadata.gz: 63e53371c1511303ce3d425ccbb586148f116d110b524f3c9ab442936ce9b8456b07aeb269f1da3a5dc410549cb4f1f7a4d64c28e797bf6de8931eb9d2cdaee3
-  data.tar.gz: 21cc10407f402a6c371c516e08f35664655693518d4d0b78b9d84293a90f019b2b343c6c650b1331643135f8d4f634833deee6aec87cc31c45a461a0ae9fb979
+  metadata.gz: 628bebb67d57d5036640357c5cc9429ada7d84b5fd70d57d9aa1a35244bf1bd50f0d6851d56c7949ef46d54db6c066810f3e7206833419cee16b7b1e9ee1c030
+  data.tar.gz: 497c85d6648b089bb6cac073684cf070becf37b2505b977d13ce2115eaaa7eef68da985713304548241a69b88dba3d2729925ec87ef384792cf721fdcf73b4a7

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.7.4'
+  VERSION = '3.7.6'
 end

data/lib/view_model/active_record/update_operation.rb

@@ -81,15 +81,15 @@ class ViewModel::ActiveRecord
             viewmodel._list_attribute = reposition_to
           end
 
+          # Visit attributes and associations as much as possible in the order
+          # that they're declared in the view.
+          member_ordering = viewmodel.class._members.keys.each_with_index.to_h
+
           # update user-specified attributes
-          valid_members = viewmodel.class._members.keys.map(&:to_s).to_set
-          bad_keys = attributes.keys.reject { |k| valid_members.include?(k) }
-          if bad_keys.present?
-            causes = bad_keys.map { |k| ViewModel::DeserializationError::UnknownAttribute.new(k, blame_reference) }
-            raise ViewModel::DeserializationError::Collection.for_errors(causes)
-          end
+          attribute_keys = attributes.keys.sort_by { |k| member_ordering[k] }
+          attribute_keys.each do |attr_name|
+            serialized_value = attributes[attr_name]
 
-          attributes.each do |attr_name, serialized_value|
             # Note that the VM::AR deserialization tree asserts ownership over any
             # references it's provided, and so they're intentionally not passed on
             # to attribute deserialization for use by their `using:` viewmodels. A
@@ -101,7 +101,13 @@ class ViewModel::ActiveRecord
           end
 
           # Update points-to associations before save
-          points_to.each do |association_data, child_operation|
+          points_to_keys = points_to.keys.sort_by do |association_data|
+            member_ordering[association_data.association_name]
+          end
+
+          points_to_keys.each do |association_data|
+            child_operation = points_to[association_data]
+
             reflection = association_data.direct_reflection
             debug "-> #{debug_name}: Updating points-to association '#{reflection.name}'"
 
@@ -138,7 +144,12 @@ class ViewModel::ActiveRecord
 
           # Update association cache of pointed-from associations after save: the
           # child update will have saved the pointer.
-          pointed_to.each do |association_data, child_operation|
+          pointed_to_keys = pointed_to.keys.sort_by do |association_data|
+            member_ordering[association_data.association_name]
+          end
+
+          pointed_to_keys.each do |association_data|
+            child_operation = pointed_to[association_data]
             reflection = association_data.direct_reflection
 
             debug "-> #{debug_name}: Updating pointed-to association '#{reflection.name}'"

data/lib/view_model/error_view.rb

@@ -24,7 +24,7 @@ class ViewModel::ErrorView < ViewModel::Record
       json.context do
         next json.null! unless exception.respond_to?(:to_honeybadger_context)
 
-        json.merge! cause.to_honeybadger_context
+        json.merge! exception.to_honeybadger_context
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.7.4
+  version: 3.7.6
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-23 00:00:00.000000000 Z
+date: 2023-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack