iknow_view_models 3.7.2 → 3.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 887749dfc0bd40e748de9293d6fea68595d41e395a3ccfca73a655c627e51fb0
-  data.tar.gz: bb16fe56a4a81f5055912d38e07766185aa082f3f4b28344369f15f8cf8078dd
+  metadata.gz: c4284905ecbec0ee35c1d61c687ed9bc12dd9030ea600f34584e97333a559141
+  data.tar.gz: 5270dfdfed945d140452555a32dbdd08ffdbc61dc26d0a6133eced8a3e261244
 SHA512:
-  metadata.gz: a8174361c58a44ade71e1976ce72b1a642e11c98d2005e40ea7f7598dae4f4eebe9c8b9ada7ed4d3c883436970e7d82890cc6580335112d1dbfdd66b8ac05730
-  data.tar.gz: 428b12acca9472a0dab1a4795f0edb4ff36805577a3722c3202b5934933a87fa3917efdd1859a3a1618677d48e79bb2304423dbe74537d173bdfec7ec839be36
+  metadata.gz: 63e53371c1511303ce3d425ccbb586148f116d110b524f3c9ab442936ce9b8456b07aeb269f1da3a5dc410549cb4f1f7a4d64c28e797bf6de8931eb9d2cdaee3
+  data.tar.gz: 21cc10407f402a6c371c516e08f35664655693518d4d0b78b9d84293a90f019b2b343c6c650b1331643135f8d4f634833deee6aec87cc31c45a461a0ae9fb979

data/.github/workflows/gem-push.yml

@@ -0,0 +1,31 @@
+name: Publish Ruby Gem
+
+on:
+  push:
+    branches: [ "master" ]
+
+jobs:
+  build:
+    name: Build + Publish
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      packages: write
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby 2.7
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7
+
+    - name: Publish to RubyGems
+      run: |
+        mkdir -p $HOME/.gem
+        touch $HOME/.gem/credentials
+        chmod 0600 $HOME/.gem/credentials
+        printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+        gem build *.gemspec
+        gem push *.gem
+      env:
+        GEM_HOST_API_KEY: "${{secrets.RUBYGEMS_AUTH_TOKEN}}"

data/.github/workflows/test.yml

@@ -0,0 +1,65 @@
+name: Run Tests
+
+on:
+  pull_request:
+    branches: "**"
+
+permissions:
+  contents: read
+  checks: write
+  pull-requests: write
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    services:
+      postgres:
+        image: postgres:13-alpine
+        ports:
+          - "5432:5432"
+        env:
+          POSTGRES_DB: iknow_view_models
+          POSTGRES_USER: rails
+          POSTGRES_PASSWORD: password
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby-version: ['2.7', '3.0', '3.1', '3.2']
+        include:
+          - ruby-version: '2.7'
+            bundle-gemfile: gemfiles/rails_5_2.gemfile
+          - ruby-version: '3.0'
+            bundle-gemfile: gemfiles/rails_6_0.gemfile
+          - ruby-version: '3.1'
+            bundle-gemfile: gemfiles/rails_6_1.gemfile
+          - ruby-version: '3.2'
+            bundle-gemfile: gemfiles/rails_7_0.gemfile
+
+    env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
+      BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.bundle-gemfile }}
+      DATABASE_URL: "postgres://rails:password@localhost:5432/iknow_view_models"
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests
+      run: bundle exec rake test
+    - name: Upload result
+      uses: actions/upload-artifact@v3
+      if: always()
+      with:
+        path: test/reports/
+        name: test_results_${{ matrix.ruby-version }}
+    - name: Test Report
+      uses: dorny/test-reporter@v1
+      if: always()
+      with:
+        name: Minitest Tests - ${{ matrix.ruby-version }}
+        path: test/reports/*.xml
+        reporter: java-junit

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.7.2'
+  VERSION = '3.7.4'
 end

data/lib/view_model/active_record/update_context.rb

@@ -163,7 +163,7 @@ class ViewModel::ActiveRecord
 
       @release_pool.release_all!
 
-      if updated_viewmodels.present?
+      if updated_viewmodels.present? && deserialize_context.validate_deferred_constraints?
         # Deferred database constraints may have been violated by changes during
         # deserialization. VM::AR promises that any errors during deserialization
         # will be raised as a ViewModel::DeserializationError, so check constraints

data/lib/view_model/deserialize_context.rb

@@ -4,9 +4,21 @@ require 'view_model/traversal_context'
 
 class ViewModel::DeserializeContext < ViewModel::TraversalContext
   class SharedContext < ViewModel::TraversalContext::SharedContext
+    def initialize(validate_deferred_constraints: true, **rest)
+      super(**rest)
+      @validate_deferred_constraints = validate_deferred_constraints
+    end
+
+    # Should deferred database constraints be checked via SET CONSTRAINTS
+    # IMMEDIATE at the end of the deserialization operation
+    def validate_deferred_constraints?
+      @validate_deferred_constraints
+    end
   end
 
   def self.shared_context_class
     SharedContext
   end
+
+  delegate :validate_deferred_constraints?, to: :shared_context
 end

data/lib/view_model/error_view.rb

@@ -12,11 +12,19 @@ class ViewModel::ErrorView < ViewModel::Record
     def serialize_view(json, serialize_context: nil)
       json.set! :class, exception.class.name
       json.backtrace exception.backtrace
-      if (cause = exception.cause)
-        json.cause do
-          json.set! :class, cause.class.name
-          json.backtrace cause.backtrace
-        end
+
+      json.cause do
+        cause = exception.cause
+        next json.null! unless cause
+
+        json.set! :class, cause.class.name
+        json.backtrace cause.backtrace
+      end
+
+      json.context do
+        next json.null! unless exception.respond_to?(:to_honeybadger_context)
+
+        json.merge! cause.to_honeybadger_context
       end
     end
   end

data/test/helpers/arvm_test_models.rb

@@ -8,11 +8,18 @@ require 'view_model/active_record/controller'
 
 require 'acts_as_manual_list'
 
-db_config_path = File.join(File.dirname(__FILE__), '../config/database.yml')
-db_config = YAML.safe_load(File.open(db_config_path))
-raise 'Test database configuration missing' unless db_config['test']
+db_config =
+  if (url = ENV['DATABASE_URL'])
+    url
+  else
+    db_config_path = File.join(File.dirname(__FILE__), '../config/database.yml')
+    yaml = YAML.safe_load(File.open(db_config_path))
+    raise 'Test database configuration missing' unless yaml['test']
 
-ActiveRecord::Base.establish_connection(db_config['test'])
+    yaml['test']
+  end
+
+ActiveRecord::Base.establish_connection(db_config)
 
 # Remove test tables if any exist
 %w[labels parents children targets poly_ones poly_twos owners

data/test/unit/view_model/active_record_test.rb

@@ -556,5 +556,21 @@ class ViewModel::ActiveRecordTest < ActiveSupport::TestCase
 
       assert_equal({ constraint: constraint, columns: columns, values: values, conflicts: conflicts, nodes: [] }, ex.meta)
     end
+
+    def test_disabled_deferred_check
+      l1 = List.create!(value: 1)
+      l2 = List.create!
+
+      ctx = ListView.new_deserialize_context(validate_deferred_constraints: false)
+      alter_by_view!(ListView, l2, deserialize_context: ctx) do |view, refs|
+        view['value'] = 1
+      end
+
+      ex = assert_raises(::ActiveRecord::StatementInvalid) do
+        List.connection.execute('SET CONSTRAINTS ALL IMMEDIATE')
+      end
+
+      assert_equal(PG::ExclusionViolation, ex.cause.class)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.7.2
+  version: 3.7.4
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-01-23 00:00:00.000000000 Z
+date: 2023-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -381,8 +381,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".circleci/config.yml"
 - ".envrc"
+- ".github/workflows/gem-push.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".idea/codeStyleSettings.xml"
 - ".rubocop.yml"
@@ -509,7 +510,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: ViewModels provide a means of encapsulating a collection of related data

data/.circleci/config.yml

@@ -1,134 +0,0 @@
-version: 2.1
-
-executors:
-  ruby-pg:
-    parameters:
-      ruby-version:
-        type: string
-        default: "2.7"
-      pg-version:
-        type: string
-        default: "12.10"
-      gemfile:
-        type: string
-        default: "Gemfile"
-    environment:
-      PGHOST: 127.0.0.1
-      PGUSER: eikaiwa
-    docker:
-      - image: cimg/ruby:<< parameters.ruby-version >>
-        environment:
-          BUNDLE_JOBS: 3
-          BUNDLE_RETRY: 3
-          BUNDLE_PATH: vendor/bundle
-          RAILS_ENV: test
-          BUNDLE_GEMFILE: << parameters.gemfile >>
-      - image: cimg/postgres:<< parameters.pg-version >>
-        environment:
-          POSTGRES_USER: eikaiwa
-          POSTGRES_DB: iknow_view_models
-          POSTGRES_PASSWORD: ""
-
-jobs:
-  test:
-    parameters:
-      ruby-version:
-        type: string
-      pg-version:
-        type: string
-      gemfile:
-        type: string
-    executor:
-      name: ruby-pg
-      ruby-version: << parameters.ruby-version >>
-      pg-version: << parameters.pg-version >>
-      gemfile: << parameters.gemfile >>
-    parallelism: 1
-    steps:
-      - checkout
-
-      - run:
-          # Remove the non-appraisal gemfile for safety: we never want to use it.
-          name: Prepare bundler
-          command: bundle -v && rm Gemfile
-
-      - run:
-          name: Compute a gemfile lock
-          command: bundle lock && cp "${BUNDLE_GEMFILE}.lock" /tmp/gem-lock
-
-      - restore_cache:
-          keys:
-            - iknow_viewmodels-<< parameters.ruby-version >>-{{ checksum "/tmp/gem-lock" }}
-            - iknow_viewmodels-
-
-      - run:
-          name: Bundle Install
-          command: bundle check || bundle install
-
-      - save_cache:
-          key: iknow_viewmodels-<< parameters.ruby-version >>-{{ checksum "/tmp/gem-lock" }}
-          paths:
-            - vendor/bundle
-
-      - run:
-          name: Wait for DB
-          command: dockerize -wait tcp://localhost:5432 -timeout 1m
-
-      - run:
-          name: Run minitest
-          command: bundle exec rake test
-
-      - store_test_results:
-          path: test/reports
-
-  publish:
-    executor: ruby-pg
-    steps:
-       - checkout
-       - run:
-           name: Setup Rubygems
-           command: |
-             mkdir ~/.gem &&
-             echo -e "---\r\n:rubygems_api_key: $RUBYGEMS_API_KEY" > ~/.gem/credentials &&
-             chmod 0600 ~/.gem/credentials
-       - run:
-           name: Publish to Rubygems
-           command: |
-             gem build iknow_view_models.gemspec
-             gem push iknow_view_models-*.gem
-
-workflows:
-  version: 2.1
-  build:
-    jobs:
-      - test:
-          name: 'ruby 2.7 rails 5.2 pg 12'
-          ruby-version: "2.7"
-          pg-version: "12.10"
-          gemfile: gemfiles/rails_5_2.gemfile
-      - test:
-          name: 'ruby 2.7 rails 6.0 pg 12'
-          ruby-version: "2.7"
-          pg-version: "12.10"
-          gemfile: gemfiles/rails_6_0.gemfile
-      - test:
-          name: 'ruby 2.7 rails 6.1 pg 12'
-          ruby-version: "2.7"
-          pg-version: "12.10"
-          gemfile: gemfiles/rails_6_1.gemfile
-      - test:
-          name: 'ruby 3.0 rails 6.1 pg 12'
-          ruby-version: "3.0"
-          pg-version: "12.10"
-          gemfile: gemfiles/rails_6_1.gemfile
-      - test:
-          name: 'ruby 3.1 rails 7.0 pg 13'
-          ruby-version: "3.1"
-          pg-version: "13.6"
-          gemfile: gemfiles/rails_7_0.gemfile
-      - publish:
-          filters:
-            branches:
-              only: master
-            tags:
-              ignore: /.*/