iknow_view_models 3.6.2 → 3.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 267212f1572c3f81b65462be6c30e02a12a6562a29d01bd5e0c342a12396acbc
-  data.tar.gz: e8c4addd984351d6df889ba7d75abbe8d5bde7793a48791e24a1b42e7a3fdf42
+  metadata.gz: ea15135f8f921a083f88184fb1602c2cb1ab1654845bf7d29b5d6a35ce4a1e93
+  data.tar.gz: cbb335d8125222a4e5efdb6fc5ae6317a6c1e74d86270885b68d2e482742f392
 SHA512:
-  metadata.gz: 6039dcc05bed20bce4681c322c3509be3f2a276c0a755fb3e27240eec74fd9eddef68f3c272df33554407853065a98e0f4d03a068c8c0e068cfc02be6f73ab67
-  data.tar.gz: 95fb89d93724d5028905612d846534916c4bdacd1bb88009ae434090b183e17d7311bb2709bfa81b08ff3dff45940ced0ce080ff861529c59cbb96671a661b64
+  metadata.gz: cde2777790785631ba0407ddd576931b05257bb1f51544927c4f9750ec0472cd45f87a9cfc3536271ead56f7b7decbc548f3f401ca23ae48a28bb11c2a6b67dd
+  data.tar.gz: 0bc8000d9cdf342248e2c9cd24e40f8fd4386f34b01891b022785747f9eda8474a19201cc1c72af8d526632ca9493d97eef00e59da3c683ba7bd8d1083790cc2

data/.circleci/config.yml

@@ -8,7 +8,7 @@ executors:
         default: "2.7"
       pg-version:
         type: string
-        default: "11"
+        default: "12.10"
       gemfile:
         type: string
         default: "Gemfile"
@@ -16,14 +16,14 @@ executors:
       PGHOST: 127.0.0.1
       PGUSER: eikaiwa
     docker:
-      - image: circleci/ruby:<< parameters.ruby-version >>
+      - image: cimg/ruby:<< parameters.ruby-version >>
         environment:
           BUNDLE_JOBS: 3
           BUNDLE_RETRY: 3
           BUNDLE_PATH: vendor/bundle
           RAILS_ENV: test
           BUNDLE_GEMFILE: << parameters.gemfile >>
-      - image: circleci/postgres:<< parameters.pg-version >>-alpine
+      - image: cimg/postgres:<< parameters.pg-version >>
         environment:
           POSTGRES_USER: eikaiwa
           POSTGRES_DB: iknow_view_models
@@ -104,27 +104,27 @@ workflows:
       - test:
           name: 'ruby 2.7 rails 5.2 pg 12'
           ruby-version: "2.7"
-          pg-version: "12"
+          pg-version: "12.10"
           gemfile: gemfiles/rails_5_2.gemfile
       - test:
           name: 'ruby 2.7 rails 6.0 pg 12'
           ruby-version: "2.7"
-          pg-version: "12"
+          pg-version: "12.10"
           gemfile: gemfiles/rails_6_0.gemfile
       - test:
           name: 'ruby 2.7 rails 6.1 pg 12'
           ruby-version: "2.7"
-          pg-version: "12"
+          pg-version: "12.10"
           gemfile: gemfiles/rails_6_1.gemfile
       - test:
           name: 'ruby 3.0 rails 6.1 pg 12'
           ruby-version: "3.0"
-          pg-version: "12"
+          pg-version: "12.10"
           gemfile: gemfiles/rails_6_1.gemfile
       - test:
-          name: 'ruby 3.0 rails 7.0 pg 12'
-          ruby-version: "3.0"
-          pg-version: "12"
+          name: 'ruby 3.1 rails 7.0 pg 13'
+          ruby-version: "3.1"
+          pg-version: "13.6"
           gemfile: gemfiles/rails_7_0.gemfile
       - publish:
           filters:

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.6.2'
+  VERSION = '3.6.5'
 end

data/lib/view_model/access_control/composed.rb

@@ -39,10 +39,20 @@ class ViewModel::AccessControl::Composed < ViewModel::AccessControl
           case
           when new_allow
             nil
-          when mergeable_error?(self.allow_error) && mergeable_error?(other.allow_error)
-            self.allow_error.merge(other.allow_error)
+          when self.allow_error.nil?
+            other.allow_error
+          when other.allow_error.nil?
+            self.allow_error
+          # Mergeable (standard) errors should be merged if possible; if not
+          # possible, we should take the first non-standard error.
+          when mergeable_error?(self.allow_error)
+            if mergeable_error?(other.allow_error)
+              self.allow_error.merge(other.allow_error)
+            else
+              other.allow_error
+            end
           else
-            self.allow_error || other.allow_error
+            self.allow_error
           end
 
         ComposedResult.new(new_allow, other.veto, new_allow_error, other.veto_error)
@@ -52,7 +62,7 @@ class ViewModel::AccessControl::Composed < ViewModel::AccessControl
     private
 
     def mergeable_error?(err)
-      err&.is_a?(NoRequiredConditionsError)
+      err.is_a?(NoRequiredConditionsError)
     end
   end
 
@@ -160,16 +170,15 @@ class ViewModel::AccessControl::Composed < ViewModel::AccessControl
         next unless visited.add?(ancestor)
         next if include_ancestor && !include_ancestor.call(ancestor)
 
-        ancestor.each_check(check_name) { |x| yield x }
+        ancestor.each_check(check_name, include_ancestor) { |x| yield x }
       end
     end
 
     def inspect
-      s = super + '('
-      s += inspect_checks.join(', ')
-      s += " includes checkers: #{@included_checkers.inspect}" if @included_checkers.present?
-      s += ')'
-      s
+      checks = inspect_checks
+      checks << "includes checkers: #{@included_checkers.inspect}" if @included_checkers.present?
+
+      super + '(' + checks.join(', ') + ')'
     end
 
     def inspect_checks

data/lib/view_model/access_control/tree.rb

@@ -192,8 +192,6 @@ class ViewModel::AccessControl::Tree < ViewModel::AccessControl
       def inspect_checks
         checks = super
         if root?
-          checks << 'no root checks'
-        else
           checks << "root_children_visible_if: #{root_children_visible_ifs.map(&:reason)}"            if root_children_visible_ifs.present?
           checks << "root_children_visible_unless: #{root_children_visible_unlesses.map(&:reason)}"   if root_children_visible_unlesses.present?
           checks << "root_children_editable_if: #{root_children_editable_ifs.map(&:reason)}"          if root_children_editable_ifs.present?
@@ -252,16 +250,16 @@ class ViewModel::AccessControl::Tree < ViewModel::AccessControl
 
     def save_root_visibility!(traversal_env)
       result = check_delegates(traversal_env,
-                               self.class.each_check(:root_children_visible_ifs,      ->(a) { a.is_a?(Node) }),
-                               self.class.each_check(:root_children_visible_unlesses, ->(a) { a.is_a?(Node) }))
+                               self.class.each_check(:root_children_visible_ifs,      ->(a) { a < Node }),
+                               self.class.each_check(:root_children_visible_unlesses, ->(a) { a < Node }))
 
       store_descendent_visibility(traversal_env.view, result)
     end
 
     def save_root_editability!(traversal_env)
       result = check_delegates(traversal_env,
-                               self.class.each_check(:root_children_editable_ifs,      ->(a) { a.is_a?(Node) }),
-                               self.class.each_check(:root_children_editable_unlesses, ->(a) { a.is_a?(Node) }))
+                               self.class.each_check(:root_children_editable_ifs,      ->(a) { a < Node }),
+                               self.class.each_check(:root_children_editable_unlesses, ->(a) { a < Node }))
 
       store_descendent_editability(traversal_env.view, result)
     end

data/lib/view_model/migration/no_path_error.rb

@@ -14,7 +14,7 @@ class ViewModel::Migration::NoPathError < ViewModel::AbstractError
   end
 
   def detail
-    "No migration path for #{vm_name} from #{from} to #{to}"
+    "No migration path for #{vm_name} between client version #{from} and server version #{to}"
   end
 
   def meta

data/lib/view_model.rb

@@ -3,6 +3,7 @@
 # A ViewModel encapsulates a particular aggregation of data calculated via the
 # underlying models and provides a means of serializing it into views.
 require 'jbuilder'
+require 'base64'
 require 'deep_preloader'
 
 class ViewModel

data/test/unit/view_model/access_control_test.rb

@@ -319,6 +319,26 @@ class ViewModel::AccessControlTest < ActiveSupport::TestCase
       assert_serializes(Tree1View, make_tree('rule:visible_children', 'visible child', 'rule:visible_children', 'visible child'))
     end
 
+    def test_root_inheritance
+      parent_access_control = Class.new(ViewModel::AccessControl::Tree)
+      parent_access_control.view 'Tree1' do
+        visible_if!('true') { true }
+
+        root_children_visible_if!('root children visible') do
+          view.val == 'rule:visible_children'
+        end
+      end
+
+      TestAccessControl.include_from(parent_access_control)
+
+      refute_serializes(Tree1View, make_tree('arbitrary parent',      'invisible child'))
+      assert_serializes(Tree1View, make_tree('rule:visible_children', 'visible child'))
+
+      # nested root
+      refute_serializes(Tree1View, make_tree('rule:visible_children', 'visible child', 'arbitrary parent',      'invisible child'))
+      assert_serializes(Tree1View, make_tree('rule:visible_children', 'visible child', 'rule:visible_children', 'visible child'))
+    end
+
     def test_visibility_veto_from_root
       TestAccessControl.view 'Tree1' do
         root_children_visible_unless!('root children invisible') do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.6.2
+  version: 3.6.5
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-02-16 00:00:00.000000000 Z
+date: 2022-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -509,7 +509,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.3.11
 signing_key: 
 specification_version: 4
 summary: ViewModels provide a means of encapsulating a collection of related data