iknow_view_models 3.5.2 → 3.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f51edf25fab0aec533446c939c44975f76806871e1341518aa4470f32c23d839
-  data.tar.gz: 140166cc68f15484a0291f4e8faa8b4e26c3233a2b3bcfacfa9a4972a2a5e0ef
+  metadata.gz: 27ea471c380869f02c7f103025a151b53d99a1c8f19181566852f12f78ba7cd3
+  data.tar.gz: dc18591e8c0b39e986cd0895e691e6d4d3a89df6cf04c4c486b3ecfc8699da4f
 SHA512:
-  metadata.gz: 27e85b3cd097d4f19e28d66d3500db4142dedd4a65a44731754afd35430d86945bb2e7f928df476e4aadb665d34518fa10211113f17b1ad0718727f957c8156f
-  data.tar.gz: 7e740ea172d15e55b870336fd833a6138c3f5aaec97da84828813b6da57d9512bbb3cd98f404f24c58c7adf7b53d875639bd22561b200d429e74523770a3a483
+  metadata.gz: 156474c34631689f937fda7e3f4a2b2421a8205b3d172a2e72476aa8e440c5bb45b760aaf72a9e70ae9ff9830a209f8be727eb27d233a875aabf963ad88ce85b
+  data.tar.gz: 8e39b0542bef145e8bbc6e6c30ff17d4ff4de2e08c93f7cc7b228cccdac6443159de74e9e3419fada058c09c38b1eba571d4f16633ce83abe6972331a8a4017c

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.5.2'
+  VERSION = '3.5.3'
 end

data/lib/view_model/migratable_view.rb

@@ -34,14 +34,36 @@ module ViewModel::MigratableView
       end
     end
 
+    protected
+
+    def migration_class(from, to)
+      @migration_classes.fetch([from, to]) do
+        raise ViewModel::Migration::NoPathError.new(self, from, to)
+      end
+    end
+
     private
 
     # Define a migration on this viewmodel
-    def migrates(from:, to:, &block)
+    def migrates(from:, to:, inherit: nil, at: nil, &block)
       @migrations_lock.synchronize do
-        builder = ViewModel::Migration::Builder.new
+        migration_superclass =
+          if inherit
+            raise ArgumentError.new('Must provide inherit version') unless at
+
+            inherit.migration_class(at - 1, at)
+          else
+            ViewModel::Migration
+          end
+
+        builder = ViewModel::Migration::Builder.new(migration_superclass)
         builder.instance_exec(&block)
-        @migration_classes[[from, to]] = builder.build!
+
+        migration_class = builder.build!
+
+        const_set(:"Migration_#{from}_To_#{to}", migration_class)
+        @migration_classes[[from, to]] = migration_class
+
         @realized_migration_paths = false
       end
     end

data/lib/view_model/migration.rb

@@ -15,13 +15,14 @@ class ViewModel::Migration
 
   # Tiny DSL for defining migration classes
   class Builder
-    def initialize
+    def initialize(superclass = ViewModel::Migration)
+      @superclass = superclass
       @up_block = nil
       @down_block = nil
     end
 
     def build!
-      migration = Class.new(ViewModel::Migration)
+      migration = Class.new(@superclass)
       migration.define_method(:up, &@up_block) if @up_block
       migration.define_method(:down, &@down_block) if @down_block
       migration

data/test/helpers/viewmodel_spec_helpers.rb

@@ -206,6 +206,55 @@ module ViewModelSpecHelpers
     end
   end
 
+  module SingleWithInheritedMigration
+    extend ActiveSupport::Concern
+    include ViewModelSpecHelpers::Base
+
+    def migration_bearing_viewmodel_class
+      define_viewmodel_class(
+        :MigrationBearingView,
+        namespace: namespace,
+        viewmodel_base: viewmodel_base,
+        model_base: model_base,
+        spec: ViewModel::TestHelpers::ARVMBuilder::Spec.new(
+          schema: ->(_) {},
+          model: ->(_) {},
+          viewmodel: ->(v) {
+            root!
+            self.schema_version = 2
+            migrates from: 1, to: 2 do
+              down do |view, _refs|
+                view['inherited_base'] = 'present'
+              end
+            end
+          }))
+    end
+
+    def model_attributes
+      migration_bearing_viewmodel_class = self.migration_bearing_viewmodel_class
+
+      super.merge(
+        schema: ->(t) { t.integer :new_field, default: 1, null: false },
+        viewmodel: ->(_v) {
+          self.schema_version = 2
+
+          attribute :new_field
+
+          migrates from: 1, to: 2, inherit: migration_bearing_viewmodel_class, at: 2 do
+            down do |view, refs|
+              super(view, refs)
+              view.delete('new_field')
+            end
+
+            up do |view, refs|
+              view.delete('inherited_base')
+              view['new_field'] = 100
+            end
+          end
+        })
+    end
+  end
+
   module ParentAndBelongsToChildWithMigration
     extend ActiveSupport::Concern
     include ViewModelSpecHelpers::ParentAndBelongsToChild

data/test/unit/view_model/active_record/migration_test.rb

@@ -210,6 +210,69 @@ class ViewModel::ActiveRecord::Migration < ActiveSupport::TestCase
     end
   end
 
+  describe 'inherited migrations' do
+    include ViewModelSpecHelpers::SingleWithInheritedMigration
+
+    def new_model
+      model_class.new(name: 'm1')
+    end
+
+    let(:migration_versions) { { viewmodel_class => 1 } }
+
+    let(:v1_serialization_data) do
+      {
+        ViewModel::TYPE_ATTRIBUTE => viewmodel_class.view_name,
+        ViewModel::VERSION_ATTRIBUTE => 1,
+        ViewModel::ID_ATTRIBUTE => viewmodel.id,
+        'name' => viewmodel.name,
+        'inherited_base' => 'present',
+      }
+    end
+
+    let(:v1_serialization_references) { {} }
+
+    let(:v1_serialization) do
+      {
+        'data' => v1_serialization_data,
+        'references' => v1_serialization_references,
+      }
+    end
+
+    describe 'downwards' do
+      let(:migrator) { down_migrator }
+      let(:subject) { current_serialization.deep_dup }
+      let(:expected_result) do
+        v1_serialization.deep_merge({ 'data' => { ViewModel::MIGRATED_ATTRIBUTE => true } })
+      end
+
+      it 'migrates' do
+        migrate!
+        assert_equal(expected_result, subject)
+      end
+    end
+
+    describe 'upwards' do
+      let(:migrator) { up_migrator }
+      let(:subject) { v1_serialization.deep_dup }
+
+      let(:expected_result) do
+        current_serialization.deep_merge(
+          {
+            'data' => {
+              ViewModel::MIGRATED_ATTRIBUTE => true,
+              'new_field' => 100,
+            },
+          },
+        )
+      end
+
+      it 'migrates' do
+        migrate!
+        assert_equal(expected_result, subject)
+      end
+    end
+  end
+
   describe 'garbage collection' do
     include ViewModelSpecHelpers::ParentAndSharedBelongsToChild
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.5.2
+  version: 3.5.3
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-28 00:00:00.000000000 Z
+date: 2021-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord