iknow_view_models 3.4.4 → 3.5.3

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 2845e303fc1acc67f0241e30586c39276f08720a824104f71416a5b9d63a8989
4
- data.tar.gz: ae89dde77c602debb67793bc36a120739c6692802e227d1835f972b0d72f542f
3
+ metadata.gz: 27ea471c380869f02c7f103025a151b53d99a1c8f19181566852f12f78ba7cd3
4
+ data.tar.gz: dc18591e8c0b39e986cd0895e691e6d4d3a89df6cf04c4c486b3ecfc8699da4f
5
5
  SHA512:
6
- metadata.gz: 808e3772112084fb81efeb7b0229ec461d4318b2f74460e01e94cd4c57c197b6c10b1fe6b0c02f0efa995d9b27209d08de8a98ed2991b270387cdc2b7a6520b4
7
- data.tar.gz: 6ffed3458c0a92ddc8a49580073bbc6827eed7be49b1c605ed7708fc995185c825df57d583fd27305d45b4425b806faf0655a81a3eb7be5f9f64cdec9d09dedc
6
+ metadata.gz: 156474c34631689f937fda7e3f4a2b2421a8205b3d172a2e72476aa8e440c5bb45b760aaf72a9e70ae9ff9830a209f8be727eb27d233a875aabf963ad88ce85b
7
+ data.tar.gz: 8e39b0542bef145e8bbc6e6c30ff17d4ff4de2e08c93f7cc7b228cccdac6443159de74e9e3419fada058c09c38b1eba571d4f16633ce83abe6972331a8a4017c
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module IknowViewModels
4
- VERSION = '3.4.4'
4
+ VERSION = '3.5.3'
5
5
  end
@@ -3,6 +3,8 @@
3
3
  # Mix-in for VM::ActiveRecord providing direct manipulation of
4
4
  # directly-associated entities. Avoids loading entire collections.
5
5
  module ViewModel::ActiveRecord::AssociationManipulation
6
+ extend ActiveSupport::Concern
7
+
6
8
  def load_associated(association_name, scope: nil, eager_include: true, serialize_context: self.class.new_serialize_context)
7
9
  association_data = self.class._association_data(association_name)
8
10
  direct_reflection = association_data.direct_reflection
@@ -49,49 +51,63 @@ module ViewModel::ActiveRecord::AssociationManipulation
49
51
  end
50
52
  end
51
53
 
52
- # Replace the current member(s) of an association with the provided hash(es).
54
+ # Replace the current member(s) of an association with the provided
55
+ # hash(es). Only mentioned member(s) will be returned.
56
+ #
57
+ # This interface deals with associations directly where reasonable,
58
+ # with the notable exception of referenced+shared associations. That
59
+ # is to say, that owned associations should be presented in the form
60
+ # of direct update hashes, regardless of their
61
+ # referencing. Reference and shared associations are excluded to
62
+ # ensure that the update hash for a shared entity is unique, and
63
+ # that edits may only be specified once.
53
64
  def replace_associated(association_name, update_hash, references: {}, deserialize_context: self.class.new_deserialize_context)
54
- association_data = self.class._association_data(association_name)
55
-
56
- if association_data.referenced?
57
- is_fupdate =
58
- association_data.collection? &&
59
- update_hash.is_a?(Hash) &&
60
- update_hash[ViewModel::ActiveRecord::TYPE_ATTRIBUTE] == ViewModel::ActiveRecord::FUNCTIONAL_UPDATE_TYPE
61
-
62
- if is_fupdate
63
- update_hash[ViewModel::ActiveRecord::ACTIONS_ATTRIBUTE].each_with_index do |action, i|
64
- action_type_name = action[ViewModel::ActiveRecord::TYPE_ATTRIBUTE]
65
- if action_type_name == ViewModel::ActiveRecord::FunctionalUpdate::Remove::NAME
66
- # Remove actions are always type/id refs; others need to be translated to proper refs
67
- next
68
- end
65
+ _updated_parent, changed_children =
66
+ self.class.replace_associated_bulk(
67
+ association_name,
68
+ { self.id => update_hash },
69
+ references: references,
70
+ deserialize_context: deserialize_context
71
+ ).first
72
+
73
+ changed_children
74
+ end
69
75
 
70
- association_references = convert_updates_to_references(
71
- action[ViewModel::ActiveRecord::VALUES_ATTRIBUTE],
72
- key: "#{action_type_name}_#{i}")
73
- references.merge!(association_references)
74
- action[ViewModel::ActiveRecord::VALUES_ATTRIBUTE] =
75
- association_references.each_key.map { |ref| { ViewModel::REFERENCE_ATTRIBUTE => ref } }
76
- end
77
- else
78
- update_hash = ViewModel::Utils.wrap_one_or_many(update_hash) do |sh|
79
- association_references = convert_updates_to_references(sh, key: 'replace')
80
- references.merge!(association_references)
81
- association_references.each_key.map { |ref| { ViewModel::REFERENCE_ATTRIBUTE => ref } }
82
- end
76
+ class_methods do
77
+ # Replace the current member(s) of an association with the provided
78
+ # hash(es) for many viewmodels. Only mentioned members will be returned.
79
+ #
80
+ # This is an interim implementation that requires loading the contents of
81
+ # all collections into memory and filtering for the mentioned entities,
82
+ # even for functional updates. This is in contrast to append_associated,
83
+ # which only operates on the new entities.
84
+ def replace_associated_bulk(association_name, updates_by_parent_id, references:, deserialize_context: self.class.new_deserialize_context)
85
+ association_data = _association_data(association_name)
86
+
87
+ touched_ids = updates_by_parent_id.each_with_object({}) do |(parent_id, update_hash), acc|
88
+ acc[parent_id] =
89
+ mentioned_children(
90
+ update_hash,
91
+ references: references,
92
+ association_data: association_data,
93
+ ).to_set
83
94
  end
84
- end
85
95
 
86
- root_update_hash = {
87
- ViewModel::ID_ATTRIBUTE => self.id,
88
- ViewModel::TYPE_ATTRIBUTE => self.class.view_name,
89
- association_name.to_s => update_hash,
90
- }
96
+ root_update_hashes = updates_by_parent_id.map do |parent_id, update_hash|
97
+ {
98
+ ViewModel::ID_ATTRIBUTE => parent_id,
99
+ ViewModel::TYPE_ATTRIBUTE => view_name,
100
+ association_name.to_s => update_hash,
101
+ }
102
+ end
91
103
 
92
- root_update_viewmodel = self.class.deserialize_from_view(root_update_hash, references: references, deserialize_context: deserialize_context)
104
+ root_update_viewmodels = deserialize_from_view(
105
+ root_update_hashes, references: references, deserialize_context: deserialize_context)
93
106
 
94
- root_update_viewmodel._read_association(association_name)
107
+ root_update_viewmodels.each_with_object({}) do |updated, acc|
108
+ acc[updated] = updated._read_association_touched(association_name, touched_ids: touched_ids.fetch(updated.id))
109
+ end
110
+ end
95
111
  end
96
112
 
97
113
  # Create or update members of a associated collection. For an ordered
@@ -313,7 +329,10 @@ module ViewModel::ActiveRecord::AssociationManipulation
313
329
  indirect_update_data, referenced_update_data = ViewModel::ActiveRecord::UpdateData.parse_hashes(subtree_hashes, references)
314
330
 
315
331
  # Convert associated update data to references
316
- indirect_references = convert_updates_to_references(indirect_update_data, key: 'indirect_append')
332
+ indirect_references =
333
+ self.class.convert_updates_to_references(
334
+ indirect_update_data, key: 'indirect_append')
335
+
317
336
  referenced_update_data.merge!(indirect_references)
318
337
 
319
338
  # Find any existing models for the direct association: need to re-use any
@@ -352,12 +371,6 @@ module ViewModel::ActiveRecord::AssociationManipulation
352
371
  return direct_update_data, referenced_update_data
353
372
  end
354
373
 
355
- def convert_updates_to_references(indirect_update_data, key:)
356
- indirect_update_data.each.with_index.with_object({}) do |(update, i), indirect_references|
357
- indirect_references["__#{key}_ref_#{i}"] = update
358
- end
359
- end
360
-
361
374
  # TODO: this functionality could reasonably be extracted into `acts_as_manual_list`.
362
375
  def select_append_positions(association_data, position_attr, append_count, before:, after:)
363
376
  direct_reflection = association_data.direct_reflection
@@ -401,4 +414,128 @@ module ViewModel::ActiveRecord::AssociationManipulation
401
414
  "Need to specify target viewmodel type for polymorphic association '#{association_data.association_name}'")
402
415
  end
403
416
  end
417
+
418
+ class_methods do
419
+ def convert_updates_to_references(indirect_update_data, key:)
420
+ indirect_update_data.each.with_index.with_object({}) do |(update, i), indirect_references|
421
+ indirect_references["__#{key}_ref_#{i}"] = update
422
+ end
423
+ end
424
+
425
+ def add_reference_indirection(update_hash, association_data:, references:, key:)
426
+ raise ArgumentError.new('Not a referenced association') unless association_data.referenced?
427
+
428
+ is_fupdate =
429
+ association_data.collection? &&
430
+ update_hash.is_a?(Hash) &&
431
+ update_hash[ViewModel::ActiveRecord::TYPE_ATTRIBUTE] == ViewModel::ActiveRecord::FUNCTIONAL_UPDATE_TYPE
432
+
433
+ if is_fupdate
434
+ update_hash[ViewModel::ActiveRecord::ACTIONS_ATTRIBUTE].each_with_index do |action, i|
435
+ action_type_name = action[ViewModel::ActiveRecord::TYPE_ATTRIBUTE]
436
+ if action_type_name == ViewModel::ActiveRecord::FunctionalUpdate::Remove::NAME
437
+ # Remove actions are always type/id refs; others need to be translated to proper refs
438
+ next
439
+ end
440
+
441
+ association_references = convert_updates_to_references(
442
+ action[ViewModel::ActiveRecord::VALUES_ATTRIBUTE],
443
+ key: "#{key}_#{action_type_name}_#{i}")
444
+ references.merge!(association_references)
445
+ action[ViewModel::ActiveRecord::VALUES_ATTRIBUTE] =
446
+ association_references.each_key.map { |ref| { ViewModel::REFERENCE_ATTRIBUTE => ref } }
447
+ end
448
+
449
+ update_hash
450
+ else
451
+ ViewModel::Utils.wrap_one_or_many(update_hash) do |sh|
452
+ association_references = convert_updates_to_references(sh, key: "#{key}_replace")
453
+ references.merge!(association_references)
454
+ association_references.each_key.map { |ref| { ViewModel::REFERENCE_ATTRIBUTE => ref } }
455
+ end
456
+ end
457
+ end
458
+
459
+ # Traverses literals and fupdates to return referenced children.
460
+ #
461
+ # Runs before the main parser, so must be defensive
462
+ def each_child_hash(assoc_update, association_data:)
463
+ return enum_for(__method__, assoc_update, association_data: association_data) unless block_given?
464
+
465
+ is_fupdate =
466
+ association_data.collection? &&
467
+ assoc_update.is_a?(Hash) &&
468
+ assoc_update[ViewModel::ActiveRecord::TYPE_ATTRIBUTE] == ViewModel::ActiveRecord::FUNCTIONAL_UPDATE_TYPE
469
+
470
+ if is_fupdate
471
+ assoc_update.fetch(ViewModel::ActiveRecord::ACTIONS_ATTRIBUTE).each do |action|
472
+ action_type_name = action[ViewModel::ActiveRecord::TYPE_ATTRIBUTE]
473
+ if action_type_name.nil?
474
+ raise ViewModel::DeserializationError::InvalidSyntax.new(
475
+ "Functional update missing '#{ViewModel::ActiveRecord::TYPE_ATTRIBUTE}'"
476
+ )
477
+ end
478
+
479
+ if action_type_name == ViewModel::ActiveRecord::FunctionalUpdate::Remove::NAME
480
+ # Remove actions are not considered children of the action.
481
+ next
482
+ end
483
+
484
+ values = action.fetch(ViewModel::ActiveRecord::VALUES_ATTRIBUTE) {
485
+ raise ViewModel::DeserializationError::InvalidSyntax.new(
486
+ "Functional update missing '#{ViewModel::ActiveRecord::VALUES_ATTRIBUTE}'"
487
+ )
488
+ }
489
+ values.each { |x| yield x }
490
+ end
491
+ else
492
+ ViewModel::Utils.wrap_one_or_many(assoc_update) do |assoc_updates|
493
+ assoc_updates.each { |u| yield u }
494
+ end
495
+ end
496
+ end
497
+
498
+ # Collects the ids of children that are mentioned in the update data.
499
+ #
500
+ # Runs before the main parser, so must be defensive.
501
+ def mentioned_children(assoc_update, references:, association_data:)
502
+ return enum_for(__method__, assoc_update, references: references, association_data: association_data) unless block_given?
503
+
504
+ each_child_hash(assoc_update, association_data: association_data).each do |child_hash|
505
+ unless child_hash.is_a?(Hash)
506
+ raise ViewModel::DeserializationError::InvalidSyntax.new(
507
+ "Expected update hash, received: #{child_hash}"
508
+ )
509
+ end
510
+
511
+ if association_data.referenced?
512
+ ref_handle = child_hash.fetch(ViewModel::REFERENCE_ATTRIBUTE) {
513
+ raise ViewModel::DeserializationError::InvalidSyntax.new(
514
+ "Reference hash missing '#{ViewModel::REFERENCE_ATTRIBUTE}'"
515
+ )
516
+ }
517
+
518
+ ref_update_hash = references.fetch(ref_handle) {
519
+ raise ViewModel::DeserializationError::InvalidSyntax.new(
520
+ "Reference '#{ref_handle}' does not exist in references"
521
+ )
522
+ }
523
+
524
+ unless ref_update_hash.is_a?(Hash)
525
+ raise ViewModel::DeserializationError::InvalidSyntax.new(
526
+ "Expected update hash, received: #{child_hash}"
527
+ )
528
+ end
529
+
530
+ if (id = ref_update_hash[ViewModel::ID_ATTRIBUTE])
531
+ yield id
532
+ end
533
+ else
534
+ if (id = child_hash[ViewModel::ID_ATTRIBUTE])
535
+ yield id
536
+ end
537
+ end
538
+ end
539
+ end
540
+ end
404
541
  end
@@ -3,8 +3,7 @@
3
3
  require 'view_model/active_record/nested_controller_base'
4
4
 
5
5
  # Controller mixin for accessing a root ViewModel which can be accessed in a
6
- # collection by a parent model. Enabled by calling `nested_in :parent, as:
7
- # :children` on the viewmodel controller
6
+ # collection by a parent model.
8
7
 
9
8
  # Contributes the following routes:
10
9
  # PUT /parents/:parent_id/children #append -- deserialize (possibly existing) children and append to collection
@@ -32,6 +31,10 @@ module ViewModel::ActiveRecord::CollectionNestedController
32
31
  write_association(serialize_context: serialize_context, deserialize_context: deserialize_context, lock_owner: lock_owner, &block)
33
32
  end
34
33
 
34
+ def replace_bulk(serialize_context: new_serialize_context, deserialize_context: new_deserialize_context, &block)
35
+ write_association_bulk(serialize_context: serialize_context, deserialize_context: deserialize_context, &block)
36
+ end
37
+
35
38
  def disassociate_all(serialize_context: new_serialize_context, deserialize_context: new_deserialize_context, lock_owner: nil)
36
39
  destroy_association(true, serialize_context: serialize_context, deserialize_context: deserialize_context, lock_owner: lock_owner)
37
40
  end
@@ -102,15 +102,35 @@ module ActionDispatch
102
102
  def arvm_resources(resource_name, options = {}, &block)
103
103
  except = options.delete(:except) { [] }
104
104
  add_shallow_routes = options.delete(:add_shallow_routes) { true }
105
+ defaults = options.delete(:defaults) { {} }
105
106
 
106
107
  nested = shallow_nesting_depth > 0
107
108
 
109
+ association_name = options.delete(:association_name) { resource_name.to_s }
110
+ owner_viewmodel = options.delete(:owner_viewmodel) do
111
+ if nested
112
+ parent_resource.name.to_s.singularize.camelize
113
+ end
114
+ end
115
+
116
+ defaults = {
117
+ association_name: association_name,
118
+ owner_viewmodel: owner_viewmodel,
119
+ }.merge(defaults)
120
+
108
121
  only_routes = []
109
122
  only_routes += [:create] unless nested
110
123
  only_routes += [:show, :destroy] if add_shallow_routes
111
124
  only_routes -= except
112
125
 
113
- resources resource_name, shallow: true, only: only_routes, **options do
126
+ # Bulk replace
127
+ if nested && !except.include?(:replace_bulk)
128
+ collection do
129
+ post resource_name, controller: resource_name, action: :replace_bulk, as: nil, defaults: defaults
130
+ end
131
+ end
132
+
133
+ resources resource_name, shallow: true, only: only_routes, defaults: defaults, **options do
114
134
  instance_eval(&block) if block_given?
115
135
 
116
136
  if nested
@@ -149,16 +169,35 @@ module ActionDispatch
149
169
  def arvm_resource(resource_name, options = {}, &block)
150
170
  except = options.delete(:except) { [] }
151
171
  add_shallow_routes = options.delete(:add_shallow_routes) { true }
172
+ defaults = options.delete(:defaults) { {} }
152
173
 
153
174
  only_routes = []
154
- is_shallow = false
155
- resource resource_name, shallow: true, only: only_routes, **options do
156
- is_shallow = shallow_nesting_depth > 1
175
+ nested = shallow_nesting_depth > 0
176
+
177
+ association_name = options.delete(:association_name) { resource_name.to_s }
178
+ owner_viewmodel = options.delete(:owner_viewmodel) do
179
+ if nested
180
+ parent_resource.name.to_s.singularize.camelize
181
+ end
182
+ end
183
+
184
+ defaults = {
185
+ association_name: association_name,
186
+ owner_viewmodel: owner_viewmodel,
187
+ }.merge(defaults)
188
+
189
+ if nested && !except.include?(:create_associated_bulk)
190
+ collection do
191
+ post resource_name, controller: resource_name, action: :create_associated_bulk, as: nil, defaults: defaults
192
+ end
193
+ end
194
+
195
+ resource resource_name, shallow: true, only: only_routes, defaults: defaults, **options do
157
196
  instance_eval(&block) if block_given?
158
197
 
159
198
  name_route = { as: '' } # Only one route may take the name
160
199
 
161
- if is_shallow
200
+ if nested
162
201
  post('', action: :create_associated, **name_route.extract!(:as)) unless except.include?(:create)
163
202
  get('', action: :show_associated, **name_route.extract!(:as)) unless except.include?(:show)
164
203
  delete('', action: :destroy_associated, **name_route.extract!(:as)) unless except.include?(:destroy)
@@ -170,7 +209,7 @@ module ActionDispatch
170
209
  end
171
210
 
172
211
  # singularly nested resources provide collection accessors at the top level
173
- if is_shallow && add_shallow_routes
212
+ if nested && add_shallow_routes
174
213
  resources resource_name.to_s.pluralize, shallow: true, only: [:show, :destroy] - except do
175
214
  shallow_scope do
176
215
  collection do
@@ -7,9 +7,45 @@ require 'view_model/active_record/controller_base'
7
7
  module ViewModel::ActiveRecord::NestedControllerBase
8
8
  extend ActiveSupport::Concern
9
9
 
10
+ class ParentProxyModel < ViewModel
11
+ # Prevent this from appearing in hooks
12
+ self.synthetic = true
13
+
14
+ attr_reader :parent, :association_data, :changed_children
15
+
16
+ def initialize(parent, association_data, changed_children)
17
+ @parent = parent
18
+ @association_data = association_data
19
+ @changed_children = changed_children
20
+ end
21
+
22
+ def serialize(json, serialize_context:)
23
+ ViewModel::Callbacks.wrap_serialize(parent, context: serialize_context) do
24
+ child_context = parent.context_for_child(association_data.association_name, context: serialize_context)
25
+
26
+ json.set!(ViewModel::ID_ATTRIBUTE, parent.id)
27
+ json.set!(ViewModel::BULK_UPDATE_ATTRIBUTE) do
28
+ if association_data.referenced? && !association_data.owned?
29
+ if association_data.collection?
30
+ json.array!(changed_children) do |child|
31
+ ViewModel.serialize_as_reference(child, json, serialize_context: child_context)
32
+ end
33
+ else
34
+ ViewModel.serialize_as_reference(changed_children, json, serialize_context: child_context)
35
+ end
36
+ else
37
+ ViewModel.serialize(changed_children, json, serialize_context: child_context)
38
+ end
39
+ end
40
+ end
41
+ end
42
+ end
43
+
10
44
  protected
11
45
 
12
46
  def show_association(scope: nil, serialize_context: new_serialize_context, lock_owner: nil)
47
+ require_external_referenced_association!
48
+
13
49
  associated_views = nil
14
50
  pre_rendered = owner_viewmodel.transaction do
15
51
  owner_view = owner_viewmodel.find(owner_viewmodel_id, eager_include: false, lock: lock_owner)
@@ -27,11 +63,27 @@ module ViewModel::ActiveRecord::NestedControllerBase
27
63
  associated_views
28
64
  end
29
65
 
66
+ # This method always takes direct update hashes, and returns
67
+ # viewmodels directly.
68
+ #
69
+ # There's no multi membership, so when viewing the children of a
70
+ # single parent each child can only appear once. This means it's
71
+ # safe to use update hashes directly.
30
72
  def write_association(serialize_context: new_serialize_context, deserialize_context: new_deserialize_context, lock_owner: nil)
73
+ require_external_referenced_association!
74
+
31
75
  association_view = nil
32
76
  pre_rendered = owner_viewmodel.transaction do
33
77
  update_hash, refs = parse_viewmodel_updates
34
78
 
79
+ update_hash =
80
+ ViewModel::ActiveRecord.add_reference_indirection(
81
+ update_hash,
82
+ association_data: association_data,
83
+ references: refs,
84
+ key: 'write-association',
85
+ )
86
+
35
87
  owner_view = owner_viewmodel.find(owner_viewmodel_id, eager_include: false, lock: lock_owner)
36
88
 
37
89
  association_view = owner_view.replace_associated(association_name, update_hash,
@@ -49,7 +101,67 @@ module ViewModel::ActiveRecord::NestedControllerBase
49
101
  association_view
50
102
  end
51
103
 
104
+ # This method takes direct update hashes for owned associations, and
105
+ # reference hashes for shared associations. The return value matches
106
+ # the input structure.
107
+ #
108
+ # If an association is referenced and owned, each child may only
109
+ # appear once so each is guaranteed to have a unique update
110
+ # hash. This means it's only safe to use update hashes directly in
111
+ # this case.
112
+ def write_association_bulk(serialize_context: new_serialize_context, deserialize_context: new_deserialize_context, lock_owner: nil)
113
+ require_external_referenced_association!
114
+
115
+ updated_by_parent_viewmodel = nil
116
+
117
+ pre_rendered = owner_viewmodel.transaction do
118
+ updates_by_parent_id, references = parse_bulk_update
119
+
120
+ if association_data.owned?
121
+ updates_by_parent_id.transform_values!.with_index do |update_hash, index|
122
+ ViewModel::ActiveRecord.add_reference_indirection(
123
+ update_hash,
124
+ association_data: association_data,
125
+ references: references,
126
+ key: "write-association-bulk-#{index}",
127
+ )
128
+ end
129
+ end
130
+
131
+ updated_by_parent_viewmodel =
132
+ owner_viewmodel.replace_associated_bulk(
133
+ association_name,
134
+ updates_by_parent_id,
135
+ references: references,
136
+ deserialize_context: deserialize_context,
137
+ )
138
+
139
+ views = updated_by_parent_viewmodel.flat_map { |_parent_viewmodel, updated_views| Array.wrap(updated_views) }
140
+
141
+ ViewModel.preload_for_serialization(views)
142
+
143
+ updated_by_parent_viewmodel = yield(updated_by_parent_viewmodel) if block_given?
144
+
145
+ return_updates = updated_by_parent_viewmodel.map do |owner_view, updated_views|
146
+ ParentProxyModel.new(owner_view, association_data, updated_views)
147
+ end
148
+
149
+ return_structure = {
150
+ ViewModel::TYPE_ATTRIBUTE => ViewModel::BULK_UPDATE_TYPE,
151
+ ViewModel::BULK_UPDATES_ATTRIBUTE => return_updates,
152
+ }
153
+
154
+ prerender_viewmodel(return_structure, serialize_context: serialize_context)
155
+ end
156
+
157
+ render_json_string(pre_rendered)
158
+ updated_by_parent_viewmodel
159
+ end
160
+
161
+
52
162
  def destroy_association(collection, serialize_context: new_serialize_context, deserialize_context: new_deserialize_context, lock_owner: nil)
163
+ require_external_referenced_association!
164
+
53
165
  if lock_owner
54
166
  owner_viewmodel.find(owner_viewmodel_id, eager_include: false, lock: lock_owner)
55
167
  end
@@ -61,7 +173,7 @@ module ViewModel::ActiveRecord::NestedControllerBase
61
173
  end
62
174
 
63
175
  def association_data
64
- owner_viewmodel._association_data(association_name)
176
+ @association_data ||= owner_viewmodel._association_data(association_name)
65
177
  end
66
178
 
67
179
  def owner_update_hash(update)
@@ -78,22 +190,22 @@ module ViewModel::ActiveRecord::NestedControllerBase
78
190
  parse_param(id_param_name, **default)
79
191
  end
80
192
 
81
- included do
82
- delegate :owner_viewmodel, :association_name, to: 'self.class'
193
+ def owner_viewmodel_class_for_name(name)
194
+ ViewModel::Registry.for_view_name(name)
83
195
  end
84
196
 
85
- class_methods do
86
- attr_accessor :owner_viewmodel, :association_name
87
-
88
- def nested_in(owner, as:)
89
- unless owner.is_a?(Class) && owner < ViewModel::Record
90
- owner = ViewModel::Registry.for_view_name(owner.to_s.camelize)
91
- end
197
+ def owner_viewmodel
198
+ name = params.fetch(:owner_viewmodel) { raise ArgumentError.new("No owner viewmodel present") }
199
+ owner_viewmodel_class_for_name(name.to_s.camelize)
200
+ end
92
201
 
93
- self.owner_viewmodel = owner
94
- raise ArgumentError.new("Could not find owner ViewModel class '#{owner_name}'") if owner_viewmodel.nil?
202
+ def association_name
203
+ params.fetch(:association_name) { raise ArgumentError.new('No association name from routes') }
204
+ end
95
205
 
96
- self.association_name = as
206
+ def require_external_referenced_association!
207
+ unless association_data.referenced? && association_data.external?
208
+ raise ArgumentError.new("Expected referenced external association: '#{association_name}'")
97
209
  end
98
210
  end
99
211
  end
@@ -1,8 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  # Controller mixin for accessing a root ViewModel which can be accessed
4
- # individually by a parent model. Enabled by calling `nested_in :parent, as:
5
- # :child` on the viewmodel controller
4
+ # individually by a parent model.
6
5
 
7
6
  # Contributes the following routes:
8
7
  # POST /parents/:parent_id/child #create_associated -- deserialize (possibly existing) child, replacing existing child
@@ -28,6 +27,10 @@ module ViewModel::ActiveRecord::SingularNestedController
28
27
  write_association(serialize_context: serialize_context, deserialize_context: deserialize_context, lock_owner: lock_owner, &block)
29
28
  end
30
29
 
30
+ def create_associated_bulk(serialize_context: new_serialize_context, deserialize_context: new_deserialize_context, &block)
31
+ write_association_bulk(serialize_context: serialize_context, deserialize_context: deserialize_context, &block)
32
+ end
33
+
31
34
  def destroy_associated(serialize_context: new_serialize_context, deserialize_context: new_deserialize_context, lock_owner: nil)
32
35
  destroy_association(false, serialize_context: serialize_context, deserialize_context: deserialize_context, lock_owner: lock_owner)
33
36
  end
@@ -35,14 +35,9 @@ class ViewModel::ActiveRecord < ViewModel::Record
35
35
 
36
36
  class << self
37
37
  attr_reader :_list_attribute_name
38
- attr_accessor :synthetic
39
38
 
40
39
  delegate :transaction, to: :model_class
41
40
 
42
- def should_register?
43
- super && !synthetic
44
- end
45
-
46
41
  # Specifies that the model backing this viewmodel is a member of an
47
42
  # `acts_as_manual_list` collection.
48
43
  def acts_as_list(attr = :position)
@@ -368,6 +363,52 @@ class ViewModel::ActiveRecord < ViewModel::Record
368
363
  end
369
364
  end
370
365
 
366
+ # Rails 6.1 introduced "previously_new_record?", but this library still
367
+ # supports activerecord >= 5.0. This is an approximation.
368
+ def self.model_previously_new?(model)
369
+ if (id_changes = model.saved_change_to_id)
370
+ old_id, _new_id = id_changes
371
+ return true if old_id.nil?
372
+ end
373
+ false
374
+ end
375
+
376
+ # Helper to return entities that were part of the last deserialization. The
377
+ # interface is complex due to the data requirements, and the implementation is
378
+ # inefficient.
379
+ #
380
+ # Intended to be used by replace_associated style methods which may touch very
381
+ # large collections that must not be returned fully. Since the collection is
382
+ # not being returned, order is also ignored.
383
+ def _read_association_touched(association_name, touched_ids:)
384
+ association_data = self.class._association_data(association_name)
385
+
386
+ associated = model.public_send(association_data.direct_reflection.name)
387
+ return nil if associated.nil?
388
+
389
+ case
390
+ when association_data.through?
391
+ # associated here are join-table models; we need to get the far side out
392
+ associated.map do |through_model|
393
+ model = through_model.public_send(association_data.indirect_reflection.name)
394
+
395
+ next unless self.class.model_previously_new?(through_model) || touched_ids.include?(model.id)
396
+
397
+ association_data.viewmodel_class_for_model!(model.class).new(model)
398
+ end.reject(&:nil?)
399
+ when association_data.collection?
400
+ associated.map do |model|
401
+ next unless self.class.model_previously_new?(model) || touched_ids.include?(model.id)
402
+
403
+ association_data.viewmodel_class_for_model!(model.class).new(model)
404
+ end.reject(&:nil?)
405
+ else
406
+ # singleton always touched by definition
407
+ model = associated
408
+ association_data.viewmodel_class_for_model!(model.class).new(model)
409
+ end
410
+ end
411
+
371
412
  def _serialize_association(association_name, json, serialize_context:)
372
413
  associated = self.public_send(association_name)
373
414
  association_data = self.class._association_data(association_name)
@@ -181,7 +181,7 @@ module ViewModel::Callbacks
181
181
  # ARVM synthetic views are considered part of their association and as such
182
182
  # are not visited by callbacks. Eligibility exclusion is intended to be
183
183
  # library-internal: subclasses should not attempt to extend this.
184
- view.is_a?(ViewModel::ActiveRecord) && view.class.synthetic
184
+ view.is_a?(ViewModel) && view.class.synthetic
185
185
  end
186
186
 
187
187
  def self.wrap_serialize(viewmodel, context:)