iknow_view_models 3.2.0 → 3.2.5

data/test/unit/view_model/active_record/controller_test.rb

@@ -1,14 +1,14 @@
-# -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
-require "minitest/autorun"
+require 'minitest/autorun'
 require 'minitest/unit'
 require 'minitest/hooks'
 
-require "view_model"
-require "view_model/active_record"
+require 'view_model'
+require 'view_model/active_record'
 
-require_relative "../../../helpers/controller_test_helpers.rb"
-require_relative "../../../helpers/callback_tracer.rb"
+require_relative '../../../helpers/controller_test_helpers'
+require_relative '../../../helpers/callback_tracer'
 
 class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   include ARVMTestUtilities
@@ -88,7 +88,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
     super
     @parent = Parent.create(name: 'p',
                             children: [Child.new(name: 'c1', position: 1.0),
-                                       Child.new(name: 'c2', position: 2.0)],
+                                       Child.new(name: 'c2', position: 2.0),],
                             label: Label.new,
                             target: Target.new)
 
@@ -98,7 +98,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   end
 
   def test_show
-    parentcontroller = ParentController.new(id: @parent.id)
+    parentcontroller = ParentController.new(params: { id: @parent.id })
     parentcontroller.invoke(:show)
 
     assert_equal({ 'data' => @parent_view.to_hash },
@@ -110,7 +110,10 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   end
 
   def test_migrated_show
-    parentcontroller = ParentController.new(id: @parent.id, versions: { ParentView.view_name => 1 })
+    parentcontroller = ParentController.new(
+      params: { id: @parent.id },
+      headers: { 'X-ViewModel-Versions' => { ParentView.view_name => 1 }.to_json })
+
     parentcontroller.invoke(:show)
 
     expected_view = @parent_view.to_hash
@@ -127,8 +130,20 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
     assert_all_hooks_nested_inside_parent_hook(parentcontroller.hook_trace)
   end
 
+  def test_invalid_migration_header
+    parentcontroller = ParentController.new(
+      params: { id: @parent.id },
+      headers: { 'X-ViewModel-Versions' => 'not a json' })
+
+    parentcontroller.invoke(:show)
+    assert_equal(400, parentcontroller.status)
+    assert_match(/Invalid JSON/i,
+                 parentcontroller.hash_response['error']['detail'],
+                 'json error propagated')
+  end
+
   def test_index
-    p2      = Parent.create(name: "p2")
+    p2      = Parent.create(name: 'p2')
     p2_view = ParentView.new(p2)
 
     parentcontroller = ParentController.new
@@ -137,7 +152,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
     assert_equal(200, parentcontroller.status)
 
     assert_equal(parentcontroller.hash_response,
-                 { "data" => [@parent_view.to_hash, p2_view.to_hash] })
+                 { 'data' => [@parent_view.to_hash, p2_view.to_hash] })
 
     assert_all_hooks_nested_inside_parent_hook(parentcontroller.hook_trace)
   end
@@ -149,10 +164,10 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
         'label'    => { '_type' => 'Label', 'text' => 'l' },
         'target'   => { '_type' => 'Target', 'text' => 't' },
         'children' => [{ '_type' => 'Child', 'name' => 'c1' },
-                       { '_type' => 'Child', 'name' => 'c2' }]
+                       { '_type' => 'Child', 'name' => 'c2' },],
     }
 
-    parentcontroller = ParentController.new(data: data)
+    parentcontroller = ParentController.new(params: { data: data })
     parentcontroller.invoke(:create)
 
     assert_equal(200, parentcontroller.status)
@@ -173,7 +188,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
       'old_name' => 'p2',
     }
 
-    parentcontroller = ParentController.new(data: data, versions: { ParentView.view_name => 1 })
+    parentcontroller = ParentController.new(params: { data: data, versions: { ParentView.view_name => 1 } })
     parentcontroller.invoke(:create)
 
     assert_equal(200, parentcontroller.status)
@@ -183,14 +198,14 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   end
 
   def test_create_empty
-    parentcontroller = ParentController.new(data: [])
+    parentcontroller = ParentController.new(params: { data: [] })
     parentcontroller.invoke(:create)
 
     assert_equal(400, parentcontroller.status)
   end
 
   def test_create_invalid
-    parentcontroller = ParentController.new(data: 42)
+    parentcontroller = ParentController.new(params: { data: 42 })
     parentcontroller.invoke(:create)
 
     assert_equal(400, parentcontroller.status)
@@ -201,7 +216,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
              '_type' => 'Parent',
              'name'  => 'new' }
 
-    parentcontroller = ParentController.new(id: @parent.id, data: data)
+    parentcontroller = ParentController.new(params: { id: @parent.id, data: data })
     parentcontroller.invoke(:create)
 
     assert_equal(200, parentcontroller.status)
@@ -216,7 +231,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   end
 
   def test_destroy
-    parentcontroller = ParentController.new(id: @parent.id)
+    parentcontroller = ParentController.new(params: { id: @parent.id })
     parentcontroller.invoke(:destroy)
 
     assert_equal(200, parentcontroller.status)
@@ -230,7 +245,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   end
 
   def test_show_missing
-    parentcontroller = ParentController.new(id: 9999)
+    parentcontroller = ParentController.new(params: { id: 9999 })
     parentcontroller.invoke(:show)
 
     assert_equal(404, parentcontroller.status)
@@ -240,10 +255,10 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
                      'status' => 404,
                      'detail' => "Couldn't find Parent(s) with id(s)=[9999]",
                      'title' => nil,
-                     'code'   => "DeserializationError.NotFound",
-                     'meta' => { 'nodes' => [{ '_type' => "Parent", 'id' => 9999 }]},
+                     'code' => 'DeserializationError.NotFound',
+                     'meta' => { 'nodes' => [{ '_type' => 'Parent', 'id' => 9999 }] },
                      'exception' => nil,
-                     'causes' => nil }},
+                     'causes' => nil } },
                  parentcontroller.hash_response)
   end
 
@@ -252,7 +267,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
              'children' => [{ '_type' => 'Child',
                               'age'   => 42 }] }
 
-    parentcontroller = ParentController.new(data: data)
+    parentcontroller = ParentController.new(params: { data: data })
     parentcontroller.invoke(:create)
 
     assert_equal({ 'error' => {
@@ -261,13 +276,13 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
                      'status' => 400,
                      'detail' => 'Validation failed: \'age\' must be less than 42',
                      'title' => nil,
-                     'code'   => "DeserializationError.Validation",
-                     'meta' => { 'nodes' => [{ '_type' => "Child", 'id' => nil }],
+                     'code' => 'DeserializationError.Validation',
+                     'meta' => { 'nodes' => [{ '_type' => 'Child', 'id' => nil }],
                                  'attribute' => 'age',
                                  'message' => 'must be less than 42',
-                                 'details' => { 'error' => 'less_than', 'value' => 42, 'count' => 42 }},
+                                 'details' => { 'error' => 'less_than', 'value' => 42, 'count' => 42 } },
                      'exception' => nil,
-                     'causes' => nil }},
+                     'causes' => nil } },
                  parentcontroller.hash_response)
   end
 
@@ -275,17 +290,17 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
     data = { '_type'    => 'Parent',
              'children' => [{ '_type' => 'Child',
                               'age'   => 1 }] }
-    parentcontroller = ParentController.new(data: data)
+    parentcontroller = ParentController.new(params: { data: data })
     parentcontroller.invoke(:create)
 
     assert_equal(400, parentcontroller.status)
-    assert_match(%r{check constraint}i,
-                 parentcontroller.hash_response["error"]["detail"],
-                 "Database error propagated")
+    assert_match(/check constraint/i,
+                 parentcontroller.hash_response['error']['detail'],
+                 'Database error propagated')
   end
 
   def test_destroy_missing
-    parentcontroller = ParentController.new(id: 9999)
+    parentcontroller = ParentController.new(params: { id: 9999 })
     parentcontroller.invoke(:destroy)
 
     assert_equal({ 'error' => {
@@ -294,8 +309,8 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
                      'status' => 404,
                      'detail' => "Couldn't find Parent(s) with id(s)=[9999]",
                      'title' => nil,
-                     'code'   => "DeserializationError.NotFound",
-                     'meta' => { "nodes" => [{"_type" => "Parent", "id" => 9999 }] },
+                     'code' => 'DeserializationError.NotFound',
+                     'meta' => { 'nodes' => [{ '_type' => 'Parent', 'id' => 9999 }] },
                      'exception' => nil,
                      'causes' => nil } },
                  parentcontroller.hash_response)
@@ -307,7 +322,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   def test_nested_collection_index_associated
     _distractor = Parent.create(name: 'p2', children: [Child.new(name: 'c3', position: 1)])
 
-    childcontroller = ChildController.new(parent_id: @parent.id)
+    childcontroller = ChildController.new(params: { parent_id: @parent.id })
     childcontroller.invoke(:index_associated)
 
     assert_equal(200, childcontroller.status)
@@ -334,7 +349,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
 
   def test_nested_collection_append_one
     data = { '_type' => 'Child', 'name' => 'c3' }
-    childcontroller = ChildController.new(parent_id: @parent.id, data: data)
+    childcontroller = ChildController.new(params: { parent_id: @parent.id, data: data })
 
     childcontroller.invoke(:append)
 
@@ -342,7 +357,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
 
     @parent.reload
 
-    assert_equal(%w{c1 c2 c3}, @parent.children.order(:position).pluck(:name))
+    assert_equal(%w[c1 c2 c3], @parent.children.order(:position).pluck(:name))
     assert_equal({ 'data' => ChildView.new(@parent.children.last).to_hash },
                  childcontroller.hash_response)
 
@@ -351,17 +366,17 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
 
   def test_nested_collection_append_many
     data = [{ '_type' => 'Child', 'name' => 'c3' },
-            { '_type' => 'Child', 'name' => 'c4' }]
+            { '_type' => 'Child', 'name' => 'c4' },]
 
-    childcontroller = ChildController.new(parent_id: @parent.id, data: data)
+    childcontroller = ChildController.new(params: { parent_id: @parent.id, data: data })
     childcontroller.invoke(:append)
 
     assert_equal(200, childcontroller.status, childcontroller.hash_response)
 
     @parent.reload
 
-    assert_equal(%w{c1 c2 c3 c4}, @parent.children.order(:position).pluck(:name))
-    new_children_hashes = @parent.children.last(2).map{ |c| ChildView.new(c).to_hash }
+    assert_equal(%w[c1 c2 c3 c4], @parent.children.order(:position).pluck(:name))
+    new_children_hashes = @parent.children.last(2).map { |c| ChildView.new(c).to_hash }
     assert_equal({ 'data' => new_children_hashes },
                  childcontroller.hash_response)
 
@@ -373,25 +388,25 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
     # Parent.children
     old_children = @parent.children
 
-    data = [{'_type' => 'Child', 'name' => 'newc1'},
-            {'_type' => 'Child', 'name' => 'newc2'}]
+    data = [{ '_type' => 'Child', 'name' => 'newc1' },
+            { '_type' => 'Child', 'name' => 'newc2' },]
 
-    childcontroller = ChildController.new(parent_id: @parent.id, data: data)
+    childcontroller = ChildController.new(params: { parent_id: @parent.id, data: data })
     childcontroller.invoke(:replace)
 
     assert_equal(200, childcontroller.status, childcontroller.hash_response)
 
     @parent.reload
 
-    assert_equal(%w{newc1 newc2}, @parent.children.order(:position).pluck(:name))
+    assert_equal(%w[newc1 newc2], @parent.children.order(:position).pluck(:name))
     assert_predicate(Child.where(id: old_children.map(&:id)), :empty?)
 
     assert_all_hooks_nested_inside_parent_hook(childcontroller.hook_trace)
   end
 
   def test_nested_collection_replace_bad_data
-    data = [{ "name" => "nc" }]
-    childcontroller = ChildController.new(parent_id: @parent.id, data: data)
+    data = [{ 'name' => 'nc' }]
+    childcontroller = ChildController.new(params: { parent_id: @parent.id, data: data })
 
     childcontroller.invoke(:replace)
 
@@ -402,14 +417,14 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
 
   def test_nested_collection_disassociate_one
     old_child = @parent.children.first
-    childcontroller = ChildController.new(parent_id: @parent.id, id: old_child.id)
+    childcontroller = ChildController.new(params: { parent_id: @parent.id, id: old_child.id })
     childcontroller.invoke(:disassociate)
 
     assert_equal(200, childcontroller.status, childcontroller.hash_response)
 
     @parent.reload
 
-    assert_equal(%w{c2}, @parent.children.order(:position).pluck(:name))
+    assert_equal(%w[c2], @parent.children.order(:position).pluck(:name))
     assert_predicate(Child.where(id: old_child.id), :empty?)
 
     assert_all_hooks_nested_inside_parent_hook(childcontroller.hook_trace)
@@ -418,7 +433,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   def test_nested_collection_disassociate_many
     old_children = @parent.children
 
-    childcontroller = ChildController.new(parent_id: @parent.id)
+    childcontroller = ChildController.new(params: { parent_id: @parent.id })
     childcontroller.invoke(:disassociate_all)
 
     assert_equal(200, childcontroller.status, childcontroller.hash_response)
@@ -434,14 +449,14 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   # direct methods on nested controller
   def test_nested_collection_destroy
     old_child = @parent.children.first
-    childcontroller = ChildController.new(id: old_child.id)
+    childcontroller = ChildController.new(params: { id: old_child.id })
     childcontroller.invoke(:destroy)
 
     assert_equal(200, childcontroller.status, childcontroller.hash_response)
 
     @parent.reload
 
-    assert_equal(%w{c2}, @parent.children.order(:position).pluck(:name))
+    assert_equal(%w[c2], @parent.children.order(:position).pluck(:name))
     assert_predicate(Child.where(id: old_child.id), :empty?)
   end
 
@@ -452,7 +467,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
              '_type' => 'Child',
              'name' => 'new_name' }
 
-    childcontroller = ChildController.new(data: data)
+    childcontroller = ChildController.new(params: { data: data })
     childcontroller.invoke(:create)
 
     assert_equal(200, childcontroller.status, childcontroller.hash_response)
@@ -464,26 +479,25 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
                  childcontroller.hash_response)
   end
 
-   def test_nested_collection_show
+  def test_nested_collection_show
     old_child = @parent.children.first
 
-    childcontroller = ChildController.new(id: old_child.id)
+    childcontroller = ChildController.new(params: { id: old_child.id })
     childcontroller.invoke(:show)
 
     assert_equal({ 'data' => ChildView.new(old_child).to_hash },
                  childcontroller.hash_response)
 
     assert_equal(200, childcontroller.status)
-   end
-
+  end
 
   ## Single association
 
   def test_nested_singular_replace_from_parent
     old_label = @parent.label
 
-    data = {'_type' => 'Label', 'text' => 'new label'}
-    labelcontroller = LabelController.new(parent_id: @parent.id, data: data)
+    data = { '_type' => 'Label', 'text' => 'new label' }
+    labelcontroller = LabelController.new(params: { parent_id: @parent.id, data: data })
     labelcontroller.invoke(:create_associated)
 
     assert_equal(200, labelcontroller.status, labelcontroller.hash_response)
@@ -505,7 +519,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   def test_nested_singular_show_from_parent
     old_label = @parent.label
 
-    labelcontroller = LabelController.new(parent_id: @parent.id)
+    labelcontroller = LabelController.new(params: { parent_id: @parent.id })
     labelcontroller.invoke(:show_associated)
 
     assert_equal(200, labelcontroller.status, labelcontroller.hash_response)
@@ -519,7 +533,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   def test_nested_singular_destroy_from_parent
     old_label = @parent.label
 
-    labelcontroller = LabelController.new(parent_id: @parent.id)
+    labelcontroller = LabelController.new(params: { parent_id: @parent.id })
     labelcontroller.invoke(:destroy_associated)
 
     @parent.reload
@@ -536,8 +550,8 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   def test_nested_singular_update_from_parent
     old_label = @parent.label
 
-    data = {'_type' => 'Label', 'id' => old_label.id, 'text' => 'new label'}
-    labelcontroller = LabelController.new(parent_id: @parent.id, data: data)
+    data = { '_type' => 'Label', 'id' => old_label.id, 'text' => 'new label' }
+    labelcontroller = LabelController.new(params: { parent_id: @parent.id, data: data })
     labelcontroller.invoke(:create_associated)
 
     assert_equal(200, labelcontroller.status, labelcontroller.hash_response)
@@ -554,7 +568,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   def test_nested_singular_show_from_id
     old_label = @parent.label
 
-    labelcontroller = LabelController.new(id: old_label.id)
+    labelcontroller = LabelController.new(params: { id: old_label.id })
     labelcontroller.invoke(:show)
 
     assert_equal(200, labelcontroller.status, labelcontroller.hash_response)
@@ -568,7 +582,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
     # foreign key violation. Destroy target instead.
     old_target = @parent.target
 
-    targetcontroller = TargetController.new(id: old_target.id)
+    targetcontroller = TargetController.new(params: { id: old_target.id })
     targetcontroller.invoke(:destroy)
 
     @parent.reload
@@ -583,8 +597,8 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   def test_nested_singular_update
     old_label = @parent.label
 
-    data = {'_type' => 'Label', 'id' => old_label.id, 'text' => 'new label'}
-    labelcontroller = LabelController.new(data: data)
+    data = { '_type' => 'Label', 'id' => old_label.id, 'text' => 'new label' }
+    labelcontroller = LabelController.new(params: { data: data })
     labelcontroller.invoke(:create)
 
     assert_equal(200, labelcontroller.status, labelcontroller.hash_response)

data/test/unit/view_model/active_record/counter_test.rb

@@ -1,9 +1,11 @@
-require_relative "../../../helpers/arvm_test_utilities.rb"
-require_relative "../../../helpers/arvm_test_models.rb"
+# frozen_string_literal: true
 
-require "minitest/autorun"
+require_relative '../../../helpers/arvm_test_utilities'
+require_relative '../../../helpers/arvm_test_models'
 
-require "view_model/active_record"
+require 'minitest/autorun'
+
+require 'view_model/active_record'
 
 class ViewModel::ActiveRecord::CounterTest < ActiveSupport::TestCase
   include ARVMTestUtilities
@@ -40,7 +42,6 @@ class ViewModel::ActiveRecord::CounterTest < ActiveSupport::TestCase
         attribute :name
       end
     end
-
   end
 
   def setup
@@ -50,15 +51,15 @@ class ViewModel::ActiveRecord::CounterTest < ActiveSupport::TestCase
   end
 
   def test_counter_cache_create
-    alter_by_view!(CategoryView, @category1) do |view, refs|
-      view['products'] << {'_type' => 'Product'}
+    alter_by_view!(CategoryView, @category1) do |view, _refs|
+      view['products'] << { '_type' => 'Product' }
     end
     assert_equal(2, @category1.products_count)
   end
 
   def test_counter_cache_move
     @category2 = Category.create(name: 'c2')
-    alter_by_view!(CategoryView, [@category1, @category2]) do |(c1view, c2view), refs|
+    alter_by_view!(CategoryView, [@category1, @category2]) do |(c1view, c2view), _refs|
       c2view['products'] = c1view['products']
       c1view['products'] = []
     end
@@ -67,7 +68,7 @@ class ViewModel::ActiveRecord::CounterTest < ActiveSupport::TestCase
   end
 
   def test_counter_cache_delete
-    alter_by_view!(CategoryView, @category1) do |view, refs|
+    alter_by_view!(CategoryView, @category1) do |view, _refs|
       view['products'] = []
     end
     assert_equal(0, @category1.products_count)