iknow_view_models 3.11.0 → 3.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40eb8cc78ae998113eac37ef9cd944ecefc1c4b0a71a492944ac88ff2bfa4077
-  data.tar.gz: cb7d430a809687598e365e54a0312e97fc6ee1938cfdd1c4f9f1bd924e8364a5
+  metadata.gz: 38a806928f1c5c2d76aadb5970b72abeabb5f579bde7164ba0b90de9ed6781ea
+  data.tar.gz: fa7c33062381a8414be49bc82b87bc938f5bdad278f10f55cb5b64aa0115eb4f
 SHA512:
-  metadata.gz: dd1c4215f6e9bafaf68c618d4ba59541089016d4dcea45ab90892489cc6ada0183f95a6d07ae88899fc54d5a9bf37a3619e70bc62c54ed9c5b9de57eeec5f37f
-  data.tar.gz: e1cd93bf28d4ad96ac347effeb96d9bbbd6a1ec9a09944091d8127555b1c22ca2e97bfa7f5ce670f86cf42647b06d3e1da13a842935eb0bd39e44c303af666ab
+  metadata.gz: 9c1b31614c56224a94331c75ff2e44080acda5d92aced69ab0e73dbc2fece60e710ae2e066f69fdf42f0726cd1c80ab7ec762ed24cac36e1343f54f4584bff60
+  data.tar.gz: fd9b38a254a62fbc67cbe2a0c668e8e3a49ca2474df4a39bf9f1344e60076aaefb8ea01d7e5196a1408a1bfaa2ab3f1f2ec624ea050bca16098b89e78ed3d919

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.11.0'
+  VERSION = '3.12.1'
 end

data/lib/view_model/active_record/update_data.rb

@@ -522,6 +522,10 @@ class ViewModel::ActiveRecord
 
     delegate :new?, :child_update?, :auto_child_update?, to: :metadata
 
+    def reference_only?
+      attributes.empty? && associations.empty? && referenced_associations.empty?
+    end
+
     def self.parse_hashes(root_subtree_hashes, referenced_subtree_hashes = {})
       valid_reference_keys = referenced_subtree_hashes.keys.to_set
 

data/lib/view_model/active_record/update_operation.rb

@@ -44,6 +44,10 @@ class ViewModel::ActiveRecord
       @built
     end
 
+    def reference_only?
+      update_data.reference_only? && reparent_to.nil? && reposition_to.nil?
+    end
+
     # Evaluate a built update tree, applying and saving changes to the models.
     def run!(deserialize_context:)
       raise ViewModel::DeserializationError::Internal.new('Internal error: UpdateOperation run before build') unless built?
@@ -123,9 +127,14 @@ class ViewModel::ActiveRecord
             end
           end
 
-          # validate
-          deserialize_context.run_callback(ViewModel::Callbacks::Hook::BeforeValidate, viewmodel)
-          viewmodel.validate!
+          # If a request makes no assertions about the model, we don't demand
+          # that the current state of the model is valid. This permits making
+          # edits to other models that refer to this model when this model is
+          # invalid.
+          unless reference_only? && !viewmodel.new_model?
+            deserialize_context.run_callback(ViewModel::Callbacks::Hook::BeforeValidate, viewmodel)
+            viewmodel.validate!
+          end
 
           # Save if the model has been altered. Covers not only models with
           # view changes but also lock version assertions.

data/lib/view_model/active_record.rb

@@ -291,6 +291,8 @@ class ViewModel::ActiveRecord < ViewModel::Record
         hook_control.record_changes(changes)
         model.destroy!
       end
+    rescue ::ActiveRecord::StatementInvalid, ::ActiveRecord::InvalidForeignKey, ::ActiveRecord::RecordNotSaved => e
+      raise ViewModel::DeserializationError::DatabaseConstraint.from_exception(e, self.blame_reference)
     end
   end
 

data/lib/view_model/migration.rb

@@ -5,8 +5,18 @@ class ViewModel::Migration
   require 'view_model/migration/one_way_error'
   require 'view_model/migration/unspecified_version_error'
 
+  REFERENCE_ONLY_KEYS = [
+    ViewModel::TYPE_ATTRIBUTE,
+    ViewModel::ID_ATTRIBUTE,
+    ViewModel::VERSION_ATTRIBUTE,
+  ].freeze
+
   def up(view, _references)
-    raise ViewModel::Migration::OneWayError.new(view[ViewModel::TYPE_ATTRIBUTE], :up)
+    # Only a reference-only view may be (trivially) migrated up without an
+    # explicit migration.
+    if (view.keys - REFERENCE_ONLY_KEYS).present?
+      raise ViewModel::Migration::OneWayError.new(view[ViewModel::TYPE_ATTRIBUTE], :up)
+    end
   end
 
   def down(view, _references)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.11.0
+  version: 3.12.1
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-07-19 00:00:00.000000000 Z
+date: 2024-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack