iknow_view_models 3.10.1 → 3.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 417eb3615156fa48cf438ead03e2ea33e323c5baa7d411b1e0fafcea5050acb1
-  data.tar.gz: cdede3ad865389a0d006725819595aec6da1ea417e9d061452ef3198a39af3d8
+  metadata.gz: 07b80f46184b9f84a29e63b4f26c65b9cf7e7b7fa0a6390365e66c92cbac0325
+  data.tar.gz: 240963485ad8192d341ad3ce40a5d360052a69055036bf3ca64fb76d2f176c36
 SHA512:
-  metadata.gz: ada26778b54ffb60a825d408fe40f05c8a4aa93cbac7b5519b2338b5afb4cadfda0d1eb7b359b65584f88fbb9cadea4a35a7d2ba0aad9fb8e4d8ec9d5f894e03
-  data.tar.gz: b70d2b42d4a599c3d284dbb96c4506c8ff7b6104108ebcb7126c554fcd671eb0bad04dc4df5a1006f76af272a71c5ca46f54736bf4961821dd7f22160d46fada
+  metadata.gz: 0ddaba32ebd18303eba6f2e91db5ca44368c538bba771c6572afa4a3b4d7e17efd69ef6bfb274218b2f1fcf73812a8bb62704aa60065c3e45900428eff91e231
+  data.tar.gz: 7b482657ab857da0848f7880caf8a67a08ecbf132b3495d2117ea89642270525db95bf92fe26160ff0bc9450d3b514e94ca2ef77252f47a0ae6f04934a49efd0

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.10.1'
+  VERSION = '3.12.0'
 end

data/lib/view_model/active_record/controller.rb

@@ -56,9 +56,14 @@ module ViewModel::ActiveRecord::Controller
   end
 
   def destroy(serialize_context: new_serialize_context, deserialize_context: new_deserialize_context)
+    viewmodel_ids = parse_param(
+      :id, with: IknowParams::Serializer::ArrayOf.new(ViewmodelIdSerializer, allow_singleton: true))
+
     viewmodel_class.transaction do
-      view = viewmodel_class.find(viewmodel_id, eager_include: false)
-      view.destroy!(deserialize_context: deserialize_context)
+      views = viewmodel_class.find(viewmodel_ids, eager_include: false)
+      views.each do |view|
+        view.destroy!(deserialize_context: deserialize_context)
+      end
     end
     render_viewmodel(nil)
   end
@@ -91,8 +96,28 @@ module ViewModel::ActiveRecord::Controller
 
   private
 
+  # Viewmodel ids are permitted to be either integers or strings
+  class ViewmodelIdSerializer < IknowParams::Serializer
+    def initialize
+      super(::Object)
+    end
+
+    def load(val)
+      case val
+      when ::Integer, ::String
+        val
+      else
+        raise IknowParams::Serializer::LoadError.new(
+                "Incorrect type for #{self.class.name}: #{val.inspect}:#{val.class.name}")
+      end
+    end
+
+    set_singleton!
+    json_value!
+  end
+
   def viewmodel_id
-    parse_param(:id)
+    parse_param(:id, with: ViewmodelIdSerializer)
   end
 
   def migrated_deep_schema_version

data/lib/view_model/active_record/controller_base.rb

@@ -156,11 +156,13 @@ module ActionDispatch
                   name_route = { as: '' } # Only one route may take the name
                   post('', action: :create, **name_route.extract!(:as)) unless except.include?(:create) || !add_shallow_routes
                   get('',  action: :index,  **name_route.extract!(:as)) unless except.include?(:index)  || !add_shallow_routes
+                  delete('', action: :destroy, as: :bulk_delete) unless except.include?(:destroy) || !add_shallow_routes
                 end
               end
             else
               collection do
                 get('', action: :index, as: '') unless except.include?(:index)
+                delete('', action: :destroy, as: :bulk_delete) unless except.include?(:destroy)
               end
             end
           end

data/lib/view_model/active_record/update_data.rb

@@ -522,6 +522,10 @@ class ViewModel::ActiveRecord
 
     delegate :new?, :child_update?, :auto_child_update?, to: :metadata
 
+    def reference_only?
+      attributes.empty? && associations.empty? && referenced_associations.empty?
+    end
+
     def self.parse_hashes(root_subtree_hashes, referenced_subtree_hashes = {})
       valid_reference_keys = referenced_subtree_hashes.keys.to_set
 

data/lib/view_model/active_record/update_operation.rb

@@ -44,6 +44,10 @@ class ViewModel::ActiveRecord
       @built
     end
 
+    def reference_only?
+      update_data.reference_only? && reparent_to.nil? && reposition_to.nil?
+    end
+
     # Evaluate a built update tree, applying and saving changes to the models.
     def run!(deserialize_context:)
       raise ViewModel::DeserializationError::Internal.new('Internal error: UpdateOperation run before build') unless built?
@@ -123,9 +127,14 @@ class ViewModel::ActiveRecord
             end
           end
 
-          # validate
-          deserialize_context.run_callback(ViewModel::Callbacks::Hook::BeforeValidate, viewmodel)
-          viewmodel.validate!
+          # If a request makes no assertions about the model, we don't demand
+          # that the current state of the model is valid. This permits making
+          # edits to other models that refer to this model when this model is
+          # invalid.
+          unless reference_only? && !viewmodel.new_model?
+            deserialize_context.run_callback(ViewModel::Callbacks::Hook::BeforeValidate, viewmodel)
+            viewmodel.validate!
+          end
 
           # Save if the model has been altered. Covers not only models with
           # view changes but also lock version assertions.

data/lib/view_model/migration.rb

@@ -5,8 +5,18 @@ class ViewModel::Migration
   require 'view_model/migration/one_way_error'
   require 'view_model/migration/unspecified_version_error'
 
+  REFERENCE_ONLY_KEYS = [
+    ViewModel::TYPE_ATTRIBUTE,
+    ViewModel::ID_ATTRIBUTE,
+    ViewModel::VERSION_ATTRIBUTE,
+  ].freeze
+
   def up(view, _references)
-    raise ViewModel::Migration::OneWayError.new(view[ViewModel::TYPE_ATTRIBUTE], :up)
+    # Only a reference-only view may be (trivially) migrated up without an
+    # explicit migration.
+    if (view.keys - REFERENCE_ONLY_KEYS).present?
+      raise ViewModel::Migration::OneWayError.new(view[ViewModel::TYPE_ATTRIBUTE], :up)
+    end
   end
 
   def down(view, _references)

data/test/unit/view_model/active_record/controller_test.rb

@@ -167,6 +167,22 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   end
 
   def test_destroy
+    other_parent = make_parent
+    parentcontroller = ParentController.new(params: { id: [@parent.id, other_parent.id] })
+    parentcontroller.invoke(:destroy)
+
+    assert_equal(200, parentcontroller.status)
+
+    assert(Parent.where(id: @parent.id).blank?, "record doesn't exist after delete")
+    assert(Parent.where(id: other_parent.id).blank?, "record doesn't exist after delete")
+
+    assert_equal({ 'data' => nil },
+                 parentcontroller.hash_response)
+
+    assert_all_hooks_nested_inside_parent_hook(parentcontroller.hook_trace)
+  end
+
+  def test_batch_destroy
     parentcontroller = ParentController.new(params: { id: @parent.id })
     parentcontroller.invoke(:destroy)
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.10.1
+  version: 3.12.0
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-05-24 00:00:00.000000000 Z
+date: 2024-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack