iknow_view_models 3.0.3 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e468d13031e18589144a941463c993e5f10bf4588ef0b69f412fa7498f54a339
-  data.tar.gz: 6366dfda3ef8869fcab34111394fb4c35f10f1e469b2c800dc02ff2bd83e3542
+  metadata.gz: f9459a78038ecf77ab3855e7e4ea6a0899ac31fd3e7dd05be247d9e0b72284f3
+  data.tar.gz: 34d662ae8733173dd3372ef9af5cd68b133848e1a94e5b1250624ec50dd4b0eb
 SHA512:
-  metadata.gz: 82cf736f4fd3d28a88a565c9c9d3bb2952804846429c4a3487f6594e9d42fee24345441de65195932923adcdda9c3d17e584baff74f060b7eb925f68be3f8b23
-  data.tar.gz: 951ca783e17c738a7ca742aaaa5e8cd7342d526a59ea3ee4726b130f8e55add82ff50ec431cf7c27997354ea0987e82b1c929268771aa146792f7cff8329bf87
+  metadata.gz: 7841f336c7f1604e3b2dbd54fb7209be02ecae7d19100707bef4ecc9b9ef2ae4d741f74d205fe468ac7ce9f14bd359d1b67b3ec1b76507ea9b51f812d0375972
+  data.tar.gz: 6b7aaa8742bdb52afa77c37be699da4c4896ab25a1bb560e5b404506e4f97730dad6659c062ff1443bdb2f21ff120e205b888d3d742b372d9306062a515c8ad4

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.0.3'
+  VERSION = '3.1.0'
 end

data/lib/view_model/active_record/cache/cacheable_view.rb

@@ -12,7 +12,17 @@ module ViewModel::ActiveRecord::Cache::CacheableView
   CacheClearer = Struct.new(:cache, :id) do
     include ViewModel::AfterTransactionRunner
 
-    def after_transaction
+    # It's important that we clear the cache before committing, because we rely
+    # on database locking to prevent cache race conditions. We require
+    # reading/refreshing the cache to obtain a FOR SHARE lock, which means that
+    # a reader must wait for a concurrent writer to commit before continuing to
+    # the cache. If the writer cleared the cache after commit, the reader could
+    # obtain old data before the clear, and then save the old data after it.
+    def before_commit
+      cache.delete(id)
+    end
+
+    def after_rollback
       cache.delete(id)
     end
 

data/lib/view_model/after_transaction_runner.rb

@@ -4,16 +4,31 @@
 # `add_to_transaction`, the abstract method `after_transaction` will be invoked
 # by AR's callbacks.
 module ViewModel::AfterTransactionRunner
-  def committed!(*); end
+  # Rails' internal API
+  def committed!(*)
+    after_commit
+  end
 
   def before_committed!
-    after_transaction
+    before_commit
   end
 
   def rolledback!(*)
-    after_transaction
+    after_rollback
+  end
+
+  def trigger_transactional_callbacks?
+    true
   end
 
+  # Our simplified API
+
+  def before_commit; end
+
+  def after_commit; end
+
+  def after_rollback; end
+
   def add_to_transaction
     if connection.transaction_open?
       connection.add_transaction_record(self)
@@ -22,9 +37,6 @@ module ViewModel::AfterTransactionRunner
     end
   end
 
-  def trigger_transactional_callbacks?
-    true
-  end
 
   # Override to tie to a specific connection.
   def connection

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iknow_view_models
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.1.0
 platform: ruby
 authors:
 - iKnow Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-29 00:00:00.000000000 Z
+date: 2019-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord