iiif-presentation 1.4.2 → 1.5.0

data/spec/unit/iiif/presentation/layer_spec.rb

@@ -1,38 +1,34 @@
 describe IIIF::Presentation::Layer do
-
   let(:fixed_values) do
     {
-      '@context' => 'http://iiif.io/api/presentation/2/context.json',
-      '@id' => 'http://www.example.org/iiif/book1/layer/transcription',
-      '@type' => 'sc:Layer',
-      'label' => 'Diplomatic Transcription',
-      'otherContent' => [
-        'http://www.example.org/iiif/book1/list/l1',
-        'http://www.example.org/iiif/book1/list/l2',
-        'http://www.example.org/iiif/book1/list/l3',
-        'http://www.example.org/iiif/book1/list/l4'
+      "@context" => "http://iiif.io/api/presentation/2/context.json",
+      "@id" => "http://www.example.org/iiif/book1/layer/transcription",
+      "@type" => "sc:Layer",
+      "label" => "Diplomatic Transcription",
+      "otherContent" => [
+        "http://www.example.org/iiif/book1/list/l1",
+        "http://www.example.org/iiif/book1/list/l2",
+        "http://www.example.org/iiif/book1/list/l3",
+        "http://www.example.org/iiif/book1/list/l4"
       ]
     }
   end
 
-
-  describe '#initialize' do
-    it 'sets @type' do
-      expect(subject['@type']).to eq 'sc:Layer'
+  describe "#initialize" do
+    it "sets @type" do
+      expect(subject["@type"]).to eq "sc:Layer"
     end
   end
 
   describe "#{described_class}.define_methods_for_string_only_keys" do
-    it_behaves_like 'it has the appropriate methods for string-only keys'
+    it_behaves_like "it has the appropriate methods for string-only keys"
   end
-  
+
   describe "#{described_class}.define_methods_for_array_only_keys" do
-    it_behaves_like 'it has the appropriate methods for array-only keys'
+    it_behaves_like "it has the appropriate methods for array-only keys"
   end
 
   describe "#{described_class}.define_methods_for_any_type_keys" do
-    it_behaves_like 'it has the appropriate methods for any-type keys'
+    it_behaves_like "it has the appropriate methods for any-type keys"
   end
-
 end
-

data/spec/unit/iiif/presentation/manifest_spec.rb

@@ -1,89 +1,86 @@
 describe IIIF::Presentation::Manifest do
-
   let(:subclass_subject) do
     Class.new(IIIF::Presentation::Manifest) do
-      def initialize(hsh={})
-        hsh = { '@type' => 'a:SubClass' }
-        super(hsh)
+      def initialize(_hsh = {})
+        super({"@type" => "a:SubClass"})
       end
     end
   end
 
   let(:fixed_values) do
     {
-      'type' => 'a:SubClass',
-      'id' => 'http://example.com/prefix/manifest/123',
-      'context' => IIIF::Presentation::CONTEXT,
-      'label' => {'en' => ['Book 1']},
-      'description' => 'A longer description of this example book. It should give some real information.',
-      'thumbnail' => {
-        '@id' => 'http://www.example.org/images/book1-page1/full/80,100/0/default.jpg',
-        'service'=> {
-          '@context' => 'http://iiif.io/api/image/2/context.json',
-          '@id' => 'http://www.example.org/images/book1-page1',
-          'profile' => 'http://iiif.io/api/image/2/level1.json'
+      "type" => "a:SubClass",
+      "id" => "http://example.com/prefix/manifest/123",
+      "context" => IIIF::Presentation::CONTEXT,
+      "label" => {"en" => ["Book 1"]},
+      "description" => "A longer description of this example book. It should give some real information.",
+      "thumbnail" => {
+        "@id" => "http://www.example.org/images/book1-page1/full/80,100/0/default.jpg",
+        "service" => {
+          "@context" => "http://iiif.io/api/image/2/context.json",
+          "@id" => "http://www.example.org/images/book1-page1",
+          "profile" => "http://iiif.io/api/image/2/level1.json"
         }
       },
-      'attribution' => 'Provided by Example Organization',
-      'license' => 'http://www.example.org/license.html',
-      'logo' => 'http://www.example.org/logos/institution1.jpg',
-      'see_also' => 'http://www.example.org/library/catalog/book1.xml',
-      'service' => {
-        '@context' => 'http://example.org/ns/jsonld/context.json',
-        '@id' =>  'http://example.org/service/example',
-        'profile' => 'http://example.org/docs/example-service.html'
+      "attribution" => "Provided by Example Organization",
+      "license" => "http://www.example.org/license.html",
+      "logo" => "http://www.example.org/logos/institution1.jpg",
+      "see_also" => "http://www.example.org/library/catalog/book1.xml",
+      "service" => {
+        "@context" => "http://example.org/ns/jsonld/context.json",
+        "@id" => "http://example.org/service/example",
+        "profile" => "http://example.org/docs/example-service.html"
       },
-      'related' => {
-        '@id' => 'http://www.example.org/videos/video-book1.mpg',
-        'format' => 'video/mpeg'
+      "related" => {
+        "@id" => "http://www.example.org/videos/video-book1.mpg",
+        "format" => "video/mpeg"
       },
-      'within' => 'http://www.example.org/collections/books/',
+      "within" => "http://www.example.org/collections/books/"
     }
   end
 
-  describe '#initialize' do
-    it 'sets @type to sc:Manifest by default' do
-      expect(subject['@type']).to eq 'sc:Manifest'
+  describe "#initialize" do
+    it "sets @type to sc:Manifest by default" do
+      expect(subject["@type"]).to eq "sc:Manifest"
     end
-    it 'allows subclasses to override @type' do
+    it "allows subclasses to override @type" do
       sub = subclass_subject.new
-      expect(sub['@type']).to eq 'a:SubClass'
+      expect(sub["@type"]).to eq "a:SubClass"
     end
   end
 
-  describe '#required_keys' do
-    it 'accumulates' do
-      expect(subject.required_keys).to eq %w{ @type @id label }
+  describe "#required_keys" do
+    it "accumulates" do
+      expect(subject.required_keys).to eq %w[@type @id label]
     end
   end
 
-  describe '#validate' do
-    it 'raises an error if there is no @id' do
-      subject.label = 'Book 1'
+  describe "#validate" do
+    it "raises an error if there is no @id" do
+      subject.label = "Book 1"
       expect { subject.validate }.to raise_error IIIF::Presentation::MissingRequiredKeyError
     end
-    it 'raises an error if there is no label' do
-      subject['@id'] = 'http://www.example.org/iiif/book1/manifest'
+    it "raises an error if there is no label" do
+      subject["@id"] = "http://www.example.org/iiif/book1/manifest"
       expect { subject.validate }.to raise_error IIIF::Presentation::MissingRequiredKeyError
     end
-    it 'raises an error if there is no @type' do
-      subject.delete('@type')
-      subject.label = 'Book 1'
-      subject['@id'] = 'http://www.example.org/iiif/book1/manifest'
+    it "raises an error if there is no @type" do
+      subject.delete("@type")
+      subject.label = "Book 1"
+      subject["@id"] = "http://www.example.org/iiif/book1/manifest"
       expect { subject.validate }.to raise_error IIIF::Presentation::MissingRequiredKeyError
     end
   end
 
   describe "#{described_class}.define_methods_for_array_only_keys" do
-    it_behaves_like 'it has the appropriate methods for array-only keys'
+    it_behaves_like "it has the appropriate methods for array-only keys"
   end
 
   describe "#{described_class}.define_methods_for_string_only_keys" do
-    it_behaves_like 'it has the appropriate methods for string-only keys'
+    it_behaves_like "it has the appropriate methods for string-only keys"
   end
 
   describe "#{described_class}.define_methods_for_any_type_keys" do
-    it_behaves_like 'it has the appropriate methods for any-type keys'
+    it_behaves_like "it has the appropriate methods for any-type keys"
   end
-
 end

data/spec/unit/iiif/presentation/range_spec.rb

@@ -1,43 +1,39 @@
 describe IIIF::Presentation::Range do
-
-  let(:fixed_values) do 
+  let(:fixed_values) do
     {
-      '@id' => 'http://www.example.org/iiif/book1/range/r1',
-      '@type' => 'sc:Range',
-      'label' => 'Introduction',
-      'ranges' => [
-        'http://www.example.org/iiif/book1/range/r1-1',
-        'http://www.example.org/iiif/book1/range/r1-2'
+      "@id" => "http://www.example.org/iiif/book1/range/r1",
+      "@type" => "sc:Range",
+      "label" => "Introduction",
+      "ranges" => [
+        "http://www.example.org/iiif/book1/range/r1-1",
+        "http://www.example.org/iiif/book1/range/r1-2"
       ],
-      'canvases' => [
-        'http://www.example.org/iiif/book1/canvas/p1',
-        'http://www.example.org/iiif/book1/canvas/p2',
-        'http://www.example.org/iiif/book1/canvas/p3#xywh=0,0,750,300'
+      "canvases" => [
+        "http://www.example.org/iiif/book1/canvas/p1",
+        "http://www.example.org/iiif/book1/canvas/p2",
+        "http://www.example.org/iiif/book1/canvas/p3#xywh=0,0,750,300"
       ]
     }
   end
 
-  describe '#initialize' do
-    it 'sets @type to sc:Range by default' do
-      expect(subject['@type']).to eq 'sc:Range'
+  describe "#initialize" do
+    it "sets @type to sc:Range by default" do
+      expect(subject["@type"]).to eq "sc:Range"
     end
   end
 
   describe "#{described_class}.define_methods_for_array_only_keys" do
-    it_behaves_like 'it has the appropriate methods for array-only keys'
+    it_behaves_like "it has the appropriate methods for array-only keys"
   end
 
   describe "#{described_class}.define_methods_for_string_only_keys" do
-    it_behaves_like 'it has the appropriate methods for string-only keys'
+    it_behaves_like "it has the appropriate methods for string-only keys"
   end
 
   describe "#{described_class}.define_methods_for_any_type_keys" do
-    it_behaves_like 'it has the appropriate methods for any-type keys'
+    it_behaves_like "it has the appropriate methods for any-type keys"
   end
 
-  describe '#validate' do
+  describe "#validate" do
   end
-
 end
-
-

data/spec/unit/iiif/presentation/resource_spec.rb

@@ -1,16 +1,13 @@
 describe IIIF::Presentation::Resource do
-
   describe "#{described_class}.define_methods_for_abstract_resource_only_keys" do
-    it_behaves_like 'it has the appropriate methods for abstract_resource_only_keys'
+    it_behaves_like "it has the appropriate methods for abstract_resource_only_keys"
   end
 
   describe "#{described_class}.int_only_keys" do
-    it_behaves_like 'it has the appropriate methods for integer-only keys'
+    it_behaves_like "it has the appropriate methods for integer-only keys"
   end
 
   describe "#{described_class}.define_methods_for_string_only_keys" do
-    it_behaves_like 'it has the appropriate methods for string-only keys'
+    it_behaves_like "it has the appropriate methods for string-only keys"
   end
-
 end
-

data/spec/unit/iiif/presentation/sequence_spec.rb

@@ -1,110 +1,105 @@
 describe IIIF::Presentation::Sequence do
-
   let(:subclass_subject) do
     Class.new(IIIF::Presentation::Sequence) do
-      def initialize(hsh={})
-        hsh = { '@type' => 'a:SubClass' }
-        super(hsh)
+      def initialize(_hsh = {})
+        super({"@type" => "a:SubClass"})
       end
     end
   end
 
   let(:fixed_values) do
     {
-      '@type' => 'sc:Sequence',
-      '@id' => 'http://example.com/prefix/sequence/456',
-      '@context' => IIIF::Presentation::CONTEXT,
-      'label' => 'Book 1',
-      'description' => 'A longer description of this example book. It should give some real information.',
-      'thumbnail' => {
-        '@id' => 'http://www.example.org/images/book1-page1/full/80,100/0/default.jpg',
-        'service'=> {
-          '@context' => 'http://iiif.io/api/image/2/context.json',
-          '@id' => 'http://www.example.org/images/book1-page1',
-          'profile' => 'http://iiif.io/api/image/2/level1.json'
+      "@type" => "sc:Sequence",
+      "@id" => "http://example.com/prefix/sequence/456",
+      "@context" => IIIF::Presentation::CONTEXT,
+      "label" => "Book 1",
+      "description" => "A longer description of this example book. It should give some real information.",
+      "thumbnail" => {
+        "@id" => "http://www.example.org/images/book1-page1/full/80,100/0/default.jpg",
+        "service" => {
+          "@context" => "http://iiif.io/api/image/2/context.json",
+          "@id" => "http://www.example.org/images/book1-page1",
+          "profile" => "http://iiif.io/api/image/2/level1.json"
         }
       },
-      'attribution' => 'Provided by Example Organization',
-      'license' => 'http://www.example.org/license.html',
-      'logo' => 'http://www.example.org/logos/institution1.jpg',
-      'see_also' => 'http://www.example.org/library/catalog/book1.xml',
-      'service' => {
-        '@context' => 'http://example.org/ns/jsonld/context.json',
-        '@id' =>  'http://example.org/service/example',
-        'profile' => 'http://example.org/docs/example-service.html'
+      "attribution" => "Provided by Example Organization",
+      "license" => "http://www.example.org/license.html",
+      "logo" => "http://www.example.org/logos/institution1.jpg",
+      "see_also" => "http://www.example.org/library/catalog/book1.xml",
+      "service" => {
+        "@context" => "http://example.org/ns/jsonld/context.json",
+        "@id" => "http://example.org/service/example",
+        "profile" => "http://example.org/docs/example-service.html"
       },
-      'related' => {
-        '@id' => 'http://www.example.org/videos/video-book1.mpg',
-        'format' => 'video/mpeg'
+      "related" => {
+        "@id" => "http://www.example.org/videos/video-book1.mpg",
+        "format" => "video/mpeg"
       },
-      'within' => 'http://www.example.org/collections/books/',
+      "within" => "http://www.example.org/collections/books/",
       # Sequence
-      'metadata' => [{'label'=>'Author', 'value'=>'Anne Author'}],
-      'canvases' => [{
-        '@id' => 'http://www.example.org/iiif/book1/canvas/p1',
-        '@type' => 'sc:Canvas',
-        'label' => 'p. 1',
-        'height' => 1000,
-        'width' => 750,
-        'images'=>  []
+      "metadata" => [{"label" => "Author", "value" => "Anne Author"}],
+      "canvases" => [{
+        "@id" => "http://www.example.org/iiif/book1/canvas/p1",
+        "@type" => "sc:Canvas",
+        "label" => "p. 1",
+        "height" => 1000,
+        "width" => 750,
+        "images" => []
       }],
-      'viewing_hint' => 'paged',
-      'start_canvas' => 'http://www.example.org/iiif/book1/canvas/p2',
-      'viewing_direction' => 'right-to-left',
+      "viewing_hint" => "paged",
+      "start_canvas" => "http://www.example.org/iiif/book1/canvas/p2",
+      "viewing_direction" => "right-to-left"
     }
   end
 
-  describe '#initialize' do
-    it 'sets @type to sc:Sequence by default' do
-      expect(subject['@type']).to eq 'sc:Sequence'
+  describe "#initialize" do
+    it "sets @type to sc:Sequence by default" do
+      expect(subject["@type"]).to eq "sc:Sequence"
     end
-    it 'allows subclasses to override @type' do
+    it "allows subclasses to override @type" do
       sub = subclass_subject.new
-      expect(sub['@type']).to eq 'a:SubClass'
+      expect(sub["@type"]).to eq "a:SubClass"
     end
   end
 
-  describe '#required_keys' do
-    it 'accumulates from the superclass' do
-      expect(subject.required_keys).to eq %w{ @type }
+  describe "#required_keys" do
+    it "accumulates from the superclass" do
+      expect(subject.required_keys).to eq %w[@type]
     end
   end
 
-  describe '#string_only_keys' do
-    it 'accumulates from the superclass' do
-      expect(subject.string_only_keys).to eq %w{ viewing_hint start_canvas viewing_direction }
+  describe "#string_only_keys" do
+    it "accumulates from the superclass" do
+      expect(subject.string_only_keys).to eq %w[viewing_hint start_canvas viewing_direction]
     end
   end
 
-  describe '#array_only_keys' do
-    it 'accumulates from the superclass' do
-      expect(subject.array_only_keys).to eq %w{ metadata canvases }
+  describe "#array_only_keys" do
+    it "accumulates from the superclass" do
+      expect(subject.array_only_keys).to eq %w[metadata canvases]
     end
   end
 
   describe "#{described_class}.define_methods_for_array_only_keys" do
-    it_behaves_like 'it has the appropriate methods for array-only keys'
+    it_behaves_like "it has the appropriate methods for array-only keys"
   end
 
   describe "#{described_class}.define_methods_for_string_only_keys" do
-    it_behaves_like 'it has the appropriate methods for string-only keys'
+    it_behaves_like "it has the appropriate methods for string-only keys"
   end
 
   describe "#{described_class}.define_methods_for_any_type_keys" do
-    it_behaves_like 'it has the appropriate methods for any-type keys'
+    it_behaves_like "it has the appropriate methods for any-type keys"
   end
 
-  describe '#validate' do
-    it 'raises an error if viewing_hint isn\'t an allowable value' do
-      subject['viewing_hint'] = 'foo'
+  describe "#validate" do
+    it "raises an error if viewing_hint isn't an allowable value" do
+      subject["viewing_hint"] = "foo"
       expect { subject.validate }.to raise_error IIIF::Presentation::IllegalValueError
     end
-    it 'raises an error if viewing_directon isn\'t an allowable value' do
-      subject['viewing_direction'] = 'foo-to-bar'
+    it "raises an error if viewing_directon isn't an allowable value" do
+      subject["viewing_direction"] = "foo-to-bar"
       expect { subject.validate }.to raise_error IIIF::Presentation::IllegalValueError
     end
   end
-
-
 end
-

data/spec/unit/iiif/presentation/shared_examples/abstract_resource_only_keys.rb

@@ -1,9 +1,5 @@
-require 'set'
-
-shared_examples 'it has the appropriate methods for abstract_resource_only_keys' do
-
+shared_examples "it has the appropriate methods for abstract_resource_only_keys" do
   described_class.new.abstract_resource_only_keys.each do |entry|
-
     describe "#{entry[:key]}=" do
       it "sets #{entry[:key]}" do
         @ex = entry[:type].new
@@ -19,11 +15,11 @@ shared_examples 'it has the appropriate methods for abstract_resource_only_keys'
       end
       it "raises an exception when attempting to set it to something other than an #{entry[:type]}" do
         e = IIIF::Presentation::IllegalValueError
-        expect { subject.send("#{entry[:key]}=", 'Foo') }.to raise_error e
+        expect { subject.send("#{entry[:key]}=", "Foo") }.to raise_error e
       end
     end
 
-    describe "#{entry[:key]}" do
+    describe entry[:key].to_s do
       it "gets #{entry[:key]}" do
         @ex = entry[:type].new
         subject[entry[:key]] = @ex
@@ -33,11 +29,9 @@ shared_examples 'it has the appropriate methods for abstract_resource_only_keys'
         it "is aliased as ##{entry[:key].camelize(:lower)}" do
           @ex = entry[:type].new
           subject[entry[:key]] = @ex
-          expect(subject.send("#{entry[:key].camelize(:lower)}")).to eq @ex
+          expect(subject.send(entry[:key].camelize(:lower).to_s)).to eq @ex
         end
       end
     end
-
   end
-
 end

data/spec/unit/iiif/presentation/shared_examples/any_type_keys.rb

@@ -1,7 +1,4 @@
-require 'set'
-
-shared_examples 'it has the appropriate methods for any-type keys' do
-
+shared_examples "it has the appropriate methods for any-type keys" do
   described_class.new.any_type_keys.each do |prop|
     describe "##{prop}=" do
       it "sets self['#{prop}']" do
@@ -18,16 +15,15 @@ shared_examples 'it has the appropriate methods for any-type keys' do
 
     describe "##{prop}" do
       it "gets self[#{prop}]" do
-        subject.send("[]=", prop, fixed_values[prop])
-        expect(subject.send("#{prop}")).to eq fixed_values[prop]
+        subject.send(:[]=, prop, fixed_values[prop])
+        expect(subject.send(prop.to_s)).to eq fixed_values[prop]
       end
       if prop.camelize(:lower) != prop
         it "is aliased as ##{prop.camelize(:lower)}" do
-          subject.send("[]=", prop, fixed_values[prop])
-          expect(subject.send("#{prop.camelize(:lower)}")).to eq fixed_values[prop]
+          subject.send(:[]=, prop, fixed_values[prop])
+          expect(subject.send(prop.camelize(:lower).to_s)).to eq fixed_values[prop]
         end
       end
     end
   end
-
 end

data/spec/unit/iiif/presentation/shared_examples/array_only_keys.rb

@@ -1,44 +1,36 @@
-require 'set'
-
-shared_examples 'it has the appropriate methods for array-only keys' do
-
+shared_examples "it has the appropriate methods for array-only keys" do
   described_class.new.array_only_keys.each do |prop|
-
     describe "#{prop}=" do
       it "sets #{prop}" do
-        ex = [{'label' => 'XYZ'}]
+        ex = [{"label" => "XYZ"}]
         subject.send("#{prop}=", ex)
         expect(subject[prop]).to eq ex
       end
       if prop.camelize(:lower) != prop
         it "is aliased as ##{prop.camelize(:lower)}=" do
-          ex = [{'label' => 'XYZ'}]
+          ex = [{"label" => "XYZ"}]
           subject.send("#{prop.camelize(:lower)}=", ex)
           expect(subject[prop]).to eq ex
         end
       end
-      it 'raises an exception when attempting to set it to something other than an Array' do
-        expect { subject.send("#{prop}=", 'Foo') }.to raise_error IIIF::Presentation::IllegalValueError
+      it "raises an exception when attempting to set it to something other than an Array" do
+        expect { subject.send("#{prop}=", "Foo") }.to raise_error IIIF::Presentation::IllegalValueError
       end
     end
 
-    describe "#{prop}" do
+    describe prop.to_s do
       it "gets #{prop}" do
-        ex = [{'label' => 'XYZ'}]
+        ex = [{"label" => "XYZ"}]
         subject[prop] = ex
         expect(subject.send(prop)).to eq ex
       end
       if prop.camelize(:lower) != prop
         it "is aliased as ##{prop.camelize(:lower)}" do
-          ex = [{'label' => 'XYZ'}]
+          ex = [{"label" => "XYZ"}]
           subject[prop] = ex
-          expect(subject.send("#{prop.camelize(:lower)}")).to eq ex
+          expect(subject.send(prop.camelize(:lower).to_s)).to eq ex
         end
       end
     end
-
   end
-
 end
-
-

data/spec/unit/iiif/presentation/shared_examples/int_only_keys.rb

@@ -1,9 +1,5 @@
-require 'set'
-
-shared_examples 'it has the appropriate methods for integer-only keys' do
-
+shared_examples "it has the appropriate methods for integer-only keys" do
   described_class.new.int_only_keys.each do |prop|
-
     describe "#{prop}=" do
       before(:all) do
         @ex = 7200
@@ -18,15 +14,15 @@ shared_examples 'it has the appropriate methods for integer-only keys' do
           expect(subject[prop]).to eq @ex
         end
       end
-      it 'raises an exception when attempting to set it to something other than an Integer' do
-        expect { subject.send("#{prop}=", 'Foo') }.to raise_error IIIF::Presentation::IllegalValueError
+      it "raises an exception when attempting to set it to something other than an Integer" do
+        expect { subject.send("#{prop}=", "Foo") }.to raise_error IIIF::Presentation::IllegalValueError
       end
-      it 'raises an exception when attempting to set it to a negative number' do
+      it "raises an exception when attempting to set it to a negative number" do
         expect { subject.send("#{prop}=", -1) }.to raise_error IIIF::Presentation::IllegalValueError
       end
     end
 
-    describe "#{prop}" do
+    describe prop.to_s do
       before(:all) do
         @ex = 7200
       end
@@ -37,13 +33,9 @@ shared_examples 'it has the appropriate methods for integer-only keys' do
       if prop.camelize(:lower) != prop
         it "is aliased as ##{prop.camelize(:lower)}" do
           subject[prop] = @ex
-          expect(subject.send("#{prop.camelize(:lower)}")).to eq @ex
+          expect(subject.send(prop.camelize(:lower).to_s)).to eq @ex
         end
       end
     end
-
   end
-
 end
-
-