ignored_columns_tasks 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5766d5af94e72067164ba02354d848710b42fc85aabb19b0a4805fc9a0d5fa2f
-  data.tar.gz: c21503fa1b197220802644e8a697bec55fb454b3d059084a8c12120c4418843f
+  metadata.gz: 17d755fcd6106bbb60881de1e5f4099fca52a81af2fe4bb91506f9d4d17e17a0
+  data.tar.gz: b7c234d546bed73d91286f6d6e75e974f79f224f979e7aa15320f9875a6147ae
 SHA512:
-  metadata.gz: 02e85c9e24669d726ba4bfb78ae04162ebe04ef9540c706ec1f710f2ba591cc050e0bf737675bbedfae763852c93d1c37ed0f76f8011c241728d76540eb9a051
-  data.tar.gz: 6f09ed53de2d8439bba4befa933ccaa979d0492f6028980ea8682b936da004f8550e681f0d9b70c5743ded6ea829cdf8df3218db23175ebbdffd7cd1f902c5b1
+  metadata.gz: efb6c72515f5bd6a97db79eb19fb3965b2e76d753e434c3a83bbba1c735b77d554e14602c6eaa82e942195ca825bccfb55a2fb61479a2f22114d8e48ec777ae1
+  data.tar.gz: 50ab666a8657cf2f72dc11032b37798dbd7d62c688b1f3311a6bc509b12a5d15b79ac9bd8e703a5803f3215b76bdf5d88c02040e6b15b78cfbb424d5738b7834

data/Changes

@@ -1,3 +1,7 @@
+2023-07-30  v0.1.1
+--------------------
+- If Strong Migrations are installed generate migration with safety_assured block
+
 2023-07-29  v0.1.0
 --------------------
 - Change IGNORED_COLUMNS_SKIP_COLUMNS env var to IGNORED_COLUMNS_TASKS_SKIP_COLUMNS

data/README.md

@@ -44,6 +44,11 @@ This task can also be limited to a single model by setting the `MODEL` environme
 ./bin/rails ignored_columns:migration MODEL=User
 ```
 
+#### Strong Migrations
+
+If your project uses [Strong Migrations](https://github.com/ankane/strong_migrations) the `remove_column` call
+will be wrapped in a `safety_assured` block.
+
 ### Ignored Columns That Have Been Dropped From Your Database
 
 This will print ignored columns that no longer exist the database:

data/lib/ignored_columns_tasks/version.rb

@@ -1,3 +1,3 @@
 module IgnoredColumnsTasks
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/ignored_columns_tasks.rb

@@ -72,12 +72,15 @@ module IgnoredColumnsTasks
         return
       end
 
+      migrations = []
       to_drop.group_by(&:klass).each do |klass, columns|
-        migration = "remove_ignored_columns_from_#{klass.table_name}"
+        migrations << "remove_ignored_columns_from_#{klass.table_name}"
 
         # Assume Rails does the shell quoting on Column#name?
-        Rails::Generators.invoke("active_record:migration", [migration, columns.map(&:name)])
+        Rails::Generators.invoke("active_record:migration", [migrations[-1], columns.map(&:name)])
       end
+
+      apply_strong_migrations(migrations) if defined?(StrongMigrations)
     end
 
     private
@@ -114,6 +117,26 @@ module IgnoredColumnsTasks
         ignored.map { |column| Column.new(class_with_all, column, class_with_all.columns_hash[column]) }
       end
     end
+
+    def apply_strong_migrations(migrations)
+      migrations.each do |migration|
+        # Better way to do this? There should only be 1 since db:migrate will fail if suffix exists.
+        path = Dir[ Rails.root.join("db/migrate") / "*_#{migration}.rb" ][0]
+        # If we can't find it could be due to migration generator failing. How to tell? $? and return value not reliable
+        next unless path
+
+        add_safety_assured(path)
+      end
+    end
+
+    def add_safety_assured(path)
+      migration = File.read(path)
+      return if migration =~ /\wsafety_assured\s/
+
+      migration.gsub!(/^(\s*)(remove_column.+)(\s*)$/) { "#$1safety_assured { #$2 }#$3" }
+
+      File.write(path, migration)
+    end
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ignored_columns_tasks
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Skye Shaw
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-07-30 00:00:00.000000000 Z
+date: 2023-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler