ignored_columns_tasks 0.0.1 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad7e03cc537a362226785d3937b5e7642eb97720cfa6353272e2b691738bc9f4
-  data.tar.gz: 2c3e07d772548bc75f0051c23ca0290ec3ead2c37a55999ad1a67f610d92fa3c
+  metadata.gz: 17d755fcd6106bbb60881de1e5f4099fca52a81af2fe4bb91506f9d4d17e17a0
+  data.tar.gz: b7c234d546bed73d91286f6d6e75e974f79f224f979e7aa15320f9875a6147ae
 SHA512:
-  metadata.gz: 06756504d577020eb1611ab1f361418ca5d90cca980a592b6c7a8f4fa9fdcecd803c91164925b9699e7c3254c5146829b39540d2d515e8bead5738d0f99ebd06
-  data.tar.gz: 39099157082e6e3f5aafc4e7768c4d126197b4e6bab7d5f4be87281dccd285c22e5f92525652d84a33d900ee84dee45b3cba16c5b53f116cfb124b47d37b4704
+  metadata.gz: efb6c72515f5bd6a97db79eb19fb3965b2e76d753e434c3a83bbba1c735b77d554e14602c6eaa82e942195ca825bccfb55a2fb61479a2f22114d8e48ec777ae1
+  data.tar.gz: 50ab666a8657cf2f72dc11032b37798dbd7d62c688b1f3311a6bc509b12a5d15b79ac9bd8e703a5803f3215b76bdf5d88c02040e6b15b78cfbb424d5738b7834

data/Changes

@@ -0,0 +1,7 @@
+2023-07-30  v0.1.1
+--------------------
+- If Strong Migrations are installed generate migration with safety_assured block
+
+2023-07-29  v0.1.0
+--------------------
+- Change IGNORED_COLUMNS_SKIP_COLUMNS env var to IGNORED_COLUMNS_TASKS_SKIP_COLUMNS

data/README.md

@@ -32,18 +32,23 @@ If you have ignored columns that must not be dropped add them to the `SKIP_COLUM
 ```
 
 You can set this once for your project instead of specifying it every time.
-In this case it is recommended to use the `IGNORED_COLUMNS_SKIP_COLUMNS` environment variable.
+In this case it is recommended to use the `IGNORED_COLUMNS_TASKS_SKIP_COLUMNS` environment variable:
 
 ```sh
-export IGNORED_COLUMNS_SKIP_COLUMNS="some_column,another_column"
+export IGNORED_COLUMNS_TASKS_SKIP_COLUMNS="some_column,another_column"
 ```
 
-This task can also be limited to a single model via the `MODEL` environment variable:
+This task can also be limited to a single model by setting the `MODEL` environment variable:
 
 ```
 ./bin/rails ignored_columns:migration MODEL=User
 ```
 
+#### Strong Migrations
+
+If your project uses [Strong Migrations](https://github.com/ankane/strong_migrations) the `remove_column` call
+will be wrapped in a `safety_assured` block.
+
 ### Ignored Columns That Have Been Dropped From Your Database
 
 This will print ignored columns that no longer exist the database:

data/ignored_columns_tasks.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/sshaw/ignored_columns_tasks"
-  # spec.metadata["changelog_uri"] = "TODO: Put your gem's CHANGELOG.md URL here."
+  spec.metadata["changelog_uri"] = "https://github.com/sshaw/ignored_columns_tasks/blob/master/Changes"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.

data/lib/ignored_columns_tasks/tasks/ignored_columns.rake

@@ -9,9 +9,9 @@ namespace :ignored_columns do
   def skip_columns
     skip = nil
 
-    # IGNORED_COLUMNS_SKIP_COLUMNS is our global, namespaced verison
+    # IGNORED_COLUMNS_TASKS_SKIP_COLUMNS is our global, namespaced version
     # SKIP_COLUMNS is shorter, command-line argument
-    %w[IGNORED_COLUMNS_SKIP_COLUMNS SKIP_COLUMNS].each do |name|
+    %w[IGNORED_COLUMNS_TASKS_SKIP_COLUMNS SKIP_COLUMNS].each do |name|
       if ENV[name]
         skip ||= []
         skip.concat(ENV[name].split(/\s*,\s/))

data/lib/ignored_columns_tasks/version.rb

@@ -1,3 +1,3 @@
 module IgnoredColumnsTasks
-  VERSION = "0.0.1"
+  VERSION = "0.1.1"
 end

data/lib/ignored_columns_tasks.rb

@@ -72,12 +72,15 @@ module IgnoredColumnsTasks
         return
       end
 
+      migrations = []
       to_drop.group_by(&:klass).each do |klass, columns|
-        migration = "remove_ignored_columns_from_#{klass.table_name}"
+        migrations << "remove_ignored_columns_from_#{klass.table_name}"
 
         # Assume Rails does the shell quoting on Column#name?
-        Rails::Generators.invoke("active_record:migration", [migration, columns.map(&:name)])
+        Rails::Generators.invoke("active_record:migration", [migrations[-1], columns.map(&:name)])
       end
+
+      apply_strong_migrations(migrations) if defined?(StrongMigrations)
     end
 
     private
@@ -114,6 +117,26 @@ module IgnoredColumnsTasks
         ignored.map { |column| Column.new(class_with_all, column, class_with_all.columns_hash[column]) }
       end
     end
+
+    def apply_strong_migrations(migrations)
+      migrations.each do |migration|
+        # Better way to do this? There should only be 1 since db:migrate will fail if suffix exists.
+        path = Dir[ Rails.root.join("db/migrate") / "*_#{migration}.rb" ][0]
+        # If we can't find it could be due to migration generator failing. How to tell? $? and return value not reliable
+        next unless path
+
+        add_safety_assured(path)
+      end
+    end
+
+    def add_safety_assured(path)
+      migration = File.read(path)
+      return if migration =~ /\wsafety_assured\s/
+
+      migration.gsub!(/^(\s*)(remove_column.+)(\s*)$/) { "#$1safety_assured { #$2 }#$3" }
+
+      File.write(path, migration)
+    end
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ignored_columns_tasks
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.1
 platform: ruby
 authors:
 - Skye Shaw
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-07-29 00:00:00.000000000 Z
+date: 2023-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -47,6 +47,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- Changes
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -64,6 +65,7 @@ licenses:
 metadata:
   homepage_uri: https://github.com/sshaw/ignored_columns_tasks
   source_code_uri: https://github.com/sshaw/ignored_columns_tasks
+  changelog_uri: https://github.com/sshaw/ignored_columns_tasks/blob/master/Changes
 post_install_message: 
 rdoc_options: []
 require_paths: