ig_markets 0.7 → 0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fe408c4f3b1493d7da7574265ceab99d931d8685
-  data.tar.gz: b21bbe2f50cb5a5bedbd92b718fea4afc02462b5
+  metadata.gz: 905ebb175a410a5b6a86f1b92c215745e642e04b
+  data.tar.gz: 6bb5b7d2360c936c46c2380002a15f632b853b63
 SHA512:
-  metadata.gz: 8ff8f42c43576533bd8c44de769f5bb43f725857294c9edce1ab8a45716704c2551eeddb0eb8307345cbfa292a0b1aacb53e45129a3b7ce4c317534ab81dd14c
-  data.tar.gz: d7a8011e786e30d2cd5a75de50edf5b129ab73ddc4d037fb6f22e18ec00a783adbd7276035326752f7a42fe2f7dad93a78dd0f77c11dcd5b6f772bd146d6ece2
+  metadata.gz: 0abc1a40d8fb0c4ef98835c40cf525c129ea5623dc23cff94792034431d2109ce164dbbea6d1097fef176b599c3ae823d88d9aa1bb78f330a7a10ce919239aa9
+  data.tar.gz: e0a4e9984d8eb1286ef8e92547512ec1cafb94fbdfc14bb152ffba9f9ff41072d8475b54805da3e1db7191bbf7b41ee958dc1f37e0e73ced7642e6a1f945cbb8

data/CHANGELOG.md

@@ -1,6 +1,13 @@
 # IG Markets Changelog
 
-### 0.7 — 1 May, 2016
+### 0.8 — April 30, 2016
+
+- The `ig_markets` prices command now takes `--from` and `--to` arguments accurate to one second
+- Fixed incomplete data being returned by `IGMarkets::DealingPlatform::AccountMethods#activities` and
+  `IGMarkets::DealingPlatform::AccountMethods#transactions`
+- Fixed errors calling `IGMarkets::DealingPlatform#instantiate_models` for models that have deprecated attributes
+
+### 0.7 — April 30, 2016
 
 - Added `ig_markets console` command which logs in then opens a live Ruby console
 - Merged `IGMarkets::DealingPlatform::AccountMethods#activities_in_date_range` and
@@ -44,7 +51,7 @@
 - Added `IGMarkets::Position#close_level`
 - Removed `IGMarkets::Position#formatted_size` and `IGMarkets::Transaction#formatted_transaction_type`
 
-### 0.4 — April 18, 2016
+### 0.4 — April 17, 2016
 
 - Added `create`, `update` and `delete` subcommands to `ig_markets orders`
 - Added `create`, `update` and `close` subcommands to `ig_markets positions`

data/lib/ig_markets/cli/commands/prices_command.rb

@@ -5,14 +5,14 @@ module IGMarkets
       desc 'prices', 'Prints historical prices for a market'
 
       option :epic, required: true, desc: 'The EPIC of the market to print historical prices for'
-      option :resolution, enum: %w(minute minute-2 minute-3 minute-5 minute-10 minute-15 minute-30 hour hour-2 hour-3
-                                   hour-4 day week month), required: true, desc: 'The price resolution'
+      option :resolution, enum: %w(second minute minute-2 minute-3 minute-5 minute-10 minute-15 minute-30 hour hour-2
+                                   hour-3 hour-4 day week month), required: true, desc: 'The price resolution'
       option :number, type: :numeric, desc: 'The number of historical prices to return, if this is specified then ' \
-                                            '--start-date and --end-date are ignored, otherwise they are required'
-      option :start_date, desc: 'The start of the period to return prices for, required unless --number is specified' \
-                                ', format: yyyy-mm-ddThh:mm(+|-)zz:zz'
-      option :end_date, desc: 'The end of the period to return prices for, required unless --number is specified' \
-                              ', format: yyyy-mm-ddThh:mm(+|-)zz:zz'
+                                            '--from and --to are ignored, otherwise they are required'
+      option :from, desc: 'The start of the period to return prices for, required unless --number is specified, ' \
+                          'format: yyyy-mm-ddThh:mm:ss(+|-)zz:zz'
+      option :to, desc: 'The end of the period to return prices for, required unless --number is specified, ' \
+                        'format: yyyy-mm-ddThh:mm:ss(+|-)zz:zz'
 
       def prices
         self.class.begin_session(options) do |dealing_platform|
@@ -43,24 +43,25 @@ END
 
         if options[:number]
           historical_price_result_from_number market
-        elsif options[:start_date] && options[:end_date]
+        elsif options[:from] && options[:to]
           historical_price_result_from_date_range market
         else
-          raise ArgumentError, 'specify --number or both --start-date and --end-date'
+          raise ArgumentError, 'specify --number or both --from and --to'
         end
       end
 
       def historical_price_result_from_number(market)
-        market.historical_prices resolution: resolution, max: options[:number]
+        market.historical_prices resolution: resolution, number: options[:number]
       end
 
       def historical_price_result_from_date_range(market)
-        filtered = self.class.filter_options options, [:start_date, :end_date]
+        filtered = self.class.filter_options options, [:from, :to]
 
-        self.class.parse_date_time filtered, :start_date, Time, '%FT%R%z', 'yyyy-mm-ddThh:mm(+|-)zz:zz'
-        self.class.parse_date_time filtered, :end_date, Time, '%FT%R%z', 'yyyy-mm-ddThh:mm(+|-)zz:zz'
+        [:from, :to].each do |attribute|
+          self.class.parse_date_time filtered, attribute, Time, '%FT%T%z', 'yyyy-mm-ddThh:mm:ss(+|-)zz:zz'
+        end
 
-        market.historical_prices resolution: resolution, from: filtered[:start_date], to: filtered[:end_date]
+        market.historical_prices resolution: resolution, from: filtered[:from], to: filtered[:to]
       end
     end
   end

data/lib/ig_markets/dealing_platform/account_methods.rb

@@ -79,6 +79,7 @@ module IGMarkets
         options[:maxSpanSeconds] = (options.delete(:days).to_f * 24 * 60 * 60).to_i if options.key? :days
         options[:from] = options[:from].strftime('%F') if options.key? :from
         options[:to] = options[:to].strftime('%F') if options.key? :to
+        options[:pageSize] = 0
       end
     end
   end

data/lib/ig_markets/model.rb

@@ -68,11 +68,14 @@ module IGMarkets
       # @return [Hash] A hash containing details of all attributes that have been defined on this model.
       attr_accessor :defined_attributes
 
+      # @return [Hash] The names of the deprecated attributes on this model.
+      attr_accessor :deprecated_attributes
+
       # Returns the names of all currently defined attributes for this model.
       #
       # @return [Array<Symbol>]
       def defined_attribute_names
-        (defined_attributes || {}).keys
+        Hash(defined_attributes).keys
       end
 
       # Returns the type of the specified attribute.
@@ -81,7 +84,9 @@ module IGMarkets
       #
       # @return The type of the specified attribute.
       def attribute_type(attribute_name)
-        defined_attributes.fetch(attribute_name).fetch :type
+        return NilClass if Array(deprecated_attributes).include? attribute_name
+
+        Hash(defined_attributes).fetch(attribute_name).fetch :type
       end
 
       # Returns the array of allowed values for the specified attribute that was passed to {attribute}.
@@ -90,7 +95,7 @@ module IGMarkets
       #
       # @return [Array]
       def allowed_values(attribute_name)
-        defined_attributes.fetch(attribute_name).fetch :allowed_values
+        Hash(defined_attributes).fetch(attribute_name).fetch :allowed_values
       end
 
       # Defines setter and getter methods for a new attribute on this class.
@@ -118,11 +123,17 @@ module IGMarkets
       end
 
       # Defines a no-op setter method for each of the passed attribute names. This is used to silently allow deprecated
-      # attributes to be set on the model but not have them be otherwise part of the model's structure.
+      # attributes to be set on the model but not have them be part of the model's structure.
+      #
+      # @param [Array<Symbol>] names The names of the deprecated attributes.
+      #
+      # @return [void]
       def deprecated_attribute(*names)
         names.each do |name|
           define_method "#{name}=" do |_value|
           end
+
+          (self.deprecated_attributes ||= []) << name
         end
       end
 

data/lib/ig_markets/version.rb

@@ -1,4 +1,4 @@
 module IGMarkets
   # The version of this gem.
-  VERSION = '0.7'.freeze
+  VERSION = '0.8'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ig_markets
 version: !ruby/object:Gem::Version
-  version: '0.7'
+  version: '0.8'
 platform: ruby
 authors:
 - Richard Viney