ig_markets 0.33 → 0.35

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de92f7363906f7bb64fe6d258c8975cb4b506f6b029e888122038a6677911394
-  data.tar.gz: 90abc4b017ba8b6a107917b9fdf0573f713d2330cd31e57fd6a1e0426fc2694f
+  metadata.gz: 04e98ad7849a63ce3005fd84aa7ae03a9ff3f560efbcc302ba2b68cecbef4023
+  data.tar.gz: 91df31e0fe72ff4ab68384191e59b70a7456d09ab164d73fae0321d6bac53d0b
 SHA512:
-  metadata.gz: dd929726e98a24eb65e9c293e2e86348ab51db440cf878cf4e9f9778ff930de22b66ddcafc8d43b6b485a61415aa207adac9ca9dea5062af67f77ff91cda7eaa
-  data.tar.gz: 220263722e82b7dd44c8aca7a5e1821e61481454ee997b7506599d398ea4ca65926204f1e6cb4521758865bdfdd48bbbf41f6ddb4fdc2342e2def9e07694c503
+  metadata.gz: fd774702efad7e59a4e724b2dfc826bb11fdb8f1c6e1d9ac8197a14af0d28f3fd3be0d8658f0a4fd5f09b468898b9743e131e50befe3442eab6441c57eccf909
+  data.tar.gz: 31404cd38fc63edac4f4d35e3afeb21778e9a1f125f510096ad53e7b3d6bea86d9c36fe3d4a69e4a7457967d00b3f166dec3f74e883d274f0b22f96ee64e8acd

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # IG Markets Changelog
 
+### 0.35 — March 26, 2023
+
+- Updated supported Ruby version range to 2.7 - 3.2.
+- Updated dependency versions.
+
+### 0.34 — April 29, 2020
+
+- Updated supported Ruby version range to 2.5 - 2.7.
+- Updated dependency versions.
+- Switched from Travis CI to GitHub Actions.
+- Removed CodeClimate.
+
 ### 0.33 — December 30, 2017
 
 - Added `DealingPlatform::ClientSentimentMethods#find` for retrieving multiple client sentiments in one request

data/LICENSE.md

@@ -1,7 +1,7 @@
 The MIT License (MIT)
 =====================
 
-Copyright © 2015-2017 Richard Viney
+Copyright © 2015-2020 Richard Viney
 
 Permission is hereby granted, free of charge, to any person
 obtaining a copy of this software and associated documentation

data/README.md

@@ -1,10 +1,7 @@
 # Ruby IG Markets Dealing Platform Gem
 
 [![Gem][gem-badge]][gem-link]
-[![Build Status][travis-ci-badge]][travis-ci-link]
-[![Test Coverage][test-coverage-badge]][test-coverage-link]
-[![Code Climate][code-climate-badge]][code-climate-link]
-[![Dependencies][dependencies-badge]][dependencies-link]
+[![Build Status][ci-badge]][ci-link]
 [![Documentation][documentation-badge]][documentation-link]
 [![License][license-badge]][license-link]
 
@@ -168,7 +165,7 @@ ig_markets console --verbose
 
 #### Documentation
 
-API documentation is available [here](http://www.rubydoc.info/github/richard-viney/ig_markets/master).
+API documentation is available [here](http://www.rubydoc.info/github/richard-viney/ig_markets/main).
 
 #### Examples
 
@@ -268,15 +265,9 @@ Gem created by Richard Viney. All contributions welcome.
 
 [gem-link]: https://rubygems.org/gems/ig_markets
 [gem-badge]: https://badge.fury.io/rb/ig_markets.svg
-[travis-ci-link]: http://travis-ci.org/richard-viney/ig_markets
-[travis-ci-badge]: https://travis-ci.org/richard-viney/ig_markets.svg?branch=master
-[test-coverage-link]: https://codeclimate.com/github/richard-viney/ig_markets/coverage
-[test-coverage-badge]: https://codeclimate.com/github/richard-viney/ig_markets/badges/coverage.svg
-[code-climate-link]: https://codeclimate.com/github/richard-viney/ig_markets
-[code-climate-badge]: https://codeclimate.com/github/richard-viney/ig_markets/badges/gpa.svg
-[dependencies-link]: https://gemnasium.com/richard-viney/ig_markets
-[dependencies-badge]: https://gemnasium.com/richard-viney/ig_markets.svg
-[documentation-link]: https://inch-ci.org/github/richard-viney/ig_markets
-[documentation-badge]: https://inch-ci.org/github/richard-viney/ig_markets.svg?branch=master
-[license-link]: https://github.com/richard-viney/ig_markets/blob/master/LICENSE.md
+[ci-link]: https://github.com/richard-viney/ig_markets/actions
+[ci-badge]: https://github.com/richard-viney/ig_markets/workflows/ci/badge.svg?branch=main
+[documentation-link]: https://inch-ci.org/github/richard-viney/ig_markets?branch=main
+[documentation-badge]: https://inch-ci.org/github/richard-viney/ig_markets.svg?branch=main
+[license-link]: https://github.com/richard-viney/ig_markets/blob/main/LICENSE.md
 [license-badge]: https://img.shields.io/badge/license-MIT-blue.svg

data/lib/ig_markets/boolean.rb

@@ -1,5 +1,5 @@
 module IGMarkets
   # Placeholder class for specifying a boolean type.
-  class Boolean
+  class Boolean # rubocop:disable Lint/EmptyClass
   end
 end

data/lib/ig_markets/cli/commands/console_command.rb

@@ -8,7 +8,7 @@ module IGMarkets
         self.class.begin_session(options) do |dealing_platform|
           ig = dealing_platform
 
-          pry binding
+          pry binding # rubocop:disable Lint/Debugger
         end
       end
     end

data/lib/ig_markets/cli/commands/performance_command.rb

@@ -25,7 +25,7 @@ module IGMarkets
 
       def gather_performances(dealing_platform)
         performances = deal_transactions_by_epic(dealing_platform).map do |epic, transactions|
-          profit_loss = transactions.map(&:profit_and_loss_amount).inject(&:+)
+          profit_loss = transactions.sum(&:profit_and_loss_amount)
 
           { epic: epic, transactions: transactions, profit_loss: profit_loss }
         end
@@ -38,7 +38,7 @@ module IGMarkets
 
         deal_transactions(dealing_platform).group_by do |transaction|
           activities.detect do |activity|
-            Regexp.new("^Position(\/s| partially) closed:.*#{transaction.reference}").match activity.description
+            Regexp.new("^Position(/s| partially) closed:.*#{transaction.reference}").match activity.description
           end.epic
         end
       end
@@ -58,16 +58,16 @@ module IGMarkets
       end
 
       def print_summary(performances)
-        profit_loss = performances.map { |h| h[:profit_loss] }.inject(:+)
+        profit_loss = performances.sum { |h| h[:profit_loss] }
         currency = performances.first[:transactions].first.currency
 
-        puts <<-MSG
+        puts <<~MSG
 
-Note: this table only shows the profit/loss made from dealing, it does not include interest payments,
-      dividends, or other adjustments that may have occurred over this period.
+          Note: this table only shows the profit/loss made from dealing, it does not include interest payments,
+                dividends, or other adjustments that may have occurred over this period.
 
-Total: #{Format.colored_currency profit_loss, currency}
-MSG
+          Total: #{Format.colored_currency profit_loss, currency}
+        MSG
       end
     end
   end

data/lib/ig_markets/cli/commands/positions_command.rb

@@ -130,7 +130,7 @@ module IGMarkets
 
       def print_position_totals(positions)
         currency_totals = positions.group_by(&:currency).map do |currency, subset|
-          total = subset.map(&:profit_loss).reduce :+
+          total = subset.sum(&:profit_loss)
 
           Format.colored_currency total, currency
         end

data/lib/ig_markets/cli/commands/prices_command.rb

@@ -21,12 +21,12 @@ module IGMarkets
 
           table = Tables::HistoricalPriceResultSnapshotsTable.new result.prices, title: "Prices for #{options[:epic]}"
 
-          puts <<-MSG
-#{table}
+          puts <<~MSG
+            #{table}
 
-Allowance: #{allowance.total_allowance}
-Remaining: #{allowance.remaining_allowance}
-MSG
+            Allowance: #{allowance.total_allowance}
+            Remaining: #{allowance.remaining_allowance}
+          MSG
         end
       end
 

data/lib/ig_markets/cli/commands/stream_command.rb

@@ -36,7 +36,7 @@ module IGMarkets
           @dealing_platform = dealing_platform
           @queue = Queue.new
 
-          @dealing_platform.streaming.on_error(&method(:on_error))
+          @dealing_platform.streaming.on_error { |error| on_error error }
           @dealing_platform.streaming.connect
           start_raw_subscriptions
 
@@ -51,7 +51,7 @@ module IGMarkets
                          chart_ticks_subscription].compact
 
         subscriptions.each do |subscription|
-          subscription.on_data(&method(:on_data))
+          subscription.on_data { |data, merged_data| on_data data, merged_data }
         end
 
         @dealing_platform.streaming.start_subscriptions subscriptions, snapshot: true

data/lib/ig_markets/cli/commands/watchlists_command.rb

@@ -9,7 +9,7 @@ module IGMarkets
           dealing_platform.watchlists.all.each_with_index do |watchlist, index|
             table = Tables::MarketOverviewsTable.new watchlist.markets, title: table_title(watchlist)
 
-            puts '' if index > 0
+            puts '' if index.positive?
             puts table
           end
         end

data/lib/ig_markets/cli/config_file.rb

@@ -13,8 +13,8 @@ module IGMarkets
       def initialize(content = {})
         @content = content || {}
 
-        @profiles = (@content['profiles'] || {}).each_with_object({}) do |(profile_name, profile_arguments), result|
-          result[profile_name] = profile_arguments.map do |argument, value|
+        @profiles = (@content['profiles'] || {}).transform_values do |profile_arguments|
+          profile_arguments.map do |argument, value|
             "--#{argument}=#{value}"
           end
         end

data/lib/ig_markets/cli/curses_window.rb

@@ -66,7 +66,7 @@ module IGMarkets
         end
       end
 
-      COLORIZE_REGEXP = /^\e\[0(?:;(\d+);49)?m/
+      COLORIZE_REGEXP = /^\e\[0(?:;(\d+);49)?m/.freeze
 
       def print_next_line_segment(line)
         match = line.match COLORIZE_REGEXP

data/lib/ig_markets/cli/main.rb

@@ -36,7 +36,7 @@ module IGMarkets
             to: history_options_parse_time(options[:to])
           }
         else
-          { from: Time.now.utc - options[:days] * 86_400 }
+          { from: Time.now.utc - (options[:days] * 86_400) }
         end
       end
 
@@ -73,8 +73,8 @@ module IGMarkets
           @dealing_platform.sign_in options[:username], options[:password], options[:api_key], platform
 
           yield @dealing_platform
-        rescue IGMarketsError => error
-          warn_and_exit error
+        rescue IGMarketsError => e
+          warn_and_exit e
         end
 
         # Requests and displays the deal confirmation for the passed deal reference. If the request for the deal
@@ -87,14 +87,12 @@ module IGMarkets
           puts "Deal reference: #{deal_reference}"
 
           5.times do |index|
-            begin
-              return print_deal_confirmation @dealing_platform.deal_confirmation(deal_reference)
-            rescue Errors::DealNotFoundError
-              raise if index == 4
+            return print_deal_confirmation @dealing_platform.deal_confirmation(deal_reference)
+          rescue Errors::DealNotFoundError
+            raise if index == 4
 
-              puts 'Deal not found, retrying ...'
-              sleep 2
-            end
+            puts 'Deal not found, retrying ...'
+            sleep 2
           end
         end
 
@@ -110,14 +108,14 @@ module IGMarkets
         def parse_date_time(attributes, attribute, klass, format, display_format)
           return unless attributes.key? attribute
 
-          if !['', attribute.to_s].include? attributes[attribute].to_s
+          if ['', attribute.to_s].include? attributes[attribute].to_s
+            attributes[attribute] = nil
+          else
             begin
               attributes[attribute] = klass.strptime attributes[attribute], format
             rescue ArgumentError
               raise ArgumentError, %(invalid #{attribute}, use format "#{display_format}")
             end
-          else
-            attributes[attribute] = nil
           end
         end
 
@@ -159,11 +157,11 @@ module IGMarkets
 
         # Prints out details of the passed deal confirmation.
         def print_deal_confirmation(deal_confirmation)
-          puts <<-MSG
-Deal ID: #{deal_confirmation.deal_id}
-Status: #{Format.symbol deal_confirmation.deal_status}
-Result: #{Format.symbol deal_confirmation.status}
-MSG
+          puts <<~MSG
+            Deal ID: #{deal_confirmation.deal_id}
+            Status: #{Format.symbol deal_confirmation.deal_status}
+            Result: #{Format.symbol deal_confirmation.status}
+          MSG
 
           print_deal_confirmation_profit_loss deal_confirmation
 

data/lib/ig_markets/cli/tables/accounts_table.rb

@@ -33,7 +33,7 @@ module IGMarkets
         def cell_color(value, _model, _row_index, column_index)
           return unless headings[column_index] == 'Profit/loss'
 
-          if value =~ /-/
+          if value.include?('-')
             :red
           else
             :green

data/lib/ig_markets/cli/tables/market_overviews_table.rb

@@ -24,9 +24,9 @@ module IGMarkets
         end
 
         def cell_color(value, _model, _row_index, column_index)
-          return unless headings[column_index] =~ /Change/
+          return unless headings[column_index].include?('Change')
 
-          if value =~ /-/
+          if value.include?('-')
             :red
           else
             :green

data/lib/ig_markets/cli/tables/performances_table.rb

@@ -27,7 +27,7 @@ module IGMarkets
         def cell_color(value, _transaction, _row_index, column_index)
           return unless headings[column_index] == 'Profit/loss'
 
-          if value =~ /-/
+          if value.include?('-')
             :red
           else
             :green

data/lib/ig_markets/cli/tables/positions_table.rb

@@ -33,7 +33,7 @@ module IGMarkets
         def cell_color(value, _model, _row_index, column_index)
           return unless headings[column_index] == 'Profit/loss'
 
-          if value =~ /-/
+          if value.include?('-')
             :red
           else
             :green
@@ -73,15 +73,15 @@ module IGMarkets
           Position.new(contract_size: first.contract_size, currency: first.currency,
                        deal_id: combine_position_deal_ids(positions), direction: first.direction,
                        level: combine_position_levels(positions), market: first.market,
-                       size: positions.map(&:size).reduce(:+)).tap do |combined|
+                       size: positions.sum(&:size)).tap do |combined|
             combined.level /= combined.size
           end
         end
 
         def combine_position_levels(positions)
-          positions.map do |position|
+          positions.sum do |position|
             position.level * position.size
-          end.reduce :+
+          end
         end
 
         def combine_position_deal_ids(positions)

data/lib/ig_markets/cli/tables/sprint_market_positions_table.rb

@@ -32,8 +32,8 @@ module IGMarkets
         def cell_color(_value, sprint, _row_index, column_index)
           return unless headings[column_index] == 'Payout'
 
-          if current_level(sprint) > sprint.strike_level && sprint.direction == :buy ||
-             current_level(sprint) < sprint.strike_level && sprint.direction == :sell
+          if (current_level(sprint) > sprint.strike_level && sprint.direction == :buy) ||
+             (current_level(sprint) < sprint.strike_level && sprint.direction == :sell)
             :green
           else
             :red

data/lib/ig_markets/cli/tables/table.rb

@@ -95,7 +95,7 @@ module IGMarkets
 
           return '' if value.empty?
 
-          value[0].upcase + value[1..-1]
+          value[0].upcase + value[1..]
         end
       end
     end

data/lib/ig_markets/cli/tables/transactions_table.rb

@@ -27,7 +27,7 @@ module IGMarkets
         def cell_color(value, _transaction, _row_index, column_index)
           return unless headings[column_index] == 'Profit/loss'
 
-          if value =~ /-/
+          if value.include?('-')
             :red
           else
             :green

data/lib/ig_markets/dealing_platform/market_methods.rb

@@ -34,7 +34,7 @@ module IGMarkets
         return [] if epics.empty?
 
         epics.each do |epic|
-          raise ArgumentError, "invalid EPIC: #{epic}" unless epic.to_s =~ Regex::EPIC
+          raise ArgumentError, "invalid EPIC: #{epic}" unless Regex::EPIC.match?(epic.to_s)
         end
 
         # The API imposes a maximum of 50 EPICs per request

data/lib/ig_markets/dealing_platform/streaming_methods.rb

@@ -12,7 +12,7 @@ module IGMarkets
 
       # Connects the streaming session. Raises a `Lightstreamer::LightstreamerError` if an error occurs.
       def connect
-        @lightstreamer.disconnect if @lightstreamer
+        @lightstreamer&.disconnect
 
         @lightstreamer = Lightstreamer::Session.new username: username, password: password, server_url: server_url
         @lightstreamer.on_error { |error| @on_error_callbacks.each { |callback| callback.call error } }
@@ -21,7 +21,7 @@ module IGMarkets
 
       # Disconnects the streaming session.
       def disconnect
-        @lightstreamer.disconnect if @lightstreamer
+        @lightstreamer&.disconnect
         @lightstreamer = nil
       end
 

data/lib/ig_markets/dealing_platform.rb

@@ -147,9 +147,10 @@ module IGMarkets
 
       source = prepare_source model_class, source
 
-      if source.is_a? Array
+      case source
+      when Array
         source.map { |entry| instantiate_models model_class, entry }
-      elsif source.is_a? Hash
+      when Hash
         instantiate_model_from_attributes_hash model_class, source
       else
         raise ArgumentError, "#{model_class}: can't instantiate from a source of type #{source.class}"
@@ -211,7 +212,7 @@ module IGMarkets
         model.send "#{attribute}=", value
       else
         unless Array(@reported_unrecognized_values).include? [model.class, attribute, value]
-          warn "ig_markets: received unrecognized value for #{model.class}##{attribute}: #{value}"
+          warn "ig_markets: received unrecognized value for #{model.class.name}##{attribute}: #{value}"
           (@reported_unrecognized_values ||= []) << [model.class, attribute, value]
         end
       end

data/lib/ig_markets/format.rb

@@ -43,7 +43,7 @@ module IGMarkets
     def colored_currency(amount, currency_name)
       return '' unless amount
 
-      color = amount < 0 ? :red : :green
+      color = amount.negative? ? :red : :green
 
       ColorizedString[currency(amount, currency_name)].colorize color
     end
@@ -60,7 +60,7 @@ module IGMarkets
                  (value / 60).to_s
                end
 
-      result + ':' + Kernel.format('%02i', value % 60)
+      "#{result}:#{Kernel.format('%02i', value % 60)}"
     end
 
     # Formats the passed symbol into a human-readable string, replacing underscores with spaces and capitalizing the

data/lib/ig_markets/model/typecasters.rb

@@ -6,11 +6,11 @@ module IGMarkets
 
       def typecaster_for(type)
         if [Boolean, String, Integer, Float, Symbol, Date, Time].include? type
-          method "typecaster_#{type.to_s.gsub(/\AIGMarkets::/, '').downcase}"
+          method "typecaster_#{type.to_s.delete_prefix('IGMarkets::').downcase}"
         elsif type
           lambda do |value, _options, name|
             if Array(value).any? { |entry| !entry.is_a? type }
-              raise ArgumentError, "incorrect type set on #{self}##{name}: #{value.inspect}"
+              raise ArgumentError, "incorrect type set on #{self.name}##{name}: #{value.inspect}"
             end
 
             value
@@ -22,14 +22,14 @@ module IGMarkets
         return value if [nil, true, false].include? value
         return value == '1' if %w[0 1].include? value
 
-        raise ArgumentError, "#{self}##{name}: invalid boolean value: #{value}"
+        raise ArgumentError, "#{self.name}##{name}: invalid boolean value: #{value}"
       end
 
       def typecaster_string(value, options, name)
         return nil if value.nil?
 
         if options.key?(:regex) && !options[:regex].match(value.to_s)
-          raise ArgumentError, "#{self}##{name}: invalid string value: #{value}"
+          raise ArgumentError, "#{self.name}##{name}: invalid string value: #{value}"
         end
 
         value.to_s
@@ -46,7 +46,7 @@ module IGMarkets
 
         Float(value)
       rescue ArgumentError
-        raise ArgumentError, "#{self}##{name}: invalid float value: #{value}"
+        raise ArgumentError, "#{self.name}##{name}: invalid float value: #{value}"
       end
 
       def typecaster_symbol(value, _options, _name)
@@ -65,14 +65,12 @@ module IGMarkets
 
       def parse_formatted_date_value(value, options, name)
         Array(options[:format]).each do |format|
-          begin
-            return Date.strptime value, format
-          rescue ArgumentError
-            next
-          end
+          return Date.strptime value, format
+        rescue ArgumentError
+          next
         end
 
-        raise ArgumentError, "#{self}##{name}: failed parsing date: #{value}"
+        raise ArgumentError, "#{self.name}##{name}: failed parsing date: #{value}"
       end
 
       def typecaster_time(value, options, name)
@@ -85,14 +83,12 @@ module IGMarkets
 
       def parse_formatted_time_value(value, options, name)
         Array(options[:format]).each do |format|
-          begin
-            return parse_time_using_format value, format
-          rescue ArgumentError
-            next
-          end
+          return parse_time_using_format value, format
+        rescue ArgumentError
+          next
         end
 
-        raise ArgumentError, "#{self}##{name}: failed parsing time: #{value}"
+        raise ArgumentError, "#{self.name}##{name}: failed parsing time: #{value}"
       end
 
       def parse_time_using_format(value, format)

data/lib/ig_markets/model.rb

@@ -47,12 +47,12 @@ module IGMarkets
     #
     # @return [Hash]
     def to_h
-      attributes.each_with_object({}) do |(key, value), hash|
-        hash[key] = if value.is_a? Model
-                      value.to_h
-                    else
-                      value
-                    end
+      attributes.transform_values do |value|
+        if value.is_a? Model
+          value.to_h
+        else
+          value
+        end
       end
     end
 
@@ -80,9 +80,10 @@ module IGMarkets
 
     # Returns the {#inspect} string for the given value.
     def inspect_value(value)
-      if value.is_a? Time
+      case value
+      when Time
         value.localtime.strftime '%F %T %Z'
-      elsif value.is_a? Date
+      when Date
         value.strftime '%F'
       else
         value.inspect
@@ -113,7 +114,7 @@ module IGMarkets
         return true if defined_attribute_names.include?(name) || Array(deprecated_attributes).include?(name)
 
         unless Array(@reported_invalid_attributes).include? name
-          warn "ig_markets: unrecognized attribute #{self}##{name}"
+          warn "ig_markets: unrecognized attribute #{self.name}##{name}"
           (@reported_invalid_attributes ||= []) << name
         end
 
@@ -183,8 +184,8 @@ module IGMarkets
       # @param [Array<Symbol>] names The names of the deprecated attributes.
       def deprecated_attribute(*names)
         names.each do |name|
-          define_method(name) {}
-          define_method("#{name}=") { |_value| }
+          define_method(name) {} # rubocop:disable Lint/EmptyBlock
+          define_method("#{name}=") { |_value| } # rubocop:disable Lint/EmptyBlock
           define_singleton_method("sanitize_#{name}_value") { |value| value }
 
           (@deprecated_attributes ||= []) << name
@@ -202,7 +203,7 @@ module IGMarkets
           value = self.class.send "sanitize_#{name}_value", value
 
           unless self.class.attribute_value_allowed? name, value
-            raise ArgumentError, "#{self.class}##{name}: invalid value: #{value.inspect}"
+            raise ArgumentError, "#{self.class.name}##{name}: invalid value: #{value.inspect}"
           end
 
           (@attributes ||= {})[name] = value

data/lib/ig_markets/position.rb

@@ -39,9 +39,10 @@ module IGMarkets
     #
     # @return [Float]
     def price_delta
-      if direction == :buy
+      case direction
+      when :buy
         close_level - level
-      elsif direction == :sell
+      when :sell
         level - close_level
       end
     end

data/lib/ig_markets/regex.rb

@@ -4,9 +4,9 @@ module IGMarkets
   # @private
   module Regex
     # Regex used to validate an ISO currency code.
-    CURRENCY = /\A[A-Z]{3}\Z/
+    CURRENCY = /\A[A-Z]{3}\Z/.freeze
 
     # Regex used to validate an EPIC.
-    EPIC = /\A[A-Z,a-z,0-9,.,_]{6,30}\Z/
+    EPIC = /\A[A-Za-z0-9.,_]{6,30}\Z/.freeze
   end
 end

data/lib/ig_markets/request_body_formatter.rb

@@ -48,7 +48,7 @@ module IGMarkets
     def snake_case_to_camel_case(value)
       pieces = value.to_s.split '_'
 
-      (pieces.first + pieces[1..-1].map(&:capitalize).join).to_sym
+      (pieces.first + pieces[1..].map(&:capitalize).join).to_sym
     end
   end
 end

data/lib/ig_markets/request_formatter.rb

@@ -50,7 +50,7 @@ module IGMarkets
         result = "  Body:\n    "
         result += JSON.pretty_generate(JSON.parse(body)).gsub("\n", "\n    ")
 
-        result + "\n"
+        "#{result}\n"
       end
 
       def format_response_headers(headers)
@@ -66,9 +66,9 @@ module IGMarkets
       def format_response_body(body)
         result = "    Body:\n      "
         result += JSON.pretty_generate(JSON.parse(body)).gsub "\n", "\n      "
-        result + "\n"
+        "#{result}\n"
       rescue JSON::ParserError
-        result + body + "\n"
+        "#{result}#{body}\n"
       end
     end
   end

data/lib/ig_markets/response_parser.rb

@@ -14,11 +14,12 @@ module IGMarkets
     #
     # @return [Hash, Array, Object] The parsed object, the type depends on the type of the `response` parameter.
     def parse(response)
-      if response.is_a? Hash
+      case response
+      when Hash
         response.each_with_object({}) do |(key, value), new_hash|
           new_hash[camel_case_to_snake_case(key).to_sym] = parse(value)
         end
-      elsif response.is_a? Array
+      when Array
         response.map { |item| parse item }
       else
         response

data/lib/ig_markets/session.rb

@@ -122,7 +122,7 @@ module IGMarkets
         options[:method] = :post
       end
 
-      options[:body] = options[:body] && options[:body].to_json
+      options[:body] = options[:body]&.to_json
 
       execute_request options
     end
@@ -148,8 +148,8 @@ module IGMarkets
       write_to_log_sinks { RequestFormatter.format_response response }
 
       process_response response, options
-    rescue Excon::Error => error
-      raise Errors::ConnectionError, error.message
+    rescue Excon::Error => e
+      raise Errors::ConnectionError, e.message
     end
 
     def write_to_log_sinks

data/lib/ig_markets/streaming/account_state.rb

@@ -170,13 +170,15 @@ module IGMarkets
       end
 
       def on_working_order_updated(working_order_update)
+        working_order_attributes = %i[good_till_date limit_distance order_type stop_distance time_in_force]
+
         @working_orders.each do |working_order|
           next unless working_order.deal_id == working_order_update.deal_id
 
           working_order.currency_code = working_order_update.currency
           working_order.order_level = working_order_update.level
 
-          %i[good_till_date limit_distance order_type stop_distance time_in_force].each do |attribute|
+          working_order_attributes.each do |attribute|
             working_order.send "#{attribute}=", working_order_update.send(attribute)
           end
         end

data/lib/ig_markets/streaming/market_subscription_manager.rb

@@ -54,7 +54,7 @@ module IGMarkets
           next if @subscriptions.key? epic
 
           subscription = @dealing_platform.streaming.build_markets_subscription epic
-          subscription.on_data(&method(:run_callbacks))
+          subscription.on_data { |data, merged_data| run_callbacks data, merged_data }
 
           @subscriptions[epic] = subscription
 

data/lib/ig_markets/streaming/subscription.rb

@@ -19,7 +19,9 @@ module IGMarkets
         @dealing_platform = dealing_platform
 
         @lightstreamer_subscription = lightstreamer_subscription
-        @lightstreamer_subscription.on_data(&method(:on_raw_data))
+        @lightstreamer_subscription.on_data do |subscription, item_name, item_data, new_data|
+          on_raw_data subscription, item_name, item_data, new_data
+        end
 
         @on_data_callbacks = []
       end
@@ -44,11 +46,11 @@ module IGMarkets
 
       private
 
-      ACCOUNT_DATA_REGEX = /^ACCOUNT:(.*)$/
-      MARKET_DATA_REGEX = /^MARKET:(.*)$/
-      TRADE_DATA_REGEX = /^TRADE:(.*)$/
-      CHART_TICK_DATA_REGEX = /^CHART:(.*):TICK$/
-      CONSOLIDATED_CHART_DATA_REGEX = /^CHART:(.*):(SECOND|1MINUTE|5MINUTE|HOUR)$/
+      ACCOUNT_DATA_REGEX = /^ACCOUNT:(.*)$/.freeze
+      MARKET_DATA_REGEX = /^MARKET:(.*)$/.freeze
+      TRADE_DATA_REGEX = /^TRADE:(.*)$/.freeze
+      CHART_TICK_DATA_REGEX = /^CHART:(.*):TICK$/.freeze
+      CONSOLIDATED_CHART_DATA_REGEX = /^CHART:(.*):(SECOND|1MINUTE|5MINUTE|HOUR)$/.freeze
 
       def on_raw_data(_subscription, item_name, item_data, new_data)
         {
@@ -58,7 +60,7 @@ module IGMarkets
           CHART_TICK_DATA_REGEX => :on_chart_tick_data,
           CONSOLIDATED_CHART_DATA_REGEX => :on_consolidated_chart_data
         }.each do |regex, handler|
-          send handler, item_name, item_data, new_data if item_name =~ regex
+          send handler, item_name, item_data, new_data if item_name&.match?(regex)
         end
       end
 

data/lib/ig_markets/transaction.rb

@@ -32,7 +32,7 @@ module IGMarkets
     def profit_and_loss_amount
       raise 'profit_and_loss does not start with the expected currency' unless profit_and_loss.start_with? currency
 
-      profit_and_loss[currency.length..-1].delete(',').to_f
+      profit_and_loss[currency.length..].delete(',').to_f
     end
   end
 end

data/lib/ig_markets/version.rb

@@ -1,4 +1,4 @@
 module IGMarkets
   # The version of this gem.
-  VERSION = '0.33'.freeze
+  VERSION = '0.35'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ig_markets
 version: !ruby/object:Gem::Version
-  version: '0.33'
+  version: '0.35'
 platform: ruby
 authors:
 - Richard Viney
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-12-30 00:00:00.000000000 Z
+date: 2023-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -30,196 +30,196 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: '0.99'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: '0.99'
 - !ruby/object:Gem::Dependency
   name: lightstreamer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.14'
+        version: '0.16'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.14'
+        version: '0.16'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.14'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.14'
 - !ruby/object:Gem::Dependency
   name: terminal-table
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '6.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '6.2'
 - !ruby/object:Gem::Dependency
-  name: factory_bot
+  name: github-markup
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.8'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.8'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
-  name: github-markup
+  name: redcarpet
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '3.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '3.6'
 - !ruby/object:Gem::Dependency
-  name: redcarpet
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.12'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rspec-mocks
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '3.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '3.12'
 - !ruby/object:Gem::Dependency
-  name: rspec-mocks
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '1.48'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '1.48'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: '1.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: '1.16'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.21'
+        version: '2.19'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.21'
+        version: '2.19'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '0.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '0.21'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -234,7 +234,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.9'
-description: 
+description:
 email: richard.viney@gmail.com
 executables:
 - ig_markets
@@ -330,8 +330,9 @@ files:
 homepage: https://github.com/richard-viney/ig_markets
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -339,16 +340,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.2
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
-signing_key: 
+rubygems_version: 3.4.6
+signing_key:
 specification_version: 4
 summary: Library and command-line client for accessing the IG Markets dealing platform.
 test_files: []