idrac 0.9.0 → 0.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40d8abda65007546224a817d15c735d6b0f4fb35f7d4aba6a429bf1f4d92bc98
-  data.tar.gz: 8a33504cada67707e4f5d38ea8af248d68c6de3d91bf9f03c867ec2042617c9b
+  metadata.gz: 54237d0e5e104838b8770088791b1896b11928d0092572035ee05117de1d6733
+  data.tar.gz: 802a048dcf46d8d9a1eab4626be4425269ee58d0012b61f1ac167b44a8b1def9
 SHA512:
-  metadata.gz: 451ec8c73047bb0af4abf66e6b8139b7c84ea4f5e94c3391aa791b669c5e7cd95bc6aaa980ea0b37978b7f464cf6b9598072efdd767a4714bd542d1345f705cc
-  data.tar.gz: 98772256156d10521bffc87e752ef2249d35c865af29a3ad74743af283dd74ac0fbb19cff18767978fa06b2ef556dc57ee847b74381f6360ab462d829d021295
+  metadata.gz: 95ff7c2f6e83194632b4ceb9febd251f01332f39271c02bfc2e0f35e677159b873b7ff74a8906f5b293af855aa2fb3f69ed4e73242be8ca704f6346da507c9a8
+  data.tar.gz: 94f8e2b5ab66ff0cf428bdb1903d3ba3d38d9b3e2002323e36a866ffb4461ae22a2766861550d4daf0fe74b274e2991ef9280fd9732581af9d0b86d3209b7047

data/README.md

@@ -291,6 +291,13 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Changelog
 
+### Version 0.9.1
+- **Code Simplification**: Removed redundant `handle_response` calls throughout the codebase
+  - `authenticated_request` now automatically handles error responses (status >= 400)
+  - Removed 15 lines of redundant error handling code across storage.rb, power.rb, and virtual_media.rb
+  - Simplified response parsing in `get_power_state` and `get_power_usage_watts` methods
+  - Improved code maintainability by relying on centralized error handling
+
 ### Version 0.9.0
 - **Automatic Retry Handling**: ServiceTemporarilyUnavailable (503) errors now automatically retry with iDRAC-specified delay
 - **Simplified API**: `authenticated_request` now returns response body string by default instead of response object

data/lib/idrac/boot.rb

@@ -165,8 +165,7 @@ module IDRAC
       response = authenticated_request(
         :patch,
         "/redfish/v1/Systems/System.Embedded.1",
-        body: body.to_json,
-        headers: { 'Content-Type': 'application/json' }
+        body: body.to_json
       )
       
       if response.status.between?(200, 299)
@@ -190,8 +189,7 @@ module IDRAC
       response = authenticated_request(
         :patch,
         "/redfish/v1/Systems/System.Embedded.1",
-        body: body.to_json,
-        headers: { 'Content-Type': 'application/json' }
+        body: body.to_json
       )
       
       if response.status.between?(200, 299)
@@ -215,8 +213,7 @@ module IDRAC
       response = authenticated_request(
         :patch,
         "/redfish/v1/Systems/System.Embedded.1",
-        body: body.to_json,
-        headers: { 'Content-Type': 'application/json' }
+        body: body.to_json
       )
       
       if response.status.between?(200, 299)
@@ -312,10 +309,9 @@ module IDRAC
             end
             
             response = authenticated_request(
-              :patch, 
+              :patch,
               "/redfish/v1/Systems/System.Embedded.1/Bios/Settings",
-              body: payload.to_json,
-              headers: { 'Content-Type': 'application/json' }
+              body: payload.to_json
             )
             
             wait_for_job(response.headers["location"])
@@ -396,10 +392,9 @@ module IDRAC
           
           # Set boot order
           response = authenticated_request(
-            :patch, 
+            :patch,
             "/redfish/v1/Systems/System.Embedded.1",
-            body: { "Boot": { "BootOrder": [boot_id] } }.to_json,
-            headers: { 'Content-Type': 'application/json' }
+            body: { "Boot": { "BootOrder": [boot_id] } }.to_json
           )
           
           if response.status.between?(200, 299)
@@ -495,10 +490,9 @@ module IDRAC
     # Configure BIOS settings
     def configure_bios_settings(settings)
       response = authenticated_request(
-        :patch, 
+        :patch,
         "/redfish/v1/Systems/System.Embedded.1/Bios/Settings",
-        body: { "Attributes": settings }.to_json,
-        headers: { 'Content-Type': 'application/json' }
+        body: { "Attributes": settings }.to_json
       )
       
       if response.status.between?(200, 299)
@@ -676,10 +670,9 @@ module IDRAC
       params["HostPowerState"] = reboot ? "On" : "Off"
       
       response = authenticated_request(
-        :post, 
+        :post,
         "/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager.ImportSystemConfiguration",
-        body: params.to_json,
-        headers: { 'Content-Type': 'application/json' }
+        body: params.to_json
       )
       
       task = wait_for_task(response.headers["location"])

data/lib/idrac/client.rb

@@ -86,14 +86,14 @@ module IDRAC
       end
     end
 
-    # Login to iDRAC
+    def authenticated?
+      @direct_mode || session.x_auth_token
+    end
+
+    # Login to iDRAC (no-op if already authenticated)
     def login
-      # If we're in direct mode, skip login attempts
-      if @direct_mode
-        debug "Using direct mode (Basic Auth) for all requests", 1, :light_yellow
-        return true
-      end
-      
+      return true if authenticated?
+
       # Try to create a Redfish session
       if session.create
         debug "Successfully logged in to iDRAC using Redfish session", 1, :green
@@ -105,6 +105,11 @@ module IDRAC
       end
     end
 
+    # Ensure we're authenticated before making requests (idempotent)
+    def ensure_authenticated!
+      login unless authenticated?
+    end
+
     # Logout from iDRAC
     def logout
       session.delete if session.x_auth_token

data/lib/idrac/firmware.rb

@@ -30,8 +30,7 @@ module IDRAC
       # Ensure we have a client
       raise Error, "Client is required for firmware update" unless client
 
-      # Login to iDRAC
-      client.login unless client.instance_variable_get(:@session_id)
+      client.ensure_authenticated!
 
       # Upload firmware file
       job_id = upload_firmware(firmware_path)
@@ -563,10 +562,7 @@ module IDRAC
         update_response = client.authenticated_request(
           :post,
           "/redfish/v1/UpdateService/Actions/UpdateService.SimpleUpdate",
-          {
-            headers: { 'Content-Type' => 'application/json' },
-            body: simple_update_payload.to_json
-          }
+          body: simple_update_payload.to_json
         )
         
         if update_response.status != 202 && update_response.status != 200

data/lib/idrac/jobs.rb

@@ -75,10 +75,9 @@ module IDRAC
       payload = { "JobID" => "JID_CLEARALL_FORCE" }
       
       response = authenticated_request(
-        :post, 
-        path, 
-        body: payload.to_json, 
-        headers: { 'Content-Type' => 'application/json' }
+        :post,
+        path,
+        body: payload.to_json
       )
       
       if response.status.between?(200, 299)
@@ -90,10 +89,9 @@ module IDRAC
         retries = 60  # ~10 minutes with 10s sleep
         while retries > 0
           lc_response = authenticated_request(
-            :post, 
+            :post,
             '/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService/Actions/DellLCService.GetRemoteServicesAPIStatus',
-            body: {}.to_json, 
-            headers: { 'Content-Type': 'application/json' }
+            body: {}.to_json
           )
           
           if lc_response.status.between?(200, 299)

data/lib/idrac/license.rb

@@ -1,359 +1,134 @@
 module IDRAC
   module License
     # Gets the license information from the iDRAC
-    # @return [Hash] License details
+    # @return [Hash, nil] License details
     def license_info
-      # Try the standard license endpoint first (works in iDRAC 9+)
-      response = authenticated_request(:get, "/redfish/v1/LicenseService/Licenses")
-      
-      if response.status == 200
-        license_data = JSON.parse(response.body)
-        debug "License collection: #{license_data}", 2
-
-        # Check if there are any license entries
-        if !license_data["Members"] || license_data["Members"].empty?
-          debug "No licenses found", 1, :yellow
-          return try_dell_oem_license_path()
-        end
-
-        # Get the first license in the list
-        license_uri = license_data["Members"][0]["@odata.id"]
-        debug "Using license URI: #{license_uri}", 2
-
-        # Get detailed license information
-        license_response = authenticated_request(:get, license_uri)
-        if license_response.status != 200
-          debug "Failed to retrieve license details: #{license_response.status}", 1, :red
-          return try_dell_oem_license_path()
+      # Try standard endpoint first (iDRAC 9+)
+      if (data = safe_get("/redfish/v1/LicenseService/Licenses"))
+        if data["Members"]&.any?
+          license_uri = data["Members"][0]["@odata.id"]
+          return safe_get(license_uri) || try_dell_oem_license_path
         end
-
-        license_details = JSON.parse(license_response.body)
-        debug "License details: #{license_details}", 2
-
-        return license_details
-      else
-        # The endpoint is not available (probably iDRAC 8)
-        debug "Standard license endpoint failed: #{response.status}, trying Dell OEM path", 1, :yellow
-        return try_dell_oem_license_path()
       end
+
+      try_dell_oem_license_path
     end
 
-    # Extracts the iDRAC version from the license description or server header
-    # @return [Integer, nil] The license version (e.g. 9) or nil if not found
+    # Extracts the iDRAC generation (e.g. 8, 9) from license or server header
+    # @return [Integer, nil]
     def license_version
-      # Use memoization to cache the result and avoid multiple API calls
       @license_version ||= compute_license_version
     end
-    
-    # Clear the cached license version (useful if iDRAC state changes)
+
     def clear_license_version_cache
       @license_version = nil
     end
-    
+
     private
-    
+
+    # GET that returns parsed JSON on 200, nil otherwise. Never raises on 4xx.
+    def safe_get(path)
+      response = authenticated_request(:get, path) { |r| r }
+      return nil unless response.status == 200
+      JSON.parse(response.body)
+    rescue JSON::ParserError
+      nil
+    end
+
     def compute_license_version
-      # First try to get from license info
       license = license_info
       if license
-        # Check the Description field, which often contains the version
-        # Example: "iDRAC9 Enterprise License"
-        if license["Description"]&.match(/iDRAC(\d+)/i)
-          version = license["Description"].match(/iDRAC(\d+)/i)[1].to_i
-          debug "Found license version from Description: #{version}", 1
-          return version
-        end
-
-        # Try alternative fields if Description didn't work
-        if license["Name"]&.match(/iDRAC(\d+)/i)
-          version = license["Name"].match(/iDRAC(\d+)/i)[1].to_i
-          debug "Found license version from Name: #{version}", 1
-          return version
-        end
-        
-        # For Dell OEM license response format
-        if license["LicenseDescription"]&.match(/iDRAC(\d+)/i)
-          version = license["LicenseDescription"].match(/iDRAC(\d+)/i)[1].to_i
-          debug "Found license version from LicenseDescription: #{version}", 1
-          return version
+        %w[Description Name LicenseDescription].each do |field|
+          if license[field]&.match(/iDRAC(\d+)/i)
+            return $1.to_i
+          end
         end
       end
-      
-      # If license info failed or didn't have version info, try to get from server header
-      # Make a simple request to check the server header (often contains iDRAC version)
-      response = authenticated_request(:get, "/redfish/v1")
-      if response.headers["server"] && response.headers["server"].match(/iDRAC\/(\d+)/i)
-        version = response.headers["server"].match(/iDRAC\/(\d+)/i)[1].to_i
-        debug "Found license version from server header: #{version}", 1
-        return version
+
+      # Fall back to server header
+      response = authenticated_request(:get, "/redfish/v1") { |r| r }
+      if response.headers["server"]&.match(/iDRAC\/(\d+)/i)
+        return $1.to_i
       end
-      
-      debug "Could not determine license version from license info or server header", 1, :yellow
+
       nil
     end
-    
-    # Attempt to get license information using Dell OEM extension path (for iDRAC 8)
-    # @return [Hash, nil] License info or nil if not found
+
     def try_dell_oem_license_path
-      # Try several potential Dell license paths (order matters - most likely first)
-      dell_license_paths = [
-        "/redfish/v1/Managers/iDRAC.Embedded.1/Oem/Dell/DellLicenseManagementService/Licenses",
-        "/redfish/v1/Managers/iDRAC.Embedded.1/Attributes", # iDRAC attributes might contain license info
-        "/redfish/v1/Managers/iDRAC.Embedded.1"             # Manager entity might have license info embedded
-      ]
-      
-      dell_license_paths.each do |path|
-        response = authenticated_request(:get, path)
-        
-        if response.status == 200
-          debug "Found valid Dell license path: #{path}", 2
-          data = JSON.parse(response.body)
-          
-          # Check for license info in this response based on the path
-          if path.include?("DellLicenseManagementService")
-            return handle_dell_license_service_response(data)
-          elsif path.include?("Attributes")
-            return handle_dell_attributes_response(data)
-          elsif path.include?("iDRAC.Embedded.1") && !path.include?("Attributes")
-            return handle_dell_manager_response(data)
+      # Try Dell OEM license service (iDRAC 8)
+      if (data = safe_get("/redfish/v1/Managers/iDRAC.Embedded.1/Oem/Dell/DellLicenseManagementService/Licenses"))
+        if data["Members"]&.any?
+          license_uri = data["Members"][0]["@odata.id"]
+          if (details = safe_get(license_uri))
+            return {
+              "Id" => details["EntitlementID"] || "iDRAC-License",
+              "Description" => details["LicenseDescription"] || "iDRAC License",
+              "Name" => details["LicenseDescription"] || "iDRAC License",
+              "LicenseType" => details["LicenseType"] || license_type_from(details["LicenseDescription"]),
+              "Status" => { "Health" => "OK" },
+              "Removable" => true
+            }
           end
-        else
-          debug "Dell path #{path} response status: #{response.status}", 3
         end
       end
-      
-      # If we couldn't find any API path that works, try the service tag detection method 
-      service_tag = get_service_tag
-      if service_tag
-        # Service tag is often used to indicate Enterprise licenses on Dell systems
-        license_type = determine_license_type()
-        return {
-          "Id" => "iDRAC-License",
-          "Description" => "iDRAC8 #{license_type} License",
-          "Name" => "iDRAC License",
-          "LicenseType" => license_type,
-          "Status" => { "Health" => "OK" },
-          "Removable" => false,
-          "EntitlementID" => service_tag # Dell often uses service tag as entitlement ID
-        }
-      end
-      
-      # Fall back to feature detection if all else fails
-      debug "All Dell OEM license paths failed, using fallback detection", 1, :yellow
-      return create_fallback_license_info()
-    end
-    
-    # Handle response from Dell License Management Service
-    def handle_dell_license_service_response(data)
-      # Check if there are any license entries
-      if !data["Members"] || data["Members"].empty?
-        debug "No licenses found in Dell OEM path", 1, :yellow
-        return create_fallback_license_info(use_basic: true)
-      end
-      
-      # Get the first license in the list
-      license_uri = data["Members"][0]["@odata.id"]
-      debug "Using Dell OEM license URI: #{license_uri}", 2
-      
-      # Get detailed license information
-      license_response = authenticated_request(:get, license_uri)
-      if license_response.status != 200
-        debug "Failed to retrieve Dell OEM license details: #{license_response.status}", 1, :red
-        return create_fallback_license_info(use_basic: true)
-      end
-      
-      dell_license = JSON.parse(license_response.body)
-      debug "Dell OEM license details: #{dell_license}", 2
-      
-      # Convert Dell OEM license format to standard format
-      license_info = {
-        "Id" => dell_license["EntitlementID"] || "iDRAC-License",
-        "Description" => dell_license["LicenseDescription"] || "iDRAC License",
-        "Name" => dell_license["LicenseDescription"] || "iDRAC License",
-        "LicenseType" => dell_license["LicenseType"] || get_license_type_from_description(dell_license["LicenseDescription"]),
-        "Status" => { "Health" => "OK" },
-        "Removable" => true
-      }
-      
-      return license_info
-    end
-    
-    # Handle response from Dell Manager attributes
-    def handle_dell_attributes_response(data)
-      # Look for license information in attributes
-      if data["Attributes"] && (
-          data["Attributes"]["LicensableDevice.1.LicenseInfo.1"] ||
-          data["Attributes"]["System.ServerOS.1.OSName"] ||
-          data["Attributes"]["iDRAC.Info.1.LicensingInfo"]
-        )
-        
-        license_info = data["Attributes"]["LicensableDevice.1.LicenseInfo.1"] || 
-                       data["Attributes"]["iDRAC.Info.1.LicensingInfo"]
-        
-        if license_info
-          license_type = license_info.include?("Enterprise") ? "Enterprise" : 
-                         license_info.include?("Express") ? "Express" : "Basic"
-          
-          return {
-            "Id" => "iDRAC-License",
-            "Description" => "iDRAC8 #{license_type} License",
-            "Name" => "iDRAC License",
-            "LicenseType" => license_type,
-            "Status" => { "Health" => "OK" },
-            "Removable" => false
-          }
-        end
+
+      # Try manager attributes
+      if (data = safe_get("/redfish/v1/Managers/iDRAC.Embedded.1/Attributes"))
+        attr = data.dig("Attributes", "LicensableDevice.1.LicenseInfo.1") ||
+               data.dig("Attributes", "iDRAC.Info.1.LicensingInfo")
+        return build_license_hash(license_type_from(attr)) if attr
       end
-      
-      # If no license attributes found, fall back to feature detection
-      license_type = determine_license_type()
-      return {
-        "Id" => "iDRAC-License",
-        "Description" => "iDRAC8 #{license_type} License",
-        "Name" => "iDRAC License",
-        "LicenseType" => license_type,
-        "Status" => { "Health" => "OK" },
-        "Removable" => false
-      }
-    end
-    
-    # Handle response from Dell Manager entity
-    def handle_dell_manager_response(data)
-      # Look for license information in Oem data
-      if data["Oem"] && data["Oem"]["Dell"]
-        dell_data = data["Oem"]["Dell"]
-        
-        if dell_data["DellLicenseManagementService"]
-          # Found license service reference, but need to query it directly
-          service_uri = dell_data["DellLicenseManagementService"]["@odata.id"]
-          debug "Found license service URI: #{service_uri}", 2
-          
-          service_response = authenticated_request(:get, service_uri)
-          if service_response.status == 200
-            return handle_dell_license_service_response(JSON.parse(service_response.body))
+
+      # Try manager entity OEM data
+      if (data = safe_get("/redfish/v1/Managers/iDRAC.Embedded.1"))
+        if (service_uri = data.dig("Oem", "Dell", "DellLicenseManagementService", "@odata.id"))
+          if (svc_data = safe_get(service_uri)) && svc_data["Members"]&.any?
+            if (details = safe_get(svc_data["Members"][0]["@odata.id"]))
+              return {
+                "Id" => details["EntitlementID"] || "iDRAC-License",
+                "Description" => details["LicenseDescription"] || "iDRAC License",
+                "Name" => details["LicenseDescription"] || "iDRAC License",
+                "LicenseType" => details["LicenseType"] || license_type_from(details["LicenseDescription"]),
+                "Status" => { "Health" => "OK" },
+                "Removable" => true
+              }
+            end
           end
         end
-        
-        # Check if license info is embedded directly
+
+        dell_data = data.dig("Oem", "Dell") || {}
         if dell_data["LicenseType"] || dell_data["License"]
-          license_type = dell_data["LicenseType"] || 
-                        (dell_data["License"] && dell_data["License"].include?("Enterprise") ? "Enterprise" : 
-                         dell_data["License"].include?("Express") ? "Express" : "Basic")
-          
-          return {
-            "Id" => "iDRAC-License",
-            "Description" => "iDRAC8 #{license_type} License",
-            "Name" => "iDRAC License",
-            "LicenseType" => license_type,
-            "Status" => { "Health" => "OK" },
-            "Removable" => false
-          }
-        end
-      end
-      
-      # Check for license type in model name or description
-      if data["Model"] && data["Model"].include?("Enterprise")
-        return {
-          "Id" => "iDRAC-License",
-          "Description" => "iDRAC8 Enterprise License",
-          "Name" => "iDRAC License",
-          "LicenseType" => "Enterprise",
-          "Status" => { "Health" => "OK" },
-          "Removable" => false
-        }
-      end
-      
-      # If no license info found in manager data, fall back to feature detection
-      license_type = determine_license_type()
-      return {
-        "Id" => "iDRAC-License",
-        "Description" => "iDRAC8 #{license_type} License",
-        "Name" => "iDRAC License",
-        "LicenseType" => license_type,
-        "Status" => { "Health" => "OK" },
-        "Removable" => false
-      }
-    end
-    
-    # Get service tag from system info
-    def get_service_tag
-      response = authenticated_request(:get, "/redfish/v1/Systems/System.Embedded.1")
-      if response.status == 200
-        data = JSON.parse(response.body)
-        return data["SKU"] if data["SKU"] # Service tag is usually in SKU field
-      end
-      
-      # Try alternate location
-      response = authenticated_request(:get, "/redfish/v1")
-      if response.status == 200
-        data = JSON.parse(response.body)
-        if data["Oem"] && data["Oem"]["Dell"] && data["Oem"]["Dell"]["ServiceTag"]
-          return data["Oem"]["Dell"]["ServiceTag"]
+          return build_license_hash(license_type_from(dell_data["LicenseType"] || dell_data["License"]))
         end
       end
-      
-      nil
+
+      # Last resort: detect from features
+      build_license_hash(detect_license_type)
     end
-    
-    # Helper method to extract license type from description
-    def get_license_type_from_description(description)
-      return "Unknown" unless description
-      
-      if description.include?("Enterprise")
-        return "Enterprise"
-      elsif description.include?("Express")
-        return "Express"
-      elsif description.include?("Datacenter")
-        return "Datacenter"
-      else
-        return "Basic"
-      end
+
+    def license_type_from(str)
+      return "Unknown" unless str
+      return "Enterprise" if str.include?("Enterprise")
+      return "Datacenter" if str.include?("Datacenter")
+      return "Express" if str.include?("Express")
+      "Basic"
     end
-    
-    # Creates a basic license info object based on system information
-    # Used as a fallback when neither the standard nor Dell OEM endpoints work
-    # @return [Hash] A basic license info object
-    def create_fallback_license_info(use_basic: false)
-      # Get the iDRAC version number from server headers
-      version = nil
-      response = authenticated_request(:get, "/redfish/v1")
-      if response.headers["server"] && response.headers["server"].match(/iDRAC\/(\d+)/i)
-        version = response.headers["server"].match(/iDRAC\/(\d+)/i)[1].to_i
-      end
-      
-      # Try to determine if it's Enterprise or Express based on available features
-      license_type = use_basic ? "Basic" : determine_license_type
-      
-      license_info = {
+
+    def build_license_hash(type)
+      {
         "Id" => "iDRAC-License",
-        "Description" => version ? "iDRAC#{version} #{license_type} License" : "iDRAC License",
+        "Description" => "iDRAC #{type} License",
         "Name" => "iDRAC License",
-        "LicenseType" => license_type,
+        "LicenseType" => type,
         "Status" => { "Health" => "OK" },
         "Removable" => false
       }
-      
-      debug "Created fallback license info: #{license_info}", 2
-      license_info
     end
-    
-    # Attempt to determine the license type (Enterprise/Express) based on available features
-    # @return [String] The license type (Enterprise, Express, or Basic)
-    def determine_license_type
-      # We can try to check for features only available in Enterprise
-      begin
-        # For example, virtual media is typically an Enterprise feature
-        virtual_media_response = authenticated_request(:get, "/redfish/v1/Managers/iDRAC.Embedded.1/VirtualMedia")
-        # If we successfully get virtual media, it's likely Enterprise
-        if virtual_media_response.status == 200
-          return "Enterprise" 
-        end
-      rescue
-        # If the request fails, don't fail the whole method
-      end
-      
-      # Default to basic license if we can't determine
-      return "Express"
+
+    def detect_license_type
+      # Virtual media is typically Enterprise-only
+      data = safe_get("/redfish/v1/Managers/iDRAC.Embedded.1/VirtualMedia")
+      data ? "Enterprise" : "Express"
     end
   end
-end 
+end

data/lib/idrac/lifecycle.rb

@@ -169,8 +169,7 @@ module IDRAC
       response = authenticated_request(
         :patch,
         "/redfish/v1/Managers/iDRAC.Embedded.1/Oem/Dell/DellAttributes/LifecycleController.Embedded.1",
-        body: payload.to_json,
-        headers: { 'Content-Type': 'application/json' }
+        body: payload.to_json
       )
       
       code = response.status
@@ -210,10 +209,9 @@ module IDRAC
       payload = { "Component": ["LCData"] }
       
       response = authenticated_request(
-        :post, 
-        path, 
-        body: payload.to_json, 
-        headers: { 'Content-Type' => 'application/json' }
+        :post,
+        path,
+        body: payload.to_json
       )
       
       if response.status.between?(200, 299)
@@ -264,7 +262,7 @@ module IDRAC
     def clear_system_event_logs!
       path = '/redfish/v1/Managers/iDRAC.Embedded.1/LogServices/Sel/Actions/LogService.ClearLog'
       
-      response = authenticated_request(:post, path, body: {}.to_json, headers: { 'Content-Type' => 'application/json' })
+      response = authenticated_request(:post, path, body: {}.to_json)
       
       if response.status.between?(200, 299)
         debug "System Event Logs cleared", 0, :green

data/lib/idrac/network.rb

@@ -171,8 +171,7 @@ module IDRAC
             response = authenticated_request(
               :patch,
               interface_path,
-              body: body.to_json,
-              headers: { 'Content-Type' => 'application/json' }
+              body: body.to_json
             )
             puts "✅ Got response with status: #{response.status}".green
           rescue => e
@@ -189,8 +188,7 @@ module IDRAC
               restart_response = authenticated_request(
                 :post,
                 "/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Manager.Reset",
-                body: { "ResetType" => "GracefulRestart" }.to_json,
-                headers: { 'Content-Type' => 'application/json' }
+                body: { "ResetType" => "GracefulRestart" }.to_json
               )
               
               if restart_response.status == 204

data/lib/idrac/power.rb

@@ -4,8 +4,7 @@ require 'colorize'
 module IDRAC
   module Power
     def power_on(wait: true)
-      # Login to iDRAC if needed
-      login unless @session_id
+      ensure_authenticated!
       
       puts "Powering on server...".light_cyan
       
@@ -22,7 +21,7 @@ module IDRAC
       
       tries = 10
       while tries > 0
-        response = authenticated_request(:post, path, body: payload.to_json, headers: { 'Content-Type' => 'application/json' })
+        response = authenticated_request(:post, path, body: payload.to_json)
         
         case response.status
         when 200, 204
@@ -60,8 +59,7 @@ module IDRAC
     end
     
     def power_off(wait: true, kind: "ForceOff")
-      # Login to iDRAC if needed
-      login unless @session_id
+      ensure_authenticated!
       
       puts "Powering off server...".light_cyan
       
@@ -76,12 +74,10 @@ module IDRAC
       path = "/redfish/v1/Systems/System.Embedded.1/Actions/ComputerSystem.Reset"
       payload = { "ResetType" => kind }
       
-      response = authenticated_request(:post, path, body: payload.to_json, headers: { 'Content-Type' => 'application/json' })
-      
+      response = authenticated_request(:post, path, body: payload.to_json)
+
       if response.status == 409
         puts "Server is already powered OFF.".yellow
-      else
-        handle_response(response)
       end
       
       # Wait for power state change if requested
@@ -98,8 +94,7 @@ module IDRAC
     end
     
     def reboot
-      # Login to iDRAC if needed
-      login unless @session_id
+      ensure_authenticated!
       
       puts "Rebooting server...".light_cyan
 
@@ -114,7 +109,7 @@ module IDRAC
       path = "/redfish/v1/Systems/System.Embedded.1/Actions/ComputerSystem.Reset"
       payload = { "ResetType" => "ForceRestart" }
       
-      response = authenticated_request(:post, path, body: payload.to_json, headers: { 'Content-Type' => 'application/json' })
+      response = authenticated_request(:post, path, body: payload.to_json)
       
       if response.status >= 200 && response.status < 300
         puts "Server reboot command sent successfully".green
@@ -125,31 +120,27 @@ module IDRAC
         # Try gracefulRestart as an alternative
         puts "Trying GracefulRestart instead...".yellow
         payload = { "ResetType" => "GracefulRestart" }
-        response = authenticated_request(:post, path, body: payload.to_json, headers: { 'Content-Type' => 'application/json' })
-        
-        handle_response(response)
+        authenticated_request(:post, path, body: payload.to_json)
       else
         raise Error, "Failed to reboot server. Status code: #{response.status}"
       end
     end
     
     def get_power_state
-      # Login to iDRAC if needed
-      login unless @session_id
+      ensure_authenticated!
       
       # Get system information
       response = authenticated_request(:get, "/redfish/v1/Systems/System.Embedded.1?$select=PowerState")
-      
-      JSON.parse(handle_response(response))&.dig("PowerState")
+
+      JSON.parse(response.body)&.dig("PowerState")
     end
     
     def get_power_usage_watts
-      # Login to iDRAC if needed
-      login unless @session_id
+      ensure_authenticated!
       
       response = authenticated_request(:get, "/redfish/v1/Chassis/System.Embedded.1/Power")
-      
-      JSON.parse(handle_response(response))&.dig("PowerControl", 0, "PowerConsumedWatts")&.to_f
+
+      JSON.parse(response.body)&.dig("PowerControl", 0, "PowerConsumedWatts")&.to_f
     end
     
     # TODO: Migrate method names to match radfish interface for uniformity:

data/lib/idrac/session.rb

@@ -180,38 +180,36 @@ module IDRAC
         debug "Skipping Redfish session creation (direct mode)", 1, :light_yellow
         return false
       end
-      
-      # Determine the correct session endpoint based on Redfish version
+
+      # Skip if already have a valid token
+      if @x_auth_token
+        debug "Session already active", 1, :green
+        return true
+      end
+
+      # Determine the correct session endpoint (cached after first call)
       session_endpoint = determine_session_endpoint
-      
-      # Check current session count before creating new session
-      current_sessions = get_session_count
-      debug "Current active sessions: #{current_sessions}", 1, :cyan
-      
+
       payload = { "UserName" => username, "Password" => password }
-      
+
       debug "Attempting to create Redfish session at #{base_url}#{session_endpoint}", 1
       debug "SSL verification: #{verify_ssl ? 'Enabled' : 'Disabled'}", 1
       print_connection_debug_info if @verbosity >= 2
-      
+
       # Try creation methods in sequence
       if create_session_with_content_type(session_endpoint, payload)
-        log_session_creation_success(current_sessions)
         return true
       end
       if create_session_with_basic_auth(session_endpoint, payload)
-        log_session_creation_success(current_sessions)
         return true
       end
       if handle_max_sessions_and_retry(session_endpoint, payload)
-        log_session_creation_success(current_sessions)
         return true
       end
       if create_session_with_form_urlencoded(session_endpoint, payload)
-        log_session_creation_success(current_sessions)
         return true
       end
-      
+
       # If all attempts fail, switch to direct mode
       @direct_mode = true
       false
@@ -652,32 +650,32 @@ module IDRAC
       end
     end
 
-    # Determine the correct session endpoint based on Redfish version
+    # Determine the correct session endpoint based on Redfish version (cached)
     def determine_session_endpoint
+      return @session_endpoint if @session_endpoint
+
       begin
         debug "Checking Redfish version to determine session endpoint...", 1
-        
+
         response = connection.get('/redfish/v1') do |req|
           req.headers['Accept'] = 'application/json'
           req.headers['Host'] = host_header if host_header
         end
-        
+
         if response.status == 200
           begin
             data = JSON.parse(response.body)
             redfish_version = data['RedfishVersion']
-            
+
             if redfish_version
               debug "Detected Redfish version: #{redfish_version}", 1
-              
-              # For version 1.17.0 and below, use the /redfish/v1/Sessions endpoint
-              # For newer versions, use /redfish/v1/SessionService/Sessions
-              endpoint = Gem::Version.new(redfish_version) <= Gem::Version.new('1.17.0') ? 
-                         '/redfish/v1/Sessions' : 
+
+              @session_endpoint = Gem::Version.new(redfish_version) <= Gem::Version.new('1.17.0') ?
+                         '/redfish/v1/Sessions' :
                          '/redfish/v1/SessionService/Sessions'
-              
-              debug "Using endpoint #{endpoint} for Redfish version #{redfish_version}", 1
-              return endpoint
+
+              debug "Using endpoint #{@session_endpoint} for Redfish version #{redfish_version}", 1
+              return @session_endpoint
             end
           rescue JSON::ParserError => e
             debug "Error parsing Redfish version: #{e.message}", 1, :red
@@ -688,11 +686,10 @@ module IDRAC
       rescue => e
         debug "Error checking Redfish version: #{e.message}", 1, :red
       end
-      
-      # Default to /redfish/v1/Sessions if we can't determine version
-      default_endpoint = '/redfish/v1/Sessions'
-      debug "Defaulting to endpoint #{default_endpoint}", 1, :light_yellow
-      default_endpoint
+
+      @session_endpoint = '/redfish/v1/Sessions'
+      debug "Defaulting to endpoint #{@session_endpoint}", 1, :light_yellow
+      @session_endpoint
     end
     
     # Get current session count

data/lib/idrac/storage.rb

@@ -361,8 +361,6 @@ module IDRAC
       puts "Deleting volume: #{path}"
       
       response = authenticated_request(:delete, "/redfish/v1/#{path}")
-
-      handle_response(response)
     end
 
     # Create a new virtual disk with RAID5 and FastPath optimizations
@@ -430,13 +428,10 @@ module IDRAC
       end
       
       response = authenticated_request(
-        :post, 
+        :post,
         "#{controller_path}/Volumes",
-        body: payload.to_json, 
-        headers: { 'Content-Type' => 'application/json' }
+        body: payload.to_json
       )
-      
-      handle_response(response)
     end
 
 
@@ -541,24 +536,20 @@ module IDRAC
       response = authenticated_request(
         :post,
         "/redfish/v1/Dell/Systems/System.Embedded.1/DellRaidService/Actions/DellRaidService.SetControllerKey",
-        body: payload.to_json,
-        headers: { 'Content-Type': 'application/json' }
+        body: payload.to_json
       )
       
       if response.status == 202
         puts "Controller encryption enabled".green
-        
+
         # Check if we need to wait for a job
         if response.headers["location"]
           job_id = response.headers["location"].split("/").last
           wait_for_job(job_id)
         end
-        
-        return true
-      else
-        # Use generic error handler which includes ExtendedInfo parsing
-        handle_response(response)
       end
+
+      true
     end
 
     # Disable Self-Encrypting Drive support on controller
@@ -568,24 +559,20 @@ module IDRAC
       response = authenticated_request(
         :post,
         "/redfish/v1/Dell/Systems/System.Embedded.1/DellRaidService/Actions/DellRaidService.RemoveControllerKey",
-        body: payload.to_json,
-        headers: { 'Content-Type': 'application/json' }
+        body: payload.to_json
       )
       
       if response.status == 202
         puts "Controller encryption disabled".green
-        
+
         # Check if we need to wait for a job
         if response.headers["location"]
           job_id = response.headers["location"].split("/").last
           wait_for_job(job_id)
         end
-        
-        return true
-      else
-        # Use generic error handler which includes ExtendedInfo parsing
-        handle_response(response)
       end
+
+      true
     end
 
     # Check if all physical disks are Self-Encrypting Drives

data/lib/idrac/system.rb

@@ -708,10 +708,9 @@ module IDRAC
     # Clear system event logs
     def clear_system_event_logs
       response = authenticated_request(
-        :post, 
+        :post,
         "/redfish/v1/Managers/iDRAC.Embedded.1/LogServices/Sel/Actions/LogService.ClearLog",
-        body: {}.to_json,
-        headers: { 'Content-Type': 'application/json' }
+        body: {}.to_json
       )
       
       if response.status.between?(200, 299)

data/lib/idrac/system_config.rb

@@ -39,10 +39,9 @@ module IDRAC
       
       # Submit configuration with job availability handling
       res = wait_for_job_availability do
-        authenticated_request(:post, 
+        authenticated_request(:post,
           "/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager.ImportSystemConfiguration",
-          body: {"ImportBuffer": scp.to_json, "ShareParameters": {"Target": "iDRAC"}}.to_json,
-          headers: {"Content-Type" => "application/json"}
+          body: {"ImportBuffer": scp.to_json, "ShareParameters": {"Target": "iDRAC"}}.to_json
         )
       end
       
@@ -58,10 +57,9 @@ module IDRAC
     # Get the system configuration profile for a given target (e.g. "RAID")
     def get_system_configuration_profile(target: "RAID")
       debug "Exporting System Configuration..."
-      response = authenticated_request(:post, 
-        "/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager.ExportSystemConfiguration", 
-        body: {"ExportFormat": "JSON", "ShareParameters":{"Target": target}}.to_json,
-        headers: {"Content-Type" => "application/json"}
+      response = authenticated_request(:post,
+        "/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager.ExportSystemConfiguration",
+        body: {"ExportFormat": "JSON", "ShareParameters":{"Target": target}}.to_json
       )
       scp = handle_location(response.headers["location"]) 
       # We experienced this with older iDRACs, so let's give a enriched error to help debug.
@@ -117,10 +115,9 @@ module IDRAC
       
       # Make the API request
       response = authenticated_request(
-        :post, 
+        :post,
         "/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager.ImportSystemConfiguration",
-        body: params.to_json,
-        headers: {"Content-Type" => "application/json"}
+        body: params.to_json
       )
       
       # Check for immediate errors

data/lib/idrac/utility.rb

@@ -61,8 +61,7 @@ module IDRAC
       response = authenticated_request(
         :post,
         "/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService/Actions/DellLCService.SupportAssistCollection",
-        body: payload.to_json,
-        headers: { 'Content-Type' => 'application/json' }
+        body: payload.to_json
       )
       
       case response.status
@@ -303,8 +302,7 @@ module IDRAC
       response = authenticated_request(
         :post,
         "/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService/Actions/DellLCService.SupportAssistGetEULAStatus",
-        body: {}.to_json,
-        headers: { 'Content-Type' => 'application/json' }
+        body: {}.to_json
       )
       
       if response.status.between?(200, 299)
@@ -333,8 +331,7 @@ module IDRAC
       response = authenticated_request(
         :post,
         "/redfish/v1/Dell/Managers/iDRAC.Embedded.1/DellLCService/Actions/DellLCService.SupportAssistAcceptEULA",
-        body: {}.to_json,
-        headers: { 'Content-Type' => 'application/json' }
+        body: {}.to_json
       )
       
       if response.status.between?(200, 299)
@@ -357,8 +354,7 @@ module IDRAC
       response = authenticated_request(
         :post,
         "/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Manager.Reset",
-        body: { "ResetType" => "GracefulRestart" }.to_json,
-        headers: { 'Content-Type' => 'application/json' }
+        body: { "ResetType" => "GracefulRestart" }.to_json
       )
       
       if response.status.between?(200, 299)

data/lib/idrac/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IDRAC
-  VERSION = "0.9.0"
+  VERSION = "0.9.4"
 end

data/lib/idrac/virtual_media.rb

@@ -71,13 +71,11 @@ module IDRAC
              end
       
       response = authenticated_request(
-        :post, 
+        :post,
         "/redfish/v1/#{path}",
-        body: {}.to_json,
-        headers: { 'Content-Type': 'application/json' }
+        body: {}.to_json
       )
 
-      handle_response(response)
       response.status.between?(200, 299)
     end
 
@@ -106,10 +104,9 @@ module IDRAC
                  end
           
           response = authenticated_request(
-            :post, 
+            :post,
             "/redfish/v1/#{path}",
-            body: { "Image": iso_url, "Inserted": true, "WriteProtected": true }.to_json,
-            headers: { 'Content-Type': 'application/json' }
+            body: { "Image": iso_url, "Inserted": true, "WriteProtected": true }.to_json
           )
           
           if response.status == 204 || response.status == 200
@@ -158,10 +155,9 @@ module IDRAC
         
         # Set one-time boot to CD
         response = authenticated_request(
-          :patch, 
+          :patch,
           "/redfish/v1/Systems/System.Embedded.1",
-          body: { "Boot": { "BootSourceOverrideTarget": "Cd", "BootSourceOverrideEnabled": "Once" } }.to_json,
-          headers: { 'Content-Type': 'application/json' }
+          body: { "Boot": { "BootSourceOverrideTarget": "Cd", "BootSourceOverrideEnabled": "Once" } }.to_json
         )
         
         if response.status.between?(200, 299)
@@ -189,10 +185,9 @@ module IDRAC
         }
         
         response = authenticated_request(
-          :patch, 
+          :patch,
           "/redfish/v1/Managers/iDRAC.Embedded.1/Attributes",
-          body: payload.to_json,
-          headers: { 'Content-Type': 'application/json' }
+          body: payload.to_json
         )
         
         if response.status.between?(200, 299)

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: idrac
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.4
 platform: ruby
 authors:
 - Jonathan Siegel
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-10-21 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -282,7 +281,6 @@ licenses:
 metadata:
   homepage_uri: https://github.com/buildio/idrac
   source_code_uri: https://github.com/buildio/idrac
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -297,8 +295,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.16
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: API Client for Dell iDRAC
 test_files: []