idrac 0.10.7 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bfa684ed67c2db2f200633f5db13d173a30f49c67b07b05da83844708bdacfa4
-  data.tar.gz: 1308339f369f5d9ec0c028f64effac7d43e39cc93dcfad88e2d5d88a6b954f53
+  metadata.gz: f24b2229f786a83cbdcaf74c4511953d92b4081194aec3885e825a83426a8ff7
+  data.tar.gz: d5b0b13b8f51b43936e01601e031617b2704bd5d09b4fffcb8c99f35864fe130
 SHA512:
-  metadata.gz: abc37992c28ab713b5960b51144bcda9f3d80ed197e7a35284c5509392f82b258072bfce2b3a3b1c3d30956b2996459b42a18582de2896d61a1e3df6851a2946
-  data.tar.gz: 65219a49a799565089f2bb59722314ba3433a2c5dc17c035d92a2bf0d6a1712b4c964f0489fa0d1a5935a65390ed9d1fbd4c99a7832d055b11730739d5068f6a
+  metadata.gz: 3d71bfb2ca893fed352c34c4726a9c76bee97c9978933f3d0928e48f8ba4a0a12fe5b3045fdc3f7a33c8ab107156e6b71d14275ca377fb93fb146a64f7be6525
+  data.tar.gz: aca2e4227201a36da2f657bfacbe2109c95ae63ddccca6a85f3c1aee84f08180987cf1b50e9f623214466c6d46701920f56a2182a74ba2616e61bfa263614b04

data/README.md

@@ -36,6 +36,19 @@ Or install it yourself as:
 
     $ gem install idrac
 
+## Compatibility
+
+`activesupport` below 8.1 and `json` 3 cannot be used together: activesupport's
+JSON encoder calls `JSON.generate(..., quirks_mode: true)`, and json 3 removed
+that keyword, so any `hash.to_json` raises `ArgumentError: unknown keyword:
+quirks_mode`. This is not specific to this gem — it bites anything that loads
+`active_support/core_ext` — but idrac depends on activesupport, so pick one of:
+
+- activesupport >= 8.1 with json 3, or
+- activesupport 7.x with json 2.
+
+CI covers both ends.
+
 ## Usage
 
 ### Command Line Interface

data/lib/idrac/boot.rb

@@ -140,7 +140,8 @@ module IDRAC
     end
     
     # Set boot override for next boot
-    def set_boot_override(target, enabled: "Once", mode: nil)
+    def set_boot_override(target, persistence: nil, mode: nil)
+      persistence = "Once" unless persistence
       # Validate target against allowed values
       boot_data = boot
       valid_targets = boot_data["allowed_override_targets"]
@@ -150,11 +151,11 @@ module IDRAC
         raise Error, "Invalid boot target: #{target}"
       end
       
-      debug "Setting boot override to #{target} (#{enabled})...", 1, :yellow
+      debug "Setting boot override to #{target} (#{persistence})...", 1, :yellow
       
       body = {
         "Boot" => {
-          "BootSourceOverrideEnabled" => enabled,  # Disabled/Once/Continuous
+          "BootSourceOverrideEnabled" => persistence,  # Disabled/Once/Continuous
           "BootSourceOverrideTarget" => target     # None/Pxe/Hdd/Cd/etc
         }
       }
@@ -225,24 +226,24 @@ module IDRAC
     end
     
     # Convenience methods for common boot targets
-    def boot_to_pxe(enabled: "Once", mode: nil)
-      set_boot_override("Pxe", enabled: enabled, mode: mode)
+    def boot_to_pxe(persistence: nil, mode: nil)
+      set_boot_override("Pxe", persistence: persistence, mode: mode)
     end
     
-    def boot_to_disk(enabled: "Once", mode: nil)
-      set_boot_override("Hdd", enabled: enabled, mode: mode)
+    def boot_to_disk(persistence: nil, mode: nil)
+      set_boot_override("Hdd", persistence: persistence, mode: mode)
     end
     
-    def boot_to_cd(enabled: "Once", mode: nil)
-      set_boot_override("Cd", enabled: enabled, mode: mode)
+    def boot_to_cd(persistence: nil, mode: nil)
+      set_boot_override("Cd", persistence: persistence, mode: mode)
     end
     
-    def boot_to_usb(enabled: "Once", mode: nil)
-      set_boot_override("Usb", enabled: enabled, mode: mode)
+    def boot_to_usb(persistence: nil, mode: nil)
+      set_boot_override("Usb", persistence: persistence, mode: mode)
     end
     
-    def boot_to_bios_setup(enabled: "Once", mode: nil)
-      set_boot_override("BiosSetup", enabled: enabled, mode: mode)
+    def boot_to_bios_setup(persistence: nil, mode: nil)
+      set_boot_override("BiosSetup", persistence: persistence, mode: mode)
     end
     
     private

data/lib/idrac/firmware.rb

@@ -590,11 +590,10 @@ module IDRAC
         end
         
         # Construct the firmware URI from the upload response
-        image_uri = if firmware_id
-          "#{http_push_uri}/#{firmware_id}"
-        else
-          upload_response.headers['Location'] || http_push_uri
-        end
+        # Prefer @odata.id from response body, then Location header, then constructed path
+        image_uri = upload_data&.dig('@odata.id') ||
+                    upload_response.headers['Location'] ||
+                    (firmware_id ? "#{http_push_uri}/#{firmware_id}" : http_push_uri)
 
         # Check if Dell OEM Install action is available (iDRAC8)
         # This is more reliable than SimpleUpdate on older iDRACs
@@ -604,9 +603,10 @@ module IDRAC
         if dell_install_target
           puts "Using Dell OEM Install action (iDRAC8)...".light_cyan
           puts "Firmware URI: #{image_uri}".light_cyan
+          # iDRAC8 DellUpdateService.Install expects @odata.id URIs
           install_payload = {
             "SoftwareIdentityURIs" => [image_uri],
-            "InstallUpon" => "Now"
+            "InstallUpon" => "NowAndReboot"
           }
           update_response = client.authenticated_request(
             :post,

data/lib/idrac/utility.rb

@@ -194,11 +194,28 @@ module IDRAC
     # @param data_selector_values [Array] Array of log types to include (optional)
     # @param wait_timeout [Integer] Maximum time to wait for generation in seconds (default: 600)
     # @return [String, nil] Path to downloaded file or nil if failed
-    def generate_and_download_tsr(output_file: nil, data_selector_values: nil, wait_timeout: 600)
+    def generate_and_download_tsr(output_file: nil, data_selector_values: nil, accept_eula: false, wait_timeout: 600)
       debug "Starting TSR generation and download process...", 1
-      
+
       output_file ||= "supportassist_#{@host}_#{Time.now.strftime('%Y%m%d_%H%M%S')}.zip"
-      
+
+      # Accept the EULA up front when asked -- generate_tsr_logs only errors out otherwise.
+      accept_supportassist_eula if accept_eula
+
+      # Wait out a collection that is still running server-side. The iDRAC allows only one
+      # SupportAssist collection at a time, so generating now would fail with "a SupportAssist job
+      # is already running". Give up after wait_timeout seconds and fail the same way the rest of
+      # this method does (return nil).
+      wait_deadline = Time.now + wait_timeout
+      while supportassist_collection_running?
+        if Time.now > wait_deadline
+          debug "Timed out after #{wait_timeout}s waiting for a running SupportAssist collection to finish", 1, :red
+          return nil
+        end
+        debug "A SupportAssist collection is already running; waiting...", 1, :yellow
+        sleep 15
+      end
+
       # First, generate the TSR
       result = generate_tsr_logs(data_selector_values: data_selector_values)
       
@@ -267,8 +284,9 @@ module IDRAC
           collection_in_progress: false
         }
         
-        # Check if there's an active collection job
-        jobs_response = authenticated_request(:get, "/redfish/v1/Managers/iDRAC.Embedded.1/Jobs")
+        # Check if there's an active collection job. The list must be expanded, otherwise each
+        # Members entry is a bare @odata.id with no Name/JobState and the check never fires.
+        jobs_response = authenticated_request(:get, "/redfish/v1/Managers/iDRAC.Embedded.1/Jobs?$expand=*($levels=1)")
         if jobs_response.status == 200
           jobs_data = JSON.parse(jobs_response.body)
           if jobs_data["Members"]
@@ -294,6 +312,25 @@ module IDRAC
       { available: false, error: e.message }
     end
 
+    # True when a SupportAssist Collection job is still running server-side. Reads the expanded Dell
+    # Jobs list (bare @odata.id members carry no Name/JobState) and treats a job as running when its
+    # Name matches SupportAssist Collection, its JobState is not terminal, and it is below 100%.
+    # Use this to wait out a prior collection before starting a new one (the iDRAC allows only one).
+    def supportassist_collection_running?
+      response = authenticated_request(:get, "/redfish/v1/Managers/iDRAC.Embedded.1/Jobs?$expand=*($levels=1)")
+      return false unless response.status == 200
+
+      members = JSON.parse(response.body)["Members"] || []
+      members.any? do |job|
+        job["Name"].to_s =~ /SupportAssist Collection/i &&
+          !IDRAC::Firmware::TERMINAL_JOB_STATES.include?(job["JobState"]) &&
+          job["PercentComplete"].to_i < 100
+      end
+    rescue => e
+      debug "Error checking SupportAssist collection state: #{e.message}", 1, :red
+      false
+    end
+
     # Check SupportAssist EULA status
     # @return [Hash] EULA status information
     def supportassist_eula_status

data/lib/idrac/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IDRAC
-  VERSION = "0.10.7"
+  VERSION = "0.11.1"
 end

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: idrac
 version: !ruby/object:Gem::Version
-  version: 0.10.7
+  version: 0.11.1
 platform: ruby
 authors:
 - Jonathan Siegel
+autorequire:
 bindir: bin
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2026-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -281,6 +282,7 @@ licenses:
 metadata:
   homepage_uri: https://github.com/buildio/idrac
   source_code_uri: https://github.com/buildio/idrac
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -295,7 +297,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.5.16
+signing_key:
 specification_version: 4
 summary: API Client for Dell iDRAC
 test_files: []